asgardius/virtualx-engine
1
0
Fork 0
Code Issues Pull requests Projects Releases 1 Packages Wiki Activity Actions

Fix data races in startup/teardown

Browse source
This commit is contained in:
myaaaaaaaaa 2023-02-22 16:49:48 -05:00
parent 7e79aead99
commit d337ed1c64
3 changed files with 8 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
core/io/ip.cpp
View file

@ -75,7 +75,7 @@ struct _IP_ResolverPrivate {
Semaphore sem; Semaphore sem;
Thread thread; Thread thread;
bool thread_abort = false; SafeFlag thread_abort;
void resolve_queues() { void resolve_queues() {
for (int i = 0; i < IP::RESOLVER_MAX_QUERIES; i++) { for (int i = 0; i < IP::RESOLVER_MAX_QUERIES; i++) {
@ -111,7 +111,7 @@ struct _IP_ResolverPrivate {
static void _thread_function(void *self) { static void _thread_function(void *self) {
_IP_ResolverPrivate *ipr = static_cast<_IP_ResolverPrivate *>(self); _IP_ResolverPrivate *ipr = static_cast<_IP_ResolverPrivate *>(self);
while (!ipr->thread_abort) { while (!ipr->thread_abort.is_set()) {
ipr->sem.wait(); ipr->sem.wait();
ipr->resolve_queues(); ipr->resolve_queues();
} }
@ -343,12 +343,12 @@ IP::IP() {
singleton = this; singleton = this;
resolver = memnew(_IP_ResolverPrivate); resolver = memnew(_IP_ResolverPrivate);
resolver->thread_abort = false; resolver->thread_abort.clear();
resolver->thread.start(_IP_ResolverPrivate::_thread_function, resolver); resolver->thread.start(_IP_ResolverPrivate::_thread_function, resolver);
} }
IP::~IP() { IP::~IP() {
resolver->thread_abort = true; resolver->thread_abort.set();
resolver->sem.post(); resolver->sem.post();
resolver->thread.wait_to_finish(); resolver->thread.wait_to_finish();

6
core/os/thread.cpp
View file

@ -50,8 +50,8 @@ void Thread::_set_platform_functions(const PlatformFunctions &p_functions) {
platform_functions = p_functions; platform_functions = p_functions;
} }
void Thread::callback(Thread *p_self, const Settings &p_settings, Callback p_callback, void *p_userdata) { void Thread::callback(ID p_caller_id, const Settings &p_settings, Callback p_callback, void *p_userdata) {
Thread::caller_id = _thread_id_hash(p_self->thread.get_id()); Thread::caller_id = p_caller_id;
if (platform_functions.set_priority) { if (platform_functions.set_priority) {
platform_functions.set_priority(p_settings.priority); platform_functions.set_priority(p_settings.priority);
} }
@ -79,7 +79,7 @@ void Thread::start(Thread::Callback p_callback, void *p_user, const Settings &p_
std::thread empty_thread; std::thread empty_thread;
thread.swap(empty_thread); thread.swap(empty_thread);
} }
std::thread new_thread(&Thread::callback, this, p_settings, p_callback, p_user); std::thread new_thread(&Thread::callback, _thread_id_hash(thread.get_id()), p_settings, p_callback, p_user);
thread.swap(new_thread); thread.swap(new_thread);
id = _thread_id_hash(thread.get_id()); id = _thread_id_hash(thread.get_id());
} }

2
core/os/thread.h
View file

@ -82,7 +82,7 @@ private:
static thread_local ID caller_id; static thread_local ID caller_id;
std::thread thread; std::thread thread;
static void callback(Thread *p_self, const Settings &p_settings, Thread::Callback p_callback, void *p_userdata); static void callback(ID p_caller_id, const Settings &p_settings, Thread::Callback p_callback, void *p_userdata);
static PlatformFunctions platform_functions; static PlatformFunctions platform_functions;