From d3c879fe1bbba83aa7c365441422b0dcb22b82f4 Mon Sep 17 00:00:00 2001 From: Klesomik Date: Mon, 26 Aug 2019 20:48:10 +0300 Subject: [PATCH] Memory leak fixed In some functions in editor/find_in_files.cpp was detected a memory leak DirAccess* and FileAccess* were replaced by DirAccessRef and FileAccessRef DirAccessRef and FileAccessRef are just wrappers for DirAccess* and FileAccess* Fixes for issue #31659 --- editor/find_in_files.cpp | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/editor/find_in_files.cpp b/editor/find_in_files.cpp index cc2efb92ae1..def22d07de4 100644 --- a/editor/find_in_files.cpp +++ b/editor/find_in_files.cpp @@ -221,8 +221,8 @@ float FindInFiles::get_progress() const { void FindInFiles::_scan_dir(String path, PoolStringArray &out_folders) { - DirAccess *dir = DirAccess::open(path); - if (dir == NULL) { + DirAccessRef dir = DirAccess::open(path); + if (!dir) { print_verbose("Cannot open directory! " + path); return; } @@ -253,8 +253,8 @@ void FindInFiles::_scan_dir(String path, PoolStringArray &out_folders) { void FindInFiles::_scan_file(String fpath) { - FileAccess *f = FileAccess::open(fpath, FileAccess::READ); - if (f == NULL) { + FileAccessRef f = FileAccess::open(fpath, FileAccess::READ); + if (!f) { print_verbose(String("Cannot open file ") + fpath); return; }