Main: Create user data dir in setup()

Custom backport of #39563 with preliminary change to make
`OS::ensure_user_data_dir()` public as done in f8a79a9.

Fixes #32488.
This commit is contained in:
Rémi Verschelde 2021-01-08 10:24:41 +01:00
parent 292bbb870f
commit d6fecf7686
No known key found for this signature in database
GPG key ID: C3336907360768E1
8 changed files with 6 additions and 12 deletions

View file

@ -460,8 +460,7 @@ OS::ScreenOrientation OS::get_screen_orientation() const {
return (OS::ScreenOrientation)_orientation; return (OS::ScreenOrientation)_orientation;
} }
void OS::_ensure_user_data_dir() { void OS::ensure_user_data_dir() {
String dd = get_user_data_dir(); String dd = get_user_data_dir();
DirAccess *da = DirAccess::open(dd); DirAccess *da = DirAccess::open(dd);
if (da) { if (da) {

View file

@ -140,7 +140,6 @@ protected:
virtual void set_cmdline(const char *p_execpath, const List<String> &p_args); virtual void set_cmdline(const char *p_execpath, const List<String> &p_args);
void _ensure_user_data_dir();
virtual bool _check_internal_feature_support(const String &p_feature) = 0; virtual bool _check_internal_feature_support(const String &p_feature) = 0;
public: public:
@ -305,6 +304,8 @@ public:
virtual List<String> get_cmdline_args() const { return _cmdline; } virtual List<String> get_cmdline_args() const { return _cmdline; }
virtual String get_model_name() const; virtual String get_model_name() const;
void ensure_user_data_dir();
virtual MainLoop *get_main_loop() const = 0; virtual MainLoop *get_main_loop() const = 0;
virtual void yield(); virtual void yield();

View file

@ -899,6 +899,9 @@ Error Main::setup(const char *execpath, int argc, char *argv[], bool p_second_ph
#endif #endif
} }
// Initialize user data dir.
OS::get_singleton()->ensure_user_data_dir();
GLOBAL_DEF("memory/limits/multithreaded_server/rid_pool_prealloc", 60); GLOBAL_DEF("memory/limits/multithreaded_server/rid_pool_prealloc", 60);
ProjectSettings::get_singleton()->set_custom_property_info("memory/limits/multithreaded_server/rid_pool_prealloc", PropertyInfo(Variant::INT, "memory/limits/multithreaded_server/rid_pool_prealloc", PROPERTY_HINT_RANGE, "0,500,1")); // No negative and limit to 500 due to crashes ProjectSettings::get_singleton()->set_custom_property_info("memory/limits/multithreaded_server/rid_pool_prealloc", PropertyInfo(Variant::INT, "memory/limits/multithreaded_server/rid_pool_prealloc", PROPERTY_HINT_RANGE, "0,500,1")); // No negative and limit to 500 due to crashes
GLOBAL_DEF("network/limits/debugger_stdout/max_chars_per_second", 2048); GLOBAL_DEF("network/limits/debugger_stdout/max_chars_per_second", 2048);

View file

@ -1774,8 +1774,6 @@ Error OS_OSX::initialize(const VideoMode &p_desired, int p_video_driver, int p_a
power_manager = memnew(PowerOSX); power_manager = memnew(PowerOSX);
_ensure_user_data_dir();
restore_rect = Rect2(get_window_position(), get_window_size()); restore_rect = Rect2(get_window_position(), get_window_size());
if (p_desired.layered) { if (p_desired.layered) {

View file

@ -97,8 +97,6 @@ Error OS_Server::initialize(const VideoMode &p_desired, int p_video_driver, int
power_manager = memnew(PowerX11); power_manager = memnew(PowerX11);
#endif #endif
_ensure_user_data_dir();
resource_loader_dummy.instance(); resource_loader_dummy.instance();
ResourceLoader::add_resource_format_loader(resource_loader_dummy); ResourceLoader::add_resource_format_loader(resource_loader_dummy);

View file

@ -340,8 +340,6 @@ Error OS_UWP::initialize(const VideoMode &p_desired, int p_video_driver, int p_a
ref new TypedEventHandler<Gyrometer ^, GyrometerReadingChangedEventArgs ^>(managed_object, &ManagedType::on_gyroscope_reading_changed); ref new TypedEventHandler<Gyrometer ^, GyrometerReadingChangedEventArgs ^>(managed_object, &ManagedType::on_gyroscope_reading_changed);
} }
_ensure_user_data_dir();
if (is_keep_screen_on()) if (is_keep_screen_on())
display_request->RequestActive(); display_request->RequestActive();

View file

@ -1687,8 +1687,6 @@ Error OS_Windows::initialize(const VideoMode &p_desired, int p_video_driver, int
RegisterTouchWindow(hWnd, 0); RegisterTouchWindow(hWnd, 0);
_ensure_user_data_dir();
DragAcceptFiles(hWnd, true); DragAcceptFiles(hWnd, true);
move_timer_id = 1; move_timer_id = 1;

View file

@ -605,7 +605,6 @@ Error OS_X11::initialize(const VideoMode &p_desired, int p_video_driver, int p_a
#ifdef JOYDEV_ENABLED #ifdef JOYDEV_ENABLED
joypad = memnew(JoypadLinux(input)); joypad = memnew(JoypadLinux(input));
#endif #endif
_ensure_user_data_dir();
power_manager = memnew(PowerX11); power_manager = memnew(PowerX11);