asgardius/virtualx-engine
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Command line arguments '--version' and '--help' return exit code 0 instead of 255

Browse source 
Allows to detect whether those commands executed successfully, which makes integration with shell scripts/CI/bindings straightforward.

(cherry picked from commit e3a8edf536)
This commit is contained in:
Jan Haller 2022-06-30 13:55:15 +02:00 committed by Rémi Verschelde
parent ad5fdcc0f3
commit da78e92321
1 changed files with 6 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
main/main.cpp
View file

@ -478,6 +478,9 @@ Error Main::setup(const char *execpath, int argc, char *argv[], bool p_second_ph
packed_data->add_pack_source(zip_packed_data);
#endif
// Default exit code, can be modified for certain errors.
Error exit_code = ERR_INVALID_PARAMETER;
I = args.front();
while (I) {
#ifdef OSX_ENABLED
@ -494,10 +497,12 @@ Error Main::setup(const char *execpath, int argc, char *argv[], bool p_second_ph
if (I->get() == "-h" || I->get() == "--help" || I->get() == "/?") { // display help
show_help = true;
exit_code = OK;
goto error;
} else if (I->get() == "--version") {
print_line(get_full_version_string());
exit_code = OK;
goto error;
} else if (I->get() == "-v" || I->get() == "--verbose") { // verbose output
@ -1328,7 +1333,7 @@ error:
OS::get_singleton()->finalize_core();
locale = String();
return ERR_INVALID_PARAMETER;
return exit_code;
}
Error Main::setup2(Thread::ID p_main_tid_override) {