Merge pull request #58174 from timothyqiu/vs-set-index-crash

This commit is contained in:
Rémi Verschelde 2022-02-16 09:42:01 +01:00 committed by GitHub
commit dbb64e5705
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23

View file

@ -1784,10 +1784,7 @@ public:
virtual int step(const Variant **p_inputs, Variant **p_outputs, StartMode p_start_mode, Variant *p_working_mem, Callable::CallError &r_error, String &r_error_str) {
bool valid;
// *p_output[0] points to the same place as *p_inputs[2] so we need a temp to store the value before the change in the next line
Variant temp = *p_inputs[2];
*p_outputs[0] = *p_inputs[0];
p_outputs[0]->set(*p_inputs[1], temp, &valid);
((Variant *)p_inputs[0])->set(*p_inputs[1], *p_inputs[2], &valid);
if (!valid) {
r_error.error = Callable::CallError::CALL_ERROR_INVALID_METHOD;