asgardius/virtualx-engine
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Display longer Git hashes in engine version dialogs

Browse source 
Due to the high number of commits in the Godot repository,
7-character hashes were starting to become occasionally ambiguous.

In contrast, 9-character hashes are currently unambiguous for
all commits.
This commit is contained in:
Hugo Locurcio 2019-06-01 13:51:10 +02:00
parent cfb9709c10
commit dc981d8af7
No known key found for this signature in database
GPG key ID: 39E8F8BE30B0A49C
3 changed files with 3 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
editor/editor_about.cpp
View file

@ -131,7 +131,7 @@ EditorAbout::EditorAbout() {
String hash = String(VERSION_HASH); String hash = String(VERSION_HASH);
if (hash.length() != 0) if (hash.length() != 0)
hash = "." + hash.left(7); hash = "." + hash.left(9);
Label *about_text = memnew(Label); Label *about_text = memnew(Label);
about_text->set_v_size_flags(Control::SIZE_SHRINK_CENTER); about_text->set_v_size_flags(Control::SIZE_SHRINK_CENTER);

2
editor/project_manager.cpp
View file

@ -1971,7 +1971,7 @@ ProjectManager::ProjectManager() {
l = memnew(Label); l = memnew(Label);
String hash = String(VERSION_HASH); String hash = String(VERSION_HASH);
if (hash.length() != 0) if (hash.length() != 0)
hash = "." + hash.left(7); hash = "." + hash.left(9);
l->set_text("v" VERSION_FULL_BUILD "" + hash); l->set_text("v" VERSION_FULL_BUILD "" + hash);
l->set_align(Label::ALIGN_CENTER); l->set_align(Label::ALIGN_CENTER);
top_hb->add_child(l); top_hb->add_child(l);

2
main/main.cpp
View file

@ -161,7 +161,7 @@ static String unescape_cmdline(const String &p_str) {
static String get_full_version_string() { static String get_full_version_string() {
String hash = String(VERSION_HASH); String hash = String(VERSION_HASH);
if (hash.length() != 0) if (hash.length() != 0)
hash = "." + hash.left(7); hash = "." + hash.left(9);
return String(VERSION_FULL_BUILD) + hash; return String(VERSION_FULL_BUILD) + hash;
} }