asgardius/virtualx-engine
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Revert "Fix extension registration order."

Browse source 
This reverts commit 94ef200bab.

This broke extension loading.
Fixes #58273.
This commit is contained in:
Rémi Verschelde 2022-02-18 14:18:24 +01:00
parent 887d4bd0d9
commit e1c303fa79
3 changed files with 5 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
core/register_core_types.cpp
View file

@ -316,11 +316,9 @@ void register_core_extensions() {
native_extension_manager->initialize_extensions(NativeExtension::INITIALIZATION_LEVEL_CORE);
}
void unregister_core_extensions() {
native_extension_manager->deinitialize_extensions(NativeExtension::INITIALIZATION_LEVEL_CORE);
}
void unregister_core_types() {
native_extension_manager->deinitialize_extensions(NativeExtension::INITIALIZATION_LEVEL_CORE);
memdelete(native_extension_manager);
memdelete(resource_uid);

1
core/register_core_types.h
View file

@ -36,6 +36,5 @@ void register_core_settings();
void register_core_extensions();
void register_core_singletons();
void unregister_core_types();
void unregister_core_extensions();
#endif // REGISTER_CORE_TYPES_H

7
main/main.cpp
View file

@ -487,7 +487,6 @@ void Main::test_cleanup() {
}
unregister_core_driver_types();
unregister_core_extensions();
unregister_core_types();
OS::get_singleton()->finalize_core();
@ -555,7 +554,6 @@ Error Main::setup(const char *execpath, int argc, char *argv[], bool p_second_ph
globals = memnew(ProjectSettings);
register_core_settings(); //here globals are present
register_core_extensions(); // core extensions must be registered after core settings and before display
translation_server = memnew(TranslationServer);
performance = memnew(Performance);
@ -636,6 +634,7 @@ Error Main::setup(const char *execpath, int argc, char *argv[], bool p_second_ph
continue;
}
#endif
List<String>::Element *N = I->next();
if (I->get() == "-h" || I->get() == "--help" || I->get() == "/?") { // display help
@ -1272,6 +1271,8 @@ Error Main::setup(const char *execpath, int argc, char *argv[], bool p_second_ph
Logger::set_flush_stdout_on_print(ProjectSettings::get_singleton()->get("application/run/flush_stdout_on_print"));
OS::get_singleton()->set_cmdline(execpath, main_args);
register_core_extensions(); //before display
// possibly be worth changing the default from vulkan to something lower spec,
// for the project manager, depending on how smooth the fallback is.
GLOBAL_DEF_RST("rendering/driver/driver_name", "vulkan");
@ -1528,7 +1529,6 @@ error:
}
unregister_core_driver_types();
unregister_core_extensions();
unregister_core_types();
OS::get_singleton()->_cmdline.clear();
@ -2888,7 +2888,6 @@ void Main::cleanup(bool p_force) {
memdelete(message_queue);
unregister_core_driver_types();
unregister_core_extensions();
unregister_core_types();
OS::get_singleton()->finalize_core();