asgardius/virtualx-engine
1
0
Fork 0
Code Issues Pull requests Projects Releases 1 Packages Wiki Activity Actions

Merge pull request #68779 from dzil123/fix_renderdummy_mesh_surface_overflow

Browse source 
RendererDummy - Fix buffer overflow due to stale mesh_get_surface
This commit is contained in:
Rémi Verschelde 2022-11-17 13:48:24 +01:00
commit e1ead0fbd1
No known key found for this signature in database
GPG key ID: C3336907360768E1
2 changed files with 8 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
servers/rendering/dummy/storage/mesh_storage.cpp
View file

@ -56,3 +56,10 @@ void MeshStorage::mesh_free(RID p_rid) {
mesh_owner.free(p_rid);
}
void MeshStorage::mesh_clear(RID p_mesh) {
DummyMesh *m = mesh_owner.get_or_null(p_mesh);
ERR_FAIL_COND(!m);
m->surfaces.clear();
}

2
servers/rendering/dummy/storage/mesh_storage.h
View file

@ -116,7 +116,7 @@ public:
virtual AABB mesh_get_aabb(RID p_mesh, RID p_skeleton = RID()) override { return AABB(); }
virtual void mesh_set_shadow_mesh(RID p_mesh, RID p_shadow_mesh) override {}
virtual void mesh_clear(RID p_mesh) override {}
virtual void mesh_clear(RID p_mesh) override;
/* MESH INSTANCE */