From e3f84916dec76de8119572750342240bfcee750a Mon Sep 17 00:00:00 2001 From: lawnjelly Date: Tue, 22 Feb 2022 13:40:41 +0000 Subject: [PATCH] Fix GIProbe gizmo out of bounds crash The GIProbe gizmo was writing values in 3 dimensions to Vector2s. This error was previously being masked by the Vector2 accessor, but now results in a crash or ERR_FAIL message. This PR removes the Vector2s as they were unused. --- editor/spatial_editor_gizmos.cpp | 5 ----- 1 file changed, 5 deletions(-) diff --git a/editor/spatial_editor_gizmos.cpp b/editor/spatial_editor_gizmos.cpp index 44fb4e9a4ac..19b3265c972 100644 --- a/editor/spatial_editor_gizmos.cpp +++ b/editor/spatial_editor_gizmos.cpp @@ -2818,13 +2818,8 @@ void GIProbeGizmoPlugin::redraw(EditorSpatialGizmo *p_gizmo) { continue; } - Vector2 dir; - dir[j] = 1.0; - Vector2 ta, tb; int j_n1 = (j + 1) % 3; int j_n2 = (j + 2) % 3; - ta[j_n1] = 1.0; - tb[j_n2] = 1.0; for (int k = 0; k < 4; k++) { Vector3 from = aabb.position, to = aabb.position;