From 23a349c427225060928b27f531a1e832a26c92e5 Mon Sep 17 00:00:00 2001 From: Aaron Franke Date: Mon, 20 Apr 2020 18:24:17 -0400 Subject: [PATCH] Improve the Vector2 rotated code --- core/math/vector2.cpp | 10 +++++----- core/math/vector2.h | 6 ------ 2 files changed, 5 insertions(+), 11 deletions(-) diff --git a/core/math/vector2.cpp b/core/math/vector2.cpp index f4259e388b7..f46badd19ed 100644 --- a/core/math/vector2.cpp +++ b/core/math/vector2.cpp @@ -119,11 +119,11 @@ Vector2 Vector2::round() const { } Vector2 Vector2::rotated(real_t p_by) const { - - Vector2 v; - v.set_rotation(angle() + p_by); - v *= length(); - return v; + real_t sine = Math::sin(p_by); + real_t cosi = Math::cos(p_by); + return Vector2( + x * cosi - y * sine, + x * sine + y * cosi); } Vector2 Vector2::posmod(const real_t p_mod) const { diff --git a/core/math/vector2.h b/core/math/vector2.h index ba5558102f6..95d24748384 100644 --- a/core/math/vector2.h +++ b/core/math/vector2.h @@ -123,12 +123,6 @@ struct Vector2 { real_t angle() const; - void set_rotation(real_t p_radians) { - - x = Math::cos(p_radians); - y = Math::sin(p_radians); - } - _FORCE_INLINE_ Vector2 abs() const { return Vector2(Math::abs(x), Math::abs(y));