asgardius/virtualx-engine
1
0
Fork 0
Code Issues Pull requests Projects Releases 1 Packages Wiki Activity Actions

Merge pull request #38064 from aaronfranke/rotated

Browse source 
Improve the Vector2 rotated code
This commit is contained in:
Rémi Verschelde 2020-04-28 20:49:22 +02:00 • committed by GitHub
commit e445be6944
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 5 additions and 11 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
core/math/vector2.cpp
View file

@ -119,11 +119,11 @@ Vector2 Vector2::round() const {
} }
Vector2 Vector2::rotated(real_t p_by) const { Vector2 Vector2::rotated(real_t p_by) const {
real_t sine = Math::sin(p_by);
Vector2 v; real_t cosi = Math::cos(p_by);
v.set_rotation(angle() + p_by); return Vector2(
v *= length(); x * cosi - y * sine,
return v; x * sine + y * cosi);
} }
Vector2 Vector2::posmod(const real_t p_mod) const { Vector2 Vector2::posmod(const real_t p_mod) const {

6
core/math/vector2.h
View file

@ -123,12 +123,6 @@ struct Vector2 {
real_t angle() const; real_t angle() const;
void set_rotation(real_t p_radians) {
x = Math::cos(p_radians);
y = Math::sin(p_radians);
}
_FORCE_INLINE_ Vector2 abs() const { _FORCE_INLINE_ Vector2 abs() const {
return Vector2(Math::abs(x), Math::abs(y)); return Vector2(Math::abs(x), Math::abs(y));