From 962b6a3e8f9d91f92f2547e2da6ba8dbd5a661dc Mon Sep 17 00:00:00 2001 From: Silc Renew Date: Fri, 2 Dec 2022 14:05:04 +0900 Subject: [PATCH] Fix animation signal caches_cleared firing timing --- scene/animation/animation_player.cpp | 3 ++- scene/animation/animation_tree.cpp | 1 - 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/scene/animation/animation_player.cpp b/scene/animation/animation_player.cpp index 45eeff71f25..de047bf82e8 100644 --- a/scene/animation/animation_player.cpp +++ b/scene/animation/animation_player.cpp @@ -1800,7 +1800,6 @@ double AnimationPlayer::get_current_animation_length() const { void AnimationPlayer::_animation_changed() { clear_caches(); - emit_signal(SNAME("caches_cleared")); if (is_playing()) { playback.seeked = true; //need to restart stuff, like audio } @@ -1839,6 +1838,8 @@ void AnimationPlayer::clear_caches() { cache_update_size = 0; cache_update_prop_size = 0; cache_update_bezier_size = 0; + + emit_signal(SNAME("caches_cleared")); } void AnimationPlayer::set_active(bool p_active) { diff --git a/scene/animation/animation_tree.cpp b/scene/animation/animation_tree.cpp index 3e0f59a48a8..7471ddd60fd 100644 --- a/scene/animation/animation_tree.cpp +++ b/scene/animation/animation_tree.cpp @@ -859,7 +859,6 @@ void AnimationTree::_clear_caches() { memdelete(K.value); } playing_caches.clear(); - track_cache.clear(); cache_valid = false; }