asgardius/virtualx-engine
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Merge pull request #45736 from kleonc/string_ends_with

Browse source 
Make String::ends_with don't use String::rfind
This commit is contained in:
Rémi Verschelde 2021-02-09 09:23:55 +01:00 committed by GitHub
commit e9bc984bef
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 31 additions and 24 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

55
core/string/ustring.cpp
View file

@ -3072,39 +3072,46 @@ int String::rfindn(const String &p_str, int p_from) const {
bool String::ends_with(const String &p_string) const {
int l = p_string.length();
if (l > length()) {
return false;
}
if (l == 0) {
return true;
}
int pos = rfind(p_string);
if (pos == -1) {
return false;
}
return pos + l == length();
}
const char32_t *p = &p_string[0];
const char32_t *s = &operator[](length() - l);
bool String::begins_with(const String &p_string) const {
if (p_string.length() > length()) {
return false;
}
int l = p_string.length();
if (l == 0) {
return true;
}
const char32_t *src = &p_string[0];
const char32_t *str = &operator[](0);
int i = 0;
for (; i < l; i++) {
if (src[i] != str[i]) {
for (int i = 0; i < l; i++) {
if (p[i] != s[i]) {
return false;
}
}
// only if i == l the p_string matches the beginning
return i == l;
return true;
}
bool String::begins_with(const String &p_string) const {
int l = p_string.length();
if (l > length()) {
return false;
}
if (l == 0) {
return true;
}
const char32_t *p = &p_string[0];
const char32_t *s = &operator[](0);
for (int i = 0; i < l; i++) {
if (p[i] != s[i]) {
return false;
}
}
return true;
}
bool String::begins_with(const char *p_string) const {