asgardius/virtualx-engine
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Fix gltf importer forcing vertex colors on all materials

Browse source 
The importer already checks if a mesh has vertex colors and enables
vertex colors on the material using it.

Before this fix, GLTF importer would force shader generation to use
vertex colors even if the scene did not have vertex colors at all, or
did not need them; causing inefficient shader and PSO generation.
This commit is contained in:
Matias N. Goldberg 2023-09-24 19:37:33 -03:00
parent c12d63556b
commit ec0e6800bc
1 changed files with 0 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
modules/gltf/gltf_document.cpp
View file

@ -3877,7 +3877,6 @@ Error GLTFDocument::_parse_materials(Ref<GLTFState> p_state) {
} else {
material->set_name(vformat("material_%s", itos(i)));
}
material->set_flag(BaseMaterial3D::FLAG_ALBEDO_FROM_VERTEX_COLOR, true);
Dictionary material_extensions;
if (material_dict.has("extensions")) {
material_extensions = material_dict["extensions"];