asgardius/virtualx-engine
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Optimize theme change in code editor

Browse source 
Postpone applying the whole theme when a setting changes, to avoid
updating everything many times when the whole editor theme is changed.
This commit is contained in:
PouleyKetchoupp 2021-07-30 10:40:59 -07:00
parent bdcc8741e4
commit edc858ad82
2 changed files with 15 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
editor/code_editor.cpp
View file

@ -31,6 +31,7 @@
#include "code_editor.h"
#include "core/input/input.h"
#include "core/object/message_queue.h"
#include "core/os/keyboard.h"
#include "core/string/string_builder.h"
#include "editor/editor_scale.h"
@ -1567,6 +1568,17 @@ void CodeTextEditor::_update_font() {
}
void CodeTextEditor::_on_settings_change() {
if (settings_changed) {
return;
}
settings_changed = true;
MessageQueue::get_singleton()->push_callable(callable_mp(this, &CodeTextEditor::_apply_settings_change));
}
void CodeTextEditor::_apply_settings_change() {
settings_changed = false;
_update_text_editor_theme();
_update_font();

3
editor/code_editor.h
View file

@ -162,7 +162,10 @@ class CodeTextEditor : public VBoxContainer {
int error_line;
int error_column;
bool settings_changed = false;
void _on_settings_change();
void _apply_settings_change();
void _update_text_editor_theme();
void _update_font();