asgardius/virtualx-engine
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Call Spatial::get_global_transform and Vector3::dot only once within Camera::is_position_behind to avoid redundant work.

Browse source 
(cherry picked from commit b2a204799a)
This commit is contained in:
Adam Reichold 2020-06-26 16:52:02 +02:00 committed by Rémi Verschelde
parent 636b1e4518
commit f06fc1fdf4
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
scene/3d/camera.cpp
View file

@ -333,8 +333,8 @@ Vector3 Camera::project_ray_origin(const Point2 &p_pos) const {
bool Camera::is_position_behind(const Vector3 &p_pos) const {
Transform t = get_global_transform();
Vector3 eyedir = -get_global_transform().basis.get_axis(2).normalized();
return eyedir.dot(p_pos) < (eyedir.dot(t.origin) + near);
Vector3 eyedir = -t.basis.get_axis(2).normalized();
return eyedir.dot(p_pos - t.origin) < near;
}
Vector<Vector3> Camera::get_near_plane_points() const {