asgardius/virtualx-engine
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Defer EditorInspector::update_tree to the process stage to improve performance

Browse source 
`EditorInspector::update_tree` is expensive, so defer the call to the process phase
to prevent multiple calls in a single frame (when switching scene tabs).
This commit is contained in:
Rindbee 2022-11-11 08:16:45 +08:00
parent 2e657e51f8
commit f352c30ad5
2 changed files with 8 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
editor/editor_inspector.cpp
View file

@ -2597,7 +2597,7 @@ bool EditorInspector::_is_property_disabled_by_feature_profile(const StringName
return false;
}
void EditorInspector::update_tree() {
void EditorInspector::_update_tree() {
//to update properly if all is refreshed
StringName current_selected = property_selected;
int current_focusable = -1;
@ -3316,6 +3316,10 @@ void EditorInspector::update_tree() {
}
}
void EditorInspector::update_tree() {
update_tree_pending = true;
}
void EditorInspector::update_property(const String &p_prop) {
if (!editor_property_map.has(p_prop)) {
return;
@ -3910,10 +3914,9 @@ void EditorInspector::_notification(int p_what) {
changing++;
if (update_tree_pending) {
update_tree();
update_tree_pending = false;
pending.clear();
_update_tree();
} else {
while (pending.size()) {
StringName prop = *pending.begin();

2
editor/editor_inspector.h
View file

@ -540,6 +540,8 @@ class EditorInspector : public ScrollContainer {
void _show_add_meta_dialog();
void _check_meta_name(const String &p_name);
void _update_tree();
protected:
static void _bind_methods();
void _notification(int p_what);