asgardius/virtualx-engine
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Fix bug in String==StrRange comparison

Browse source 
It was comparing the StrRange with itself, always return true if both
were the same length.

Fix #3843
This commit is contained in:
George Marques 2016-06-24 12:39:58 -03:00
parent 95e3279d34
commit f4dfa37a23
No known key found for this signature in database
GPG key ID: 046BD46A3201E43D
1 changed files with 2 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
core/ustring.cpp
View file

@ -257,13 +257,10 @@ bool String::operator==(const StrRange &p_range) const {
return true; return true;
const CharType *c_str=p_range.c_str; const CharType *c_str=p_range.c_str;
const CharType *dst = &operator[](0);
int l=length();
const CharType *dst = p_range.c_str;
/* Compare char by char */ /* Compare char by char */
for (int i=0;i<l;i++) { for (int i=0;i<len;i++) {
if (c_str[i]!=dst[i]) if (c_str[i]!=dst[i])
return false; return false;