asgardius/virtualx-engine
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Fix area calculation of Face3

Browse source 
There seemed to be a bug in area calculation in Face3::get_area()-function. It returned the area of "imaginary" parallelogram instead of the triangle. Therefore the area returned was twice the real area. This manifested itself when using a hydro module for godot ( https://gitlab.com/ringtechsolutions/godot-tools/hydro/hydro ) causing the buoyancy to be two times the expected value.

"Reference": http://www.maths.usyd.edu.au/u/MOW/vectors/vectors-11/v-11-7.html

(cherry picked from commit a165eed73b)
This commit is contained in:
Pasi Nuutinmaki 2020-03-15 10:01:28 +02:00 committed by Rémi Verschelde
parent c05ff94b84
commit f8c4ffcdde
No known key found for this signature in database
GPG key ID: C3336907360768E1
1 changed files with 1 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
core/math/face3.cpp
View file

@ -180,8 +180,7 @@ Vector3 Face3::get_median_point() const {
} }
real_t Face3::get_area() const { real_t Face3::get_area() const {
return vec3_cross(vertex[0] - vertex[1], vertex[0] - vertex[2]).length() * 0.5;
return vec3_cross(vertex[0] - vertex[1], vertex[0] - vertex[2]).length();
} }
ClockDirection Face3::get_clock_dir() const { ClockDirection Face3::get_clock_dir() const {