asgardius/virtualx-engine
1
0
Fork 0
Code Issues Pull requests Projects Releases 1 Packages Wiki Activity Actions

Correctly handle failures to open a project

Browse source
This commit is contained in:
Yuri Sizov 2024-01-30 17:35:46 +01:00
parent 28e8a4c0ee
commit f923b58f88
1 changed files with 8 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
editor/project_manager.cpp
View file

@ -474,12 +474,12 @@ void ProjectManager::_open_selected_projects() {
loading_label->show(); loading_label->show();
const HashSet<String> &selected_list = project_list->get_selected_project_keys(); const HashSet<String> &selected_list = project_list->get_selected_project_keys();
for (const String &path : selected_list) { for (const String &path : selected_list) {
String conf = path.path_join("project.godot"); String conf = path.path_join("project.godot");
if (!FileAccess::exists(conf)) { if (!FileAccess::exists(conf)) {
_show_error(vformat(TTR("Can't open project at '%s'."), path)); loading_label->hide();
_show_error(vformat(TTR("Can't open project at '%s'.\nProject file doesn't exist or is inaccessible."), path));
return; return;
} }
@ -497,7 +497,12 @@ void ProjectManager::_open_selected_projects() {
args.push_back("--editor"); args.push_back("--editor");
Error err = OS::get_singleton()->create_instance(args); Error err = OS::get_singleton()->create_instance(args);
ERR_FAIL_COND(err); if (err != OK) {
loading_label->hide();
_show_error(vformat(TTR("Can't open project at '%s'.\nFailed to start the editor."), path));
ERR_PRINT(vformat("Failed to start an editor instance for the project at '%s', error code %d.", path, err));
return;
}
} }
project_list->project_opening_initiated = true; project_list->project_opening_initiated = true;
@ -508,7 +513,6 @@ void ProjectManager::_open_selected_projects() {
void ProjectManager::_open_selected_projects_ask() { void ProjectManager::_open_selected_projects_ask() {
const HashSet<String> &selected_list = project_list->get_selected_project_keys(); const HashSet<String> &selected_list = project_list->get_selected_project_keys();
if (selected_list.size() < 1) { if (selected_list.size() < 1) {
return; return;
} }