asgardius/virtualx-engine
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Make "Export with Debug" more visible in the Export dialog

Browse source 
This swaps out the CheckButton with a CheckBox, which has two benefits:

- The checkbox icon appears to the left of the text, which moves it
  closer from the text. This makes it more easily noticeable, as
  it also appears below the "File:" text now.
- It follows the UI convention of using checkboxes for options that
  do not bear an immediate effect, unlike CheckButtons which are
  expected to have an immediate effect when toggled.

This closes #25170.
This commit is contained in:
Hugo Locurcio 2019-01-20 23:50:46 +01:00
parent 09e4d7e9eb
commit f9d0bc1858
No known key found for this signature in database
GPG key ID: 39E8F8BE30B0A49C
2 changed files with 4 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
editor/project_export.cpp
View file

@ -1298,12 +1298,12 @@ ProjectExportDialog::ProjectExportDialog() {
export_project->connect("file_selected", this, "_export_project_to_path"); export_project->connect("file_selected", this, "_export_project_to_path");
export_project->get_line_edit()->connect("text_changed", this, "_validate_export_path"); export_project->get_line_edit()->connect("text_changed", this, "_validate_export_path");
export_debug = memnew(CheckButton); export_debug = memnew(CheckBox);
export_debug->set_text(TTR("Export With Debug")); export_debug->set_text(TTR("Export With Debug"));
export_debug->set_pressed(true); export_debug->set_pressed(true);
export_project->get_vbox()->add_child(export_debug); export_project->get_vbox()->add_child(export_debug);
export_pck_zip_debug = memnew(CheckButton); export_pck_zip_debug = memnew(CheckBox);
export_pck_zip_debug->set_text(TTR("Export With Debug")); export_pck_zip_debug->set_text(TTR("Export With Debug"));
export_pck_zip_debug->set_pressed(true); export_pck_zip_debug->set_pressed(true);
export_pck_zip->get_vbox()->add_child(export_pck_zip_debug); export_pck_zip->get_vbox()->add_child(export_pck_zip_debug);

4
editor/project_export.h
View file

@ -141,8 +141,8 @@ private:
FileDialog *export_pck_zip; FileDialog *export_pck_zip;
FileDialog *export_project; FileDialog *export_project;
CheckButton *export_debug; CheckBox *export_debug;
CheckButton *export_pck_zip_debug; CheckBox *export_pck_zip_debug;
void _open_export_template_manager(); void _open_export_template_manager();