asgardius/virtualx-engine
1
0
Fork 0
Code Issues Pull requests Projects Releases 1 Packages Wiki Activity Actions

Merge pull request #49522 from JFonS/fix_surfacetool_tangents

Browse source 
Fix tangents array in SurfaceTool
This commit is contained in:
Rémi Verschelde 2021-06-12 01:08:03 +02:00 committed by GitHub
commit fe7559f751
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 4 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
scene/resources/surface_tool.cpp
View file

@ -370,13 +370,13 @@ Array SurfaceTool::commit_to_arrays() {
for (uint32_t idx = 0; idx < vertex_array.size(); idx++) { for (uint32_t idx = 0; idx < vertex_array.size(); idx++) {
const Vertex &v = vertex_array[idx]; const Vertex &v = vertex_array[idx];
w[idx + 0] = v.tangent.x; w[idx * 4 + 0] = v.tangent.x;
w[idx + 1] = v.tangent.y; w[idx * 4 + 1] = v.tangent.y;
w[idx + 2] = v.tangent.z; w[idx * 4 + 2] = v.tangent.z;
//float d = v.tangent.dot(v.binormal,v.normal); //float d = v.tangent.dot(v.binormal,v.normal);
float d = v.binormal.dot(v.normal.cross(v.tangent)); float d = v.binormal.dot(v.normal.cross(v.tangent));
w[idx + 3] = d < 0 ? -1 : 1; w[idx * 4 + 3] = d < 0 ? -1 : 1;
} }
a[i] = array; a[i] = array;