asgardius/virtualx-engine
1
0
Fork 0
Code Issues Pull requests Projects Releases 1 Packages Wiki Activity Actions

Merge pull request #58295 from Pineapple/ustring-optimizations

Browse source 
Optimize String concatenation and copy functions
This commit is contained in:
Rémi Verschelde 2022-02-21 08:45:23 +01:00 • committed by GitHub
commit fe8ea0de5b
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 32 additions and 43 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

75
core/ustring.cpp
View file

@ -108,9 +108,12 @@ bool CharString::operator<(const CharString &p_right) const {
} }
CharString &CharString::operator+=(char p_char) { CharString &CharString::operator+=(char p_char) {
resize(size() ? size() + 1 : 2); const int lhs_len = length();
set(length(), 0); resize(lhs_len + 2);
set(length() - 1, p_char);
char *dst = ptrw();
dst[lhs_len] = p_char;
dst[lhs_len + 1] = 0;
return *this; return *this;
} }
@ -217,11 +220,7 @@ void String::copy_from(const char *p_cstr) {
return; return;
} }
int len = 0; const size_t len = strlen(p_cstr);
const char *ptr = p_cstr;
while (*(ptr++) != 0) {
len++;
}
if (len == 0) { if (len == 0) {
resize(0); resize(0);
@ -232,7 +231,7 @@ void String::copy_from(const char *p_cstr) {
CharType *dst = this->ptrw(); CharType *dst = this->ptrw();
for (int i = 0; i < len + 1; i++) { for (size_t i = 0; i <= len; i++) {
dst[i] = p_cstr[i]; dst[i] = p_cstr[i];
} }
} }
@ -263,19 +262,17 @@ void String::copy_from(const CharType *p_cstr, const int p_clip_to) {
// p_length <= p_char strlen // p_length <= p_char strlen
void String::copy_from_unchecked(const CharType *p_char, const int p_length) { void String::copy_from_unchecked(const CharType *p_char, const int p_length) {
resize(p_length + 1); resize(p_length + 1);
set(p_length, 0);
CharType *dst = ptrw(); CharType *dst = ptrw();
memcpy(dst, p_char, p_length * sizeof(CharType));
for (int i = 0; i < p_length; i++) { dst[p_length] = 0;
dst[i] = p_char[i];
}
} }
void String::copy_from(const CharType &p_char) { void String::copy_from(const CharType &p_char) {
resize(2); resize(2);
set(0, p_char); CharType *dst = ptrw();
set(1, 0); dst[0] = p_char;
dst[1] = 0;
} }
bool String::operator==(const String &p_str) const { bool String::operator==(const String &p_str) const {
@ -312,27 +309,23 @@ String String::operator+(const String &p_str) const {
} }
String &String::operator+=(const String &p_str) { String &String::operator+=(const String &p_str) {
if (empty()) { const int lhs_len = length();
if (lhs_len == 0) {
*this = p_str; *this = p_str;
return *this; return *this;
} }
if (p_str.empty()) { const int rhs_len = p_str.length();
if (rhs_len == 0) {
return *this; return *this;
} }
int from = length(); resize(lhs_len + rhs_len + 1);
resize(length() + p_str.size());
const CharType *src = p_str.c_str(); const CharType *src = p_str.c_str();
CharType *dst = ptrw(); CharType *dst = ptrw() + lhs_len;
set(length(), 0); memcpy(dst, src, (rhs_len + 1) * sizeof(CharType));
for (int i = 0; i < p_str.length(); i++) {
dst[from + i] = src[i];
}
return *this; return *this;
} }
@ -343,9 +336,12 @@ String &String::operator+=(const CharType *p_str) {
} }
String &String::operator+=(CharType p_char) { String &String::operator+=(CharType p_char) {
resize(size() ? size() + 1 : 2); const int lhs_len = length();
set(length(), 0); resize(lhs_len + 2);
set(length() - 1, p_char);
CharType *dst = ptrw();
dst[lhs_len] = p_char;
dst[lhs_len + 1] = 0;
return *this; return *this;
} }
@ -355,22 +351,15 @@ String &String::operator+=(const char *p_str) {
return *this; return *this;
} }
int src_len = 0; const size_t rhs_len = strlen(p_str);
const char *ptr = p_str; const int lhs_len = length();
while (*(ptr++) != 0) {
src_len++;
}
int from = length(); resize(lhs_len + rhs_len + 1);
resize(from + src_len + 1); CharType *dst = ptrw() + lhs_len;
CharType *dst = ptrw(); for (size_t i = 0; i <= rhs_len; i++) {
dst[i] = p_str[i];
set(length(), 0);
for (int i = 0; i < src_len; i++) {
dst[from + i] = p_str[i];
} }
return *this; return *this;