Yuri Sizov
cfe2a14ec3
Merge pull request #74537 from nongvantinh/fix-74458
...
Fixes gutter set width results in receiving only half of the desired size
2023-03-20 15:31:28 +01:00
Fredia Huya-Kouadio
2c7633dce5
Fix the issue preventing dragging in the 2D and visual shader editor
2023-03-19 12:36:36 -07:00
Nong Van Tinh
bb3d0fc6b7
Fixes gutter set width results in receiving only half of the desired size
2023-03-20 00:14:16 +07:00
bruvzg
4793b6eee9
[RTL] Add option to customize list bullet, use U+2022 by default.
2023-03-17 09:34:28 +02:00
Yuri Sizov
a2a524df71
Prevent crash in ItemList when checking for visible items
...
Also some light code refactoring to make the drawing logic more manageable.
We also store each item's column for more reliable checks.
2023-03-16 12:25:11 +01:00
Yuri Sizov
a1c2f03055
Merge pull request #74898 from Spartan322/patch-1
...
Remove methods in header removed in c7eb814
2023-03-16 11:43:54 +01:00
George L. Albany
f3313ba4cd
Remove methods in header removed in c7eb814
...
c7eb814c7eb814
2023-03-15 21:13:38 -04:00
Andrej Eškinja
6ccef8b831
Fix for deselecting item when select_mode == SELECT_ROW
2023-03-15 15:46:53 +01:00
justchen1369
dbfecdb3b0
Fix exported type for Menubar start_index
2023-03-10 11:42:09 -05:00
Yuri Sizov
ff98395556
Prevent passing events from CodeEdit to TextEdit when code completion is active
2023-03-09 15:54:08 +01:00
Rémi Verschelde
677cba3d58
Merge pull request #67910 from pkowal1982/scroll_bar
...
Fix scrolling behaviour with zero/low page value
2023-03-08 14:06:30 +01:00
Yuri Sizov
dac2d8fb42
Merge pull request #68325 from pfertyk/issue-68242-rich-text-label-crash
...
Fix RichTextLabel crash with out of bound exception
2023-03-08 11:32:47 +01:00
Rémi Verschelde
0ef3d1bf56
Merge pull request #73188 from Sauermann/fix-inconsistent-viewport-size
...
Fix some ways to create inconsistent Viewport size states
2023-03-07 12:04:00 +01:00
Arman Elgudzhyan
688d00b706
Don't autocomplete numbers in GDScript
...
Cancel code autocompletion when a numerical value is entered. Avoids interference when setting numbers.
2023-03-06 14:20:24 -08:00
bruvzg
25bc62ad13
[TextEdit] Do not draw virtual spaces (word break / justification points).
2023-03-06 15:01:43 +02:00
Rémi Verschelde
0b98b470cc
Merge pull request #73716 from bruvzg/improve_locale_selection
...
Improve layout direction/locale automatic selection.
2023-03-06 10:57:56 +01:00
Rémi Verschelde
45738d078a
Merge pull request #74472 from bruvzg/ime_single_pos
...
Fix IME position in the single window mode sub-windows.
2023-03-06 10:57:25 +01:00
bruvzg
3ca3ee36ab
Fix IME position in the single window mode sub-windows.
2023-03-06 10:08:55 +02:00
Rémi Verschelde
d81e6ee024
FBX: Disable importer when canceling FBX2glTF setup
...
Pretty hacky solution but it's better than an infinite loop.
All this import setup needs to be redone, it's very difficult to properly
bail out from an invalid import without triggering reimport loops.
Also fix underline not visible at default editor scale in LinkButton.
Fixes #73319 .
2023-03-03 13:53:03 +01:00
Paweł Fertyk
44592c8c19
Fix RichTextLabel crash with out of bound exception
...
Fixes #68242 .
2023-02-28 22:49:57 +01:00
bruvzg
315164c619
[TextEdit / IME] Check selection before deleting to avoid unnecessary error messages.
2023-02-27 08:58:28 +02:00
bruvzg
cebfc02d6f
Revert "Reordering emitted signals in PopupMenu" and fix editor selection issue in the safer way.
2023-02-24 21:17:05 +02:00
Rémi Verschelde
76d4d09bfa
Revert Label text reshaping fix #71553 and subsequent regression fixes
...
Despite a lot of great work from Pedro to try to improve the Label text
reshaping logic and fix subsequent regressions, we found ourselves still
chasing more edge cases, such as #73736 (which got reverted already due
to it causing yet another regression).
In parallel, it seems like the crash scenario that #71553 was addressing
got solved differently in the master branch, so it appears like this
change is no longer necessary at all (at least not urgently), so we
decided to revert to the previous known "ok" state of Label.
- Revert #71553 "Prevent infinite cascade of re-layout after label text reshaping"
This reverts commit ed8c5cd52f#72387 "Enhance label sizing algorithm"
This reverts commit 5131b81a4d#73234 "Fix blank non-autowrapping labels"
This reverts commit 3ccabee9ae#73343 "Make label sizing algorithm more robust"
This reverts commit 4f7f1ef60b#73426 "Fix width determination of non-trimmed, non-wrapped labels"
This reverts commit 73b6c0b972
2023-02-23 10:36:42 +01:00
Michael Alexsander
c567a853db
Fix GraphNode resizing when its bottom border is too thin
2023-02-23 01:42:06 -03:00
Rémi Verschelde
d66f6b3b04
Revert "Fix visible_lines calculation"
...
This reverts commit ceee405cec#73736 and #73780 .
Fixes #73780 .
2023-02-22 22:44:55 +01:00
Rémi Verschelde
d8014e9fab
Merge pull request #73736 from helviett/fix_visible_lines_calculation
...
Fix visible_lines calculation
2023-02-22 14:50:06 +01:00
helviett
ceee405cec
Fix visible_lines calculation
2023-02-22 14:17:52 +04:00
Rémi Verschelde
be336cea1e
Merge pull request #73587 from YuriSizov/rtl-the-underliner
...
Ensure minimal thickness for `RichTextLabel` underlines
2023-02-22 10:14:32 +01:00
bruvzg
82d7923c65
Improve layout direction/locale automatic selection.
2023-02-22 08:37:14 +02:00
Rémi Verschelde
69b99730e0
Merge pull request #73597 from MewPurPur/add-missing-queue-redraw--oh-wait-that-barely-narrows-it-down
...
Fix Indent/Unindent without a selection not causing a redraw
2023-02-20 11:28:18 +01:00
VolTer
9de731a9ec
Fix Indent/Unindent without a selection not causing a redraw
2023-02-19 21:08:04 +01:00
Yuri Sizov
28b7556914
Ensure minimal thickness for RichTextLabel underlines
2023-02-19 13:42:25 +01:00
Paulb23
60161cbe7d
Fix ctrl+backspace crash with multicarets on the same line
2023-02-19 12:04:14 +00:00
Yuri Sizov
236cec0633
Add a custom icon for the project.godot file in the EditorFileDialog
2023-02-17 22:42:23 +01:00
Dawid Marzec
b05572b7d0
Fix TreeItem's button being rendered under Selected highlight
2023-02-17 21:49:31 +01:00
Yuri Sizov
6bb4b00647
Merge pull request #73508 from nongvantinh/reorder-emitted-signals
...
Reordering emitted signals in PopupMenu
2023-02-17 21:17:01 +03:00
Nong Van Tinh
5928d801a9
Reordering emitted signals in PopupMenu
2023-02-17 23:18:56 +07:00
Rémi Verschelde
a0afeb5d5a
Merge pull request #72184 from Maran23/item-list-index-out-of-bounds
...
ItemList: Check if the index is out bounds before accessing the internal items
2023-02-17 16:20:49 +01:00
Rémi Verschelde
9004279afb
Merge pull request #70781 from jamesmintram/jamesm/bugfix/fix-minimap-oob
...
Fix error spam when hovering minimap in the script editor
2023-02-17 15:20:19 +01:00
bruvzg
7246b229e1
Set RTL minimal dash size to 2.0, add invalid dash size error to the draw_dashed_line.
2023-02-17 08:53:08 +02:00
Rémi Verschelde
2824774d29
Merge pull request #69801 from nongvantinh/fix-invalid-scene-name
...
Fixed scene name can be saved as extension only
2023-02-17 00:35:00 +01:00
Rémi Verschelde
b90d70d592
Merge pull request #72764 from Sauermann/fix-color-picking
...
Fix Color Picking
2023-02-17 00:33:20 +01:00
Nong Van Tinh
010ddfbc16
Prevent saving files with no name and only an extension.
...
Fixes #69768 .
Co-authored-by: Rémi Verschelde <rverschelde@gmail.com>
2023-02-17 00:23:15 +01:00
James Mintram
aa024296d1
Fix error spam when hovering minimap in the script editor
2023-02-16 22:03:01 +01:00
Rémi Verschelde
25da47edd6
Merge pull request #73396 from KoBeWi/sorry
...
Fix crash with AspectRatioContainer and TextureRect
2023-02-16 18:34:41 +01:00
kobewi
a12921ca2c
Fix crash with AspectRatioContainer and TextureRect
2023-02-16 14:35:09 +01:00
Pedro J. Estébanez
73b6c0b972
Fix width determination of non-trimmed, non-wrapped labels
...
In other words, exclude trimmable labels from the special logic used for non-wrapping ones, since they are not expected to dictate their width authoritatively.
2023-02-16 11:54:57 +01:00
Rémi Verschelde
2874961309
Merge pull request #73343 from RandomShaper/labels_are_evil
...
Make label sizing algorithm more robust
2023-02-15 22:34:21 +01:00
Pedro J. Estébanez
4f7f1ef60b
Make label sizing algorithm more robust
2023-02-15 18:00:29 +01:00
Yuri Sizov
f2aae8fa5c
Merge pull request #73349 from dalexeev/fix-tab-bar-redraw
...
Fix `TabBar` not redrawing on locale change
2023-02-15 18:23:25 +03:00
Danil Alexeev
1cdf3398a0
Fix TabBar not redrawing on locale change
2023-02-15 14:51:31 +03:00
Yuri Sizov
d2b1474da7
Merge pull request #73293 from RedMser/rich-text-label-fixes
...
RichTextLabel: Unexpose internal ItemType enum, improve `push_meta` docs
2023-02-15 12:58:23 +03:00
VolTer
d16df33021
Fix autocomplete persisting at the beginning of a line
2023-02-15 09:24:13 +01:00
RedMser
22dd621cf9
RichTextLabel fixes
...
- Unexpose ItemType enum, since it is not used in public API.
- Fix documentation for meta tag, since it has no BBCode equivalent.
2023-02-14 17:20:05 +01:00
bruvzg
39b69e6f76
[Editor] Fix editor progress dialog auto closing on ESC press, and on application focus loss.
2023-02-14 09:23:40 +02:00
Pedro J. Estébanez
3ccabee9ae
Fix blank non-autowrapping labels
2023-02-13 18:46:56 +01:00
Rémi Verschelde
98d5e0b72f
Merge pull request #73191 from KoBeWi/some_color_picker_stuff
...
Fix HSV Rectangle Wheel values
2023-02-13 12:56:32 +01:00
M4rYu5
97d355c13d
Now, in editor, CapsLock behave like a modifier key: does nothing when pressed alone.
...
Before, it ended up closing the code completion, and rerendering portions of editor.
2023-02-13 10:46:00 +02:00
Rémi Verschelde
b7723a01d9
Merge pull request #66745 from EricEzaM/66453-popupmenu-shortcut-shape-fix
...
Ensure PopupMenu item is shaped when the shortcut is set.
2023-02-13 09:29:41 +01:00
Rémi Verschelde
a90bbc3544
Merge pull request #72225 from MinusKube/shaped_text_invalidated_bug
...
Mark dirty flags when shaped texts are invalidated
2023-02-13 09:13:27 +01:00
Rémi Verschelde
428bf1188d
Merge pull request #72387 from RandomShaper/avoid_infinite_2
...
Enhance label sizing algorithm (a.k.a. prevent infinite GUI re-layout)
2023-02-13 09:13:00 +01:00
Markus Sauermann
34a7fc7447
Fix some ways to create inconsistent Viewport sizes
...
In the editor, it was possible to set the size of a `SubViewport` even
in cases where a parent `SubViewportContainer` had stretch enabled.
This PR disables editing a `SubViewport.size` while the parent disallows
it and it makes necessary adjustments during `NOTIFICATION_ENTER_TREE`.
2023-02-13 08:19:00 +01:00
kobewi
3542d24fda
Fix HSV Rectangle Wheel values
2023-02-13 01:18:44 +01:00
Hendrik Brucker
3aab79914c
Fix GraphEdit port hotzone snapping
2023-02-12 01:31:58 +01:00
Rémi Verschelde
008cafc103
Merge pull request #72378 from maximkulkin/line-edit-consume-events
...
Fix LineEdit not consuming events
2023-02-10 15:08:28 +01:00
Rémi Verschelde
29d89caafe
Merge pull request #72714 from DarkMessiah/fix-unlimited-text-in-tree
...
Fix unlimited text rendering in Tree if width <= 0
2023-02-10 15:07:18 +01:00
Rémi Verschelde
5c1295dc20
Merge pull request #72884 from groud/fix_trackpad_viewpanner
...
Fix panning via InputEventPanGesture
2023-02-09 16:44:56 +01:00
Hendrik Brucker
4601acbaf4
Update GraphEdit configuration warning, mark GraphNode/GraphEdit as experimental
2023-02-09 02:39:55 +01:00
Markus Sauermann
888add8418
Fix Color Picking
...
With the 4.x-introduction of Windows the previous method for
color picking was no longer working.
This PR uses the following approach to reintroduce color-picking.
When the Color-Picking-Button is pressed, a quasi-screenshot of the
Window-content is created and displayed in a new Popup-Window.
This new Window allows selecting colors by Mouse-Click.
A Preview of the targeted Color is also displayed.
2023-02-09 01:00:54 +01:00
Gilles Roudière
ca4bc8de81
Fix panning via InputEventPanGesture
...
Co-authored-by: bruvzg <7645683+bruvzg@users.noreply.github.com>
2023-02-08 12:01:20 +01:00
Rindbee
c73844f117
Use min_size/max_size to limit the window size and the position while popup center
2023-02-07 21:28:26 +08:00
Rémi Verschelde
fe2cd2e6b1
Merge pull request #72770 from Kabiirk/Control-has-point-doc-update
...
Fix description and argument name in `Control._has_point`
2023-02-06 22:50:47 +01:00
Kabiir
17ee6fcf03
Fix description and argument name in Control._has_point
2023-02-07 02:29:28 +05:30
Markus Sauermann
084a4addc4
Fix Screen-Transform missing in Button Size in OptionButton::show_popup
...
The button size is affected by the screen transform, which was previously
not taken into consideration.
2023-02-06 20:58:57 +01:00
Yuri Sizov
9d3b4b0b40
Merge pull request #72204 from MinusKube/anchorable_rect_editor_bug
...
Fix get_parent_anchorable_rect() not returning the correct size in some cases
2023-02-06 16:28:19 +03:00
Pedro J. Estébanez
5131b81a4d
Enhance label sizing algorithm
2023-02-06 14:12:29 +01:00
Stanislav Labzyuk
0c766ef271
Fix unlimited text rendering in Tree if width <= 0
2023-02-04 16:17:42 +01:00
Yuri Sizov
e14cacb8da
Merge pull request #71862 from RedMser/splitcontainer-fixes
...
Fix SplitContainer rendering and theming
2023-02-03 23:09:18 +03:00
Maxim Kulkin
5adc7e397e
Fix LineEdit not consuming events
...
The most important issue is LineEdit not consuming
"ui_text_submit" event which makes pressing Enter after
editing escape to other components causing unwanted
interactions.
Also fix handling mouse button interactions not consuming
some events.
Also implement early return in case we know which event
type it is and there is no point in checking other event
types.
PS I'm also suspicious that mouse motion events also need
to be consumed, but haven't explored those cases.
2023-02-03 14:38:12 -05:00
Danil Alexeev
fb107e04d3
Fix RichTextLabel context menu not customizable
2023-02-03 12:07:36 +03:00
Markus Sauermann
3bc426c9d8
Fix toplevel nomenclature
...
toplevel was 3.x
top_level is 4.x
2023-02-02 17:37:41 +01:00
Rémi Verschelde
9c84aae940
Merge pull request #72471 from mbrlabs/blink
...
Always show caret when moving in LineEdit
2023-02-02 09:35:16 +01:00
bruvzg
9f42649823
[X11] Fix IME subwindow in the popup not getting input focus.
2023-02-01 11:10:10 +02:00
Rémi Verschelde
d9ade633b3
Merge pull request #71936 from akien-mga/remove-some-unused-signals
...
Remove some unused signals
2023-02-01 07:53:52 +01:00
Rémi Verschelde
a5be03e59a
Merge pull request #72476 from TokageItLab/graph-signal
...
Fix `scroll_offset_changed` signal doesn't fired when panning `GraphEdit`
2023-02-01 07:43:05 +01:00
Rémi Verschelde
51414fc987
Merge pull request #66906 from Sauermann/fix-prohibit-inconsistent-size-state
...
Prohibit inconsistent size state for SubViewport
2023-02-01 07:26:00 +01:00
Silc Renew
8f21f637e2
Fix scroll_offset_changed signal doesn't fired when panning GraphEdit
2023-02-01 07:11:35 +09:00
Markus Sauermann
decbda68d7
Prohibit inconsistent size state for SubViewport
...
Prohibit size changes of SubViewports with parent SubViewportContainers that have stretch mode enabled.
2023-01-31 22:53:43 +01:00
Marcus Brummer
a54cb5b07b
Always show caret when moving in LineEdit
2023-01-31 20:56:06 +01:00
Rémi Verschelde
b342dcdf04
Remove some unused signals
...
Part of #37604 .
2023-01-31 18:54:04 +01:00
Rémi Verschelde
4cfdd25384
Merge pull request #67507 from Sauermann/fix-toplevel-root-control-node
...
Fix event propagation to child after set_as_toplevel
2023-01-31 15:55:46 +01:00
anish bhobe
42a9c33fad
Updates VideoDecoder plugin API to GDExtension.
...
Adds VideoStream and relevant resource loaders to migrate
external GDNative plugins to GDExtension.
Adds a VideoStreamLoader as a specialization of ResourceFormatLoader
as ClassDB::is_parent_class is inaccessible from GDExtension currently.
Using Object* instead of Ref<T> in order to avoid the refcount bug
(godotengine/godot-cpp#652 )
Also another bug is in ResourceLoader in use on the extension side that
requires fixing.
2023-01-30 18:39:29 -08:00
bruvzg
0cc1f4240a
[RichTextLabel] Fix thread unsafe set_physics_process_internal usage. Use WorkerThreadPool instead of creating new threads.
2023-01-30 20:47:45 +02:00
Rémi Verschelde
915bdd4b4d
Merge pull request #71896 from poohcom1/fix/autocomplete-substring-filter
...
Fix autocomplete filter not including substrings
2023-01-29 14:10:53 +01:00
MinusKube
0f512a68dd
Fix get_parent_anchorable_rect() not returning the correct size in some cases
2023-01-28 20:09:24 +01:00
Stanislav Labzyuk
068f4d88f6
Fix connections drawing in GraphEdit minimap
2023-01-28 18:55:14 +01:00
MinusKube
d59c221404
Mark dirty flags when shaped texts are invalidated
2023-01-28 03:31:55 +01:00
Marius Hanl
bcf3c81726
ItemList: Check if the index is out bounds before accessing the internal items
...
The following keys may lead to the exception described above under certain conditions:
- ui_page_up
- ui_page_down
- ui_left
- ui_right
2023-01-27 18:34:18 +01:00
Rémi Verschelde
3e1925fd00
Merge pull request #58334 from Sauermann/fix-to-gui-or-not-to-gui
...
Fix SubViewportContainer processing Events before other Control-Nodes
2023-01-27 10:39:49 +01:00
Rémi Verschelde
22e1575021
Merge pull request #72167 from dalexeev/line-text-edit-context-menu
...
Fix `LineEdit` and `TextEdit` context menus not customizable
2023-01-27 10:32:34 +01:00
