Commit graph

2988 commits

Author SHA1 Message Date
Marius Hanl
09f974b21d Check for null event in Tree._gui_input to avoid engine crash 2022-12-15 17:35:53 +01:00
Haoyu Qiu
6f69d29398
Fix crash after executing ItemList.set_icon_scale
(cherry picked from commit 8d0fa193c3)
2022-12-13 14:24:25 +01:00
Hugo Locurcio
c54c1b0b6b
Fix infinite loop when calling Control.popup_centered_minsize()
Co-authored-by: sriramun <sriramun2@gmail.com>
(cherry picked from commit 08e804b3b7)
2022-12-12 14:49:23 +01:00
Dawid Marzec
ecef4804f2
Fix errors while deselecting all tree items; issue #65185
(cherry picked from commit d4d5df2314)
2022-12-12 14:49:23 +01:00
Rémi Verschelde
bfce0c1e52
Merge pull request #59765 from pfertyk/issue-59359-wrong-visible-line-count-if-newline
Fix wrong visible line count for newline
2022-12-12 13:40:14 +01:00
Phnix
9ac09dfb64 incorrect range value with min value and step
If the minimum value and the steps are greater than 0, the value will not be calculated correctly.

Co-Authored-By: Astral-Sheep <109028693+Astral-Sheep@users.noreply.github.com>
(cherry picked from commit fe1f8443a4)
2022-12-12 14:22:54 +08:00
Haoyu Qiu
7bdbfbf822 Fix TreeItem.remove_child not updating Tree immediately 2022-12-04 21:37:19 +08:00
Dawid Marzec
1a123070c8 Remove auto selecting the first file for FileDialog with Save file mode selected
(cherry picked from commit 5cd30be56d)
2022-12-01 12:27:43 +08:00
Micky
2ab79719b2
Fix ColorPicker always emitting color_changed on html submit
The color change was always emitted when the the modal was closed, even if it was exactly the same as before.

(cherry picked from commit 544727ac1e)
2022-11-30 15:36:25 +01:00
Nong Van Tinh
ffbaa7fff0 Enhance null checking for input event 2022-11-27 15:01:34 +07:00
Rémi Verschelde
1ad9992ab7
Merge pull request #67995 from YeldhamDev/how_backporting
[3.x] Stop centering clicked suggestions in the autocomplete popup
2022-11-14 23:52:00 +01:00
Rémi Verschelde
d80396db03
Merge pull request #68556 from 98teg/flow-container-alignment
Add alignment options to flow container
2022-11-14 14:35:46 +01:00
Michael Alexsander
7a682236df Stop centering clicked suggestions in the autocomplete popup 2022-11-13 09:17:05 -03:00
Teggy
5d0c29460a Add alignment options to flow container 2022-11-12 12:11:16 +01:00
arkology
afdf00c40f [3.x] AtlasTexture in radial modes of TextureProgress 2022-11-04 13:24:47 +03:00
kobewi
a0ad958582 Hide text of RichTextLabel if BBCode is enabled 2022-10-11 15:21:19 +02:00
Waridley
199f3d99c3 Support multiline strings in buttons 2022-10-01 21:50:39 -05:00
Rémi Verschelde
2aee09c6bc
Merge pull request #65428 from lawnjelly/input_uninit 2022-09-09 14:28:06 +02:00
Rémi Verschelde
92fa63886c
Merge pull request #65397 from maximkulkin/3.x-graph-edit-node-selection 2022-09-07 17:52:24 +02:00
Abhinav Chennubhotla
8acc25578e Fix code folding icon color not matching defined color
Cherrypick of #58457 in master

Caused by reusing icons from the main editor in the code editor. These
icons were converted based on the main editor theme and not the code
editor theme.

    - Create new icons for use specifically in the code editor
    - Add these icons to the exceptions when converting dark theme icons
    to light theme automatically
    - Change the default value of the code folding color to match previous
    color
    - Code folding icon is now pure white by default to correctly match
    the color defined in settings
2022-09-06 21:50:33 +05:30
lawnjelly
d60eae3dbc Fix uninitialized data reads in Input
Found by Valgrind.
2022-09-06 14:21:01 +01:00
lawnjelly
fa4a325180 FlowContainer fix uninitialized data
This uninitialized data was finding its way into the renderer.
2022-09-06 09:04:00 +01:00
Maxim Kulkin
466c912344 Add GraphNode 'selected' and 'unselected' signals, simplify GraphEdit
Backport of the fix from master to 3.x
2022-09-06 01:35:58 -04:00
kobewi
8c9cd1d3ae Hide prefix/suffix on SpinBox focus 2022-08-29 18:06:25 +02:00
Rémi Verschelde
47da910fcb
Merge pull request #64965 from YeldhamDev/more_hl_stuff_bp 2022-08-29 08:05:54 +02:00
Rémi Verschelde
ec23113403
Merge pull request #64968 from YeldhamDev/pm_up_fix_bp 2022-08-29 07:56:22 +02:00
Rémi Verschelde
8551d5875e
Merge pull request #64707 from YeldhamDev/tabs_button_expose
Expose `set/get_tab_button_icon()` to scripting
2022-08-28 23:29:58 +02:00
Michael Alexsander
1e80b17a8d Fix some corner cases in the Menu/OptionButton item auto-highlight 2022-08-28 01:45:08 -03:00
Michael Alexsander
f0d380c9fd Fix crash when pressing up on an empty PopupMenu 2022-08-27 18:26:31 -03:00
Rémi Verschelde
6358e41772
Merge pull request #64838 from akien-mga/3.x-cherrypicks
Cherry-picks for the 3.x branch (future 3.6) - 2nd batch
2022-08-25 00:51:19 +02:00
Rémi Verschelde
04a857fe86
Merge pull request #64636 from YeldhamDev/menu_buttons_popup_fix_bp
[3.x] Make `Menu/OptionButton` item auto-highlight behave better
2022-08-24 19:06:37 +02:00
Michael Alexsander
245d70bec0 Fix ItemList selection visual when the scrollbar visibility changes
(cherry picked from commit e298144a41)
2022-08-24 17:23:59 +02:00
Michael Alexsander
73470e1b16 Expose set/get_tab_button_icon() to scripting 2022-08-22 11:08:38 -03:00
Michael Alexsander
50506e19a6 Make Menu/OptionButton item auto-highlight behave better 2022-08-19 15:19:34 -03:00
Haoyu Qiu
4c47c6ab75 Tree: Don't draw selection background of individual cells in Row mode 2022-08-09 17:07:53 +08:00
kobewi
520d341836 Add root_subfolder to FileDialog 2022-08-08 19:50:41 +02:00
Rémi Verschelde
f30a2c1292
Merge pull request #63113 from snailrhymer/3.x-folding-comment-fix 2022-08-08 15:54:57 +02:00
Rémi Verschelde
0e93600fe0
Merge pull request #62644 from Piralein/remove_redundant_checkbox_check 2022-08-05 19:37:47 +02:00
Rémi Verschelde
26762a71b6
Merge pull request #58537 from winterpixelgames/feature/virtual-keyboard-types-3.x 2022-08-05 19:37:13 +02:00
Rémi Verschelde
d2d77c93bc
Merge pull request #61588 from YuriSizov/control-fix-theme-owner-toplevel-3.x 2022-08-05 19:34:05 +02:00
Rémi Verschelde
818f1eed31 Code quality: Fix header guards consistency
Adds `header_guards.sh` bash script, used in CI to validate future
changes. Can be run locally to fix invalid header guards.
2022-07-25 14:53:37 +02:00
Rémi Verschelde
be5051422b Revert "Call update_scrollbars() in sort_children() so the max is set properly so you can set scroll_container.scroll_vertical instantly after adding children to a scroll container."
This reverts commit b73d2980b7.

This caused a regression. Fixes #63417.
2022-07-25 11:29:33 +02:00
Jason Knight
b73d2980b7 Call update_scrollbars() in sort_children() so the max is set properly so you can set scroll_container.scroll_vertical instantly after adding children to a scroll container. 2022-07-21 12:25:50 -06:00
SnailRhymer
efed5087ae Change code folding behavior to include terminal indented comments
Previously, when folding a block of code that finished with an indented comment (i.e. one indented as much as or more than the starting indent of the code), that comment would be left out of the fold. Change the behavior to include such comments, but still leave less-indented ones out.
2022-07-17 17:38:51 +01:00
Brian Semrau
ce24b48e50 Add support for multiple virtual keyboard types 2022-07-07 14:22:28 -04:00
Thakee Nathees
da626d8922 Fix FileDialog file name autocompletion with filters
Fixes #38195.

(cherry picked from commit 446f1b7052)
2022-07-06 11:39:04 +02:00
Haoyu Qiu
d86a2d57cf Fix LineEdit caret after using arrow key to deselect 2022-07-06 09:32:39 +08:00
Hana
36ff8962cc
remove redundant check preventing checkbox theme style to apply hover_pressed 2022-07-02 20:53:02 +02:00
kobewi
14f69acaa4 Fix find_next_valid_focus() freeze
(cherry picked from commit 8d62b736b2)
2022-07-01 14:00:55 +02:00
kobewi
f659869a45 Fix find_next_valid_focus() freeze
(cherry picked from commit d9ede52ded)
2022-06-30 19:23:01 +02:00
ConteZero
a13b3028a2 Add an option to drag'n'drop selected text in TextEdit
(cherry picked from commit 5d56efcaa4)
2022-06-30 19:23:01 +02:00
Rémi Verschelde
0c5c5381d7
Merge pull request #61980 from KoBeWi/obliterate_scroll
Disable scroll when dragging at edges of TextEdit
2022-06-14 23:47:17 +02:00
kobewi
053fdb8872 Disable scroll when dragging at edges of TextEdit 2022-06-14 23:36:54 +02:00
Rémi Verschelde
606ec57d2c
Merge pull request #61985 from bruvzg/win_net_share3
[Windows, 3.x] Add support for handling network share paths.
2022-06-13 09:16:13 +02:00
bruvzg
64a107508a
[3.x] Improve RTL table fill. 2022-06-13 09:57:35 +03:00
bruvzg
11a7997a67 [Windows, 3.x] Add support for handling network share paths. 2022-06-13 09:24:35 +03:00
Rémi Verschelde
4987cd43bf
Merge pull request #61346 from AaronRecord/fix-scrollbars-initializing 2022-06-10 14:24:27 +02:00
bruvzg
f5fa1ca944
Add readable export errors. Add RTL image vertical alignment support. 2022-06-08 17:56:28 +03:00
Rémi Verschelde
70951b3a9c
Merge pull request #61728 from YeldhamDev/always_clear_backport
[3.x] Take into account the clear icon's size even when not visible in `LineEdit`s
2022-06-07 14:16:32 +02:00
Rémi Verschelde
e80dfb7b12
Merge pull request #61687 from YeldhamDev/double_hover_fix
Fix hover being drawn twice inside `PopupMenu`s
2022-06-06 13:17:25 +02:00
Michael Alexsander
43b0e054be Take into account the clear icon's size even when not visible in LineEdits 2022-06-05 16:22:01 -03:00
Michael Alexsander
b4e4f88cd9 Fix specific bug related to submenus in PopupMenu 2022-06-04 13:26:12 -03:00
Michael Alexsander
78fdebf8cc Fix hover being drawn twice inside PopupMenus 2022-06-04 02:51:22 -03:00
Yuri Sizov
8ed297fc83 Fix theme propagation for children of top level controls 2022-06-01 03:56:51 +03:00
Rémi Verschelde
b44928586b
Merge pull request #61483 from kleonc/popup-update-exclusive-when-shown
[3.x] Allow changing `exclusive` of already popped up `Popup`
2022-05-31 12:14:37 +02:00
Haoyu Qiu
1e6747d185 Fix LineEdit clear button for asymmetric stylebox 2022-05-28 19:51:50 +08:00
kleonc
9ba598f94f Allow changing exclusive of already popped up Popup 2022-05-28 01:10:49 +02:00
kleonc
736b0c4e97 PopupMenu Fix hover stylebox overflowing horizontally 2022-05-27 23:35:17 +02:00
Aaron Record
ae9e523025 [3.x] Allow ScrollBar params of a ScrollContainer to be modified from _ready()
Cherrypicks b8610dbd31
2022-05-23 21:46:59 -06:00
bruvzg
dc6d8d6098
Backport Label3D node implementation and Sprite*3D material render priority. 2022-05-23 09:14:41 +03:00
Haoyu Qiu
4a03bc8f75 Update last min size when Control becomes visible
(cherry picked from commit 4ac999cc3f)
2022-05-22 19:43:56 +02:00
Daniel Kariv
47ead8504a add check for selection when try to push a meta.
Add a check for when we select a text but end on a link. Before it would act as if we just click an link, but now it changes it so if we click-drag over a link, we could select it (and not move to other page).

(cherry picked from commit e6c909b489)
2022-05-22 19:26:45 +02:00
Rémi Verschelde
78a9d21da3
Merge pull request #61185 from okla/3.x 2022-05-19 12:02:14 +02:00
Sergey Pershenkov
46ab2512b8 Return -1 from get_selected_id() when not selected
Partial cherry pick from 3b146c5eaa
2022-05-19 12:42:54 +03:00
Rémi Verschelde
b7523a953f Revert invalid PopupMenu breaking change from #61102
Fixes #61179.
2022-05-19 10:02:02 +02:00
Yuri Rubinsky
32b9818965 Add node list param to GraphEdit::delete_nodes_request signal 2022-05-18 12:36:00 +03:00
Rémi Verschelde
281c5c9a56
Merge pull request #61102 from okla/3.x
[3.x] Make various improvements to OptionButton
2022-05-16 23:51:55 +02:00
Sergey Pershenkov
431c032d8c Make various improvements to OptionButton
- Allow OptionButton selection to be set to -1 to signify no selection, both via API and in the editor.
- Reset OptionButton selection to -1 when the selected item has been removed.
- Fully convert PopupMenu to a zero-based ID system, which improves an inconsistency in generated IDs when making new items in the editor.

(cherry picked from commit 3b146c5eaa)
2022-05-16 22:47:46 +03:00
Markus Sauermann
ff52becb47 Distribute remaining pixel to expanding childs of GridContainer
(cherry picked from commit 6b3207644b)
2022-05-16 21:12:21 +02:00
Hendrik Brucker
7a4187495d Fix button icon expansion calculation with empty text
(cherry picked from commit c09a5e2774)
2022-05-16 17:14:43 +02:00
FireForge
f17c5fa7bd Add interpolation modes to Gradient
- Linear, Constant, and Cubic interpolation modes
- Partial backport of #53321
2022-05-12 14:24:04 -05:00
Rémi Verschelde
20c72e8275
Merge pull request #60891 from YeldhamDev/pm_sep_font 2022-05-09 13:57:02 +02:00
Haoyu Qiu
20d3632268 Fix tree button icon not centered vertically 2022-05-09 10:53:02 +08:00
Michael Alexsander
2e4e76b2e3 Add font_separator to PopupMenu 2022-05-08 14:11:59 -03:00
Michael Alexsander
4f70201fbe Fix separator height influencing labeled variation in PopupMenu 2022-05-07 21:15:57 -03:00
Rémi Verschelde
e61c4dd787
Merge pull request #60282 from YeldhamDev/backwards_relationships_are_even_harder 2022-05-02 09:49:09 +02:00
bruvzg
ff381f6e84
Fixed implementation of RTL remove_line()
Co-authored-by: Eric M <itsjusteza@gmail.com>
2022-04-29 10:59:31 +03:00
Rémi Verschelde
510ed791f9
Merge pull request #60554 from timothyqiu/editor-settings-cleanup 2022-04-27 11:51:03 +02:00
Rémi Verschelde
3b2ed9bdd6
Merge pull request #60330 from Calinou/aspectratiocontainer-add-property-hint-3.x 2022-04-27 10:17:04 +02:00
Haoyu Qiu
d088128b43 Remove duplicate editor settings definitions 2022-04-27 15:26:46 +08:00
Haoyu Qiu
d43b4039db Fix Label autowrap for CJK text 2022-04-18 21:54:46 +08:00
Hugo Locurcio
90044d6ac9
Add a property hint for AspectRatioContainer's ratio property
Zero or negative ratios are not valid, so the property hint prevents
choosing such values.

The property hint allows using 4 decimals so that common aspect ratios
like 16/9 can be specified with a good level of precision.
2022-04-17 22:04:39 +02:00
Michael Alexsander
b6c501f9b0 Draw relationship lines for items offscreen 2022-04-15 16:31:15 -03:00
Michael Alexsander
21bdadbf79 Fix GridContainer not ignoring toplevel children
(cherry picked from commit 506d8ba526)
2022-04-14 21:36:07 +02:00
Rémi Verschelde
8182a754d2
Merge pull request #59827 from ConteZero/fix_right_menu 2022-04-14 21:29:57 +02:00
Rémi Verschelde
4e4f6311b6
Merge pull request #60233 from ZheisterCoding/leading-space-fix-3.x
Fixed leading spaces pushing text outside Label autowrap boundary problem
2022-04-14 12:15:33 +02:00
DESKTOP-893BK8A\howar
c0513268bd Fixed #59985 leading spaces autowrap boundary problem
Bug problem:
No condition for when the first character of the label is a space character

Fix:
Added an IF condition for when the first character is a space character
The autowrap boundary treat this space character as another dummy word in the WordCache linked list and proceed to function normally, by detecting when line width is 0
2022-04-14 16:05:35 +07:00
Haoyu Qiu
19a0145742 Fix undo history for function name autocompletion 2022-04-14 14:37:31 +08:00
Eric McGuirk
f82cd740cf Fix toggling GraphEdit's minimap with minimap_enabled
Fixes #53831.

(cherry picked from commit b1441bbcfc)
2022-04-13 11:43:49 +02:00
kobewi
bf6e7dc6f6 Fix GraphEdit's valid connections being reversed
(cherry picked from commit b29aff8dac)
2022-04-13 11:43:49 +02:00