Commit graph

5826 commits

Author SHA1 Message Date
Rémi Verschelde
37d164e24e CharFXTransform: Drop unnecessary get_value_or()
See https://github.com/godotengine/godot/pull/23658#issuecomment-562706669
The method was implemented back when Dictionary.get(key, default) did not
exist, but now that it does we do not need a custom method in CharFXTransform.

It's a new feature in 3.2, so does not break compat with 3.1.x.
2019-12-12 07:47:08 +01:00
jitspoe
2c894f3426 Fix for collision polygon not working at all on exported builds.
(cherry picked from commit a169e1406de77c3abfe670217f18bcf2c1468bae)
2019-12-12 00:13:44 -05:00
Andrii Doroshenko (Xrayez)
81db0e9274 Provide default Tween values for transition and easing types
TRANS_LINEAR and EASE_IN_OUT are chosen as defaults for
interpolation and follow methods.
2019-12-12 02:15:15 +02:00
Tomasz Chabora
77a8657633 Scroll ScrollContainer to focused children 2019-12-11 14:29:36 +01:00
Aaron Franke
a139104646
Expose Mesh get_aabb 2019-12-11 08:25:36 -05:00
Rémi Verschelde
30cf60bb89
Merge pull request #34259 from timothyqiu/validate-texture-32982
Fixes crash after set_piece_texture with invalid texture
2019-12-11 08:41:29 +01:00
Rémi Verschelde
ea865d0e7e
Merge pull request #34241 from timothyqiu/sync-fallbacks-size-32701
Fixes crash when using DynamicFont::set_font_data
2019-12-11 08:34:21 +01:00
Rémi Verschelde
74381c380b
Merge pull request #34240 from timothyqiu/invalid-shader-io-29985
Fixes crash when shader inputs/outputs is invalid string
2019-12-11 08:33:54 +01:00
Haoyu Qiu
5586103a94 Validates texture in set_piece_texture 2019-12-11 11:24:42 +08:00
Haoyu Qiu
5deb6497a1 Fixes crash when using DynamicFont::set_font_data 2019-12-10 21:26:42 +08:00
Haoyu Qiu
024c25426b Fixes crash when shader inputs/outputs is invalid string 2019-12-10 17:04:18 +08:00
Haoyu Qiu
c29b8cf751 Fixes crash when using Theme::clear 2019-12-10 16:31:40 +08:00
Rémi Verschelde
2845e6a21a
Merge pull request #34040 from qarmin/unused_variable_more_precise_numbers
Removed unused variables, add some constants numbers
2019-12-10 08:25:31 +01:00
Rafał Mikrut
ed1c4bc77d Removed unused variables, add some constants numbers 2019-12-10 05:13:02 +01:00
Haoyu Qiu
5bf8e1e426 Fixes long popup menu scroll behavior
Popup menus longer than the viewport have stange behaviors before this
fix:

* They always have one pixel outside the viewport.
* You can scroll down the long menu even if bottom outside screen and
top inside the screen. (Only menus one pixel above the screen is limited
to scroll down.)
2019-12-10 09:49:02 +08:00
Tomasz Chabora
6e1dc7b2fe Update minimum size of SpinBox on theme change 2019-12-10 02:11:22 +01:00
Rémi Verschelde
d7b2940eb6
Merge pull request #34203 from bruvzg/ime_placeholder
Hide LineEdit placeholder if IME composition string is not empty.
2019-12-09 09:09:42 +01:00
allkhor
2c559feb92 Fixed strange behaviour of scroll in the ItemList. 2019-12-09 01:54:10 +06:00
bruvzg
4937b21ce5
Hide LineEdit placeholder if IME composition string is not empty. 2019-12-08 18:24:30 +02:00
Michael Alexsander
d057007541 Add spaces after commas and strip extra ones in *FileDialog filter menu 2019-12-06 22:40:59 -03:00
Michael Alexsander
80dcd4423a Remove extra spaces from parenthesis in *FileDialog's filter menu 2019-12-06 07:31:42 -03:00
Tomasz Chabora
3b80eb06b7 Don't store index of root nodes 2019-12-05 01:18:48 +01:00
Rémi Verschelde
10bae7c05b
Merge pull request #33857 from nekomatata/polygon-2d-antialiasing
Fixed antialiased option for Polygon2D
2019-12-03 07:51:16 +01:00
Marcel Admiraal
750f343e4a Ensure move_and_slide() is consistent between the 2D and 3D versions.
In the 3D version:
- Partially revert #20908 that was reverted in the 2D version as part
  of #21653. This ensures that the Vector returned is always perpendicular
  to the surface collided with; and not the floor_normal Vector passed to
  the function when on a floor.
- Include an update of the floor velocity before multiplying by the time
  delta, which was added to the 2D version as part of commit 13a8014.

In the 2D version:
- Use the Vector2.slide() function instead of Vector2.tangent() to adjust
  the amount of motion the stop_on_slope undoes to ensure that it is in the
  right direction. This is a implementation of the 3D approach from #30588.
- Combine the !found_collision and motion == Vector2() checks for break.
- Other minor formating changes to make the functions look identical.

Also renamed some variables to align with their use.
2019-12-02 08:35:50 +01:00
PouleyKetchoupp
fdd99d4a7c Properly remove joint when a physical bone is removed from the scene
It was triggering a warning in bullet followed with a crash in some cases.
WARNING: assert_no_constraints: A body with a joints is destroyed. Please check the implementation in order to destroy the joint before the body.
     At: modules/bullet/rigid_body_bullet.cpp:465
2019-12-01 18:30:59 +01:00
Paulb23
b68703a35c Fixed caret alignment with placeholder text 2019-12-01 14:27:39 +00:00
Paulb23
3df68b4fa6 Fixed LineEdit alignment when removing text or undo / redo 2019-12-01 13:54:09 +00:00
Rémi Verschelde
06fd6e6945
Merge pull request #34019 from nekomatata/inspector-transform-update
Update transform property in the inspector when changing translation/rotation/scale
2019-12-01 11:43:04 +01:00
PouleyKetchoupp
b44e0d60c7 Update transform property in the inspector when changing translation/rotation/scale 2019-11-30 17:16:19 +01:00
Rémi Verschelde
5bf04d16f0
Merge pull request #34011 from nekomatata/state-machine-travel-on-ready
Handle state machine travel before the start node is processed
2019-11-30 17:05:17 +01:00
Rémi Verschelde
fc034be033
Merge pull request #34014 from KoBeWi/like_2d_like_3d
Port Path2D changes to 3D
2019-11-30 14:50:53 +01:00
Tomasz Chabora
9276684e95 Port Path2D changes to 3D 2019-11-30 12:43:34 +01:00
Tomasz Chabora
7e6fa6c7a8 Remove unnecessary bounded_offset from PathFollow2D 2019-11-30 03:16:33 +01:00
PouleyKetchoupp
598d769804 Handle state machine travel before the start node is processed
This change allows travel() to be called on AnimationNodeStateMachinePlayback during _ready(), before the start node has been processed and the state machine is considered playing.
2019-11-30 02:41:40 +01:00
PouleyKetchoupp
e6ebc43d72 Fixed antialiased option for Polygon2D / Line2D
Polygon2D:
The property wasn't used anymore after switching from canvas_item_add_polygon() to canvas_item_add_triangle_array() for drawing.

Line2D:
Added the same property as for Polygon2D & fixed smooth line drawing to use indices correctly.

Fixes #26823
2019-11-28 22:57:27 +01:00
x2f
f085110b20 Added more details in Timer.start() error message. 2019-11-27 14:11:15 -05:00
Hugo Locurcio
639c9b3a35
Only display Environment sky rotation in degrees in the Inspector
This makes it consistent with Spatial.
2019-11-26 18:57:29 +01:00
Rémi Verschelde
966c68badd Range: Remove min/max check added in #33908
This wasn't a very good idea as it puts too strict requirements on how
to set `min` and `max` values. For example, since the default min and
max are 0 and 100, this triggers an error:

```
set_min(256)
set_max(16384)
```

Since `min` will be higher than `max` temporarily. It can be worked
around by setting max first, but it's not really intuitive. I'll relax
the requirement as it's only a problem in `get_as_ratio`, which already
has a check.

Fix another min == max occurrence.
2019-11-26 12:11:21 +01:00
Rémi Verschelde
bfd5e09879 Range: Fix cases where max was set to or below min value
It will now raise an error whenever this happens so that we can fix
these situations. `max == min` is not allowed as it could lead to
divisions by zero in ratios, and `max < min` doesn't make much sense.

Fixes #33907.
2019-11-26 10:25:41 +01:00
clayjohn
85dba0c09d Fix bug where specularmode disabled is not cached 2019-11-25 07:36:07 -08:00
Rémi Verschelde
5ddce7a9df
Merge pull request #33869 from jbuck3/dialog-resize-bug
Fix WindowDialog moving when resized from the left/top edge
2019-11-25 14:38:33 +01:00
Rémi Verschelde
967cc2c014
Merge pull request #33862 from Faless/net/http_request_chunk_size
Add download_chunk_size property to HTTPRequest.
2019-11-25 14:29:59 +01:00
Rémi Verschelde
f6e5751767
Merge pull request #33860 from nekomatata/stylebox-preview-shadow
StyleBox preview adjusted to fit all drawn content
2019-11-25 14:25:39 +01:00
James Buck
5f451e0fb2 Fix WindowDialog moving when resized from the left/top edge
get_combined_minimum_size() must be used in order to consider the min size
specified by the user when determining how far the left/top edge is allowed
to move. Otherwise the dialog may think it can shrink further than it
should, causing the right/bottom edge to move when the rect size is fixed in
set_size().
2019-11-24 23:39:55 -06:00
Fabio Alessandrelli
ed19b4076e Add download_chunk_size property to HTTPRequest.
This allows setting the `read_chunk_size` of the internal HTTPClient.
This is important to reduce the allocation overhead and number of file
writes when downloading large files, allowing for better download speed.
2019-11-24 19:32:20 +01:00
PouleyKetchoupp
1120de862d StyleBox preview adjusted to fit all drawn content
This change allows StyleBox preview to take shadows and content margins into account to display how a whole panel would be rendered.

The preview control clips contents so that in any case it doesn't bleed on controls around.

Fixes #33801
2019-11-24 16:26:30 +01:00
PouleyKetchoupp
8830e53fe1 Fixed index out of size error in TextEdit when opening scripts 2019-11-24 10:48:04 +01:00
Martin Capitanio
a7df198c94 Setting the node process priority should not trigger an error
Fixes #33749
This function can be called outside the scene tree.
2019-11-21 18:08:52 +01:00
Rémi Verschelde
2981915f19
Merge pull request #28526 from PtrMan/pr_bakeGi1
GIProbe::bake(): special handling of spatial
2019-11-21 09:28:44 +01:00
Rémi Verschelde
5ef5e6a7e4
Merge pull request #32274 from raphael10241024/fix_sync_physics_jitter
fix kinematicBody2D jitters when sync_to_physics is turned on
2019-11-21 08:53:24 +01:00
PtrMan
8695135691 GIProbe::bake: Remove check for ownership
Fixes #28508.
2019-11-21 08:48:56 +01:00
Rémi Verschelde
083d088de3
Merge pull request #33583 from qarmin/fix_overflows_unitialized
Fix some overflows and unitialized variables
2019-11-20 21:31:12 +01:00
Rafał Mikrut
99d8626f4a Fix some overflows and unitialized variables 2019-11-20 16:22:16 +01:00
Rémi Verschelde
60711e6738
Merge pull request #33750 from lupoDharkael/gradient
GradientEdit: Fix index crashes
2019-11-20 11:24:10 +01:00
lupoDharkael
268fe9dda5 GradientEdit: Fix index crashes 2019-11-19 22:05:37 +01:00
volzhs
cdae65c4a6 Rename External MSAA to AndroidVR MSAA on Viewport property
following up f392c4ea7a
2019-11-20 03:02:11 +09:00
Rémi Verschelde
0a96235b44
Merge pull request #33683 from clayjohn/material-texture-bug
Properly update texture when roughness/metallic set
2019-11-17 21:48:00 +01:00
Rémi Verschelde
cc025fc8e7
Merge pull request #33663 from Calinou/add-node-get-process-priority
Implement `Node::get_process_priority()` and its associated property
2019-11-17 21:43:28 +01:00
clayjohn
2bc6302607 Properly update texture when roughness/metallic set 2019-11-17 11:11:25 -08:00
Hugo Locurcio
ae76c62601
Implement Node::get_process_priority() and its associated property
This closes #33660.
2019-11-17 17:48:50 +01:00
PouleyKetchoupp
2511f275b9 StyleBoxFlat doesn't draw content when width or height is zero
Causes unnecessary computations and drawing, and a division by zero when calculating uv coordinates.

This case happened with ScriptEditor's member overview (ItemList), initialized with a minimum width of 0.

Fixes #33634
2019-11-17 15:38:05 +01:00
Rémi Verschelde
c9782b0e97
Merge pull request #33645 from Calinou/graphedit-ctrl-toggle-snapping
Make holding Ctrl toggle snapping in GraphEdit
2019-11-16 22:54:17 +01:00
Rémi Verschelde
f392c4ea7a
Merge pull request #33658 from NeoSpark314/rename_ext_msaa
Rename External MSAA to AndroidVR MSAA
2019-11-16 22:52:51 +01:00
Holger Dammertz
1b9c2ec92e Rename External MSAA to AndroidVR MSAA
A new external MSAA setting was introduced in https://github.com/godotengine/godot/pull/33518
that fixed issues on GLES2 and Oculus Mobile VR. To avoid misunderstanding it was suggested
by @BastiaanOlij and discussed on discord to rename it to AndroidVR.
2019-11-16 15:36:43 +01:00
Hugo Locurcio
72b31aafc4
Make holding Ctrl toggle snapping in GraphEdit
This affects the visual script and visual shader editors as well.
2019-11-15 19:34:44 +01:00
Rémi Verschelde
88a8f9ab36
Merge pull request #33557 from nekomatata/empty-tree-crash
Fixed crash when pressing down key on empty Tree
2019-11-12 08:38:43 +01:00
PouleyKetchoupp
47a4ca0022 Fixed crash when pressing down key on empty Tree
Fixes #33554
2019-11-12 08:15:29 +01:00
Rémi Verschelde
4b8feff594
Merge pull request #33518 from BastiaanOlij/msaa_ext_modes
Add MSAA mode for Quest
2019-11-11 11:46:50 +01:00
Bastiaan Olij
4e2343160c Add special external MSAA modes for GLES2 Rift S/Quest and OpenXR optimisation 2019-11-11 21:02:06 +11:00
Rémi Verschelde
8ffc56c3ca
Merge pull request #29579 from mrcdk/fix_29575
Drop the physics mouseover whenever a input has been handled.
2019-11-11 09:37:27 +01:00
Rémi Verschelde
2143f46df2
Merge pull request #33516 from qarmin/small_fixes
Memory leaks and crash fixes
2019-11-10 10:17:19 +01:00
Rémi Verschelde
2fdeed1b4f
Merge pull request #33501 from akien-mga/camera-project_position-defval
Camera: Don't set default value for project_position
2019-11-10 10:11:16 +01:00
Rémi Verschelde
e711534c46
Merge pull request #33452 from Chaosus/fix_tilemap
Fix incorrect offset for old-format tilemaps
2019-11-10 10:10:29 +01:00
Rafał Mikrut
7dda9309f9 Memory leak and crash fixes 2019-11-10 09:49:13 +01:00
Rémi Verschelde
6c557b8bdf Camera: Don't set default value for project_position
A z_depth of 0 returns the camera position, which is not really useful.
This also makes the API breakage from 3.1 clearer as 3.1 code will now
fail to compile, so users will have to adapt and use the new parameter.

For the reference, in 3.1, the z_depth was hardcoded to the near plane.

Closes #33493.
2019-11-10 00:17:26 +01:00
PouleyKetchoupp
0fc0f0fc98 Fixed crash when using icon override in button
Missing change for PR #33495
2019-11-09 23:06:46 +01:00
PouleyKetchoupp
0c79bbeea3 Fixed crash when using icon override in button
Fixes #33457
2019-11-09 20:14:52 +01:00
Rémi Verschelde
7afa1a64ec
Merge pull request #33478 from nekomatata/particles-restart-glitch
Fixed Particles restart after visibility has been set to off and on again
2019-11-09 18:53:34 +01:00
Rémi Verschelde
52de63afc8
Merge pull request #33492 from Paulb23/issue_32229_fix_single_line_wrap
Fixed not being able to scroll ending wrapped line
2019-11-09 18:52:45 +01:00
Rémi Verschelde
0bfd06a911
Merge pull request #33465 from rxlecky/list-theme-resources-fix
Fix functions listing all theme resources
2019-11-09 18:23:49 +01:00
Paulb23
25cba699f0 Fixed not being able to scroll ending wrapped line 2019-11-09 16:45:44 +00:00
rxlecky
80b9c8e950 Fix functions listing all theme resources
Fix functions get_<resource>_list in Theme currently returning vector
of double-the-necessary size with the first half completely empty.
2019-11-09 11:56:55 +00:00
PouleyKetchoupp
530665197f Fixed Particles restart after visibility has been set to off and on again
Make sure particles are processed during the same frame when visibility is set to on, in case they are still active from before and need to be restarted.

Fixed #33476
2019-11-09 09:51:17 +01:00
Rémi Verschelde
60d4909048
Merge pull request #33431 from Kaonnull/bugParticles2D_2
Fixed the particles2D prematurely animation ending
2019-11-09 07:40:07 +01:00
Simon Hardt
7e4ae4c503 Fixed prematurely ending animation of particles. 2019-11-08 21:28:19 +01:00
Yuri Roubinsky
26b933dc21 Fix incorrect offset for old-format tilemaps 2019-11-08 20:07:41 +03:00
Rémi Verschelde
3c0c8f26f9 Revert "Fixed TouchScreenButton::shape_centered having no effect"
This reverts commit 127c2d75ad.

This was a misunderstanding as #32725 is not a bug but expected
behavior.

Reverts #32927.
Supersedes and closes #33436.
2019-11-08 10:54:36 +01:00
Rémi Verschelde
621dc7022f
Merge pull request #27742 from rxlecky/camera-replication
Game camera override
2019-11-08 10:02:18 +01:00
Rémi Verschelde
31f327a4a9
Merge pull request #33052 from KoBeWi/naughty_sliders
Fix analog input in sliders
2019-11-08 09:55:11 +01:00
Rémi Verschelde
2d3fcd0ff0
Merge pull request #30721 from NilsIrl/tab_key
Allow tab key to be used for shortcuts
2019-11-07 18:32:54 +01:00
Tomasz Chabora
a7b202ef18 Fix analog input in sliders 2019-11-07 16:39:14 +01:00
Rémi Verschelde
d596e169dc
Merge pull request #30588 from Demiu/patch-1
Fix 3D move_and_slide with stop_on_slope
2019-11-07 15:11:53 +01:00
Rémi Verschelde
77816fea8b
Merge pull request #32477 from aaronfranke/equal-approx-separate
Make is_equal_approx separate and make == exact again
2019-11-07 14:54:15 +01:00
codecustard
71e79af1f1 Fixes ItemList max column update
When setting the max column of an ItemList, the layout does not update until it is resized.
2019-11-06 12:26:51 -08:00
Yuri Roubinsky
213ecd65cd
Merge pull request #33341 from Chaosus/vs_fix_samplers
Fix invalid casting on visual shader sampler
2019-11-04 19:08:43 +03:00
Rémi Verschelde
6dca64140c
Merge pull request #33330 from nekomatata/fix-label-autowrap-size
Fixed cases where labels with autowrap can overflow the editor ui
2019-11-04 16:57:53 +01:00
Yuri Roubinsky
f5ffc1aedc Fix invalid casting on visual shader sampler 2019-11-04 18:50:33 +03:00
Rémi Verschelde
83409bac0e
Merge pull request #33282 from Chaosus/vs_texture_inputs
Added sampler inputs for visual shaders
2019-11-04 11:32:04 +01:00
PouleyKetchoupp
13c88878c4 Fixed cases where labels with autowrap can overflow the editor ui
Fixes #33155
2019-11-04 10:12:36 +01:00
Rémi Verschelde
e684df08fc
Merge pull request #33286 from groud/fix_tree_edit_rect
Fixes the edit rect in TreeItems
2019-11-03 17:35:01 +01:00