Commit graph

9 commits

Author SHA1 Message Date
Hein-Pieter van Braam
2a02f44ad9 Don't try to update the visual shader graph if it doesn't exist yet
When setting shader mode on a visual shader that was just created in the
editor we try to _update_graph(). However, the graph does not yet exist
in the visualshadereditor. This gets populated in
VisualShaderEditor::edit() which hasn't been called yet.

This PR simply changes the logic to not try to update the non-existent
graph.

This fixes #20322
2018-08-12 22:33:35 +02:00
Hein-Pieter van Braam
0e29f7974b Reduce unnecessary COW on Vector by make writing explicit
This commit makes operator[] on Vector const and adds a write proxy to it.  From
now on writes to Vectors need to happen through the .write proxy. So for
instance:

Vector<int> vec;
vec.push_back(10);
std::cout << vec[0] << std::endl;
vec.write[0] = 20;

Failing to use the .write proxy will cause a compilation error.

In addition COWable datatypes can now embed a CowData pointer to their data.
This means that String, CharString, and VMap no longer use or derive from
Vector.

_ALWAYS_INLINE_ and _FORCE_INLINE_ are now equivalent for debug and non-debug
builds. This is a lot faster for Vector in the editor and while running tests.
The reason why this difference used to exist is because force-inlined methods
used to give a bad debugging experience. After extensive testing with modern
compilers this is no longer the case.
2018-07-26 00:54:16 +02:00
Nufflee
228bd21e26 Fix #20171. 2018-07-20 22:25:18 +02:00
Rémi Verschelde
95d99cb2ac
Merge pull request #20176 from Chaosus/vs_namefixes
Several name fixes for visual shaders
2018-07-17 13:54:22 +02:00
Thomas Herzog
72430b041e
Merge pull request #20169 from Chaosus/rightclick_vs
Visual shaders - make "Add node" menu showed by right click
2018-07-16 15:46:18 +02:00
Chaosus
3af81427a1 Several name fixes for visual shader 2018-07-15 17:28:06 +03:00
Chaosus
f8417ac682 Visual shaders - make "Add node" menu showed by right click 2018-07-15 10:33:11 +03:00
Chaosus
c88da2fce5 Fix display scale bug in visual shaders 2018-07-15 08:55:41 +03:00
Juan Linietsky
f6ce73f724 Visual Shaders are back. 2018-07-14 18:16:18 -03:00