Commit graph

7617 commits

Author SHA1 Message Date
smix8
17e6d76de6 Fix Navigation agent callback wild pointer crash
Fixes crash in sanitizer builds when callback agent or object are already freed.

(cherry picked from commit 194c1c44e0)
2022-12-18 10:32:04 +08:00
Haoyu Qiu
b2e5c8fe10 Fix possible Tween leak on exit
(cherry picked from commit e173710963)
2022-12-18 10:32:04 +08:00
FireForge
0d602ce881 Add Vector2/3 linking to more properties
- Camera2D.zoom
- CanvasLayer.scale
- ParallaxBackground.scroll_base_scale
- ParallaxLayer.motion_scale
- Polygon2D.texture_scale
- SpatialMaterial.uv1_scale
- SpatialMaterial.uv2_scale

(cherry picked from commit 92817aa72f)
2022-12-18 10:32:04 +08:00
kobewi
9499ebecee Add vector value linking
Co-authored-by: redlamp <244062+redlamp@users.noreply.github.com>
(cherry picked from commit 5553e27fe8)
2022-12-18 10:32:04 +08:00
Hugo Locurcio
65465f309c
Add a project setting to make the root viewport transparent
This allows creating a project with a transparent window without having
to write any script.
2022-12-18 00:38:05 +01:00
Rémi Verschelde
607940875c
Merge pull request #70111 from Maran23/3.x-check-null-event-in-tree
[3.x] Check for null event in Tree._gui_input to avoid engine crash
2022-12-17 14:28:11 +01:00
Rémi Verschelde
84566b3296
Merge pull request #70089 from Rubonnek/3x-avoid-compiling-editor-checks-in-visibilitynotfier2d
[3.x] Avoid compiling Editor checks in release builds for `VisibilityNotifier2D`
2022-12-17 14:27:21 +01:00
Marius Hanl
09f974b21d Check for null event in Tree._gui_input to avoid engine crash 2022-12-15 17:35:53 +01:00
Wilson E. Alvarez
78b8cf7edb
Avoid compiling Editor checks in release builds for VisibilityNotifier2D 2022-12-15 11:13:10 -05:00
Rémi Verschelde
6963ba631e
Fix typos with codespell 2022-12-15 12:26:59 +01:00
Wilson E. Alvarez
6a8bae4e35
Do not fire VisibilityNotifier screen_entered and screen_exited signals in the Editor 2022-12-13 10:29:28 -05:00
Haoyu Qiu
6f69d29398
Fix crash after executing ItemList.set_icon_scale
(cherry picked from commit 8d0fa193c3)
2022-12-13 14:24:25 +01:00
lawnjelly
ff714fbe02 SurfaceTool - efficiency improvements
Changed to use LocalVector rather than linked lists.
2022-12-12 20:12:50 +00:00
Rémi Verschelde
5d5f0a3958
Merge pull request #69963 from lawnjelly/variant_parser_optional_readahead_3
VariantParser make readahead optional [3.x]
2022-12-12 19:02:17 +01:00
lawnjelly
776c9d0579 VariantParser make readahead optional
It turns out some areas are independently moving / reading filepointers outside of the VariantParser, which can cause the readahead caching to get out of sync.

This PR makes the VariantParser readahead to be optional to allow for these use cases.
2022-12-12 15:44:39 +00:00
Rémi Verschelde
2343ba148b
Merge pull request #69959 from Calinou/distance-fade-use-circular-fade-3.x
Use circular fade instead of linear fade for distance fade (3.x)
2022-12-12 16:07:31 +01:00
Rémi Verschelde
2c714f19e5
Merge pull request #65453 from timothyqiu/agent-target-3.x
[3.x] Make NavigationAgent `target_location` a property
2022-12-12 16:07:25 +01:00
Hugo Locurcio
56ac14fbf0
Use circular fade instead of linear fade for distance fade
This makes distance fade look the same regardless of the camera angle,
for all distance fade modes (Pixel Alpha, Pixel Dither, Object Dither).
Distance fade now behaves like fog in this regard.
2022-12-12 15:16:34 +01:00
Hugo Locurcio
c54c1b0b6b
Fix infinite loop when calling Control.popup_centered_minsize()
Co-authored-by: sriramun <sriramun2@gmail.com>
(cherry picked from commit 08e804b3b7)
2022-12-12 14:49:23 +01:00
Dawid Marzec
ecef4804f2
Fix errors while deselecting all tree items; issue #65185
(cherry picked from commit d4d5df2314)
2022-12-12 14:49:23 +01:00
Rémi Verschelde
bfce0c1e52
Merge pull request #59765 from pfertyk/issue-59359-wrong-visible-line-count-if-newline
Fix wrong visible line count for newline
2022-12-12 13:40:14 +01:00
Phnix
9ac09dfb64 incorrect range value with min value and step
If the minimum value and the steps are greater than 0, the value will not be calculated correctly.

Co-Authored-By: Astral-Sheep <109028693+Astral-Sheep@users.noreply.github.com>
(cherry picked from commit fe1f8443a4)
2022-12-12 14:22:54 +08:00
smix8
16bb34d23d Add detail to NavigationPolygon outline error msg
Adds additional information to the error msg when the convex partition fails due to invalid outline arrays.

(cherry picked from commit f30ebacbe8)
2022-12-12 14:19:46 +08:00
Rémi Verschelde
f128170a18
Merge pull request #69558 from timothyqiu/canvas-layer-unique-call
[3.x] Fix CanvasLayer visibility toggle can only run once per frame
2022-12-11 15:39:57 +01:00
Hugo Locurcio
5115db63aa
Fix BackBufferCopy rect property appearing when not relevant in inspector
The `rect` property is only effective if `copy_mode` is Rect.
2022-12-08 20:04:56 +01:00
Rémi Verschelde
c42bbc6feb
Merge pull request #69585 from bruvzg/fix_tm_tr
[TextMesh, 3.x] Fix auto-translation and ignore control chars.
2022-12-05 00:13:42 +01:00
Rémi Verschelde
4b7b9b74bc
Merge pull request #69569 from timothyqiu/tree-update-remove-child
[3.x] Fix TreeItem.remove_child not updating Tree immediately
2022-12-05 00:13:37 +01:00
bruvzg
efa6b01c97
[TextMesh, 3.x] Fix auto-translation and ignore control chars. 2022-12-04 23:11:28 +02:00
Haoyu Qiu
7bdbfbf822 Fix TreeItem.remove_child not updating Tree immediately 2022-12-04 21:37:19 +08:00
Silc Renew
1a45268639 Fix animation signal caches_cleared firing timing
(cherry picked from commit 962b6a3e8f)
2022-12-04 20:24:55 +08:00
Haoyu Qiu
a6a89356b7 Fix CanvasLayer visibility toggle can only run once per frame 2022-12-04 14:49:19 +08:00
Rémi Verschelde
af635f05bf
Merge pull request #68630 from m4gr3d/fix_input_event_screen_drag_routing_3x
[3.x] Fix routing of `InputEventScreenDrag` events to `Control` nodes
2022-12-01 18:13:52 +01:00
Dawid Marzec
1a123070c8 Remove auto selecting the first file for FileDialog with Save file mode selected
(cherry picked from commit 5cd30be56d)
2022-12-01 12:27:43 +08:00
kobewi
2f13adbdb6 Remove error condition from get_global_transform()
(cherry picked from commit 2ff676a696)
2022-12-01 11:47:52 +08:00
Markus Sauermann
0ae562c9dc Update root order on layer change
When the layer of a CanvasLayer changes, the order of roots needs to be recalculated.

(cherry picked from commit 8d60e8b5d4)
2022-12-01 10:23:04 +08:00
Lyuma
099e90e00d Make Node editable_instance methods available to GDScript
(cherry picked from commit 7eb6ae2798)
2022-12-01 10:15:06 +08:00
Fredia Huya-Kouadio
b28bcb4cfc Fix the logic used to route InputEventScreenDrag events to Control nodes. 2022-11-30 14:16:26 -08:00
Haoyu Qiu
3b869e8027
Fix crash of queue_free() when main loop is not SceneTree
(cherry picked from commit 3b08d0e852)
2022-11-30 15:44:49 +01:00
Micky
2ab79719b2
Fix ColorPicker always emitting color_changed on html submit
The color change was always emitted when the the modal was closed, even if it was exactly the same as before.

(cherry picked from commit 544727ac1e)
2022-11-30 15:36:25 +01:00
Rafał Mikrut
e359ba3733
Fix exporting big templates
(cherry picked from commit 86fa3ba560)
2022-11-30 15:34:26 +01:00
jbcolli2
dd807ca5e7
Changed normal of CylinderMesh to account for slanted side.
(cherry picked from commit 491ec622f6)
2022-11-30 15:34:26 +01:00
hare_ware
4150749698
Fix Skeleton3D falsely assuming all physical bones will be children of their first bone
(cherry picked from commit 913f57f695)
2022-11-30 15:34:26 +01:00
Rémi Verschelde
6f91639af2
Merge pull request #69246 from nongvantinh/3.x-check-null-for-input_event
3.x Enhance null checking for input event
2022-11-28 13:21:22 +01:00
dzil123
85811c2b99 [3.x] BakedLightmap add null bake_end_function check 2022-11-28 00:30:17 -08:00
Nong Van Tinh
ffbaa7fff0 Enhance null checking for input event 2022-11-27 15:01:34 +07:00
lawnjelly
edc85d22fc Faster queue free
Calling queue_free() for large numbers of siblings could previously be very slow, with the time taken rising exponentially with number of children. This looked partly due to ordered_remove from the child list and notifications.

This PR identifies objects that are nodes, and sorts the deletion queue so that children are deleted in reverse child order. This minimizes the costs of reordering.
2022-11-25 09:53:50 +00:00
Hugo Locurcio
4c26cac0e6
Improve collision exception error messages for easier understanding 2022-11-19 17:37:42 +01:00
Rémi Verschelde
1ad9992ab7
Merge pull request #67995 from YeldhamDev/how_backporting
[3.x] Stop centering clicked suggestions in the autocomplete popup
2022-11-14 23:52:00 +01:00
Rémi Verschelde
d80396db03
Merge pull request #68556 from 98teg/flow-container-alignment
Add alignment options to flow container
2022-11-14 14:35:46 +01:00
Haoyu Qiu
3acc0779a4 Fix error when having BoneAttachment before PhysicalBone 2022-11-14 08:36:12 +08:00
Michael Alexsander
7a682236df Stop centering clicked suggestions in the autocomplete popup 2022-11-13 09:17:05 -03:00
Teggy
5d0c29460a Add alignment options to flow container 2022-11-12 12:11:16 +01:00
arkology
afdf00c40f [3.x] AtlasTexture in radial modes of TextureProgress 2022-11-04 13:24:47 +03:00
Rémi Verschelde
e0682f6d8f
Merge pull request #67626 from bruvzg/improve_font_packing_and_delay_texture_update_3
[3.x] Improve font glyph cache packing and texture update.
2022-11-03 11:33:23 +01:00
kleonc
3e373c4eec Add ShapeCast2D/3D::get_collider_rid method 2022-11-02 15:20:13 +01:00
Haoyu Qiu
78981d2e0a Make NavigationAgent target_location a property 2022-10-31 20:46:38 +08:00
Sam Briels
3e186ae043 fix: emit target_reached signal after updating state 2022-10-31 13:04:20 +01:00
Rémi Verschelde
80b50e59d5
Merge pull request #67612 from timothyqiu/who-ami-i-3.x
[3.x] Fix get_path() error when calling get_node()
2022-10-31 12:25:12 +01:00
Rémi Verschelde
20ce0284cf
Merge pull request #67313 from Mickeon/3.x-rename-params
[3.x] Rename `set_indexed` & `get_child`'s params to be clearer
2022-10-31 12:24:58 +01:00
Rémi Verschelde
f52f797f59
Merge pull request #67255 from KoBeWi/remove_text_from_RichTextLabel
Hide text of RichTextLabel if BBCode is enabled
2022-10-31 12:24:53 +01:00
bruvzg
46e2e0f62e
[3.x] Improve font glyph cache packing shelf best height fit heuristic, delay font texture update, until texture is accessed. 2022-10-19 14:31:41 +03:00
Haoyu Qiu
5d6dc206bc Fix get_path() error when calling get_node() 2022-10-19 13:05:41 +08:00
Michael Alexsander
6059cf2594 Expose various color themes for Button 2022-10-12 18:19:52 -03:00
Micky
6102f3cfc2 [3.x] Rename set_indexed & get_child's params to be clearer
3.x backport of #67300 and #64463.
2022-10-12 20:55:41 +02:00
kobewi
a0ad958582 Hide text of RichTextLabel if BBCode is enabled 2022-10-11 15:21:19 +02:00
Haoyu Qiu
456c0ecda6 Remove leading spaces from enumerator name hints 2022-10-08 15:23:46 +08:00
Rémi Verschelde
f793f20d65 Merge pull request #41464 from Waridley/button_multiline_strings
Support multiline strings in buttons
2022-10-03 13:58:44 +02:00
Rémi Verschelde
90f6baf26c Merge pull request #66155 from KoBeWi/animat3d_diff
[3.x] Don't store frame of playing AnimatedSprite
2022-10-03 13:58:28 +02:00
Waridley
199f3d99c3 Support multiline strings in buttons 2022-10-01 21:50:39 -05:00
Haoyu Qiu
acf86efebc Fix NavigationObstacle not estimating radius 2022-09-29 14:39:14 +08:00
Haoyu Qiu
fba5a4ab9a Fix NavigationObstacle not registering to default navigation map 2022-09-28 15:49:26 +08:00
smix8
881e49c375 Fix TileMaps with origin offset placing NavPolygons wrong without a Navigation2D node
The legacy navigation was positioning baked TileMap navpolygons relative to the current Navigation2D node assuming that it is usually one of the parent nodes.

Without the deprecated Navigation2D node the default navigation map of the world_2d is used. This navigation map has no relative Node2D so it needs to use the global_transform of the TileMap to place navregions with the correct offset in case the TileMap is moved from the origin.
2022-09-22 17:14:51 +02:00
Rémi Verschelde
4207983ce9
Merge pull request #66145 from lawnjelly/object_get_name 2022-09-21 12:04:19 +02:00
lawnjelly
17f42e8e66 Improve signal already connected error message
The signal already connected message is improved to provide the names of the objects involved.
2022-09-21 07:52:30 +01:00
Rémi Verschelde
edc196f926
Merge pull request #66063 from kleonc/sprite3d-fix-drawing-with-vertical-margins-3x
[3.x] `Sprite3D`/`AnimatedSprite3D` Fix drawing `AtlasTexture`s with vertical margins differently than in 2D
2022-09-20 23:06:57 +02:00
kobewi
dbce96abd9 Don't store frame of playing AnimatedSprite 2022-09-20 13:11:50 +02:00
kobewi
1aee1b1720 Fix crash when playing Tween right after finishing
(cherry picked from commit 1a462bc84e)
2022-09-20 10:26:17 +02:00
lawnjelly
fdd82f4754 CPUParticles initialize data on set_amount
Fills particle data with zeroes on resize using set_amount(), to prevent garbage data including Nans being sent to VisualServer, which can corrupt the spatial partitioning.
2022-09-19 16:53:01 +01:00
kleonc
0a64c2eba5 SpriteBase3D Fix drawing AtlasTextures with vertical margins differently than in 2D 2022-09-18 20:27:23 +02:00
kleonc
0bf2b8e813 Move duplicated drawing code from Sprite3D/AnimatedSprite3D to SpriteBase3D 2022-09-18 20:27:09 +02:00
Rémi Verschelde
a10c2d4a38 Merge pull request #65686 from lawnjelly/portals_show_raycast
Portals - Show RayCast debug helper
2022-09-12 11:34:25 +02:00
lawnjelly
09befec1ed Portals - Show RayCast debug helper
Switches the raycast helper to global portal_mode, allowing it to show when portals are active.
2022-09-12 06:46:48 +01:00
lawnjelly
54a939a029 Low priority redraw request for AnimatedSprite
Prevents animated sprite from creating continuous redraws in vital_redraws_only mode.
2022-09-11 19:09:07 +01:00
Rémi Verschelde
2aee09c6bc
Merge pull request #65428 from lawnjelly/input_uninit 2022-09-09 14:28:06 +02:00
Rémi Verschelde
92fa63886c
Merge pull request #65397 from maximkulkin/3.x-graph-edit-node-selection 2022-09-07 17:52:24 +02:00
Abhinav Chennubhotla
8acc25578e Fix code folding icon color not matching defined color
Cherrypick of #58457 in master

Caused by reusing icons from the main editor in the code editor. These
icons were converted based on the main editor theme and not the code
editor theme.

    - Create new icons for use specifically in the code editor
    - Add these icons to the exceptions when converting dark theme icons
    to light theme automatically
    - Change the default value of the code folding color to match previous
    color
    - Code folding icon is now pure white by default to correctly match
    the color defined in settings
2022-09-06 21:50:33 +05:30
lawnjelly
d60eae3dbc Fix uninitialized data reads in Input
Found by Valgrind.
2022-09-06 14:21:01 +01:00
Rémi Verschelde
e2030748b0 Merge pull request #65411 from lawnjelly/flow_container_uninit
FlowContainer fix uninitialized data
2022-09-06 12:31:11 +02:00
lawnjelly
fa4a325180 FlowContainer fix uninitialized data
This uninitialized data was finding its way into the renderer.
2022-09-06 09:04:00 +01:00
Maxim Kulkin
466c912344 Add GraphNode 'selected' and 'unselected' signals, simplify GraphEdit
Backport of the fix from master to 3.x
2022-09-06 01:35:58 -04:00
kobewi
0511f48c49 Fix Viewport size change not updating textures
(cherry picked from commit 3a4a4aeade)
2022-09-05 15:35:45 +02:00
kobewi
737bfa57d3 Allow to change the Stop shortcut used at runtime
(cherry picked from commit 409613ba7b)
2022-09-05 15:35:45 +02:00
Micky
9ca40f0e0a Cast between float and ints in SceneTreeTween.tween_property()
(cherry picked from commit 2b18a4002c)
2022-09-05 14:58:56 +02:00
Rémi Verschelde
2ee933bb77
Merge pull request #64920 from lawnjelly/bind_physics_interpolation
Bind Physics Interpolation functions in VisualServer
2022-08-30 22:02:58 +02:00
lawnjelly
96a1b86717 Bind Physics Interpolation functions in VisualServer
To allow maximum flexibility in the initial rollout, VisualServer functions were not bound in order to prevent compatibility issues if the API changed.

These functions are now bound to allow direct use from the VisualServer.
2022-08-30 18:06:12 +01:00
QbieShay
acdcbefa4e added options for sorting transparent objects
Co-authored-by: Rémi Verschelde <rverschelde@gmail.com>
Co-authored-by: Clay John <claynjohn@gmail.com>
2022-08-30 13:39:32 +02:00
Rémi Verschelde
bbaedffb93
Merge pull request #64875 from fabriceci/ulgy-hack-bullet-margin 2022-08-30 11:44:25 +02:00
Rémi Verschelde
747d30d567
Merge pull request #64372 from smix8/navigation_fix_obstacles_default_map_3.x 2022-08-30 11:01:30 +02:00
Rémi Verschelde
ac00cad299
Merge pull request #65050 from KoBeWi/suffix_b3gon3 2022-08-30 09:14:06 +02:00
Rémi Verschelde
c551a79084
Merge pull request #65063 from Atlinx/fix/65033_fix-hdr-warning
Disable HDR warning for Viewport on GLES2 projects
2022-08-30 08:38:06 +02:00