asgardius/virtualx-engine
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
66836 commits 1 branch 0 tags 2.2 GiB
Commit graph

685 commits

Author SHA1 Message Date
Rémi Verschelde
622393c115
Merge pull request #95317 from esainane/when-i-am-64 
binder_common: Fix uninitialized marshalling for `PtrToArg<char32_t>`
 2024-08-28 17:15:05 +02:00
Rémi Verschelde
71accb9008
Merge pull request #94679 from rune-scape/remove-unused-initialize_ref 
Remove unused `initialize_ref`
 2024-08-28 00:12:16 +02:00
Haoyu Qiu
8bf4ecc026 Add String.is_valid_unicode_identifier() 
- Adds `is_valid_unicode_identifier()`
- Adds `is_valid_ascii_identifier()`
- Deprecates `is_valid_identifier()`
- Renames `validate_identifier()` to `validate_ascii_identifier()`
 2024-08-27 11:34:08 +08:00
Aaron Franke
7db24a9ad5
Simplify and fix Rect2/AABB get_support function 2024-08-19 23:55:31 -07:00
Sai Nane
e6a7c63125 binder_common: Fix uninitialized marshalling 
C# uses `long`s to access many native values. With `PtrToArg<m_enum>` and
`PtrToArg<bitfield<m_enum>>` this isn't a problem, as C++ code converts
through a `*(int64_t*)` cast in assignment, so all 64-bits are initialized.

However, with `PtrToArg<char32_t>`, value assignment happens through an
`*(int *)` cast, leaving 32 bits uninitialized where `int` is 32 bits. On
platforms where `int` is 16 bits, there are presumably 48 bits uninitialized,
though there are very few platforms where this is still the case.

The easiest way to see the practical effects of this is by looking at
`EventInputKey.Unicode`:

```csharp
    public override void _Input(InputEvent @event) {
        if (@event is InputEventKey keyEvent) {
            if (keyEvent.IsPressed() && !keyEvent.Echo) {
                var raw = keyEvent.Unicode;
                var value = raw & 0xffffffff;
                GD.Print($"Key pressed: raw: {raw}; masked: {(char) value} ({value})");
            }
        }
    }
```

Pressing 'a' emits the following line:
```
Key pressed: raw: -3617008645356650399; masked: a (97)
```

Examining execution flow in gdb shows this conversion going through the
following line:
```
PtrToArg<char32_t>::encode (p_ptr=0x7ffcd5bb4b18, p_val=97 U'a') at ./core/variant/binder_common.h:221
221			*(int *)p_ptr = p_val;
```

Here, `p_val` is still 97, which is the value `InputEventKey.Unicode`
is expected to have. After assignment, `p *(int64_t *)0x7ffcd5bb4b18` displays
`-3617008645356650399`, with only the lower 32 bits being properly assigned,
and is the value we see from C#.

With this patch applied, the above testing `_Input` now prints:
```
Key pressed: raw: 97; masked: a (97)
```

Thank you to blujay1269 for asking about an unexpected value they saw in
`EventInputKey.Unicode`, which prompted this investigation.
 2024-08-09 05:15:54 +00:00
A Thousand Ships
8f3e2c96eb
[Core] Fix Variant::construct of Object 
Variant type was not updated correctly causing leaks in ref-counted
 2024-07-25 12:25:29 +02:00
Rémi Verschelde
496b7b8482
Core: Improve vformat error reporting on sprintf failure 
And fix a few occurrences of formatting errors that led me to this.
 2024-07-04 10:54:55 +02:00
rune-scape
c8b697c64c Remove unused initialize_ref 2024-07-03 13:32:50 -07:00
Rémi Verschelde
152d7c1bba
Revert "Make freed object different than null in comparison operators" 
This reverts commit 150b50cfcd.

As discussed with the GDScript team, this has some implications which aren't
fully consensual yet, and which we want to revisit.

For now we revert to the 4.2 behavior for the 4.3 release, to avoid breaking
user expectations.
 2024-07-01 14:11:43 +02:00
Rémi Verschelde
3d8562d775
Merge pull request #89197 from AThousandShips/arr_typed_fix 
[Core] Fix sharing of typed arrays from constructor
 2024-06-26 18:15:09 +02:00
bruvzg
e651421905
[TextServer, GDExtension] Fix building text servers as GDExtension, expose new/changed low-level methods to GDExtension API. 2024-06-12 19:30:19 +03:00
bruvzg
d8e1ab085a
[Windows] Fix 32-bit MinGW LTO build. 2024-06-04 13:46:03 +03:00
rune-scape
4463e7dee9 fix callable not clearing freed pointer 2024-06-02 21:22:16 -07:00
Thaddeus Crews
7599a7b719
Core: Readd Variant class initializer, fix comment 2024-05-14 12:20:40 -05:00
kobewi
413c11357d Use Core/Scene stringnames consistently 2024-05-13 23:41:07 +02:00
kobewi
a262d2d881 Add shorthand for using singleton string names 2024-05-11 18:53:08 +02:00
A Thousand Ships
b4c6cc7d82
[Core] Add case-insensitive String::containsn 2024-05-08 12:48:01 +02:00
Rémi Verschelde
63ed5749ac
Merge pull request #91104 from RandomShaper/simple_type_cpp 
Redefine `GetSimpleTypeT<>` in terms of `<type_traits>`
 2024-05-08 09:54:16 +02:00
Wilson E. Alvarez
d4154dbc55
Add const char * overloads to String class 
Co-authored-by: A Thousand Ships <96648715+AThousandShips@users.noreply.github.com>
 2024-05-07 10:53:00 -04:00
A Thousand Ships
09460d33e6
[Core] Fix sharing of typed arrays from constructor 2024-05-07 09:52:17 +02:00
K. S. Ernest (iFire) Lee
f9b488508c
Add PackedVector4Array Variant type 
Co-authored-by: A Thousand Ships <96648715+AThousandShips@users.noreply.github.com>
Co-authored-by: Rémi Verschelde <rverschelde@gmail.com>
 2024-05-03 00:58:27 +02:00
A Thousand Ships
0f5e0d1637
Expose Vector* component-wise and scalar min/max to scripting 2024-05-02 13:02:40 +02:00
A Thousand Ships
308dbb8c63
[Core] Add scalar versions of Vector* min/max/clamp/snap(ped) 
Convenience for a number of cases operating on single values
 2024-05-02 10:31:13 +02:00
A Thousand Ships
c4e24d2b3b
[GDScript] Correctly report invalid read-only access 2024-05-01 12:28:47 +02:00
Rémi Verschelde
4e30bc71f5
Merge pull request #91376 from clayjohn/DOCS-reflect-vec3 
Update the description and parameter name for Vector3 reflect to correct how the plane is constructed
 2024-05-01 09:55:27 +02:00
Rémi Verschelde
273a643145
Merge pull request #89647 from AThousandShips/read_only_dict 
[Core] Fix property access on read-only `Dictionary`
 2024-05-01 09:54:48 +02:00
clayjohn
4d580b15be Update the description and parameter name for Vector3 reflect to correct how the plane is constructed 2024-04-30 13:50:39 -07:00
Rémi Verschelde
ef481148b2
Merge pull request #90394 from dsnopek/object-ptrcall-null-unlikely 
Use `likely()` in `PtrToArg<T *>` when checking for null `Object *`s
 2024-04-30 17:03:16 +02:00
kobewi
f647888006 Make varray() variadic 2024-04-26 14:33:11 +02:00
Rémi Verschelde
2e92fb00d4
Merge pull request #90540 from Repiteo/core/type-info-use-type-traits 
Core: Use `<type_traits>` where applicable
 2024-04-24 18:55:07 +02:00
Pedro J. Estébanez
dee65d1435 Redefine GetSimpleTypeT<> in terms of <type_traits> 2024-04-24 11:43:13 +02:00
Rémi Verschelde
ff9d78c141
Merge pull request #90889 from timothyqiu/compat 
Use compatible text resource format when possible
 2024-04-23 19:11:46 +02:00
Rémi Verschelde
cb1d6140be
Merge pull request #90866 from Repiteo/core/variant-initalizer-lists 
Core: Utilize initalizer lists in Variant constructors
 2024-04-23 19:11:29 +02:00
Haoyu Qiu
941e5c4820 Use compatible text resource format when possible 2024-04-23 12:04:44 +08:00
A Thousand Ships
ec29c3e784
[Core] Fix property access on read-only Dictionary 2024-04-22 13:57:34 +02:00
Aaron Franke
b1f5e9fe3a
Rename internal is_ascii_char to is_ascii_alphabet_char 2024-04-20 02:36:41 -07:00
Thaddeus Crews
b95e7fcecd
Core: Integrate initalizer lists for Variant 2024-04-19 08:52:17 -05:00
A Thousand Ships
80cb914e06
[Core] Fix incorrect comparison for Array const iterator 2024-04-13 17:32:33 +02:00
Thaddeus Crews
127025679b
Core: Use <type_traits> where applicable 2024-04-11 13:13:59 -05:00
Rémi Verschelde
8764769ee8
Merge pull request #89186 from groud/save_byte_arrays_as_base64_encoded 
Save PackedByteArrays as base64 encoded
 2024-04-10 17:49:24 +02:00
A Thousand Ships
64146cb7f3
[Core] Add iteration support to Array 2024-04-10 14:49:34 +02:00
clayjohn
c0d0bdc160
Clarify bounce and reflect docs and update param names 2024-04-10 14:07:08 +02:00
David Snopek
927f2e1e53 Use likely() in PtrToArg<T *> when checking for null Object *s 2024-04-08 11:06:56 -05:00
kobewi
f0cbd388dc Ignore ERR_FILE_CANT_OPEN error when loading scene 2024-04-05 17:51:27 +02:00
Thaddeus Crews
bbb3eb3a1a
Update lingering do/while(0) defines 2024-04-04 14:17:22 -05:00
Thaddeus Crews
b0cda1f85f
Core: Use fixed-width integer types in Variant 2024-04-04 08:54:11 -05:00
Rémi Verschelde
9335b83a32
Merge pull request #87831 from Riteo/bitfield-xor 
Core: Implement a XOR operator for BitField
 2024-03-26 13:45:02 +01:00
A Thousand Ships
2cbf469912
Fix sorting of files/dirs in dialogs 
Sorts leading `_` before other characters except `.`.
 2024-03-20 13:45:47 +01:00
Rémi Verschelde
453485aede
Merge pull request #89270 from Repiteo/enforce-typename-in-templates 
Enforce template syntax `typename` over `class`
 2024-03-14 22:34:37 +01:00
Rémi Verschelde
a1c476f9d7
Merge pull request #87680 from AThousandShips/the_angry_count 
Add methods to get argument count of methods
 2024-03-13 22:16:43 +01:00