Muller-Castro
ffacd0a148
Removed unnecessary reassigns
...
Those assignments are duplicated since add_to_group() or remove_from_group() aren't changing the state of those members.
2019-08-06 17:40:47 -03:00
qarmin
6cbaf7662f
Changed some code showed in LGTM and Coverage
2019-07-20 08:09:57 +02:00
Rémi Verschelde
111154a4a5
Merge pull request #30498 from bojidar-bg/30495-cannot-insert-key
...
Fix inability to insert keys via Insert Key context menu
2019-07-11 19:36:33 +02:00
Bojidar Marinov
8ecbb6a20d
Fix inability to insert keys via Insert Key context menu
...
Fixes #30495
2019-07-10 21:03:04 +03:00
qarmin
01cc7a996b
Use reference to constant in functions
2019-07-10 11:54:12 +02:00
Rémi Verschelde
6b30f284a0
Merge pull request #29980 from Dentrax/directed-by-qarmin
...
Fix some editor crashes
2019-07-01 14:59:29 +02:00
Furkan Türkal
7d8d337b2c
fix some crashes
2019-07-01 14:28:29 +03:00
Rémi Verschelde
eaaff9da31
Merge pull request #29941 from qarmin/redundant_code_and_others
...
Remove redundant code, possible NULL pointers and others
2019-06-27 01:05:18 +02:00
Rémi Verschelde
6e9272eea8
Node: Fix logic of has/get_node_and_resource and document it
...
Also document NodePath.
2019-06-26 15:46:32 +02:00
qarmin
4e5310cc60
Some code changed with Clang-Tidy
2019-06-26 15:08:25 +02:00
Rémi Verschelde
6d16f2f053
Fix error macro calls not ending with semicolon
...
It's not necessary, but the vast majority of calls of error macros
do have an ending semicolon, so it's best to be consistent.
Most WARN_DEPRECATED calls did *not* have a semicolon, but there's
no reason for them to be treated differently.
2019-06-11 14:49:34 +02:00
Rémi Verschelde
0823ae7ae4
Node::duplicate: Don't set name if original node is nameless
...
In practice this only happens when duplicating a node which is not in
the scene tree yet, as nameless nodes get assigned a generated name
when added to the scene tree.
Fixes #27319 .
2019-05-28 12:40:44 +02:00
PouleyKetchoupp
3f174c86d0
Fixed scene tree update after changing node name in tool script
2019-05-24 15:27:22 +02:00
Rémi Verschelde
9dc9434b1b
Merge pull request #24437 from mateusfccp/single_quotes_option
...
Add settings for single-quotes on completion
2019-04-30 14:58:33 +02:00
Rémi Verschelde
201cdd358a
Merge pull request #28140 from Daw11/orphan-nodes
...
Add a monitor for the orphan nodes
2019-04-22 11:55:15 +02:00
Hein-Pieter van Braam-Stewart
20b0046945
Object::script may not be a valid Ref<Script>
...
It appears that Object::script may be a valid ScriptInstance but not be
castable to Ref<Script>. There were only 5 places in the code that made
this assumption. This commit fixes that.
2019-04-20 02:13:28 +02:00
Daw11
04d0371648
Add a monitor for the orphan nodes
...
- Allow the user to keep track of the nodes that might leak
- Possible fix for #27103
2019-04-17 23:13:16 +02:00
Juan Linietsky
c1dcdf6109
No more metadata and dependency indices kept in resources saved.
...
-Node folding is now saved externally together with the properties
-External resources remember their ID when scenes are saved.
2019-04-11 14:36:58 -03:00
Rémi Verschelde
50ef456c78
Merge pull request #26803 from ptrojahn/emptynode
...
Make get_node return NULL for empty NodePaths
2019-04-05 16:55:42 +02:00
Juan Linietsky
a18989602b
Clean up notifications and merge Node and MainLoop ones for clarity, closes #27614
2019-04-04 10:34:41 -03:00
Paul Trojahn
97e8c88ce7
Make get_node return NULL for empty NodePaths
...
Fixes #25292
2019-03-08 21:31:36 +01:00
K. S. Ernest (iFire) Lee
b83c3827f3
Add check in folding to see if the nodepath exists to avoid message spam.
2019-01-30 20:19:44 -08:00
Rémi Verschelde
1ff170e67f
Redo serial name fixup from 799ed2b989
...
reduz wanted the original PR reverted due to issues, so this follow-up had to be too
(done in 8cb54182ad27d7772381
2019-01-11 23:02:57 +01:00
Juan Linietsky
27d7772381
Rewrote rename logic to be less buggy and more efficient, fixes #23803 and probably many recent bugs using GraphEdit
2019-01-10 18:58:16 -03:00
Rémi Verschelde
8cb54182ad
Revert "Node: make _generate_serial_child_name manipulate numbers as String"
...
This reverts commits 1025e3ecea799ed2b989
2019-01-10 22:40:42 +01:00
volzhs
799ed2b989
Fix strip out spaces while generating serial number for node name
2019-01-08 22:37:45 +09:00
Rémi Verschelde
b16c309f82
Update copyright statements to 2019
...
Happy new year to the wonderful Godot community!
2019-01-01 12:58:10 +01:00
Mateus Felipe C. C. Pinto
ca1935d6f7
Add settings for single-quotes on completion
2018-12-18 12:48:36 -02:00
lupoDharkael
1025e3ecea
Node: make _generate_serial_child_name manipulate numbers as String
...
The conversion from an String to int can overflow int and int64
so it is safer to manipulate strings when we try to find the next
available name for a Node.
2018-11-21 14:18:34 +01:00
Juan Linietsky
2d6b994e47
Massive speed up on deleting nodes, fixes #18673
...
Also makes the editor exit faster
2018-11-18 11:48:21 -03:00
Juan Linietsky
c5656b7468
Merge pull request #23564 from endragor/fix-remove-child-ordering
...
Notify node's moved children after sibling removed
2018-11-14 20:30:41 +01:00
Juan Linietsky
f2e54057ae
-Moved EditorDefaultValue to ClassDB, made it core
...
-Removed one and zero hints for properties, replaced by default value
2018-11-08 11:30:59 -03:00
Ruslan Mustakov
3b02cd3e71
Notify node's moved children after sibling removed
...
Fixes #16213 .
2018-11-07 16:31:25 +07:00
Juan Linietsky
e647342140
Moved folding outside the resource files, now saved outside the project.
2018-10-29 16:37:09 -03:00
DualMatrix
6afedaa498
Fixed error when duplicating a scene which has connection
...
Fixed error when duplicating a scene which has connection
2018-10-11 01:30:12 +02:00
Rémi Verschelde
344a453bb8
Merge pull request #22681 from akien-mga/fix-warnings
...
Fix warnings on release builds and some MSVC warnings
2018-10-03 19:05:55 +02:00
Rémi Verschelde
95131e6f23
Fix warnings on release builds (not DEBUG_ENABLED)
...
Fixes the following Clang 5 warnings:
```
modules/bmp/image_loader_bmp.cpp:46:60: warning: comparison of unsigned expression < 0 is always false [-Wtautological-compare]
modules/bmp/image_loader_bmp.cpp:48:61: warning: comparison of unsigned expression < 0 is always false [-Wtautological-compare]
drivers/png/image_loader_png.cpp:231:20: warning: comparison of unsigned expression >= 0 is always true [-Wtautological-compare]
scene/gui/graph_edit.cpp:1045:8: warning: comparison of constant 0 with expression of type 'bool' is always false [-Wtautological-constant-out-of-range-compare]
core/class_db.cpp:812:13: warning: unused variable 'check' [-Wunused-variable]
core/io/file_access_pack.cpp:172:11: warning: unused variable 'ver_rev' [-Wunused-variable]
core/math/bsp_tree.cpp:195:13: warning: unused variable 'plane' [-Wunused-variable]
core/math/bsp_tree.cpp:168:6: warning: unused variable 'plane_count' [-Wunused-variable]
modules/gdscript/gdscript_function.cpp:685:10: warning: unused variable 'ok' [-Wunused-variable]
modules/gdscript/gdscript_function.cpp:706:10: warning: unused variable 'ok' [-Wunused-variable]
modules/gdscript/gdscript_function.cpp:755:19: warning: unused variable 'var_type' [-Wunused-variable]
modules/gdscript/gdscript_function.cpp:1306:12: warning: unused variable 'err' [-Wunused-variable]
modules/gdscript/gdscript_function.cpp:158:15: warning: unused function '_get_var_type' [-Wunused-function]
modules/gdscript/gdscript_parser.cpp:750:20: warning: unused variable 'lv' [-Wunused-variable]
modules/gdscript/gdscript_parser.cpp:59:15: warning: unused function '_find_function_name' [-Wunused-function]
scene/main/node.cpp:2489:13: warning: unused function '_Node_debug_sn' [-Wunused-function]
```
2018-10-03 17:34:55 +02:00
DualMatrix
cb9559350f
Fixed error when duplicating node from editor.
...
Fixed error when duplicating node from editor.
2018-10-03 14:59:16 +02:00
Max Hilbrunner
d878c828b5
Merge pull request #22115 from akerudesu/find-parent
...
Added find_parent method to node class
2018-09-22 17:15:38 +02:00
Unknown
0fdbf6b2ef
Added find_parent method to node class
2018-09-15 18:22:29 +02:00
DualMatrix
b0d9f7686c
Made duplicate_and_reown preserve groups
2018-09-14 18:13:41 +02:00
Rémi Verschelde
277b24dfb7
Make core/ includes absolute, remove subfolders from include path
...
This allows more consistency in the manner we include core headers,
where previously there would be a mix of absolute, relative and
include path-dependent includes.
2018-09-12 09:52:22 +02:00
Juan Linietsky
4b6846a59d
Ensure that tree_exited signal really happens after tree exited, fixes #19641
2018-09-07 15:31:53 -03:00
Rémi Verschelde
52466d57e9
Make some debug prints verbose-only, remove others
2018-08-24 14:59:01 +02:00
Rémi Verschelde
404ee1a56b
Style: Fix issues that went past CI
2018-08-21 21:28:06 +02:00
volzhs
4e9795aa99
Fix not to show configuration warning on every node has script
2018-08-15 21:35:06 +09:00
Juan Linietsky
ef5095720b
-Deprecate ImageTexture::load
...
-Add warning to Image::load when loading resources
-Add script binding for get_configuration_warning
2018-08-14 16:53:20 -03:00
Andrea Catania
c1860fe88b
Fixed process priority
2018-08-04 14:51:44 +02:00
Juan Linietsky
15db793ef2
Ensure process notification is received only if really enabled, fixes #7894
2018-07-29 21:20:41 -03:00
Juan Linietsky
172f652dc0
Merge pull request #19888 from AndreaCatania/pry
...
Implemented proceses priority
2018-07-23 07:21:38 -03:00
Andrea Catania
51dfa10ac7
Implemented proceses priority
2018-07-23 12:19:38 +02:00
Rémi Verschelde
7c9f7452f4
Style: Format code with clang-format 6.0.1
2018-07-18 16:27:03 +02:00
Max Hilbrunner
465edbd2bc
Merge pull request #19853 from khairul169/duplicate_bug
...
Fix duplicate method on instanced node generates duplicated children.
2018-07-03 18:48:45 +02:00
Juan Linietsky
2dc738ce27
-Fixes to how hashing happened, now StringName and NodePath use default hasher, this was leading to some severe slowdown in scenarios
...
-Fixes to some duplication scenarios for instanced scenes
2018-07-02 15:08:35 -03:00
khairul169
8e03715a5c
Fix duplicate bug
2018-06-30 17:35:51 +07:00
Marcelo Fernandez
8c1c7ff131
Add missing NULL checks for add_child_below_node
2018-06-19 22:47:34 -03:00
Fabio Alessandrelli
1400f6fdc4
Refactor RPCMode enum and checks
2018-05-29 20:26:41 +02:00
Max Hilbrunner
4c69a495c9
Revert "RPCMode refactor, more sync modes"
2018-05-29 11:47:52 +02:00
Fabio Alessandrelli
9de4ffde61
Refactor RPCMode enum and checks
2018-05-26 10:43:43 +02:00
Juan Linietsky
005b69cf6e
-New inspector.
...
-Changed UI resizing code, gained huge amount of speed.
-Reorganized timer sync to clean up behavior (sorry forgot commit this before)
-
2018-05-15 17:14:31 -03:00
Fabio Alessandrelli
234914c42c
Rename multiplayer_api to just multiplayer.
...
Only the class name retain the MultiplayerAPI name
2018-05-08 10:51:04 +02:00
Juan Linietsky
7b065a59fa
Merge pull request #15911 from Zephilinox/ready_signal
...
Add ready signal to Node
2018-05-07 17:56:10 -03:00
Rémi Verschelde
b774156729
Merge pull request #18514 from neikeq/api-hash-fixes
...
API hash fixes
2018-05-03 14:36:32 +02:00
volzhs
6758b6c131
Check invalid node name
2018-05-03 00:00:06 +09:00
Ignacio Etcheverry
7034d48032
Fix binding some core API methods only in tools builds
2018-04-29 19:49:26 +02:00
Geoffrey
8362ce4769
Made print_tree_pretty() function which displays scene tree graphically
2018-04-09 15:01:37 +02:00
Juan Linietsky
e9e5aa617e
Merge pull request #17227 from Faless/multiplayer_api
...
[RFC] MultiplayerAPI refactor
2018-04-08 11:04:16 -03:00
Juan Linietsky
4ee3f3251d
Merge pull request #17382 from bojidar-bg/13971-path-array-unsaved
...
Duplicate Arrays and Dictionaries when instancing scene in editor
2018-04-08 09:39:03 -03:00
Bojidar Marinov
9f6c0c6eae
Duplicate Arrays and Dictionaries when instancing scene in editor
...
Also, add deep (=false) parameter to Array.duplicate and Dictionary.duplicate
Fixes #13971
2018-03-13 17:18:08 +02:00
Link
611c050469
Fix switching WindowDialog types leaves garbage buttons
...
We can distinguish between node-specific children and custom children by `child->is_owned_by_parent()`.
Fixes : #16350
2018-03-07 18:28:29 +08:00
Fabio Alessandrelli
5081ced57f
Use MultiplayerAPI class for high level networking
...
Remove networking related logic from Node and SceneTree.
SceneTree now simply relay all networking related stuff to
MultiplayerAPI for compatibility
2018-03-03 18:34:22 +01:00
luz.paz
612ab4bbc6
Fix typos with codespell
...
Found via `codespell -q 3 --skip="./thirdparty,./editor/translations" -I ../godot-word-whitelist.txt`
Whitelist consists of:
```
ang
doubleclick
lod
nd
que
te
unselect
```
2018-02-21 19:46:06 +01:00
Zephilinox
a826fb8d8b
Add ready signal to Node
...
Closes #15889
2018-01-20 21:57:59 +00:00
Rémi Verschelde
9f479f096c
Fix typos in code and docs with codespell
...
Using v1.11.0 from https://github.com/lucasdemarchi/codespell
2018-01-18 22:01:42 +01:00
Juan Linietsky
a26e6c8215
Renamed tree_exited to tree_exiting. tree_exited is now used for actual out of tree notification.
...
Updated doc accordingly.
2018-01-12 08:29:24 -03:00
Bojidar Marinov
9b8e8b2220
Bind many more properties to scripts
...
Notable potentially breaking changes:
- PROPERTY_USAGE_NOEDITOR is now PROPERTY_USAGE_STORAGE | PROPERTY_USAGE_NETWORK, without PROPERTY_USAGE_INTERNAL
- Some properties were renamed, and sometimes even shadowed by new ones
- New getter methods (some virtual) were added
2018-01-12 00:58:14 +02:00
AndreaCatania
5ac441131e
Fixed crash on duplicate GIProbe baking
2018-01-11 19:50:33 +01:00
Rémi Verschelde
e4213e66b2
Add missing copyright headers and fix formatting
...
Using `misc/scripts/fix_headers.py` on all Godot files.
Some missing header guards were added, and the header inclusion order
was fixed in the Bullet module.
2018-01-05 01:22:23 +01:00
Rémi Verschelde
b50a9114b1
Update copyright statements to 2018
...
Happy new year to the wonderful Godot community!
2018-01-01 14:40:47 +01:00
volzhs
d6a88cdc41
Fix crash from move_child at saving scene
2017-12-25 01:31:13 +09:00
Rémi Verschelde
e83c502939
Merge pull request #14754 from willnationsdev/dictionary-copy
...
Added 'duplicate' function for Dictionary in C++ and API.
2017-12-17 23:58:59 +01:00
Will Nations
f19fc83546
Dictionary::copy -> ::duplicate
2017-12-17 16:07:15 -06:00
Matthias Hoelzl
ced1ff63a8
Improve duplication and saving of instanced scenes
2017-12-16 17:58:17 +01:00
Juan Linietsky
f3ad14224e
-Add lightmapper
...
-Fixes to unwrapper (remove degenerates), makes Thekla not crash
-Added optional cancel button in EditorProgress
-Added function to force processing of events (needed for cancel button)
2017-12-14 09:01:27 -03:00
Konstantin Zaitsev
1f0e9c13a4
Fixed crash on duplicate instanced nodes ( #13432 )
2017-12-01 17:57:47 +07:00
Pedro J. Estébanez
922cf9fbb0
Fix crash on node duplication
...
That happened when an instanced scene was being duplicated while it also contained nodes added to it in the scene holding the instance.
Plus:
- Add comments about the logic behind all this.
- Move the null guard to where it can protect the most, but consider it a runtime error rather that a situation we expect.
Fixes #13282 .
2017-11-25 21:14:35 +01:00
Juan Linietsky
bc2e8d99e5
Made Vector::ptrw explicit for writing, compiler was sometimes using the wrong function,
...
leading to unnecesary copy on writes and reduced performance.
2017-11-25 00:09:40 -03:00
Will Nations
e1c907ec73
Node.duplicate(): instanced node's descendants' properties now update
...
w/ original's runtime values.
2017-11-21 23:04:40 -06:00
Rémi Verschelde
613d374bc5
Merge pull request #12284 from bojidar-bg/allow-subproperty-set
...
Allow for getting/setting "dotted" properties of objects
2017-11-21 22:44:14 +01:00
Bojidar Marinov
0cf9597758
Allow for getting/setting indexed properties of objects using get/set_indexed
...
Performance is around the same as using pure set() through GDScript.
2017-11-21 20:58:21 +02:00
Chaosus
fc74dbabd5
Preserve duplicate signal flags
2017-11-21 11:46:19 +03:00
Pedro J. Estébanez
5a0be858f4
Let SceneTreeDock duplicate nodes via Node::duplicate()
...
Helps with #11182 .
2017-11-19 21:30:17 +01:00
Pedro J. Estébanez
7286966971
Remove out-of-logic assignment of instance's original scene
2017-11-19 21:30:17 +01:00
Pedro J. Estébanez
803b3934d6
Fix duplication of signals
...
- Partially revert 6496b53549Fixes #12951 .
2017-11-19 15:07:05 +01:00
Ian
12b4e232b2
fix signals disconnecting on changing target node type
2017-11-13 17:44:58 -05:00
Chaosus
6496b53549
Duplicate signals fixes
2017-11-13 18:42:07 +03:00
Poommetee Ketson
9cadb9e5f3
Bind unbound enums, rearrange some by value
2017-10-22 01:58:02 +07:00
Nathan Warden
999ad9c0a8
Added a node_added signal to the SceneTree
2017-10-19 10:46:00 -05:00
AndreaCatania
4537977d6d
Renamed fixed_process to physics_process
2017-09-30 16:19:07 +02:00
Rémi Verschelde
a1779c9044
Merge pull request #11013 from MednauN/master
...
Fix duplication of node with script
2017-09-21 10:53:58 +02:00
