Rémi Verschelde
62120c7841
Fix Steam input "crc" errors, and some other Coverity reports of uninitialized scalar variable
...
- Fixes #88630 .
- Fixes #92578 .
2024-05-31 09:55:02 +02:00
Rémi Verschelde
7728839247
Rename FBX2glTF binary path setting back to 4.2 name
...
This preserves compatibility when upgrading Godot 4.2 projects which relied on that
path being configured in the editor settings.
The old name also makes sense for this one, it's fine for fbx2gltf_path to be under
a generic fbx category which could have more settings also impacting ufbx.
2024-05-30 23:42:11 +02:00
A Thousand Ships
926afccbd8
[Scene] Add SceneStringNames::panel
2024-05-30 22:54:50 +02:00
A Thousand Ships
755a0efbb6
[Scene] Add SceneStringNames::id_pressed
2024-05-30 22:54:04 +02:00
Rémi Verschelde
ce82984b5c
Merge pull request #92544 from dalexeev/gds-fix-const-non-metatype-subscript
...
GDScript: Fix subscript resolution on constant non-metatype GDScript base
2024-05-30 22:38:36 +02:00
Rémi Verschelde
cd53026b2c
Merge pull request #92558 from dalexeev/gds-adjust-inferred-declaration
...
GDScript: Do not produce `INFERRED_DECLARATION` on type import
2024-05-30 22:13:52 +02:00
Rémi Verschelde
34fe09dda7
Merge pull request #92386 from AThousandShips/goto_fix
...
[GDScript LSP] Fix `show_native_symbol_in_editor`
2024-05-30 22:13:46 +02:00
Danil Alexeev
3fd30ed4ff
GDScript: Do not produce INFERRED_DECLARATION on type import
2024-05-30 19:30:07 +03:00
Danil Alexeev
18d8838051
GDScript: Fix subscript resolution on constant non-metatype GDScript base
2024-05-30 17:37:05 +03:00
Rémi Verschelde
2666955011
Merge pull request #92251 from Chaosus/gdscript_fix_new_argument_completion
...
Fix completion for `new` arguments
2024-05-30 11:47:54 +02:00
Rémi Verschelde
5f572561c5
Merge pull request #92368 from fire/vsk-csg-gltf-4.3
...
Fix GLTFDocument so it can export CSG Meshes correctly.
2024-05-29 22:14:00 +02:00
Rémi Verschelde
d1f6d4c8c3
Merge pull request #92339 from devloglogan/comp-layer-reference-frame
...
Apply reference frame transform to `OpenXRCompositionLayer` nodes
2024-05-29 22:13:56 +02:00
K. S. Ernest (iFire) Lee
5a24aec599
Fix GLTFDocument so it can export CSG Meshes correctly.
2024-05-29 07:10:45 -07:00
devloglogan
6a8f2f00ac
Apply reference frame transform to OpenXRCompositionLayer nodes
2024-05-29 07:52:54 -05:00
Rémi Verschelde
dbc6f2af1d
Merge pull request #92241 from dalexeev/gds-fix-lambda-captures-non-local-vars
...
GDScript: Fix lambdas capturing non-local variables
2024-05-28 16:21:42 +02:00
Rémi Verschelde
607fa8229b
Merge pull request #92422 from groud/fix_navigation_baking_crash
...
Fix crash when baking TileMap navigation
2024-05-28 15:49:57 +02:00
Rémi Verschelde
bf2deacee1
Merge pull request #92359 from DanielSnd/fix-multiplayer-spawner-free-node-bug
...
Fix Multiplayer Spawner freeing node after client disconnected Issue
2024-05-28 15:49:37 +02:00
Gilles Roudière
1a380db62a
Fix crash when baking TileMap navigation
2024-05-27 10:46:54 +02:00
A Thousand Ships
e6ab22d450
[GDScript LSP] Fix show_native_symbol_in_editor
2024-05-26 16:33:19 +02:00
Yuri Rubinsky
fc2b82188b
Fix completion for new arguments
2024-05-26 13:47:22 +03:00
Daniel Snd
1a9d95f933
Fix Multiplayer Spawner freeing node after client disconnected Issue
2024-05-25 13:34:33 -03:00
Aaron Franke
d3a58e57b8
Rename accessor GLTFType to GLTFAccessorType, fix verbose prints, doc
2024-05-24 03:21:13 -07:00
K. S. Ernest (iFire) Lee
24f56008ac
Add bake_fps for FBXDocument, GLTFDocument and both import-export.
2024-05-23 09:09:36 -07:00
Rémi Verschelde
782a0261cb
Merge pull request #92196 from lyuma/gltf_anim_library_import_as_bones
...
Support Import As Skeleton Bones on glTF and AnimationLibrary import
2024-05-23 08:59:13 +02:00
patwork
1a89ae70eb
Upgrade to eslint 9
2024-05-22 11:32:25 +02:00
Rémi Verschelde
c40c89f94c
Merge pull request #90457 from Chubercik/ruff-formatter
...
Replace `black` formatter with `ruff`
2024-05-22 09:26:42 +02:00
Danil Alexeev
4b692959de
GDScript: Fix lambdas capturing non-local variables
2024-05-22 10:07:31 +03:00
Jakub Marcowski
d9f8ef68df
Update pre-commit hooks configuration to use ruff instead of black
2024-05-21 18:02:29 -05:00
Rémi Verschelde
4c0d5e59bf
Merge pull request #92200 from devloglogan/composition-layer-viewport-fix
...
Allow `OpenXRCompositionLayer` property `layer_viewport` to always be assigned `nullptr`
2024-05-21 23:19:03 +02:00
Rémi Verschelde
03aa82849d
Merge pull request #92197 from lyuma/better_fbx_defaults
...
FBX: Change trimming default and use FBX2glTF for compatibility
2024-05-21 23:18:59 +02:00
Rémi Verschelde
d916423327
Merge pull request #92181 from smix8/recast_vertices_dup
...
Remove duplicated vertices after 3D NavigationMesh bake
2024-05-21 23:18:53 +02:00
Rémi Verschelde
aa20f54cb7
Merge pull request #92137 from BastiaanOlij/fix_fb_swapchain_foveation
...
OpenXR: Fix updating swapchain for foveation
2024-05-21 23:18:45 +02:00
Lyuma
c433754d34
fbx: change import option defaults
...
ufbx has special logic to handle animation/trimming, and most users expect trimming to be on.
For existing projects, we should upgrade files0 to FBX2glTF to preserve node compatibility.
2024-05-21 07:58:36 -07:00
devloglogan
3d7b712c86
Allow OpenXRCompositionLayer property layer_viewport to be assigned to nullptr
2024-05-21 07:52:40 -05:00
smix8
4128c7b311
Remove duplicated vertices after 3D NavigationMesh bake
...
Removes duplicated vertices that may exist on shared polygon corners after a ReCast navigation mesh bake.
2024-05-21 14:18:32 +02:00
Lyuma
ef486db569
Support Import As Skeleton Bones on glTF and AnimationLibrary import
2024-05-21 03:19:35 -07:00
Rémi Verschelde
c0eb347946
Merge pull request #91557 from AThousandShips/dotnet_doc_fix
...
[C#] Unexpose `GodotSharp`
2024-05-21 11:22:40 +02:00
Rémi Verschelde
0cf42d6273
Merge pull request #88919 from nongvantinh/fix-88834
...
Revise implementation of C# `Aabb.GetSupport` to match the implementation in `core`
2024-05-21 11:22:36 +02:00
kobewi
eca19d6e80
Fix broken script reloading
2024-05-20 23:54:27 +02:00
Bastiaan Olij
6582be0c50
OpenXR: Fix updating swapchain for foveation
2024-05-20 12:23:56 +10:00
Rémi Verschelde
daa81bbb7d
Merge pull request #92087 from Repiteo/scons/windows-color-fix-maybe
...
SCons: Fix potential Windows ANSI exception
2024-05-19 11:21:18 +02:00
Rémi Verschelde
c63383fa88
Merge pull request #92035 from rune-scape/rune-gdscript-invalid
...
GDScript: Fix segfault on invalid script
2024-05-19 11:21:14 +02:00
Rémi Verschelde
4ce95d684c
Merge pull request #91653 from HolonProduction/autocompletion-analyze-recursively-but-leave-the-parser-alone
...
Autocompletion: Analyze CLASS types as they are encountered
2024-05-19 11:21:11 +02:00
Rémi Verschelde
6761923f4f
Merge pull request #90716 from dalexeev/gds-fix-export-annotation-issues
...
GDScript: Fix some export annotation issues
2024-05-19 11:21:00 +02:00
Thaddeus Crews
a9810cffb4
SCons: Fix potential Windows ANSI exception
2024-05-18 13:14:31 -05:00
rune-scape
9fa13da16f
GDScript: fix segfault on invalid script
2024-05-17 15:26:25 -07:00
Rémi Verschelde
b569ae3ddc
Merge pull request #92027 from dalexeev/gds-fix-standalone-expression-for-preload
...
GDScript: Fix `STANDALONE_EXPRESSION` warning for `preload()`
2024-05-17 13:00:33 +02:00
Rémi Verschelde
c4889e4793
Merge pull request #91901 from akien-mga/scons-thorvg-webp-loader-opt-out
...
thorvg: Disable webp loader if corresponding module is disabled
2024-05-17 11:14:00 +02:00
Danil Alexeev
7dd801c580
GDScript: Fix STANDALONE_EXPRESSION warning for preload()
2024-05-17 10:33:01 +03:00
Rémi Verschelde
5708a3a02e
Merge pull request #92000 from clayjohn/vram-debugger
...
Increase coverage of VRAM debugger and add support to RD backends
2024-05-16 09:32:11 +02:00
Rémi Verschelde
8663f27159
Merge pull request #91996 from Maran23/ms-build-context-menu
...
Fix ContextMenu `Copy Error` is off in `MSBuild` Panel
2024-05-16 09:32:06 +02:00
clayjohn
c84616c2d2
Increase coverage of VRAM debugger and add support to RD backends
2024-05-15 16:30:19 -07:00
Marius Hanl
32be459e54
Fix ContextMenu Copy Error is off in MSBuild Panel
2024-05-15 22:55:05 +02:00
Rémi Verschelde
42b60c1b01
Merge pull request #91985 from passivestar/fix-lightmapper-seams
...
Fix lightmapper seam blending
2024-05-15 22:41:59 +02:00
Rémi Verschelde
82fb849678
Merge pull request #91943 from akien-mga/libwebp-1.4.0
...
libwebp: Update to 1.4.0
2024-05-15 22:41:52 +02:00
passivestar
d06bce3002
Fix lightmapper seam blending
2024-05-15 19:30:14 +04:00
Rémi Verschelde
693a13a849
Merge pull request #91601 from lander-vr/lightmap_seams_fix
...
LightmapGI: Fix lightleaks caused by insufficient padding and add denoiser range property for LightmapGI
2024-05-15 13:51:35 +02:00
Rémi Verschelde
5caa8e41f7
Merge pull request #91951 from dalexeev/gds-pot-gen-add-atr-and-atr-n
...
GDScript: Add support for `atr` and `atr_n` to POT generator
2024-05-15 12:09:56 +02:00
landervr
e7bd1b0673
Add denoiser range property for LightmapGI
2024-05-15 08:26:04 +02:00
Rémi Verschelde
4971b71899
Merge pull request #91952 from dsnopek/openxr-composition-layer-sample-count
...
Fix sample count on OpenXR composition layers
2024-05-14 18:10:14 +02:00
Rémi Verschelde
c0d2464d6b
Merge pull request #91939 from AThousandShips/pressed_sname
...
[Scene] Add `SceneStringNames::pressed`
2024-05-14 18:10:05 +02:00
Rémi Verschelde
882449f496
Merge pull request #91924 from ZerxZ/dotnet/useless-is-first-entry
...
[C#] Remove useless `isFirstEntry` and useless `source.Append("else ")`
2024-05-14 18:10:02 +02:00
David Snopek
45a02c28cd
Fix sample count on OpenXR composition layers
2024-05-14 10:43:44 -05:00
Danil Alexeev
0bd4345736
GDScript: Add support for atr and atr_n to POT generator
2024-05-14 18:35:59 +03:00
A Thousand Ships
ee79386f7b
[Scene] Add SceneStringNames::pressed
2024-05-14 15:51:28 +02:00
Rémi Verschelde
09bd34df93
libwebp: Update to 1.4.0
...
https://chromium.googlesource.com/webm/libwebp/+/refs/tags/v1.4.0/NEWS
2024-05-14 13:01:07 +02:00
Rémi Verschelde
78cce1954d
Merge pull request #91937 from bruvzg/icu_751
...
Update ICU to 75.1
2024-05-14 12:07:31 +02:00
Rémi Verschelde
d6eab9f5df
Merge pull request #91917 from Pepito468/fix-docs-typo
...
Fix a typo in the GridMap docs
2024-05-14 12:07:06 +02:00
Rémi Verschelde
bdefe53992
Merge pull request #91909 from KoBeWi/have_fun_reviewing_this
...
Use Core/Scene stringnames consistently
2024-05-14 12:07:03 +02:00
bruvzg
e74fea2864
Update ICU to 75.1
2024-05-14 12:38:52 +03:00
Gaoyao Massimo Hu
e3270113ca
Remove useless isFirstEntry and useless source.Append("else ")
2024-05-14 07:44:56 +01:00
kobewi
413c11357d
Use Core/Scene stringnames consistently
2024-05-13 23:41:07 +02:00
Pepito468
73479cb56e
Fixed a typo in the docs
...
Fixed a typo in GridMap.xml where a 'See also' suggestion link to the wrong method.
2024-05-13 21:19:54 +02:00
Rémi Verschelde
0a67ee52d1
Revert "GDScript: Implement get_dependencies()"
...
This reverts commit dc73440f89Fixes #91726 .
2024-05-13 16:59:43 +02:00
Danil Alexeev
76b2d85c9f
GDScript: Fix some export annotation issues
2024-05-13 17:49:06 +03:00
Rémi Verschelde
831ebda806
thorvg: Disable webp loader if corresponding module is disabled
...
Fixes #91873 .
2024-05-13 13:01:34 +02:00
Rémi Verschelde
ba0dcf70f1
Merge pull request #91783 from ogapo/pr/gltf-export-fixes
...
GLTF export improvements
2024-05-13 12:05:42 +02:00
David Nikdel
522f035cb1
GLTF export improvements
...
- GLBs produced by godot don't pass validation when there's no data in the buffer segment. The segment is dropped but the size of the chunk_header is still reported in total length (incorrectly)
- Remove empty "extensions" JSON object being appended to all nodes (if it's still empty). This is just cutting down on unnecessary bloat and consistent with the rest of the file's attempts to not emit any keys that are equal to their default value.
- Allow the case where root_nodes is empty. This is permitted by the GLTF spec. Moreover it can happen fairly naturally when using the ROOT_NODE_MODE_MULTI_ROOT root node mode on a scene with only a root node (which is valid in godot).
- Don't create an initial buffer until we're ready to write data into it (buffers of byteLength=0 don't pass validation).
2024-05-11 21:42:05 -04:00
kobewi
a262d2d881
Add shorthand for using singleton string names
2024-05-11 18:53:08 +02:00
Rémi Verschelde
1cf283dd26
Merge pull request #91788 from akien-mga/thorvg-0.13.3
...
thorvg: Update to 0.13.3, add webp loader
2024-05-11 12:38:21 +02:00
Rémi Verschelde
da5714ad6e
Merge pull request #91775 from dsnopek/openxr-composition-layer-viewport-in-use-bug
...
Fix `layer_viewport` getting cleared on `OpenXRCompositionLayer` in editor
2024-05-10 09:56:15 +02:00
Rémi Verschelde
d24403d056
Merge pull request #91763 from paulloz/dotnet/fix-stringextension-warnings
...
C#: Fix comparison warnings in `StringExtensions.cs`
2024-05-10 09:56:12 +02:00
Rémi Verschelde
6766404afa
Merge pull request #91745 from timothyqiu/destruct
...
Fix memory leak when ASTC compression fails
2024-05-10 09:56:03 +02:00
Rémi Verschelde
7704457434
Merge pull request #91645 from ZerxZ/dotnet/hint-string-fix
...
Fix C# Hint NodeType and ResourceType HintString
2024-05-10 09:55:54 +02:00
Rémi Verschelde
6fcdd24468
Merge pull request #91624 from Repiteo/scons/native-generation
...
SCons: Generate all scripts natively, implement wrapper function
2024-05-10 09:55:51 +02:00
Rémi Verschelde
b7783a43c5
Merge pull request #91564 from paulloz/huisedenanhai-fix_csharp_method_info
...
CSharpScript should not own method infos of the base class
2024-05-10 09:55:47 +02:00
Paul Joannon
af5f695a99
Fix comparison warnings in StringExtensions.cs
2024-05-10 09:42:58 +02:00
Rémi Verschelde
1cf9f37589
thorvg: Update to 0.13.3, add webp loader
...
Remove embedded png loader, we use the external (libpng) one.
2024-05-10 09:30:57 +02:00
David Snopek
a8a7110b90
Fix layer_viewport getting cleared on OpenXRCompositionLayer in editor
2024-05-09 14:05:20 -05:00
Paul Joannon
1d7085571e
CSharpScript should not own base script signals
2024-05-09 13:46:25 +02:00
Haoyu Qiu
a35ff3c737
Fix memory leak when ASTC compression fails
2024-05-09 14:41:35 +08:00
Gaoyao Massimo Hu
06b716d8b3
Fix C# Hint NodeType and ResourceType HintString
2024-05-08 16:22:52 +01:00
Rémi Verschelde
2042420bd7
Merge pull request #91709 from KoBeWi/deawkwarding_labels
...
Improve transition enabled header in interactive music editor
2024-05-08 14:35:48 +02:00
Rémi Verschelde
a9a1d0a162
Merge pull request #91619 from AThousandShips/find_improve
...
Replace `find` with `contains/has` where applicable
2024-05-08 14:35:44 +02:00
kobewi
a880b2dcba
Improve transition enabled header in interactive music editor
2024-05-08 14:19:11 +02:00
A Thousand Ships
b4c6cc7d82
[Core] Add case-insensitive String::containsn
2024-05-08 12:48:01 +02:00
A Thousand Ships
a0dbdcc3ab
Replace find with contains/has where applicable
...
* Replaces `find(...) != -1` with `contains` for `String`
* Replaces `find(...) == -1` with `!contains` for `String`
* Replaces `find(...) != -1` with `has` for containers
* Replaces `find(...) == -1` with `!has` for containers
2024-05-08 12:37:42 +02:00
Rémi Verschelde
9ef50524d0
Merge pull request #91696 from akien-mga/style-file-format
...
Style: Trim trailing whitespace and ensure newline at EOF
2024-05-08 12:31:32 +02:00
Rémi Verschelde
f349418fc0
Merge pull request #91693 from timothyqiu/interactive-editor
...
Fix i18n in AudioStreamInteractive transition editor
2024-05-08 12:31:30 +02:00
Rémi Verschelde
c4cf2a8f90
Merge pull request #91686 from dsnopek/openxr-fix-composition-layers
...
OpenXR: Fix composition layers not having correct play space
2024-05-08 12:31:26 +02:00
Rémi Verschelde
6533c52706
Merge pull request #91670 from paulloz/dotnet/fix-godottools-openvisualstudio
...
C#: Specify a runtime rollforward for OpenVisualStudio
2024-05-08 12:31:23 +02:00
Haoyu Qiu
4a316c4ac8
Fix i18n in AudioStreamInteractive transition editor
...
- Don't translate user-defined clip names.
- Add missing i18n for some UI strings.
- Also fixed error when selecting top-right "From/To" cell.
- Also removed unused header includes.
2024-05-08 17:15:38 +08:00
Rémi Verschelde
7d03b1de0b
Style: Trim trailing whitespace and ensure newline at EOF
...
Found by apply the file_format checks again via #91597 .
2024-05-08 10:12:46 +02:00
David Snopek
de654d9846
OpenXR: Fix composition layers not having correct play space
2024-05-07 20:49:46 -05:00
Thaddeus Crews
34fb3f7730
SCons: Generate all scripts natively
2024-05-07 15:30:45 -05:00
Rémi Verschelde
316b87dc5f
Merge pull request #91485 from dsnopek/openxr-composition-layers-hole-punch
...
OpenXR: Allow composition layers to enable hole punching
2024-05-07 21:52:49 +02:00
Rémi Verschelde
d83586f1e4
Merge pull request #84492 from HolonProduction/reduce-const-arrays
...
Autocompletion: Mark datatype as constant for constant arrays
2024-05-07 21:52:40 +02:00
Paul Joannon
c2d72a691f
Specify a runtime rollforward for OpenVisualStudio
...
Use `LatestMajor`
Fixes #91638
2024-05-07 19:40:25 +02:00
David Snopek
666bf60e36
OpenXR: Allow composition layers to enable hole punching
2024-05-07 10:02:32 -05:00
Rémi Verschelde
ff018079a1
Merge pull request #84706 from HolonProduction/completion-get-child
...
Fix autocompletion after DOLLAR token
2024-05-07 16:49:13 +02:00
Rémi Verschelde
4db9103c2b
Merge pull request #91650 from akien-mga/codespell
...
Fix various typos with codespell
2024-05-07 13:49:03 +02:00
Rémi Verschelde
82e77eab35
Merge pull request #91529 from bqqbarbhg/ufbx-warnings
...
FBX: Print ufbx load warnings on import
2024-05-07 13:48:56 +02:00
Rémi Verschelde
e8d5bdd95d
Merge pull request #91528 from bqqbarbhg/ufbx-v0.14.0
...
FBX: Update ufbx to v0.14.0
2024-05-07 13:48:52 +02:00
Rémi Verschelde
0404e3a85e
Merge pull request #84148 from KANAjetzt/fix_crash_take_over_path_named_class
...
Fix crash when extending taken-over named class
2024-05-07 13:48:36 +02:00
bqqbarbhg
5cd7ae198d
Update ufbx to v0.14.0
2024-05-07 14:27:21 +03:00
bqqbarbhg
04db5cf063
Print ufbx load warnings on import
2024-05-07 12:43:48 +03:00
HolonProduction
d131064841
Autocompletion: Analyze CLASS types as they are encountered
2024-05-07 10:45:28 +02:00
Rémi Verschelde
4b070e8031
Fix various typos with codespell
...
Using 2.2.7.dev217+g10c2abcf.
Had to add `colour` to the ignore list as we used it as an alias/keyword for the
documentation of color-related APIs.
Also ignore recommendations to change `thirdparty` to either `third-party` or
`third party`, which are correct but we use the former fairly consistently.
2024-05-07 10:08:42 +02:00
Rémi Verschelde
2576addc28
Merge pull request #91636 from akien-mga/miniupnpc-disable-SET_SOCKET_TIMEOUT
...
miniupnpc: Disable socket timeout on Windows, matching upstream
2024-05-07 09:04:51 +02:00
Rémi Verschelde
e63252b421
Merge pull request #90705 from AThousandShips/foreach_list
...
Reduce and prevent unnecessary random-access to `List`
2024-05-07 09:04:44 +02:00
Kai
f4192aad6f
Fix crash when extending taken-over named class
...
Added error handling in `_prepare_compilation()` to address cases where the `base_type` cannot be found, preventing a crash.
2024-05-07 08:07:11 +02:00
Rémi Verschelde
f695de7c68
miniupnpc: Disable socket timeout on Windows, matching upstream
...
Fixes #88471 .
2024-05-06 23:30:09 +02:00
A Thousand Ships
86de59d60a
[Core] Add LocalVector::has for convenience
2024-05-06 18:03:37 +02:00
Haoyu Qiu
7355e672ae
Fix crash when executing Image.save_jpg_to_buffer
2024-05-05 23:37:22 +08:00
huisedenanhai
c313312ff5
CSharpScript should not own method infos of the base class
2024-05-04 18:54:37 +02:00
A Thousand Ships
955d5affa8
Reduce and prevent unnecessary random-access to List
...
Random-access access to `List` when iterating is `O(n^2)` (`O(n)` when
accessing a single element)
* Removed subscript operator, in favor of a more explicit `get`
* Added conversion from `Iterator` to `ConstIterator`
* Remade existing operations into other solutions when applicable
2024-05-04 16:08:55 +02:00
A Thousand Ships
aff2e47bff
[C#] Unexpose GodotSharp
...
This class seems to have been exposed accidentally, and breaks
documentation on non-mono builds, requiring hacks
2024-05-04 14:09:42 +02:00
Rémi Verschelde
4313524ae3
Merge pull request #91526 from bqqbarbhg/ufbx-bad-skin-fix
...
FBX: Fix handling missing skins using ufbx importer
2024-05-04 11:52:38 +02:00
Rémi Verschelde
9ed8399514
Merge pull request #91509 from akien-mga/dotnet-fix-generating-glue-in-project-folder
...
.NET: Prevent generating mono glue in project folder
2024-05-04 11:52:32 +02:00
Rémi Verschelde
629e91acff
Merge pull request #91479 from Repiteo/dotnet/sln-csproj-attributes
...
C#: Fix attributes for `sln`/`csproj` files
2024-05-04 11:52:29 +02:00
Rémi Verschelde
458106a73e
Merge pull request #91203 from pirey0/stringcomp_fix
...
C#: Fix `StringExtensions.CompareTo` IndexOutOfRangeException
2024-05-04 11:52:25 +02:00
Rémi Verschelde
a2fc5e2d78
Merge pull request #89894 from BastiaanOlij/improve_foveated_rendering
...
Improvements to VRS/Foveated rendering
2024-05-04 11:52:15 +02:00
bqqbarbhg
b9ab0e46e2
Fix handling missing skins using ufbx importer
...
Previously, _asset_parse_skins() would mess with the order of skin indices.
However, the rest of the code expected these to match to ufbx skin indices.
To fix this, retain the original skin indices in FBXState::original_skin_indices.
2024-05-03 20:46:26 +03:00
Thaddeus Crews
64f2e8b64f
Dotnet: Fix attributes for sln/csproj files
2024-05-03 12:21:51 -05:00
Rémi Verschelde
baec8da3b3
.NET: Prevent generating mono glue in project folder
...
Fixes #83128 .
2024-05-03 14:24:35 +02:00
Rémi Verschelde
03e6fbb010
Merge pull request #85474 from fire/packedvector4array
...
Add `PackedVector4Array` Variant type
2024-05-03 12:25:26 +02:00
Luca Martinelli (laptop)
c02540bd66
fixed StringExtensions.CompareTo IndexOutOfRangeException
...
fixes #91118
marked CompareTo obsolete
dropped CompareTo [-1,1] range
Co-authored-by: Raul Santos <raulsntos@gmail.com>
2024-05-03 10:13:06 +02:00
Bastiaan Olij
9042ddf19f
Improvements to VRS/Foveated rendering
2024-05-03 17:20:30 +10:00
Rémi Verschelde
4d43fe1c96
Merge pull request #91472 from vnen/gdscript-default-static-variables-non-tool
...
GDScript: Initialize static variables with defaults in-editor
2024-05-03 01:21:40 +02:00
Rémi Verschelde
25fe3d4b46
Merge pull request #81639 from MJacred/is_letter
...
Add `is_valid_letter()` to `TextServer`
2024-05-03 01:21:34 +02:00
K. S. Ernest (iFire) Lee
f9b488508c
Add PackedVector4Array Variant type
...
Co-authored-by: A Thousand Ships <96648715+AThousandShips@users.noreply.github.com>
Co-authored-by: Rémi Verschelde <rverschelde@gmail.com>
2024-05-03 00:58:27 +02:00
MJacred
717513a62d
Add is_valid_letter() to TextServer
2024-05-02 21:32:20 +02:00
George Marques
22236380c0
GDScript: Initialize static variables with defaults in-editor
...
When the script is not marked as `@tool` the static constructor is not
called and thus the variables contain `null` by default. But since some
validated operations requires a valid value, this would cause a crash.
This commit solves this by initializing the static variables with a
default value based on their types in the editor, when they are not
marked as `@tool`, so if some `@tool` script access them, they will have
a valid typed value, avoiding the crash.
2024-05-02 15:09:22 -03:00
Rémi Verschelde
7fef538223
Merge pull request #91464 from groud/fix_tilemap_layer_navmesh_baking
...
Fix TileMapLayer navmesh baking
2024-05-02 19:06:06 +02:00
Gilles Roudière
23b9a9f2de
Fix TileMapLayer navmesh baking
2024-05-02 18:06:23 +02:00
Rémi Verschelde
76f642b962
Merge pull request #91412 from dalexeev/gds-fix-non-static-access-in-static-context
...
GDScript: Fix access non-static members in static context
2024-05-02 17:31:39 +02:00
Rémi Verschelde
a7029e4c8a
Merge pull request #91364 from vnen/gdscript-implicit-ready-base-first
...
GDScript: Call implicit ready on base script first
2024-05-02 17:31:32 +02:00
Rémi Verschelde
7a968c619d
Merge pull request #91140 from RadiantUwU/add-mobile-vr-screen-rect
...
Add a new property named `offset_rect` to `MobileVRInterface`
2024-05-02 17:31:28 +02:00
George Marques
99b702ea3d
GDScript: Call implicit ready on base script first
...
It is generally expected that the base class is called before the
inherited clas. This commit implements this behavior for the implicit
ready function (`@onready` annotation) to make it consistent with the
expectations.
2024-05-02 11:25:52 -03:00
Radiant
9be2f7090a
Implement offset_rect property to MobileVRInterface to allow changing screen area.
2024-05-02 16:25:48 +03:00
Rémi Verschelde
28a18cf1b8
Merge pull request #88763 from BlueCube3310/image-is-compressed-static
...
Image: Add static `is_format_compressed` function.
2024-05-02 14:01:18 +02:00
A Thousand Ships
0f5e0d1637
Expose Vector* component-wise and scalar min/max to scripting
2024-05-02 13:02:40 +02:00
Rémi Verschelde
4eaafc8fa8
Merge pull request #91375 from paulloz/dotnet/prevent-generator-crash-on-exported-unconstructed-generic-arrays
...
C#: Fix generator crash w/ generic arrays
2024-05-02 12:46:42 +02:00
Rémi Verschelde
9122286553
Merge pull request #89426 from BlueCube3310/basisu-mult-of-4
...
BasisUniversal: Fix artifacts on images with resolutions not divisible by 4
2024-05-02 12:46:25 +02:00
Rémi Verschelde
0b6c29f2d2
Merge pull request #89114 from AThousandShips/vec_elem_scalar
...
[Core] Add scalar versions of `Vector*` `min/max/clamp/snap(ped)`
2024-05-02 12:46:22 +02:00
BlueCube3310
c71490043a
Fix BasisU compression on images with resolutions not divisible by 4.
2024-05-02 12:15:02 +02:00
Bastiaan Olij
527c30c594
Add support for OpenXR hand interaction extension
2024-05-02 19:15:02 +10:00
A Thousand Ships
308dbb8c63
[Core] Add scalar versions of Vector* min/max/clamp/snap(ped)
...
Convenience for a number of cases operating on single values
2024-05-02 10:31:13 +02:00
Danil Alexeev
8122a27eac
GDScript: Fix access non-static members in static context
2024-05-01 19:55:40 +03:00
A Thousand Ships
c4e24d2b3b
[GDScript] Correctly report invalid read-only access
2024-05-01 12:28:47 +02:00
Rémi Verschelde
0e0ef3cd69
Merge pull request #91368 from raulsntos/dotnet/must-be-variant-dynamic
...
C#: Ignore late bound methods in MustBeVariantAnalyzer
2024-05-01 09:55:21 +02:00
Rémi Verschelde
731ea17dd4
Merge pull request #91192 from vnen/gdscript-validated-native-static-calls
...
GDScript: Perform validated calls with static methods
2024-05-01 09:55:04 +02:00
Rémi Verschelde
70247adf25
Merge pull request #89734 from BastiaanOlij/openxr_reorder_wait_frame
...
OpenXR: Change timing of xrWaitFrame and fix XR multithreading issues
2024-05-01 09:54:51 +02:00
Rémi Verschelde
273a643145
Merge pull request #89647 from AThousandShips/read_only_dict
...
[Core] Fix property access on read-only `Dictionary`
2024-05-01 09:54:48 +02:00
Bastiaan Olij
cbab7dc049
OpenXR: Change timing of xrWaitFrame and add thread safety features to OpenXR
2024-05-01 14:24:41 +10:00
Raul Santos
1510f88ae1
C#: Ignore late bound methods in MustBeVariantAnalyzer
...
If symbol is late bound (as is the case when using `dynamic`) we can't obtain the symbol to analyze the usage of `[MustBeVariant]`.
2024-05-01 03:18:21 +02:00
Paul Joannon
aba787393f
C#: Fix generator crash w/ generic arrays
2024-04-30 22:22:09 +02:00
Rémi Verschelde
d282e4f0e6
Merge pull request #91360 from bruvzg/arm_win_build
...
Fix arm64/Windows build.
2024-04-30 17:03:58 +02:00
bruvzg
986d297ed3
Fix arm64/Windows build.
2024-04-30 16:26:42 +03:00
Thaddeus Crews
dec2a121a9
SCons: Fixes for warn/error colorization
2024-04-29 11:56:21 -05:00
Rémi Verschelde
f03301ca1a
Merge pull request #91305 from BastiaanOlij/fix_mobile_vr_gyro
...
MobileVR: Orientation is progressive and needs to be initialized
2024-04-29 15:20:32 +02:00
Bastiaan Olij
d83aaeea17
MobileVR: orientation is progressive and needs to be initialised
2024-04-29 21:46:28 +10:00
Rémi Verschelde
c4733e8003
Merge pull request #90860 from vnen/gdscript-get-dependencies
...
GDScript: Implement `get_dependencies()`
2024-04-29 12:30:12 +02:00
Rémi Verschelde
296758a8f8
Merge pull request #90552 from vnen/gdscript-constructor-callable-release
...
GDScript: Assume constructor to be accessible from class
2024-04-29 12:30:08 +02:00
Rémi Verschelde
d216a385a6
Merge pull request #90498 from vnen/gdscript-resolve-scene-autoload-types
...
GDScript: Resolve types from autoload scenes
2024-04-29 12:30:02 +02:00
Rémi Verschelde
dee1231ce6
Merge pull request #91220 from Repiteo/scons/colorize-warn-error
...
SCons: Colorize warnings/errors during generation
2024-04-29 10:10:16 +02:00
Rémi Verschelde
13fbd42c37
Merge pull request #90975 from aaronfranke/plugin-org
...
Organize existing code for editor plugins
2024-04-29 10:09:45 +02:00
Rémi Verschelde
c33cd94509
Merge pull request #90949 from rhofour/gdignore
...
LSP: Have `GDScriptWorkspace::list_script_files` respect `.gdignore`.
2024-04-29 10:09:42 +02:00
Thaddeus Crews
e0e8ce1fc0
SCons: Colorize warnings/errors during generation
2024-04-28 16:24:48 -05:00
Aaron Franke
1bcbbe96c4
Organize existing code for editor plugins
2024-04-27 11:59:58 -07:00
George Marques
8b7fc225f0
GDScript: Resolve types from autoload scenes
...
When the autoload is a scene, it now extracts the script from it and
use it to further infer nested types.
2024-04-26 10:46:19 -03:00
Rémi Verschelde
38d2928fca
Merge pull request #91144 from Konstantin-Kretov/k.kretov/add_copyright_to_csproj_files
...
Fill copyright field in .csproj files to ensure that nuget packages will have both license and copyright fields filled
2024-04-26 15:13:37 +02:00
Konstantin Kretov
2b46e009fa
Fill copyright field in .csproj files
...
This ensures that nuget packages will have both license and copyright fields filled.
2024-04-26 11:41:04 +02:00
Rémi Verschelde
0d589abcbd
Merge pull request #91130 from Malcolmnixon/xrhandtracker-dotnet-name-collision
...
Remove the Hand enum from XRHandTracker
2024-04-26 11:08:44 +02:00
Rémi Verschelde
36833c6871
Merge pull request #91036 from bqqbarbhg/ufbx-bind-pose-fix
...
Resolve bind poses from FBX clusters instead of FBX poses.
2024-04-26 11:08:38 +02:00
Rémi Verschelde
643afab6b7
Merge pull request #89639 from dalexeev/gds-fix-object-iterator-opcodes
...
GDScript: Fix object iterator opcodes
2024-04-26 11:08:22 +02:00
Rémi Verschelde
cb01094ccd
Merge pull request #88301 from aaronfranke/gltf-explicit-compound-triggers
...
Add support for explicitly-defined compound triggers in GLTF files
2024-04-26 11:08:19 +02:00
Danil Alexeev
2778069025
GDScript: Fix object iterator opcodes
2024-04-26 09:21:55 +03:00
George Marques
7ca038effa
GDScript: Perform validated calls with static methods
...
When the types are validated at compile time, this type of call runs
faster. It is already used for instance methods, this adds this
optimization to native static methods as well.
2024-04-25 21:19:40 -03:00
Malcolm Nixon
e00e5c0386
Remove the Hand enum from XRHandTracker to fix name-collision with the hand property of the base class.
...
Co-Authored-By: David Snopek <191561+dsnopek@users.noreply.github.com>
2024-04-25 19:38:57 -04:00
bqqbarbhg
095569011c
Resolve bind poses from FBX clusters instead of FBX poses
...
Turns out that the information in FBX Pose objects is relatively often broken.
Using skin cluster bind poses seems more reliable, but cannot capture the bind pose of the root bone.
2024-04-25 21:13:50 +03:00
Rémi Verschelde
f859400c6b
Merge pull request #91078 from aaronp64/import_skip_crash
...
Fix errors/crashes related to skipped imports
2024-04-25 17:12:38 +02:00
aaronp64
e63d0983d0
Fix errors/crashes related to skipped imports
...
- Added check for "animation/fps" key before attempting to use it in EditorSceneFormatImporterBlend::import_scene, to give error instead of crashing
- Don't show "Advanced..." button if last import used "Keep File" or "Skip File"
- Don't try to call ResourceLoader::load on kept/skipped file when changing importer, which would give an error
Fixes #90324
2024-04-25 10:33:59 -04:00
Danil Alexeev
4136ed7fc8
GDScript: Fix test reset_uninit_local_vars.gd failure
2024-04-24 20:49:52 +03:00
Rémi Verschelde
69a23e64e4
Merge pull request #89990 from dalexeev/gds-reset-uninit-local-vars
...
GDScript: Fix uninitialized local variables not being reset
2024-04-24 18:54:56 +02:00
Rémi Verschelde
ba3007d127
Merge pull request #91079 from paulloz/dotnet/enforce-use-sdk-8
...
Enforce using .NET SDK >= 8
2024-04-24 09:59:53 +02:00
Rémi Verschelde
17d9c52ad9
Merge pull request #90894 from lyuma/animation_step_30
...
Set animation step from importers. Increase default step from 10 to 30FPS
2024-04-24 09:59:21 +02:00
Rémi Verschelde
4e46e9ae74
Merge pull request #89929 from smix8/ClipperD
...
Change 2D navigation mesh baking to use floating point coordinates
2024-04-24 09:59:07 +02:00
Owen Edwards
2343c4208c
Modified MultPlayer spawnable scene path error checking.
2024-04-23 18:51:33 -04:00
Paul Joannon
f2efa545d6
Enforce using .NET SDK >= 8 in modules/mono/
2024-04-23 22:54:22 +02:00
Rémi Verschelde
515404486b
Merge pull request #91045 from lyuma/fbx_root_node
...
fbx: Avoid name conflict with humanoid "Root" bone
2024-04-23 19:12:14 +02:00
Rémi Verschelde
ad4dff27ba
Merge pull request #90027 from Faless/mp/cache_no_spam
...
[MP] Gracefully handle cache confirmation of deleted nodes
2024-04-23 19:11:05 +02:00
Rémi Verschelde
6b28cb6721
Merge pull request #89884 from HolonProduction/tests-batch-2
...
Completion Tests: Add script to owner
2024-04-23 19:10:57 +02:00
Rémi Verschelde
13b66bcea2
Merge pull request #89738 from dalexeev/gds-docgen-improve-non-constant
...
GDScript: Improve DocGen for non-constant expressions
2024-04-23 19:10:51 +02:00
Lyuma
33e977ee34
fbx: Avoid name conflict with humanoid "Root" bone
...
The importer forces name uniqueness, even for the root. "RootNode" is less likely to conflict.
2024-04-23 01:43:03 -07:00
smix8
6a4d8d4b5c
Change 2D navigation mesh baking to use floating point coordinates
...
Replaces internal uses of Clipper2 integer structs to their floating point equivalents.
2024-04-23 10:28:43 +02:00
Rémi Verschelde
e8eca0b3f0
Merge pull request #90601 from rune-scape/rune-gdscript-dependant-parser-ref-errors
...
GDScript: Fix out of date errors in depended scripts
2024-04-22 22:18:15 +02:00
Fabio Alessandrelli
c6be5f130c
[MP] Fix disconnect_peer not doing the proper cleanup
...
Lower layers (cache, replication) were not being notified about the peer
being disconnected.
2024-04-22 14:58:45 +02:00
A Thousand Ships
ec29c3e784
[Core] Fix property access on read-only Dictionary
2024-04-22 13:57:34 +02:00
Rémi Verschelde
2b42352c99
Merge pull request #90968 from raulsntos/fix-gdscript-analyzer-with-overloaded-dotnet-methods
...
C#: Don't return MethodInfo for overloaded methods
2024-04-22 12:53:47 +02:00
Rémi Verschelde
8931a3ec14
Merge pull request #90912 from clayjohn/CVTT-decomp
...
Avoid writing out of range data over valid data in CVTT decompress methods when decompressing small mip levels
2024-04-22 12:53:24 +02:00
Rémi Verschelde
8c474ddd49
Merge pull request #90710 from m4gr3d/fix_jstring_leaks
...
Fix leakage of JNI object references
2024-04-22 12:52:16 +02:00
Rémi Verschelde
bffaa98b13
Merge pull request #90645 from Malcolmnixon/unified-xr-trackers
...
Rework XR Trackers to have a common ancestor
2024-04-22 12:52:07 +02:00
Rémi Verschelde
1a6e4ce906
Merge pull request #90002 from raulsntos/dotnet/expose-property-accessors
...
C#: Make internal properties and property accessors public (but hidden)
2024-04-22 12:51:42 +02:00
Raul Santos
7316918a0f
C#: Don't return MethodInfo for overloaded methods
...
This means the GDScript analyzer loses the method signature information so it can't do type checking for the parameters.
2024-04-21 05:32:47 +02:00
R. Alex Hofer
2452176990
Have GDScriptWorkspace::list_script_files respect .gdignore.
2024-04-20 13:29:27 -04:00
clayjohn
98dacc14ea
Avoid writing out of range data over valid data in CVTT decompress methods when decompressing small mip levels
2024-04-19 10:16:36 -07:00
Rémi Verschelde
fba6803486
Merge pull request #90876 from smix8/source_geometry_callback
...
Add navigation mesh source geometry parsers and callbacks
2024-04-19 16:28:30 +02:00
Rémi Verschelde
81f08c396c
Merge pull request #90837 from paulloz/dotnet/callable-deserialization-order
...
Change order of operation for C# types reloading
2024-04-19 16:27:49 +02:00
Rémi Verschelde
931f878390
Merge pull request #88899 from AThousandShips/gdscript_clean
...
[GDScript] Clean up some unused code
2024-04-19 16:26:58 +02:00
smix8
58593d1bb7
Add navigation source geometry parser callbacks
...
Adds navigation source geometry parser callbacks so that externals can hook their own geometry into the navigation mesh baking process.
2024-04-19 12:10:57 +02:00
Lyuma
bb9674c1b1
Set animation step from importers. Increase default step from 10 to 30 FPS.
2024-04-19 03:02:20 -07:00
Malcolm Nixon
823ae7b3fa
Rework XR Trackers to have a common ancestor. Allow creation of XRNode3D to drive node positions and visibility.
2024-04-18 20:04:01 -04:00
rune-scape
6b88c86cec
GDScript: invalidate GDScriptParserRef when reloading
2024-04-18 14:05:58 -07:00
George Marques
dc73440f89
GDScript: Implement get_dependencies()
...
The parser and analyzer now track the dependencies of the script and
return the list when the resource loader ask for them.
What is considered a dependency:
- Any `preload()` call.
- The base script this one extends.
- Any identifier, including types, that refers to global scripts.
- Any autoload singleton reference.
2024-04-18 11:54:37 -03:00
Rémi Verschelde
2efbc6bfb3
Merge pull request #90848 from BlueCube3310/lightmapper-dir-seam-fix
...
LightmapGI: Fix seam blending with directional lightmaps
2024-04-18 15:17:21 +02:00
Rémi Verschelde
978d206f34
Merge pull request #90794 from vnen/gdscript-no-unused-constant-warning-with-underscore
...
GDScript: Suppress unused constant warning with underscore
2024-04-18 15:17:13 +02:00
George Marques
a3b3a20ac0
GDScript: Suppress unused constant warning with underscore
...
The warning message mentions that local constants prefixed with `_` does
not generate the warning. This commit actually implements this warning
suppression.
2024-04-18 09:58:23 -03:00
BlueCube3310
f1b758022a
LightmapGI: Fix seam blending with directional lightmaps
2024-04-18 14:21:29 +02:00
Rémi Verschelde
c295f18955
Merge pull request #90789 from lyuma/fix_skeleton_root
...
Fix FBX and glTF when root nodes are skeleton bones
2024-04-18 12:24:47 +02:00
Rémi Verschelde
d06cb2e57d
Merge pull request #90761 from dsnopek/openxr-composition-layers-experimental
...
Mark `OpenXRCompositionLayer` and its children as experimental
2024-04-18 12:24:40 +02:00
Paul Joannon
1627287586
Change order of operation for C# types reloading
...
We now deserialize callables before reloading property states, in case a property is doing anything with the callable in its getter and/or setter.
2024-04-18 09:38:58 +02:00
Lyuma
d3706488d9
Fix FBX and glTF when root nodes are skeleton bones
...
Set p_scene_parent to the skeleton to guarantee BoneAttachment3D nodes are added as a child of the active skeleton.
Use get_owner() to go all the way up when calculating the root node in generate_scene
2024-04-17 22:10:05 -07:00
Rémi Verschelde
36bdab4ddd
Merge pull request #90759 from dsnopek/openxr-hand-revert
...
Revert `OpenXRHand` to its pre-`SkeletonModifier3D` state
2024-04-17 10:59:10 +02:00
David Snopek
a094ff377d
Mark OpenXRCompositionLayer and its children as experimental
2024-04-16 11:02:44 -05:00
David Snopek
dfca388d75
Revert OpenXRHand to its pre-SkeletonModifier3D state
2024-04-16 10:36:43 -05:00
George Marques
f9048fcd7d
GDScript: Warn when enum variable has no default
...
The default will always be set to `0`, so if it's not a valid value in
the enum, the warning is shown.
2024-04-16 11:46:59 -03:00
A Thousand Ships
c070c12ddd
[GDScript] Clean up some unused code
2024-04-16 15:59:38 +02:00
Aaron Franke
77e35cf781
Move NavigationMeshSourceGeometryData(2D/3D) to the 2D/3D subfolders
2024-04-15 18:40:43 -07:00
Fredia Huya-Kouadio
f291a4ed3a
Fix leakage of JNI object references
...
Fixes https://github.com/godotengine/godot/issues/87548
2024-04-15 10:30:18 -07:00
Rémi Verschelde
8a3195ef56
Merge pull request #90678 from raulsntos/dotnet/StringExtensions.Match
...
C#: Fix ExprMatch for case sensitive matching
2024-04-15 18:14:45 +02:00
Rémi Verschelde
684e7aa37a
Merge pull request #89472 from dalexeev/gds-fix-bin-tokenizer-continuation-lines
...
GDScript: Fix continuation lines in `GDScriptTokenizerBuffer`
2024-04-15 18:14:38 +02:00
Raul Santos
509d4f5302
C#: Fix ExprMatch for case sensitive matching
...
We were accidentally stopping the recursion when matching in the case sensitive scenario.
Took the opportunity to also rename the private method to follow the Core method naming more closely so it's easier to compare the implementations in the future.
Also, the private method now uses `ReadOnlySpan<char>` to avoid allocating strings on each recursion.
2024-04-15 03:15:28 +02:00
Rémi Verschelde
d00734053f
Merge pull request #90635 from bqqbarbhg/texture-path-fix
...
Fix FBX texture path resolving
2024-04-14 14:39:17 +02:00
Rémi Verschelde
122054cf7a
Merge pull request #90573 from timothyqiu/svg-image
...
Fix error when loading SVG imported as Image
2024-04-14 14:39:11 +02:00
bqqbarbhg
2a757e4897
Fix FBX texture path resolving
2024-04-13 20:28:12 +03:00
Rémi Verschelde
3a57f10dd5
Merge pull request #90602 from smix8/bsfmod
...
Use fmod for navigation mesh border size warning
2024-04-13 11:30:47 +02:00
Rémi Verschelde
c9a595afb5
Merge pull request #90580 from vnen/gdscript-allow-enum-to-int-cast
...
GDScript: Allow casting enum to int
2024-04-13 11:30:34 +02:00
Rémi Verschelde
8e1b50045a
Merge pull request #90554 from bqqbarbhg/fbx-color-fixes
...
FBX: Fix material colors
2024-04-13 11:30:31 +02:00
smix8
8a0f1f1995
Use fmod for navigation mesh border size warning
...
Uses fmod for checking that navigation mesh border size matches the cell size as a multiple of cell size is also valid.
2024-04-13 03:39:53 +02:00
