Gil Arasa Verge
f144ec9e67
Clicking backgrd. dimming of editor popup stops input event propagation
...
A click on the dimmed background of a popup in the editor should stop the input event from propagating to the background.
This solution reuses the system introduced in commit efc3ffb8
, taking advantage of the hide() notifications from the modal where we will set the flag "pass_on_modal_close_click(false)" to stop event handling at the viewport input event handling.
The viewport first hides the modal and after marks the input as handled if the flag mentioned above is set.
Fixes #36341
(cherry picked from commit 35bc88ca34
)
2020-03-25 11:38:54 +01:00
nathanwfranke
b95a2306db
Fix tab container too large when tabs are hidden
...
(cherry picked from commit c0a84f747e
)
2020-03-25 11:38:54 +01:00
Rémi Verschelde
86ecefa1a2
Fix potential divisions by 0 reported by MSVC
...
The `TextEdit` one was indeed a potential bug.
The `PCKPacker` one seems to be a false positive, it's already in a
`for` loop that depends on `files.size()`.
(cherry picked from commit ca4e4506db
)
2020-03-25 11:38:54 +01:00
Tomasz Chabora
c8318012a8
Make search in RichTextLabel case-insensitive
...
(cherry picked from commit b3f83ac115
)
2020-03-25 11:38:53 +01:00
simpuid
223d0abd7e
Remove update condition from LineEdit::update_placeholder_width
...
Placeholder with length greater than `max_length` are allowed, so there is no reason for those update condition.
It fixes the odd alignment of placeholder when it's length is greater than `max_length`
(cherry picked from commit 43b2f75d64
)
2020-03-25 11:38:53 +01:00
Darren Kaste
53c8d8a5fb
Use LineEdit secret character width everywhere
...
(cherry picked from commit c7c47410aa
)
2020-03-25 11:38:53 +01:00
Darren Kaste
f657614760
Calculate LineEdit selection with secret character
...
(cherry picked from commit 395a038c85
)
2020-03-25 11:38:53 +01:00
Dominik 'dreamsComeTrue' Jasiński
e590a33d45
Allow single quotes in comments
...
Fixes : #36638
(cherry picked from commit ab6456d1bc
)
2020-03-25 09:45:08 +01:00
Rémi Verschelde
c01e840f03
Merge pull request #36639 from RandomShaper/imvu/improve_drives_ux_3.2
...
Improve UX of drive letters (3.2)
2020-03-17 16:27:33 +01:00
Pedro J. Estébanez
6105dfdac9
Improve UX of drive letters
...
Namely, move the drive dropdown to just the left of the path text box and don't include the former
in the latter.
This improves the UX on Windows.
In the UNIX case, since its concept of drives is (ab)used to provide shortcuts to useful paths, its
dropdown is kept at the original location.
2020-03-17 14:48:54 +01:00
Dominik 'dreamsComeTrue' Jasiński
f328ac36d6
Fix: auto brace complete for quoted strings
...
Fixes #36002
(cherry picked from commit 6a404a88e4
)
2020-03-04 09:53:44 +01:00
Rémi Verschelde
2bae35353d
Revert "Fix control node transform animation jitter with pivot offset"
...
This reverts commit 15315f118c
.
It caused a regression: #36087 .
2020-03-04 09:50:21 +01:00
Dominik 'dreamsComeTrue' Jasiński
eb22bcead7
RichTextLabel: proper handling of internal key events
...
Fixes #36211
(cherry picked from commit ff030afc93
)
2020-02-19 10:09:28 +01:00
Michael Alexsander
18eba898f8
Fix hiding ColorPicker's presets not fully hiding its controls
...
(cherry picked from commit 5f5ccfc361
)
2020-02-18 14:20:04 +01:00
Haoyu Qiu
be34e45233
Uses split cursor for SplitContainer
...
(cherry picked from commit 206b9f2d23
)
2020-02-14 16:02:56 +01:00
Haoyu Qiu
0a3bf2b627
Fixes add group in Group Editor dialog
...
Before this fix, new group can't be created if any existing group starts
with the new name.
(cherry picked from commit 421ea09195
)
2020-02-14 15:58:36 +01:00
Eoin O'Neill
0dedc0a1a3
Fix RichTextEffect visibility
to Account for Skipped Characters.
...
A picture is easier to describe this issue than words. Basically, rich
text effects allowed for character visibility changes. While doing so
would work properly, the rich text label would render the next `word` in
an offset accounting for the hidden characters (leaving a huge space.)
This patch fixes this issue by keeping track of the amount of
`backtrack` necessary per line.
(cherry picked from commit b3fd4884d7
)
2020-02-14 15:57:47 +01:00
sumit0190
58a940e5aa
Update cached_width of the line_edit element when setting it to be secret
...
(cherry picked from commit 2e08578985
)
2020-02-14 15:56:48 +01:00
Georg Wacker
15315f118c
Fix control node transform animation jitter with pivot offset
...
The workaround for moving the pivot is not needed anymore, in fact it causes all transforms applied to control nodes to jitter while animating (if a pivot offset is set).
This can be observed via AnimationPlayer and Tween.
The fix is to remove the obsolete workaround that causes this bug.
Fixes #28804
(cherry picked from commit dfb7d46a2a
)
2020-02-06 13:02:07 +01:00
Haoyu Qiu
808a0bac33
Fixes OptionButton min size
...
(cherry picked from commit ddc397d9ff
)
2020-02-06 13:02:07 +01:00
Rémi Verschelde
11d28b2d10
Revert "make Label consider spaces for visible_characters"
...
This reverts commit 695980a0f2
.
Fixes #35668 .
2020-01-28 19:37:04 +01:00
Haoyu Qiu
71b1a1c7d9
Updates minimum size on VideoPlayer::set_stream
2020-01-26 10:24:56 +08:00
Rémi Verschelde
c2e07db071
Merge pull request #35438 from MadEqua/virtual-keyboard-line-edit
...
Android virtual keyboard respecting LineEdit max length.
2020-01-23 08:20:24 +01:00
Bruno Lourenço
a3bcdbeb78
Android virtual keyboard respecting LineEdit max length.
2020-01-23 01:52:49 +00:00
Ricardo Buring
40542b0b0f
Fix Control::_window_find_focus_neighbor
...
Due to a typo, the size of a candidate neighbor was confused with the
size of the control itself.
Fixes #34936 .
2020-01-19 23:38:50 +01:00
Rémi Verschelde
dd3779c12e
Merge pull request #35183 from YeldhamDev/scrollbar_regression
...
Fix scrollbar regression on large scales
2020-01-16 07:56:05 +01:00
Michael Alexsander
76e03f9b4d
Fix scrollbar regression on large scales
2020-01-16 00:59:46 -03:00
Haoyu Qiu
574918f344
Updates ScrollContainer min size when toggle scrollbars
2020-01-16 09:42:31 +08:00
Haoyu Qiu
26e3b4a58a
Updates LineEdit's min size when necessary
...
These properties will affect the minimum size of LineEdit:
* The right icon (`set_right_icon`)
* The clear button (`set_editable` and `set_clear_button_enabled`)
* The text, when "expand to text length" is enabled (`set_text`)
2020-01-15 10:15:32 +08:00
Michael Alexsander
db8c4c2a22
Fix regression on scrollbar raising in ScrollContainer
2020-01-14 19:55:12 -03:00
Michael Alexsander
34bf81fa7c
Cleanup unnecessary code from before the scrollbar overlapping fixes
2020-01-14 18:19:12 -03:00
Rémi Verschelde
57986208f3
Merge pull request #35130 from qarmin/crash_item_bad_index
...
Don't allow to use too big index in ItemList
2020-01-14 21:03:25 +01:00
Rafał Mikrut
724f5f3178
Don't allow to use too big index in ItemList
2020-01-14 20:17:48 +01:00
Rémi Verschelde
63112b5090
Merge pull request #35106 from YeldhamDev/scrollbar_overlap_fixes
...
Fix more instances of overlapping scrollbars
2020-01-14 08:12:20 +01:00
Michael Alexsander
712cd8a97e
Fix more instances of overlapping scrollbars
2020-01-13 22:49:17 -03:00
Haoyu Qiu
66a54582ee
Updates min size on CenterContainer::set_use_top_left
2020-01-14 08:35:21 +08:00
Rémi Verschelde
04a1ae90df
Merge pull request #35080 from malbach/scrollbars_overlap
...
Fix #33309 Overlapping Scrollbars in ScrollContainer
2020-01-13 16:10:12 +01:00
malbach
bc8ce836e3
Fix overlapping scrollbars in ScrollContainer ( #33309 )
2020-01-13 14:37:55 +01:00
Rémi Verschelde
100f50b7df
Control/Light2D: Preventing setting 0 as scale as for Node2D
...
Triggers errors in `Transform2D::affine_invert()`.
Fixes #26510 .
Fixes https://github.com/godotengine/godot/issues/24997#issuecomment-457951639 .
2020-01-13 12:20:15 +01:00
Rémi Verschelde
478ab8b45b
Merge pull request #34960 from johannesgunnar/spin_box-apply-method
...
Spinbox apply input method
2020-01-12 14:16:14 +01:00
Paulb23
22c15083af
Fix empty LineEdit crash on ctrl+backspace
2020-01-11 17:57:36 +00:00
Jóhannes Gunnar Þorsteinsson
083637a901
Add apply method to SpinBox
2020-01-11 10:47:51 +00:00
Tomasz Chabora
60cd3df337
Add signal for LineEdit overflow event
2020-01-10 21:07:00 +01:00
Rémi Verschelde
59a2fed1e6
Merge pull request #34938 from OverloadedOrama/fix-basebutton-button-press
...
Fixes BaseButton not triggering the pressed signal on "Button Press"…
2020-01-10 10:35:11 +01:00
Haoyu Qiu
fbd937bd30
Update minimum size on Label::set_autowrap
...
If `clip_text` is true, the minimum height is one line if `autowrap` is
true , or one pixel otherwise.
2020-01-10 17:08:27 +08:00
Gilles Roudière
b5251eb00f
Don't compile editor-only function when tools=no
2020-01-09 22:15:48 +01:00
OverloadedOrama
bf4a0242ff
Fixes BaseButton not triggering the "pressed" signal on "Button Press" Action Mode
...
This should fix #34935
2020-01-09 02:17:53 +02:00
Haoyu Qiu
4293f76cf1
Emits meta_hover_ended when mouse exit RichTextLabel
2020-01-08 21:01:08 +08:00
Rémi Verschelde
1de54bb388
Merge pull request #34874 from wingedadventurer/bugfix-label-visible-characters
...
Make Label node consider spaces for visible_characters property
2020-01-08 08:18:59 +01:00
Rémi Verschelde
033fb72c03
Merge pull request #34871 from lentsius-bark/textEdit-vertical-horizontal-scroll-expose
...
expose scroll_vertical and scroll_horizontal in TextEdit
2020-01-08 08:18:12 +01:00