asgardius/virtualx-engine
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
67691 commits 1 branch 0 tags 2.2 GiB
Commit graph

1453 commits

Author SHA1 Message Date
Rémi Verschelde
b638967d01
Revert "Return error when no ResourceFormatLoader found." 
This reverts commit 6df3621b47.

Fixes #97153.
 2024-09-19 12:41:51 +02:00
Rémi Verschelde
a6d84bc0ce
Merge pull request #97059 from Gaktan/fix_weird_msvc_compilation_error 
Fix weird MSVC compilation error
 2024-09-16 13:36:06 +02:00
Rémi Verschelde
46d9db565b
Merge pull request #96904 from RandomShaper/fix_previewer_deadlock 
ResourceLoader: Fix deadlocks caused by the resource changed feature
 2024-09-16 13:35:21 +02:00
Gaktan
453f32ae0a Fix weird MSVC compilation error 
For some reason, MSVC doesn't appreciate uint8 math with enum constants
 2024-09-15 23:13:24 +02:00
Pedro J. Estébanez
e3ddf3d44a ResourceLoader: Fixup resource changed feature (no. 2) 2024-09-13 11:32:55 +02:00
BlueCube3310
606eedb0c9 Betsy: Add caching and BC1 compression support 2024-09-11 23:48:29 +02:00
bruvzg
3009073b39 [Resource Loader] Do not check property type for non registered properties. 2024-09-10 11:27:16 +03:00
Rémi Verschelde
effbc07976
Merge pull request #96617 from RandomShaper/res_loader_pending 
ResourceLoader: Add last resort life-time insurance for tokens
 2024-09-06 22:38:41 +02:00
Rémi Verschelde
0b4ae20156
Merge pull request #78656 from Repiteo/typed-dictionary 
Implement typed dictionaries
 2024-09-06 22:38:13 +02:00
Pedro J. Estébanez
97197ff5e9 ResourceLoader: Fixup resource changed feature 
This is a complement to: https://github.com/godotengine/godot/pull/96593
 2024-09-06 18:31:51 +02:00
Pedro J. Estébanez
ccd470d33c ResourceLoader: Add last resort life-time insurance for tokens 2024-09-06 14:00:10 +02:00
Pedro J. Estébanez
74b9c38d58 ResourceLoader: Add thread-aware resource changed mechanism 2024-09-06 08:57:09 +02:00
Pedro J. Estébanez
c450f4d667 ResourceLoader: Simplify handling of unregistered tasks 2024-09-05 09:54:03 +02:00
Thaddeus Crews
9853a69144
Implement typed dictionaries 2024-09-04 10:27:26 -05:00
Rémi Verschelde
d15de6f264
Merge pull request #96292 from AThousandShips/null_check_ref_fix 
Cleanup of raw `nullptr` checks with `Ref`
 2024-09-03 16:13:55 +02:00
Rémi Verschelde
866099684c
Merge pull request #92667 from Hilderin/fix-addon-requires-editor-restart 
Fix Addon requires editor restart to become functional
 2024-09-03 11:42:52 +02:00
Hilderin
7dd235905e Fix Addon requires editor restart to become functional 2024-09-02 16:54:45 -04:00
BlueCube3310
205a10e0ae Reduce code duplication in FileAccess 2024-09-01 12:39:32 +02:00
A Thousand Ships
194bdde947
Cleanup of raw nullptr checks with Ref 
Using `is_valid/null` over checks with `nullptr` or `ERR_FAIL_NULL` etc.
 2024-08-31 15:01:09 +02:00
Rémi Verschelde
909629d9f9
Merge pull request #96166 from AThousandShips/more_lock_raii 
Use `MutexLock` in more places
 2024-08-30 09:59:19 +02:00
Rémi Verschelde
4c6bac15a3
Merge pull request #92656 from fire/vsk-json-to-native-4.3 
Ability to convert native engine types to JSON and back.
 2024-08-30 09:58:57 +02:00
K. S. Ernest (iFire) Lee
71bdbcdfb1 Ability to convert native engine types to JSON and back. 
Implements support for all engine types in JSON encoding/decoding

Co-Authored-By: Juan <reduzio@gmail.com>
Co-Authored-By: Rémi Verschelde <rverschelde@gmail.com>
 2024-08-29 10:57:15 -07:00
A Thousand Ships
e33fdb4296
Use MutexLock in more places 2024-08-29 14:12:59 +02:00
Rémi Verschelde
cb96fc95c3
Merge pull request #92316 from alula/msvc-clang 
Add support for compiling with VS clang-cl toolset
 2024-08-29 10:36:17 +02:00
Alula
346cbc7f1f
Add support for compiling with VS clang-cl toolset 2024-08-28 13:30:44 -05:00
Pedro J. Estébanez
0441c67de6 ResourceLoader: Handle another case of user tokens 2024-08-28 13:53:39 +02:00
Rémi Verschelde
de7d4b6f5b
Merge pull request #94920 from gongpha/bring-back-print-verbose-when-loading-resources 
Fix ResourceLoader is not printing a resource path on loading when `verbose_stdout` is enabled
 2024-08-28 00:12:38 +02:00
Kongfa Waroros
bfb5570c03 Fix ResourceLoader is not verbosely printing a resource path on loading 2024-08-28 03:37:51 +07:00
Rémi Verschelde
6e3320446a
Merge pull request #92799 from BlueCube3310/image-detech-signed 
Image: Add a method for detecting signed values
 2024-08-27 22:27:18 +02:00
Sébastien Dunne Fulmer
c3ed8a842c
Remove confusing USER prefix from script-logged errors 2024-08-27 15:00:48 +01:00
BlueCube3310
76c8211653 Image: Add a method for detecting signed values 2024-08-27 09:23:17 +02:00
Rémi Verschelde
ac5a528620
Merge pull request #84944 from KoBeWi/legacy_of_ancient_godots 
Fix some legacy code
 2024-08-26 23:28:14 +02:00
Rémi Verschelde
ce44c91223
Merge pull request #93739 from AThousandShips/lock_unlock 
[Core] Allow locking/unlocking of `MutexLock`
 2024-08-26 22:45:13 +02:00
Rémi Verschelde
b78da13e2a
Merge pull request #93064 from Hilderin/fix-fileSystem-dock-wont-show-any-file-folders 
Fix FileSystem dock won't show any file folders (v2)
 2024-08-26 22:45:04 +02:00
A Thousand Ships
723f5500f4
[Core] Allow locking/unlocking of MutexLock 2024-08-26 12:38:03 +02:00
Rémi Verschelde
0ba0be27c7
Merge pull request #94169 from RandomShaper/wtp_rl_prize 
Batch of fixes for `WorkerThreadPool` and `ResourceLoader`
 2024-08-26 10:51:25 +02:00
Rémi Verschelde
b4f268fae8
Merge pull request #91018 from Daylily-Zeleen/daylily-zeleen/optionally_postinitialization_for_extension_owner 
Allow ClassDB to create a Object without postinitialization for GDExtension.
 2024-08-26 10:51:17 +02:00
Pedro J. Estébanez
f4d76853b9 WorkerThreadPool (plus friends): Overhaul unlock allowance zones 
This fixes a rare but possible deadlock, maybe due to undefined behavior. The new implementation is safer, at the cost of some added boilerplate.
 2024-08-21 12:22:52 +02:00
Pedro J. Estébanez
df23858488 ResourceLoader: Fix edge cases in the management of user tokens 
1. Make handling of user tokens atomic:
   Loads started with the external-facing API used to perform a two-step setup of the user token. Between both, the mutex was unlocked without its reference count having been increased. A non-user-initiated load could therefore destroy the load task when it unreferenced the token.
   Those stages now happen atomically so in the one hand, the described race condition can't happen so the load task life insurance doesn't have a gap anymore and, on the other hand, the ugliness that the call to load could return `ERR_BUSY` if happening while other thread was between both steps is gone.
   The code has been refactored so the user token concerns are still outside the inner load start function, which is agnostic to that for a cleaner implementation.
2. Clear ambiguity between load operations running on `WorkerThreadPool`:
   The two cases are: single-loaded thread directly started by a user pool task and a load started by the system as part of a multi-threaded load.
   Since ensuring all the code dealing with this distinction would make it very complex, and error-prone, a different measure is applied instead: just take one of the cases out of the dicotomy. We now ensure every load happening on a pool thread has been initiated by the system.
   The way of achieving that is that a single-threaded user-started load initiated from a pool thread, is run as another task.
 2024-08-21 12:22:52 +02:00
Pedro J. Estébanez
5c970db2e4 ResourceLoader: Optimize remap check by deferring until a non-mutex zone 2024-08-21 12:19:43 +02:00
Pedro J. Estébanez
28619e26cf ResourceLoader: Enhance deadlock prevention 
Benefits:
- Simpler code. The main load function is renamed so it's apparent that it's not just a thread entry point anymore.
- Cache and thread modes of the original task are honored. A beautiful consequence of this is that, unlike formerly, re-issued loads can use the resource cache, which makes this mechanism much more performant.
- The newly added getter for caller task id in WorkerThreadPool allows to remove the custom tracking of that in ResourceLoader.
- The check to replace a cached resource and the replacement itself happen atomically. That fixes deadlock prevention leading to multiple resource instances of the same one on disk. As a side effect, it also makes the regular check for replace load mode more robust.
 2024-08-21 12:19:43 +02:00
Pedro J. Estébanez
bd0959ebdd ResourceLoader: Properly push & pop TLS state on recursive load tasks 2024-08-21 12:19:43 +02:00
Rémi Verschelde
5ca419e32c
Merge pull request #94801 from gamelessone/fix-cond-var 
Fix use-after-free of `ConditionVariable` in `ResourceLoader`
 2024-08-21 11:14:22 +02:00
Rémi Verschelde
4b8946102b
Merge pull request #91535 from BlueCube3310/betsy-bc6h 
Add Betsy to speed up BC6 compression
 2024-08-21 06:38:03 +02:00
Hilderin
1b0c5cbc01 Fix FileSystem dock won't show any file folders (v2) 2024-08-20 21:23:13 -04:00
Daylily-Zeleen
3d575801ce Allow ClassDB to create a Object without postinitialization for GDExtension. 2024-08-20 20:19:02 +08:00
Rémi Verschelde
6a829d5a86
Merge pull request #95508 from Summersay415/loaded-when-not 
Return error when no ResourceFormatLoader found
 2024-08-19 14:34:17 +02:00
Pedro J. Estébanez
e9407d4877 ResourceLoader: Revert workaround resource loading crashes due to buggy TLS 
This reverts commit 41c0785636.
 2024-08-19 12:22:31 +02:00
Rémi Verschelde
f4037d6f6c
Merge pull request #92496 from clayjohn/HDR-2D-sRGB 
Ensure MovieWriter output is in gamma space when using HDR 2D
 2024-08-19 12:08:40 +02:00
BlueCube3310
394ea653aa Add Betsy to speed up BC6 compression 2024-08-18 11:14:05 +02:00