asgardius/virtualx-engine
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
virtualx-engine/scene/2d
History
Lyuma c088a2dd89 Fix crash due to reentrancy in AudioStreamPlayer* finished signal. 
This crash occurred when an audio stream finished playing in NOTIFICATION_INTERNAL_PROCESS,
during which it would iterate through a loop of playbacks,
leading to a "finished" signal, which removed the audio player from the tree
which led to a NOTIFICATION_EXIT_TREE,
which would mutate the array of playbacks while within the above loop.

This moves the signal callback outside of the loop which avoids the crash.
Note: previously, the signal was called multiple times if the same player finishes multiple times in one frame. Now it is at most once per frame.

Affects AudioStreamPlayer, AudioStreamPlayer2D and AudioStreamPlayer3D
2021-10-28 19:45:29 -07:00
..
animated_sprite_2d.cpp Fix rendering centered odd-size texture in AnimatedSprite2D/AnimatedSprite3D 2021-10-03 14:30:51 +02:00
animated_sprite_2d.h Fix some unnecessary includes 2021-08-13 00:27:38 -05:00
area_2d.cpp Merge pull request #53054 from MaxLap/doc_shape_signals 2021-10-14 14:31:58 -07:00
area_2d.h Merge pull request #42742 from madmiraal/fix-12215 2021-05-18 20:00:48 +02:00
audio_listener_2d.cpp Rename Listener2D/Listener3D to AudioListener2D/AudioListener3D 2021-09-16 17:51:51 -04:00
audio_listener_2d.h Remove unimplemented methods 2021-10-21 18:44:25 +01:00
audio_stream_player_2d.cpp Fix crash due to reentrancy in AudioStreamPlayer* finished signal. 2021-10-28 19:45:29 -07:00
audio_stream_player_2d.h Add polyphony to Audio Stream Player nodes 2021-09-07 09:44:39 -07:00
back_buffer_copy.cpp Initialize class variables with default values in scene/ [1/2] 2021-02-07 22:29:31 +01:00
back_buffer_copy.h Initialize class variables with default values in scene/ [1/2] 2021-02-07 22:29:31 +01:00
camera_2d.cpp Add Get Center Method for Rect2/Rect2i and AABB. 2021-09-21 21:14:17 +05:45
camera_2d.h Fix some unnecessary includes 2021-08-13 00:27:38 -05:00
canvas_group.cpp Use real_t in non-physics 2D nodes 2021-03-19 13:04:45 -04:00
canvas_group.h Use real_t in non-physics 2D nodes 2021-03-19 13:04:45 -04:00
canvas_modulate.cpp Rename instance()->instantiate() when it's a verb 2021-06-19 20:49:18 -06:00
canvas_modulate.h Use Array for node configuration warnings 2021-04-11 23:25:38 -05:00
collision_object_2d.cpp Merge pull request #54157 from bjauny/fix_potential_nullpointer_collision3d 2021-10-27 12:40:50 -07:00
collision_object_2d.h Entirely removes BIND_VMETHOD in favor of GDVIRTUAL 2021-08-23 08:10:13 -03:00
collision_polygon_2d.cpp Fix unexpected crashes in notification 2021-10-23 13:01:52 +08:00
collision_polygon_2d.h Fix some unnecessary includes 2021-08-13 00:27:38 -05:00
collision_shape_2d.cpp Fix unexpected crashes in notification 2021-10-23 13:01:52 +08:00
collision_shape_2d.h Use Array for node configuration warnings 2021-04-11 23:25:38 -05:00
cpu_particles_2d.cpp Merge pull request #52430 from AnilBK/vector2-replacements 2021-09-24 13:04:42 +02:00
cpu_particles_2d.h Remove unimplemented methods 2021-10-21 18:44:25 +01:00
gpu_particles_2d.cpp doctool: Fix differences between headless and Vulkan rendering backends 2021-10-20 17:48:50 +02:00
gpu_particles_2d.h Fix some unnecessary includes 2021-08-13 00:27:38 -05:00
joint_2d.cpp Joint2D: Use boolean instead of warning string for validity test 2021-10-07 14:18:44 -03:00
joint_2d.h Rename Joint2D and Joint3D files for consistency 2021-10-01 12:00:32 -07:00
light_2d.cpp Fix some unnecessary includes 2021-08-13 00:27:38 -05:00
light_2d.h Use Array for node configuration warnings 2021-04-11 23:25:38 -05:00
light_occluder_2d.cpp Use Array for node configuration warnings 2021-04-11 23:25:38 -05:00
light_occluder_2d.h Use Array for node configuration warnings 2021-04-11 23:25:38 -05:00
line_2d.cpp Line2D::set_point_position Fail if passed index is out of bounds 2021-02-21 13:50:11 +01:00
line_2d.h Initialize class variables with default values in scene/ [1/2] 2021-02-07 22:29:31 +01:00
line_builder.cpp clang-format: Disable alignment of operands, too unreliable 2021-10-28 15:19:35 +02:00
line_builder.h Fix some unnecessary includes 2021-08-13 00:27:38 -05:00
mesh_instance_2d.cpp Fix MeshInstance2D rect 2021-10-21 15:18:52 +02:00
mesh_instance_2d.h Fix MeshInstance2D rect 2021-10-21 15:18:52 +02:00
multimesh_instance_2d.cpp Fixed a bunch of connection errors in TextureEditorPlugin 2021-06-12 08:01:02 +03:00
multimesh_instance_2d.h Update copyright statements to 2021 2021-01-01 20:19:21 +01:00
navigation_agent_2d.cpp Improved readability for failing error conditions 2021-10-08 17:29:25 -04:00
navigation_agent_2d.h Fix some unnecessary includes 2021-08-13 00:27:38 -05:00
navigation_obstacle_2d.cpp Use get_global_* functions instead of using transforms. 2021-08-14 14:01:57 +05:45
navigation_obstacle_2d.h Use Array for node configuration warnings 2021-04-11 23:25:38 -05:00
navigation_region_2d.cpp Use builtin Vector2 functions for calculation of angles. 2021-09-07 08:30:26 +05:45
navigation_region_2d.h Use Array for node configuration warnings 2021-04-11 23:25:38 -05:00
node_2d.cpp Revert "Display a matrix for Node2D and don't display a duplicate origin" 2021-08-29 17:01:07 -03:00
node_2d.h Fix editor suffixes and degrees conversion 2021-06-30 12:38:25 -03:00
parallax_background.cpp Use real_t in non-physics 2D nodes 2021-03-19 13:04:45 -04:00
parallax_background.h Fix some unnecessary includes 2021-08-13 00:27:38 -05:00
parallax_layer.cpp Fix some LGTM errors of "Multiplication result converted to larger type" 2021-10-12 00:17:27 -05:00
parallax_layer.h Use Array for node configuration warnings 2021-04-11 23:25:38 -05:00
path_2d.cpp Fix some unnecessary includes 2021-08-13 00:27:38 -05:00
path_2d.h Use Array for node configuration warnings 2021-04-11 23:25:38 -05:00
physical_bone_2d.cpp Rename Joint2D and Joint3D files for consistency 2021-10-01 12:00:32 -07:00
physical_bone_2d.h Rename Joint2D and Joint3D files for consistency 2021-10-01 12:00:32 -07:00
physics_body_2d.cpp Fix #54298 where a CharacterBody2D can be stuck on the wall. 2021-10-27 18:05:35 +02:00
physics_body_2d.h Fix #54298 where a CharacterBody2D can be stuck on the wall. 2021-10-27 18:05:35 +02:00
polygon_2d.cpp Fix editor suffixes and degrees conversion 2021-06-30 12:38:25 -03:00
polygon_2d.h Fix editor suffixes and degrees conversion 2021-06-30 12:38:25 -03:00
position_2d.cpp Fix some unnecessary includes 2021-08-13 00:27:38 -05:00
position_2d.h Use real_t in non-physics 2D nodes 2021-03-19 13:04:45 -04:00
ray_cast_2d.cpp Fix unexpected crashes in notification 2021-10-23 13:01:52 +08:00
ray_cast_2d.h Uniformize layer names, script methods and documentation 2021-08-12 08:06:42 -07:00
remote_transform_2d.cpp Fix some unnecessary includes 2021-08-13 00:27:38 -05:00
remote_transform_2d.h Use Array for node configuration warnings 2021-04-11 23:25:38 -05:00
SCsub SCons: Format buildsystem files with psf/black 2020-03-30 09:05:53 +02:00
skeleton_2d.cpp Use builtin Vector2 functions for calculation of angles. 2021-09-07 08:30:26 +05:45
skeleton_2d.h Some work on double support 2021-08-09 17:43:48 -05:00
sprite_2d.cpp Fix some unnecessary includes 2021-08-13 00:27:38 -05:00
sprite_2d.h Change frame_coords to Vector2i 2021-05-23 21:38:27 +02:00
tile_map.cpp clang-format: Disable alignment of operands, too unreliable 2021-10-28 15:19:35 +02:00
tile_map.h Implement runtime update of TileData object in TileMap 2021-10-27 18:32:52 +02:00
touch_screen_button.cpp Entirely removes BIND_VMETHOD in favor of GDVIRTUAL 2021-08-23 08:10:13 -03:00
touch_screen_button.h Entirely removes BIND_VMETHOD in favor of GDVIRTUAL 2021-08-23 08:10:13 -03:00
visible_on_screen_notifier_2d.cpp Fix some unnecessary includes 2021-08-13 00:27:38 -05:00
visible_on_screen_notifier_2d.h Rename VisibilityNotifierXD to VisibleOnScreenNotifierXD 2021-06-16 22:01:39 -03:00