virtualx-engine/servers
Matias N. Goldberg 472226422e Fix uninitialized variable ending up sent to Vulkan
The first time a shader is compiled Godot performs the following:

```cpp
for (uint32_t i = 0; i < SHADER_STAGE_MAX; i++) {
	if
(spirv_data.push_constant_stages_mask.has_flag((ShaderStage)(1 << i))) {
		binary_data.push_constant_vk_stages_mask |=
shader_stage_masks[i];
	}
}
```

However binary_data.push_constant_vk_stages_mask is never initialized to
0 and thus contains garbage data or'ed with the good data.

This value is used by push constants (and many other things) thus it can
be a big deal.

Fortunately because the relevant flags are always guaranteed to be set
(but not guaranteed to be unset), the damage is restricted to:

1. Performance (unnecessary flushing & over-excessive barriers)
2. Overwriting push descriptors already set (this would be serious,
doesn't seem to be an issue)
3. Driver implementations going crazy when they see bits set they don't
expect (unknown if this is an issue)

This uninitialized value is later saved into the binary cache.

Valgrind is able to detect this bug on the first run, but not on the
subsequent ones because they data comes from a file.

cache_file_version has been bumped to force rebuild of all cached
shaders. Because the ones generated so far are compromised.
2023-07-29 18:28:33 -03:00
..
audio Fix AudioEffectRecord circular reference 2023-06-19 18:13:01 -04:00
camera
debugger
extensions
movie_writer
navigation
physics_2d
physics_3d
rendering Fix uninitialized variable ending up sent to Vulkan 2023-07-29 18:28:33 -03:00
text
xr
audio_server.cpp
audio_server.h
camera_server.cpp
camera_server.h
display_server.cpp Merge pull request #63826 from deakcor/dev_clipboard 2023-07-27 15:22:16 +02:00
display_server.h Merge pull request #63826 from deakcor/dev_clipboard 2023-07-27 15:22:16 +02:00
display_server_headless.h
navigation_server_2d.cpp Add NavigationServer API to enable regions and links 2023-07-26 01:20:15 +02:00
navigation_server_2d.h Add NavigationServer API to enable regions and links 2023-07-26 01:20:15 +02:00
navigation_server_3d.cpp Add NavigationServer API to enable regions and links 2023-07-26 01:20:15 +02:00
navigation_server_3d.h Add NavigationServer API to enable regions and links 2023-07-26 01:20:15 +02:00
navigation_server_3d_dummy.h Add NavigationServer API to enable regions and links 2023-07-26 01:20:15 +02:00
physics_server_2d.cpp
physics_server_2d.h
physics_server_2d_wrap_mt.cpp
physics_server_2d_wrap_mt.h
physics_server_3d.cpp
physics_server_3d.h
physics_server_3d_wrap_mt.cpp
physics_server_3d_wrap_mt.h
register_server_types.cpp Expose RenderingSceneBuffers through ClassDB 2023-07-26 23:48:30 +10:00
register_server_types.h
rendering_server.cpp Add custom texture create function 2023-07-26 20:46:34 +10:00
rendering_server.h Add custom texture create function 2023-07-26 20:46:34 +10:00
SCsub
server_wrap_mt_common.h
text_server.cpp [Text Server] Fix ellipsis outline drawing. 2023-07-24 08:07:29 +03:00
text_server.h
xr_server.cpp
xr_server.h