virtualx-engine/modules/upnp
Fabio Alessandrelli 50f0f51604 [Net] Fix miniupnpc when no interface is specified
This is a tricky one, it used to work, but it was wrong, because in such
a scenario instead of passing NULL as required by the API, it would pass
a buffer containing the `\0` terminator.
This stopped working on a specific miniupnpc version, when they fixed
some network endianess issue on Windows, to which we made a workaround,
which in turn would probably result in failures when the interface is
specified.

This commit address the issue properly, by checking the specified
interface string size, and correctly passing NULL instead of the empty
string when necessary.

Also reverts the commit that introduced the bogus workaround:
388adac947

One of those PR when the explanation is much longer then code changes
:).
2021-03-15 18:12:05 +01:00
..
doc_classes Mention the duration parameter unit in UPNP.add_port_mapping() 2020-03-04 12:40:14 +01:00
config.py SCons: Format buildsystem files with psf/black 2020-06-10 15:30:52 +02:00
register_types.cpp Update copyright statements to 2021 2021-01-13 16:17:06 +01:00
register_types.h Update copyright statements to 2021 2021-01-13 16:17:06 +01:00
SCsub SCons: Format buildsystem files with psf/black 2020-06-10 15:30:52 +02:00
upnp.cpp [Net] Fix miniupnpc when no interface is specified 2021-03-15 18:12:05 +01:00
upnp.h Update copyright statements to 2021 2021-01-13 16:17:06 +01:00
upnp_device.cpp Update copyright statements to 2021 2021-01-13 16:17:06 +01:00
upnp_device.h Update copyright statements to 2021 2021-01-13 16:17:06 +01:00