asgardius/virtualx-engine
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
virtualx-engine/core/templates
History
Rémi Verschelde 7da392bcc5
Don't return reference on copy assignment operators 
We prefer to prevent using chained assignment (`T a = b = c = T();`) as this
can lead to confusing code and subtle bugs.

According to https://en.wikipedia.org/wiki/Assignment_operator_(C%2B%2B), C++
allows any arbitrary return type, so this is standard compliant.

This could be re-assessed if/when we have an actual need for a behavior more
akin to that of the C++ STL, for now this PR simply changes a handful of
cases which were inconsistent with the rest of the codebase (`void` return
type was already the most common case prior to this commit).
2021-11-30 16:26:29 +01:00
..
bin_sorted_array.h Rename remove() to remove_at() when removing by index 2021-11-23 18:58:57 -07:00
command_queue_mt.cpp Refactor CommandQueueMT 2021-06-09 13:10:49 -03:00
command_queue_mt.h Fix various typos with codespell 2021-07-25 11:21:51 +02:00
cowdata.h Rename remove() to remove_at() when removing by index 2021-11-23 18:58:57 -07:00
hash_map.h clang-format: Various fixes to comments alignment from clang-format 13 2021-10-28 15:43:36 +02:00
hashfuncs.h #52491 Cosmetic: fix type cast and add comment with the algorithm source 2021-10-05 21:40:33 +02:00
list.h clang-format: Various fixes to comments alignment from clang-format 13 2021-10-28 15:43:36 +02:00
local_vector.h Don't return reference on copy assignment operators 2021-11-30 16:26:29 +01:00
lru.h Update copyright statements to 2021 2021-01-01 20:19:21 +01:00
map.h Replace HTTP links with HTTPS for sites with HTTPS versions 2021-08-22 20:13:11 -05:00
oa_hash_map.h Don't return reference on copy assignment operators 2021-11-30 16:26:29 +01:00
ordered_hash_map.h Don't return reference on copy assignment operators 2021-11-30 16:26:29 +01:00
paged_allocator.h Add the possibility to initialize the classes allocated with the PagedAllocator 2021-08-14 09:04:31 +02:00
paged_array.h Update copyright statements to 2021 2021-01-01 20:19:21 +01:00
pair.h Merge pull request #47395 from sygi/shape_idx_collision 2021-07-16 19:05:08 +02:00
pass_func.h Update copyright statements to 2021 2021-01-01 20:19:21 +01:00
pooled_list.h Replace #pragma once by traditional include guards for consistency 2021-09-24 02:33:15 +02:00
rid.h Rewrite render code to be more cache and thread friendly. 2021-01-05 08:50:18 -03:00
rid_owner.cpp Modernize atomics 2021-02-18 17:12:46 +01:00
rid_owner.h Rename RID's getornull() to get_or_null() 2021-09-29 23:58:02 +02:00
ring_buffer.h Update copyright statements to 2021 2021-01-01 20:19:21 +01:00
safe_list.h Add a SafeList data structure for future audio server usage. 2021-08-27 10:26:18 -07:00
safe_refcount.h Add type_traits include for std::is_trivially_destructible 2021-04-22 16:23:55 +02:00
SCsub
search_array.h Implement bsearch for Vector and Packed*Array 2021-09-30 23:57:26 +00:00
self_list.h Update copyright statements to 2021 2021-01-01 20:19:21 +01:00
set.h Replace HTTP links with HTTPS for sites with HTTPS versions 2021-08-22 20:13:11 -05:00
simple_type.h Update copyright statements to 2021 2021-01-01 20:19:21 +01:00
sort_array.h Update copyright statements to 2021 2021-01-01 20:19:21 +01:00
thread_work_pool.cpp [OS] Add ThreadWorkPool default size to OS. 2021-11-02 04:16:00 +01:00
thread_work_pool.h ThreadWorkPool no longer starts worker threads if given zero work. 2021-11-01 19:19:25 +00:00
vector.h Don't return reference on copy assignment operators 2021-11-30 16:26:29 +01:00
vmap.h Don't return reference on copy assignment operators 2021-11-30 16:26:29 +01:00
vset.h Rename remove() to remove_at() when removing by index 2021-11-23 18:58:57 -07:00