virtualx-engine/core/extension
Joel Croteau f44d6a235f Fix reload of GDExtension libraries in framework package on macos
`GDExtension::open_library` has a check in it to see if the library was loaded
from a temp file, and if it was to restore the original name as that is the one
we actually care about. This check is breaking extension reloading on Mac when
the library path is to a framework folder, as the file inside the framework
will not generally be the same name as the folder.

This check also shouldn't be necessary even on Windows, which is the only
platform that uses `generate_temp_files`, since disposal of the created temp
file is handled within `OS_Windows::open_dynamic_library`, and
`GDExtension::open_library` (which is the only function to call
`open_dynamic_library` with a `p_data` argument) only cares about the original
library file path and has to do extra work to remove the name of the temp file.
Instead, I have removed that check and set `OS_Windows::open_dynamic_library`
to return the name of the original file and not the name of the copy.

This fixes GDExtension reloading on macOS. I do not have a Windows machine
available to test that it still works properly on Windows, so someone should
check that before merging this.
2024-08-08 08:31:49 -06:00
..
extension_api_dump.cpp Replace find with contains/has where applicable 2024-05-08 12:37:42 +02:00
extension_api_dump.h Optionally include documentation in GDExtension API dump 2023-09-26 21:39:24 +02:00
gdextension.compat.inc Bind compatibility GDExtension methods removed in 88418 2024-05-07 01:36:36 -07:00
gdextension.cpp Fix reload of GDExtension libraries in framework package on macos 2024-08-08 08:31:49 -06:00
gdextension.h Merge pull request #91502 from lyuma/gdextension_open_library_compat 2024-05-30 11:47:43 +02:00
gdextension_compat_hashes.cpp Fix gdextension_compat_hashes.cpp for double precision builds 2024-02-10 19:05:33 -06:00
gdextension_compat_hashes.h Check that GDExtensionCompatHashes are valid when generating extension_api.json 2023-11-16 06:40:06 -06:00
gdextension_interface.cpp [TextServer, GDExtension] Fix building text servers as GDExtension, expose new/changed low-level methods to GDExtension API. 2024-06-12 19:30:19 +03:00
gdextension_interface.h GDExtension docs: advise bindings to use uint64_t for bitfields 2024-07-15 22:37:33 +02:00
gdextension_manager.cpp GDExtension: Prevent crash during shutdown as singletons are deleted 2024-05-10 13:17:36 -05:00
gdextension_manager.h Fix StringName leaks in GDExtension, core, and editor themes 2023-10-18 17:36:20 +02:00
make_interface_dumper.py SCons: Remove run_in_subprocess dependency 2024-03-11 13:20:09 -05:00
make_wrappers.py Update pre-commit hooks configuration to use ruff instead of black 2024-05-21 18:02:29 -05:00
SCsub Update pre-commit hooks configuration to use ruff instead of black 2024-05-21 18:02:29 -05:00