asgardius/virtualx-engine
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
virtualx-engine/core
History
Rémi Verschelde e5bbcb8bcf Fix warnings for comparison between signed and unsigned integers [-Wsign-compare] 
Also turn off -Wsign-compare warnings in the future, we do not consider them important.

Fixes the following GCC 5 warnings:
```
core/node_path.cpp:279:24: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
core/oa_hash_map.h:169:21: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
core/oa_hash_map.h:314:21: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
drivers/gles2/shader_gles2.cpp:985:23: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
drivers/gles3/rasterizer_storage_gles3.cpp:1075:25: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
drivers/pulseaudio/audio_driver_pulseaudio.cpp:343:34: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
editor/editor_plugin.cpp:525:21: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
editor/editor_properties_array_dict.cpp:747:25: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
editor/plugins/spatial_editor_plugin.cpp:2078:20: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
editor/plugins/spatial_editor_plugin.cpp:4096:27: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
editor/plugins/sprite_editor_plugin.cpp💯20: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
modules/cvtt/image_compress_cvtt.cpp:122:23: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
modules/cvtt/image_compress_cvtt.cpp:134:77: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
modules/cvtt/image_compress_cvtt.cpp:339:25: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
modules/etc/image_etc.cpp:222:34: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
modules/gdnative/register_types.cpp:242:21: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
modules/gdnative/register_types.cpp:258:21: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
modules/opensimplex/simplex_noise.cpp:200:13: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
modules/opensimplex/simplex_noise.cpp:222:13: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
modules/opensimplex/simplex_noise.cpp:246:13: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
platform/android/export/export.cpp:1085:21: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
platform/android/export/export.cpp:1489:23: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
platform/android/export/export.cpp:1623:22: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
platform/iphone/export/export.cpp:206:20: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
platform/iphone/export/export.cpp:356:20: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
platform/iphone/export/export.cpp:406:20: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
platform/iphone/export/export.cpp:493:21: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
scene/3d/audio_stream_player_3d.cpp:420:23: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
scene/resources/audio_stream_sample.cpp:565:22: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
scene/resources/audio_stream_sample.cpp:571:22: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
servers/audio/audio_rb_resampler.cpp:156:36: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
```

The following warnings were not fixed, as they implied casting for no gain:
```
core/io/packet_peer.cpp:228:38: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
core/io/resource_format_binary.cpp:109:11: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
drivers/gles2/rasterizer_scene_gles2.cpp:144:57: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
drivers/unix/file_access_unix.cpp:249:46: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
scene/3d/voxel_light_baker.cpp:889:14: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
scene/3d/voxel_light_baker.cpp:1020:14: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
scene/3d/voxel_light_baker.cpp:1154:14: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
scene/3d/voxel_light_baker.cpp:2255:38: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
scene/resources/bit_mask.cpp:336:25: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
servers/audio/audio_stream.cpp:141:49: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
servers/audio/audio_stream.cpp:150:19: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
servers/audio/audio_stream.cpp:154:19: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
servers/audio_server.cpp:86:21: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
servers/audio_server.cpp:89:17: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
```
2018-09-27 16:25:23 +02:00
..
bind Make core/ includes absolute, remove subfolders from include path 2018-09-12 09:52:22 +02:00
io Fix warnings for operator precedence disambiguation [-Wparentheses] 2018-09-27 10:29:48 +02:00
math Removed obsoleted core/helper/value_evaluator.h and moved math_fieldwise to core/math/ 2018-09-23 14:58:15 +02:00
os Merge pull request #21954 from isaacremnant/fix_inputs 2018-09-14 18:06:11 +02:00
allocators.h Make core/ includes absolute, remove subfolders from include path 2018-09-12 09:52:22 +02:00
array.cpp Make core/ includes absolute, remove subfolders from include path 2018-09-12 09:52:22 +02:00
array.h Make core/ includes absolute, remove subfolders from include path 2018-09-12 09:52:22 +02:00
class_db.cpp Make core/ includes absolute, remove subfolders from include path 2018-09-12 09:52:22 +02:00
class_db.h Make core/ includes absolute, remove subfolders from include path 2018-09-12 09:52:22 +02:00
color.cpp Make core/ includes absolute, remove subfolders from include path 2018-09-12 09:52:22 +02:00
color.h Make core/ includes absolute, remove subfolders from include path 2018-09-12 09:52:22 +02:00
color_names.inc Make core/ includes absolute, remove subfolders from include path 2018-09-12 09:52:22 +02:00
command_queue_mt.cpp Make core/ includes absolute, remove subfolders from include path 2018-09-12 09:52:22 +02:00
command_queue_mt.h Make core/ includes absolute, remove subfolders from include path 2018-09-12 09:52:22 +02:00
compressed_translation.cpp Make core/ includes absolute, remove subfolders from include path 2018-09-12 09:52:22 +02:00
compressed_translation.h Make core/ includes absolute, remove subfolders from include path 2018-09-12 09:52:22 +02:00
core_builders.py Allow system certs file to be used by Editor. 2018-09-15 14:45:54 +02:00
core_string_names.cpp
core_string_names.h Make core/ includes absolute, remove subfolders from include path 2018-09-12 09:52:22 +02:00
cowdata.h Make core/ includes absolute, remove subfolders from include path 2018-09-12 09:52:22 +02:00
dictionary.cpp Make core/ includes absolute, remove subfolders from include path 2018-09-12 09:52:22 +02:00
dictionary.h Make core/ includes absolute, remove subfolders from include path 2018-09-12 09:52:22 +02:00
dvector.cpp
dvector.h Make core/ includes absolute, remove subfolders from include path 2018-09-12 09:52:22 +02:00
engine.cpp Make core/ includes absolute, remove subfolders from include path 2018-09-12 09:52:22 +02:00
engine.h Make core/ includes absolute, remove subfolders from include path 2018-09-12 09:52:22 +02:00
error_list.h
error_macros.cpp Make core/ includes absolute, remove subfolders from include path 2018-09-12 09:52:22 +02:00
error_macros.h Make core/ includes absolute, remove subfolders from include path 2018-09-12 09:52:22 +02:00
func_ref.cpp
func_ref.h Make core/ includes absolute, remove subfolders from include path 2018-09-12 09:52:22 +02:00
global_constants.cpp Make core/ includes absolute, remove subfolders from include path 2018-09-12 09:52:22 +02:00
global_constants.h Make core/ includes absolute, remove subfolders from include path 2018-09-12 09:52:22 +02:00
hash_map.h Make core/ includes absolute, remove subfolders from include path 2018-09-12 09:52:22 +02:00
hashfuncs.h Make core/ includes absolute, remove subfolders from include path 2018-09-12 09:52:22 +02:00
image.cpp Make core/ includes absolute, remove subfolders from include path 2018-09-12 09:52:22 +02:00
image.h Make core/ includes absolute, remove subfolders from include path 2018-09-12 09:52:22 +02:00
input_map.cpp Merge pull request #21954 from isaacremnant/fix_inputs 2018-09-14 18:06:11 +02:00
input_map.h Make core/ includes absolute, remove subfolders from include path 2018-09-12 09:52:22 +02:00
int_types.h
list.h Make core/ includes absolute, remove subfolders from include path 2018-09-12 09:52:22 +02:00
make_binders.py fix windows build using python 3.7 2018-07-28 18:13:48 +02:00
map.h Make core/ includes absolute, remove subfolders from include path 2018-09-12 09:52:22 +02:00
message_queue.cpp Make core/ includes absolute, remove subfolders from include path 2018-09-12 09:52:22 +02:00
message_queue.h Make core/ includes absolute, remove subfolders from include path 2018-09-12 09:52:22 +02:00
method_bind.cpp Make core/ includes absolute, remove subfolders from include path 2018-09-12 09:52:22 +02:00
method_bind.h Make core/ includes absolute, remove subfolders from include path 2018-09-12 09:52:22 +02:00
method_ptrcall.h Make core/ includes absolute, remove subfolders from include path 2018-09-12 09:52:22 +02:00
node_path.cpp Fix warnings for comparison between signed and unsigned integers [-Wsign-compare] 2018-09-27 16:25:23 +02:00
node_path.h Make core/ includes absolute, remove subfolders from include path 2018-09-12 09:52:22 +02:00
oa_hash_map.h Fix warnings for comparison between signed and unsigned integers [-Wsign-compare] 2018-09-27 16:25:23 +02:00
object.cpp Make core/ includes absolute, remove subfolders from include path 2018-09-12 09:52:22 +02:00
object.h Make core/ includes absolute, remove subfolders from include path 2018-09-12 09:52:22 +02:00
ordered_hash_map.h Make core/ includes absolute, remove subfolders from include path 2018-09-12 09:52:22 +02:00
packed_data_container.cpp Make core/ includes absolute, remove subfolders from include path 2018-09-12 09:52:22 +02:00
packed_data_container.h Make core/ includes absolute, remove subfolders from include path 2018-09-12 09:52:22 +02:00
pair.h
path_remap.cpp
path_remap.h
pool_allocator.cpp Make core/ includes absolute, remove subfolders from include path 2018-09-12 09:52:22 +02:00
pool_allocator.h Make core/ includes absolute, remove subfolders from include path 2018-09-12 09:52:22 +02:00
print_string.cpp Make core/ includes absolute, remove subfolders from include path 2018-09-12 09:52:22 +02:00
print_string.h Make core/ includes absolute, remove subfolders from include path 2018-09-12 09:52:22 +02:00
project_settings.cpp Merge pull request #21982 from luzpaz/misc-typos 2018-09-13 10:59:00 +02:00
project_settings.h Make core/ includes absolute, remove subfolders from include path 2018-09-12 09:52:22 +02:00
ref_ptr.cpp Make core/ includes absolute, remove subfolders from include path 2018-09-12 09:52:22 +02:00
ref_ptr.h Make core/ includes absolute, remove subfolders from include path 2018-09-12 09:52:22 +02:00
reference.cpp Make core/ includes absolute, remove subfolders from include path 2018-09-12 09:52:22 +02:00
reference.h Make core/ includes absolute, remove subfolders from include path 2018-09-12 09:52:22 +02:00
register_core_types.cpp Unify StreamPeerTCP/TCP_Server with NetSocket API 2018-09-12 15:56:20 +02:00
register_core_types.h
resource.cpp Make core/ includes absolute, remove subfolders from include path 2018-09-12 09:52:22 +02:00
resource.h Make core/ includes absolute, remove subfolders from include path 2018-09-12 09:52:22 +02:00
rid.cpp
rid.h Make core/ includes absolute, remove subfolders from include path 2018-09-12 09:52:22 +02:00
ring_buffer.h Make core/ includes absolute, remove subfolders from include path 2018-09-12 09:52:22 +02:00
safe_refcount.cpp reduce clang warning spam 2018-07-24 12:13:05 +02:00
safe_refcount.h Make core/ includes absolute, remove subfolders from include path 2018-09-12 09:52:22 +02:00
script_debugger_local.cpp Make core/ includes absolute, remove subfolders from include path 2018-09-12 09:52:22 +02:00
script_debugger_local.h Make core/ includes absolute, remove subfolders from include path 2018-09-12 09:52:22 +02:00
script_debugger_remote.cpp Fixed error spam in remote debugger 2018-09-19 11:32:11 +02:00
script_debugger_remote.h Make core/ includes absolute, remove subfolders from include path 2018-09-12 09:52:22 +02:00
script_language.cpp Make core/ includes absolute, remove subfolders from include path 2018-09-12 09:52:22 +02:00
script_language.h Make core/ includes absolute, remove subfolders from include path 2018-09-12 09:52:22 +02:00
SCsub Fixed scons warning: Ignoring missing 'core/helper/SCsub' after #22351. 2018-09-23 21:45:35 +06:00
self_list.h Make core/ includes absolute, remove subfolders from include path 2018-09-12 09:52:22 +02:00
set.h Make core/ includes absolute, remove subfolders from include path 2018-09-12 09:52:22 +02:00
simple_type.h
sort.h Make core/ includes absolute, remove subfolders from include path 2018-09-12 09:52:22 +02:00
string_buffer.h Make core/ includes absolute, remove subfolders from include path 2018-09-12 09:52:22 +02:00
string_builder.cpp
string_builder.h Fix several in-class initialization clang warning 2018-03-22 00:17:18 -03:00
string_db.cpp Make core/ includes absolute, remove subfolders from include path 2018-09-12 09:52:22 +02:00
string_db.h Make core/ includes absolute, remove subfolders from include path 2018-09-12 09:52:22 +02:00
translation.cpp Fallback to "en" when invalid locale is requested 2018-09-23 13:58:01 +02:00
translation.h Make core/ includes absolute, remove subfolders from include path 2018-09-12 09:52:22 +02:00
type_info.h State machine animation node 2018-06-25 16:22:41 -03:00
typedefs.h Fix warnings for operator precedence disambiguation [-Wparentheses] 2018-09-27 10:29:48 +02:00
ucaps.h
undo_redo.cpp Make core/ includes absolute, remove subfolders from include path 2018-09-12 09:52:22 +02:00
undo_redo.h Make core/ includes absolute, remove subfolders from include path 2018-09-12 09:52:22 +02:00
ustring.cpp Make core/ includes absolute, remove subfolders from include path 2018-09-12 09:52:22 +02:00
ustring.h Make core/ includes absolute, remove subfolders from include path 2018-09-12 09:52:22 +02:00
variant.cpp Make core/ includes absolute, remove subfolders from include path 2018-09-12 09:52:22 +02:00
variant.h Make core/ includes absolute, remove subfolders from include path 2018-09-12 09:52:22 +02:00
variant_call.cpp Make core/ includes absolute, remove subfolders from include path 2018-09-12 09:52:22 +02:00
variant_construct_string.cpp
variant_op.cpp Color: Fix rounding error converting from float to 8-bit 2018-09-18 17:11:15 +02:00
variant_parser.cpp Merge pull request #21982 from luzpaz/misc-typos 2018-09-13 10:59:00 +02:00
variant_parser.h Make core/ includes absolute, remove subfolders from include path 2018-09-12 09:52:22 +02:00
vector.h Make core/ includes absolute, remove subfolders from include path 2018-09-12 09:52:22 +02:00
version.h Make core/ includes absolute, remove subfolders from include path 2018-09-12 09:52:22 +02:00
vmap.h Make core/ includes absolute, remove subfolders from include path 2018-09-12 09:52:22 +02:00
vset.h Make core/ includes absolute, remove subfolders from include path 2018-09-12 09:52:22 +02:00