asgardius/virtualx-engine
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Update OccluderInstance3D warnings on project setting changes

Browse source 
This ensures the node configuration warning is always up-to-date,
even when the Use Occlusion Culling project setting is changed
while a scene with an OccluderInstance3D is being edited.
This commit is contained in:
Hugo Locurcio 2022-06-14 11:43:34 +02:00
parent 706dc74e01
commit abf42402f8
No known key found for this signature in database
GPG key ID: 39E8F8BE30B0A49C
2 changed files with 20 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

18
scene/3d/occluder_instance_3d.cpp
View file

@ -467,6 +467,11 @@ void OccluderInstance3D::_occluder_changed() {
update_configuration_warnings();
}
void OccluderInstance3D::_project_settings_changed() {
// Use Occlusion Culling project setting affects node configuration warnings.
update_configuration_warnings();
}
Ref<Occluder3D> OccluderInstance3D::get_occluder() const {
return occluder;
}
@ -719,6 +724,19 @@ Ref<Resource> OccluderInstance3D::_get_editable_3d_polygon_resource() const {
return occluder;
}
void OccluderInstance3D::_notification(int p_what) {
#ifdef TOOLS_ENABLED
switch (p_what) {
case NOTIFICATION_READY: {
if (Engine::get_singleton()->is_editor_hint()) {
// Use Occlusion Culling project setting affects node configuration warnings.
EditorNode::get_singleton()->connect("project_settings_changed", callable_mp(this, &OccluderInstance3D::_project_settings_changed));
}
} break;
}
#endif
}
void OccluderInstance3D::_bind_methods() {
ClassDB::bind_method(D_METHOD("set_bake_mask", "mask"), &OccluderInstance3D::set_bake_mask);
ClassDB::bind_method(D_METHOD("get_bake_mask"), &OccluderInstance3D::get_bake_mask);

2
scene/3d/occluder_instance_3d.h
View file

@ -169,6 +169,7 @@ private:
float bake_simplification_dist = 0.1f;
void _occluder_changed();
void _project_settings_changed();
static bool _bake_material_check(Ref<Material> p_material);
static void _bake_surface(const Transform3D &p_transform, Array p_surface_arrays, Ref<Material> p_material, float p_simplification_dist, PackedVector3Array &r_vertices, PackedInt32Array &r_indices);
@ -178,6 +179,7 @@ private:
Ref<Resource> _get_editable_3d_polygon_resource() const;
protected:
void _notification(int p_what);
static void _bind_methods();
public: