Commit graph

231 commits

Author SHA1 Message Date
Rémi Verschelde
77ec3ec0a3
Merge pull request from YeldhamDev/fix_track_removal_errors
Fix errors in the animation editor when removing tracks via undo/redo
2019-09-20 17:28:15 +02:00
Michael Alexsander Silva Dias
c0acaab1aa Fix keying integer and float values from inspector not being able to use bezier curves 2019-09-15 08:59:43 -03:00
Michael Alexsander Silva Dias
5c2582ad34 Fix errors in the animation editor when removing tracks via undo/redo 2019-09-13 22:16:53 -03:00
Michael Alexsander Silva Dias
5f3a55acb7 Add informational messages to various editors 2019-09-04 12:37:11 -03:00
Hugo Locurcio
bd05d0e71b
Change mouse cursor when hovering a resize area in the animation editor
This also scales the default width of the track name column
on hiDPI displays.
2019-08-23 23:00:38 +02:00
Rémi Verschelde
40640a01dc
Merge pull request from Calinou/improve-animation-editor-timeline
Improve timeline drawing in the animation editor
2019-08-17 12:05:42 +02:00
Hugo Locurcio
a341c65f65
Improve timeline drawing in the animation editor
A small arrow-like icon is now drawn at the top of the timeline.
The timeline is now also wider as to be more visible.
2019-08-17 00:20:21 +02:00
Hugo Locurcio
108f9646f5
Add an outline to box selection rectangles for better visibility
This also refactors selection box color definitions
to avoid repetition.
2019-08-15 22:27:32 +02:00
Hugo Locurcio
4a28657cf5
Tweak range steps in the animation editor
This makes the step of the "frame" SpinBox larger, so that clicking
on the SpinBox arrows will make the number increase in a visible manner.
Previously, the full number was being cut off due to the SpinBox
being narrow.

This also makes the "step" SpinBox allow for more precise input.
2019-08-06 12:25:53 +02:00
Hugo Locurcio
8b12498f8b
Improve snapping in the animation editor
Snapping can now be toggled temporarily by holding the Ctrl key.
Toggling timeline snapping is now done with the "Snap" checkbox rather
than by setting the animation's "Step" setting to 0.

The timeline cursor can no longer exit the animation's boundaries
if the animation's "Step" is set to 0.
2019-08-06 01:44:10 +02:00
Michael Alexsander Silva Dias
3d9df3b2ed Fix undo problems with method and transform tracks in the animation editor 2019-07-24 11:29:51 -03:00
Michael Alexsander Silva Dias
97e18f03db Make possible to edit multiple keys in an animation again 2019-07-22 20:12:01 -03:00
Rémi Verschelde
9f5b77acc9
Revert "Expose "meta" to the Inspector" 2019-07-22 12:03:57 +02:00
Rémi Verschelde
3aeca70659
Merge pull request from bojidar-bg/6067-pale-customtype-script
Make custom types more subtle and more useful
2019-07-20 11:49:52 +02:00
Bojidar Marinov
4f72178868
Make custom types more subtle and more useful
Implements  (aaronfranke's idea)
Fixes 
2019-07-19 22:33:58 +03:00
Rémi Verschelde
2ca3e47d66
Merge pull request from YeldhamDev/inspector_metadata
Expose "meta" to the Inspector
2019-07-19 14:39:23 +02:00
Hugo Locurcio
acbd0fea97
Use CheckBoxes in the editor instead of CheckButtons when applicable
CheckButtons should only be used if toggling them has an
immediate effect. Otherwise, CheckBoxes should be used.
2019-07-04 17:32:59 +02:00
jens
0f6c572db6 Make easier to select keys that are at position 0 in AnimationPlayer editor
Fixes .

Co-Authored-By: Michael Alexsander Silva Dias <michaelalexsander@protonmail.com>
2019-07-03 12:56:36 -03:00
Rémi Verschelde
eaaff9da31
Merge pull request from qarmin/redundant_code_and_others
Remove redundant code, possible NULL pointers and others
2019-06-27 01:05:18 +02:00
qarmin
4e5310cc60 Some code changed with Clang-Tidy 2019-06-26 15:08:25 +02:00
Rémi Verschelde
b3d772ed83 Display invalid value keys in AnimationTrackEdit
Godot 2.1 and 3.0 had this feature but it was lost in the rewrite
of the animation editor in 3.1.
Drop unused KeyValid icon, since all valid keys now have a custom
type icon.
2019-06-23 19:52:49 +02:00
Rémi Verschelde
bf7a6f9c46
Merge pull request from Chaosus/select_all_tracks
Added button to select all tracks in track copy dialog
2019-06-19 20:04:54 +02:00
Chaosus
be7bd97cb0 Added button to select all tracks in track copy dialog 2019-06-19 15:10:48 +03:00
Chaosus
47e24dd1ee Fix animation keys selection with SHIFT/CTRL 2019-06-19 13:34:22 +03:00
Rémi Verschelde
cd22551d2d i18n: Sync translation template with current source 2019-06-16 22:08:53 +02:00
Michael Alexsander Silva Dias
bb1c5f5525 Enhancements for the audio bus editor 2019-06-09 00:23:08 -03:00
volzhs
fe98a31743 Sync Animation editor with Inspector 2019-05-31 06:50:14 +09:00
volzhs
e16e5012ca Revert "Fix AnimationPlayer editor length and step synchronization"
This reverts commit ca80ebe9f6.
2019-05-31 04:43:46 +09:00
Michael Alexsander Silva Dias
fad0338beb Make animation editor change tracks positions instead of swapping them 2019-05-27 22:03:26 -03:00
Michael Alexsander Silva Dias
757a1de58d Fix "Node not found:" error message when adding tracks 2019-05-25 15:30:53 -03:00
Rémi Verschelde
04ee4f45e5
Merge pull request from timoschwarzer/animation-player-editor-pos-drag-fix
Fix AnimationPlayer editor length and step synchronization
2019-05-24 15:21:47 +02:00
Rémi Verschelde
e0574e1d98 Fix typos with codespell
Using codespell 1.15.0.

Method:
```
$ cat > ../godot-word-whitelist.txt << EOF
ang
curvelinear
doubleclick
leapyear
lod
merchantibility
nd
numer
ois
ony
que
seeked
synching
te
uint
unselect
webp
EOF

$ codespell -w -q 3 -I ../godot-word-whitelist.txt --skip="./thirdparty,*.po"
$ git diff // undo unwanted changes
```
2019-05-19 13:10:35 +02:00
Timo Schwarzer
ca80ebe9f6
Fix AnimationPlayer editor length and step synchronization 2019-05-06 21:39:24 +02:00
Ben Hickling
a7ef836c69 Fixed a few issues with the bezier animation track editor, fixed the Travis CI errors, added TTR to bezier value labels and rounded them to 3 decimal points 2019-04-30 10:41:23 +01:00
Rémi Verschelde
e98ccaefe8
Merge pull request from homer666/animationplayer-imported-anim-warning
Warn when opening imported anim in Animation editor
2019-04-30 10:15:30 +02:00
homer666
e5c8e4019b Warn when opening imported anim in AnimationPlayer 2019-04-30 04:46:45 +10:00
homer666
62e0262951 Update edited keyframe's snap mode properly 2019-04-28 09:31:53 +10:00
Hein-Pieter van Braam
ad744cefb0
Merge pull request from homer666/animationplayer-fps-mode-fixes
AnimationPlayer FPS mode fixes
2019-04-25 23:09:47 +03:00
Rémi Verschelde
9fc84061dd i18n: Sync translation template with current source
(cherry picked from commit 23cf9f3b6f)
2019-04-25 14:31:13 +02:00
homer666
e3b7f9e1ca AnimationPlayer FPS mode fixes 2019-04-24 10:52:10 +10:00
homer666
659162ab98 Fix AnimationPlayer snap mode dropdown behaviour 2019-04-18 14:43:48 +10:00
Hugo Locurcio
c0959f00a0
Scale animation track editor line widths on hiDPI displays 2019-04-15 14:11:31 +02:00
Juan Linietsky
296c74072c Implement autokeying in Animation editor. 2019-04-15 00:49:03 -03:00
Juan Linietsky
8f762aefcd Oops I missed a line, continuation to 0d41f8f. 2019-04-15 00:05:27 -03:00
Juan Linietsky
0d41f8fb00 Avoid crash on changing snap mode when no animation exists, closes 2019-04-15 00:02:17 -03:00
Juan Linietsky
caaa492133 Also show length in FPS when using FPS mode for AnimationPlayer editor 2019-04-14 23:48:53 -03:00
Juan Linietsky
4203266923 Add support for FPS snap in Animation Editor. 2019-04-14 16:43:38 -03:00
Anish
d6e4a08c61 Prevents a Null Reference in deleting Animations.
A null Animation would cause a crash by accessing restricted memory.
Solved by checking if the animation track is null before using the
animation.

Fixes: 
2019-03-11 17:04:02 +05:30
Juan Linietsky
9b5c6f539b Safer way to update animation if changed, fixes 2019-03-06 10:22:38 -03:00
Juan Linietsky
8b4c4d9b2f Implement a more coherent (and way less hack) way to block animation updates, fixes 2019-03-03 17:57:16 -03:00
Michael Alexsander Silva Dias
3ef8238c1c Make translatable some undo/redo operations in the editor 2019-02-21 16:41:01 -03:00
marxin
8d51618949 Add -Wshadow=local to warnings and fix reported issues.
Fixes .
2019-02-20 19:44:12 +01:00
Rémi Verschelde
c6c788581e Drop unused AnimationTrackKeyEdit::track_editor
Added by mistake in 4a24ba6e77.
2019-02-14 16:16:45 +01:00
Juan Linietsky
4a24ba6e77 -Fixes to undo redo to avoid crash, closes
-Changed Animation to have a special signal when tracks are changed, to avoid unnecesary track cache rebuilds in AnimationPlayer
-Added missing emit_changed whe modifying keys to Animation
-Changed AnimationPlayer to use the new refcounted connections instead of the previous hacky way to keep references
-Changed AnimationEditor to update the current track when keys are edited
-Fixed bug where undo/redo did not work with AnimationKeyEdit (was not being updated)
-Made sure UndoRedo does not mind deleted objects in undo/redo history, this would corrupt the history or clear it without need.
2019-02-14 10:22:34 -03:00
Juan Linietsky
f981e9fe91 Avoid case where editors are deleted while moved, fixes , fixes 2019-02-14 08:03:32 -03:00
Dawid Wdowiak
855a82211f Removed duplicated code 2019-01-04 22:18:54 +01:00
Rémi Verschelde
b16c309f82 Update copyright statements to 2019
Happy new year to the wonderful Godot community!
2019-01-01 12:58:10 +01:00
Michael Alexsander Silva Dias
e425f2d498 Expose "meta" to the Inspector 2018-12-08 02:27:20 -02:00
DualMatrix
e4e8fc6314 AnimationPlayer, snap absolute position instead of motion.
Fixes 
2018-11-09 12:35:49 +01:00
Juan Linietsky
0e27af280c
Merge pull request from DualMatrix/animation_group
Made AnimationPlayer track groups update after changing path
2018-11-01 20:05:49 -03:00
DualMatrix
87f8077a70 Fixed Animation Keyframe inspector not displaying after moving key.
Fixed Animation Keyframe inspector not displaying after moving key.
2018-10-08 12:43:44 +02:00
DualMatrix
e99f16153e Made AnimationPlayer track groups update after changing path
Made AnimationPlayer track groups update after changing path
2018-10-07 01:36:21 +02:00
Rémi Verschelde
cda5b0bfe1 Fix warnings about unused variables [-Wunused-variable]
Fixes the following GCC 5 warnings:
```
drivers/gles2/rasterizer_scene_gles2.cpp:1139:15: warning: unused variable 'offset' [-Wunused-variable]
drivers/gles2/rasterizer_scene_gles2.cpp:1205:39: warning: unused variable 'multi_mesh' [-Wunused-variable]
drivers/gles2/rasterizer_storage_gles2.cpp:359:7: warning: unused variable 'srgb' [-Wunused-variable]
drivers/gles2/shader_gles2.cpp:1016:45: warning: unused variable 'texture_hints' [-Wunused-variable]
editor/animation_track_editor.cpp:776:9: warning: unused variable 'keys_to' [-Wunused-variable]
editor/editor_inspector.cpp:273:7: warning: unused variable 'vs_height' [-Wunused-variable]
editor/editor_themes.cpp:202:10: warning: unused variable 'begin_time' [-Wunused-variable]
editor/editor_themes.cpp:239:10: warning: unused variable 'end_time' [-Wunused-variable]
editor/plugins/animation_blend_tree_editor_plugin.cpp:726:17: warning: unused variable 'an' [-Wunused-variable]
editor/plugins/script_text_editor.cpp:1278:8: warning: unused variable 'fold_state' [-Wunused-variable]
main/main.cpp:132:13: warning: 'use_vsync' defined but not used [-Wunused-variable]
modules/cvtt/image_compress_cvtt.cpp:231:8: warning: unused variable 'y_end' [-Wunused-variable]
modules/cvtt/image_compress_cvtt.cpp:311:6: warning: unused variable 'shift' [-Wunused-variable]
modules/gdscript/gdscript_editor.cpp:58:7: warning: unused variable 'th' [-Wunused-variable]
modules/gridmap/grid_map.cpp:1084:6: warning: unused variable 'ofs' [-Wunused-variable]
modules/theora/video_stream_theora.cpp:442:9: warning: unused variable 'tr' [-Wunused-variable]
modules/visual_script/visual_script_editor.cpp:2606:6: warning: unused variable 'count' [-Wunused-variable]
modules/visual_script/visual_script_editor.cpp:2829:6: warning: unused variable 'seq_count' [-Wunused-variable]
modules/visual_script/visual_script_editor.cpp:2844:24: warning: unused variable 'vnode_function' [-Wunused-variable]
modules/websocket/lws_peer.cpp:122:12: warning: unused variable 'peer_data' [-Wunused-variable]
modules/websocket/lws_peer.cpp:135:12: warning: unused variable 'peer_data' [-Wunused-variable]
modules/websocket/lws_peer.cpp:63:12: warning: unused variable 'peer_data' [-Wunused-variable]
modules/websocket/lws_peer.cpp:91:12: warning: unused variable 'peer_data' [-Wunused-variable]
platform/android/export/export.cpp:763:16: warning: unused variable 'node_size' [-Wunused-variable]
scene/gui/rich_text_label.cpp:850:10: warning: unused variable 'x_ofs' [-Wunused-variable]
scene/gui/text_edit.cpp:653:8: warning: unused variable 'tab_w' [-Wunused-variable]
scene/resources/bit_mask.cpp:186:6: warning: unused variable 'i' [-Wunused-variable]
scene/resources/mesh.cpp:549:20: warning: '_array_name' defined but not used [-Wunused-variable]
servers/audio/audio_rb_resampler.cpp:107:10: warning: unused variable 'v2' [-Wunused-variable]
servers/audio/audio_rb_resampler.cpp:108:10: warning: unused variable 'v3' [-Wunused-variable]
servers/audio/audio_rb_resampler.cpp:109:10: warning: unused variable 'v4' [-Wunused-variable]
servers/audio/audio_rb_resampler.cpp:110:10: warning: unused variable 'v5' [-Wunused-variable]
servers/audio/audio_rb_resampler.cpp:111:10: warning: unused variable 'v0n' [-Wunused-variable]
servers/audio/audio_rb_resampler.cpp:112:10: warning: unused variable 'v1n' [-Wunused-variable]
servers/audio/audio_rb_resampler.cpp:113:10: warning: unused variable 'v2n' [-Wunused-variable]
servers/audio/audio_rb_resampler.cpp:114:10: warning: unused variable 'v3n' [-Wunused-variable]
servers/audio/audio_rb_resampler.cpp:115:10: warning: unused variable 'v4n' [-Wunused-variable]
servers/audio/audio_rb_resampler.cpp:116:10: warning: unused variable 'v5n' [-Wunused-variable]
servers/visual/default_mouse_cursor.xpm:2:21: warning: 'default_mouse_cursor_xpm' defined but not used [-Wunused-variable]
```
2018-09-27 16:25:24 +02:00
Hugo Locurcio
c4770a5b5d
Tweak some editor texts' capitalization, use "Go to" instead of "Goto"
This also fixes a typo in the `debugger/debug_with_external_editor`
shortcut.
2018-09-25 22:51:13 +02:00
Rémi Verschelde
277b24dfb7 Make core/ includes absolute, remove subfolders from include path
This allows more consistency in the manner we include core headers,
where previously there would be a mix of absolute, relative and
include path-dependent includes.
2018-09-12 09:52:22 +02:00
Rémi Verschelde
39168f125e
Merge pull request from bojidar-bg/19448-fix-subproperty-handling
Fix bug in animationplayer editor not using subproperties properly
2018-07-26 10:31:05 +02:00
Hein-Pieter van Braam
0e29f7974b Reduce unnecessary COW on Vector by make writing explicit
This commit makes operator[] on Vector const and adds a write proxy to it.  From
now on writes to Vectors need to happen through the .write proxy. So for
instance:

Vector<int> vec;
vec.push_back(10);
std::cout << vec[0] << std::endl;
vec.write[0] = 20;

Failing to use the .write proxy will cause a compilation error.

In addition COWable datatypes can now embed a CowData pointer to their data.
This means that String, CharString, and VMap no longer use or derive from
Vector.

_ALWAYS_INLINE_ and _FORCE_INLINE_ are now equivalent for debug and non-debug
builds. This is a lot faster for Vector in the editor and while running tests.
The reason why this difference used to exist is because force-inlined methods
used to give a bad debugging experience. After extensive testing with modern
compilers this is no longer the case.
2018-07-26 00:54:16 +02:00
Max Hilbrunner
9f82368d40
Merge pull request from YeldhamDev/animplayer_cosmetic
Minor changes to the AnimationPlayer editor
2018-07-05 04:25:04 +02:00
Max Hilbrunner
073e77454d
Merge pull request from volzhs/fix-crash-nodepath-animation-edit
Fix crash when assigning a node on editing animation key
2018-07-05 04:20:40 +02:00
khairul169
0f616ff5d8 Hide play position if animation node is invalid 2018-07-03 13:24:47 +07:00
Michael Alexsander Silva Dias
02181292b8 Minor changes to the AnimationPlayer editor. 2018-06-30 00:12:05 -03:00
volzhs
b4f60ae3ac Fix crash when assigning a node on editing animation key 2018-06-22 14:48:49 +09:00
Guilherme Felipe
b75ad7b6b0 Prevent animation player crash 2018-06-18 15:57:15 -03:00
Bojidar Marinov
7b107cb180
Fix bug in animationplayer editor not using subproperties properly
Fixes  
2018-06-18 15:59:13 +03:00
Juan Linietsky
257d3c3f39 Bit more of visual polish 2018-06-08 21:03:27 -03:00
Juan Linietsky
e5b876e92a Remove the "go back" behavior in track editor for inspector based key editing, fixes , fixes 2018-06-08 19:21:26 -03:00
Juan Linietsky
66871322b9 Properly update range and valid key range when keys are in/out of view, fixes 2018-06-08 17:58:37 -03:00
Juan Linietsky
c8289d95cd Fixed cursor not updating in some circumstances, closes 2018-06-08 16:08:24 -03:00
Juan Linietsky
7572b31a39 Disallow via add track for animation player to animate itself, fixes 2018-06-08 13:59:29 -03:00
Juan Linietsky
9cb17d7af8 Avoid animation length from ever being completely, fixes 2018-06-08 13:42:45 -03:00
Juan Linietsky
b659fd6d74 Entirely new (and much improved) animation editor. 2018-06-07 12:52:00 -03:00