Commit graph

65818 commits

Author SHA1 Message Date
Hilderin
650981a080 Fix editor crash when editor settings resource is invalid 2024-07-21 13:26:15 -04:00
aaronp64
5682cc7b81 Avoid FlowContainer crash with TextureRect using EXPAND_FIT_* expand modes
When a FlowContainer had a TextureRect child using any of the EXPAND_FIT_* expand modes, it could crash when changing the FlowContainer's minimum size, or that of its children.  This was due to the TextureRect resizing in FlowContainer::_resort, updating its minimum size, and triggering another _resort.  If the TextureRect's minimum size changed in a way that caused any of the FlowContainer's children to be put on a different line, it could repeatedly cause _resort to be called again, moving the children back and forth between the old and new lines.

This change is for FlowContainer::_resort to give a warning for TextureRects with EXPAND_FIT_* expand modes when multiple lines are used, and just keep the TextureRect size the same in that case.  This is similar to the check added to AspectRatioContainer in godotengine#73396, but attempting to still support it in FlowContainer when possible.  In the case where the TextureRect is forced to stay the same size, there may be some overlap between the FlowContainer's children, but should no longer crash.
2024-07-21 13:09:22 -04:00
Alvin Wong
baf1cdabd1 End benchmark of Main::Setup properly before calling setup2 2024-07-21 21:46:01 +08:00
Hugo Locurcio
41b7196ad4
Fix incorrect Curve editor preview thumbnail scaling
`EDSCALE` scaling was applied even though it shouldn't be, which led
to pixelated thumbnails due to double scaling. For reference,
AudioStream previews don't use `EDSCALE` and look fine at any editor
scale (the editor itself already scales the thumbnail requests).
2024-07-21 05:59:01 +02:00
Kristoff
ebb80c6975 Update godot documentation contribution link
Hey there, first time contributing and I'm in the middle of reading the contribution best practice, so sorry for any mistakes in this pull request. 

When clicking the **Contributing section** link under the **Contributors guidelines** title, this linked to the Godot *page not found* link.

I changed the link from `https://docs.godotengine.org/en/latest/contributing/ways_to_contribute.html` to `https://docs.godotengine.org/en/latest/contributing/how_to_contribute.html`.

Now, when a user clicks the link, it will redirect them to the start of the contribution documentation.
2024-07-20 20:51:11 -06:00
Alexander Hartmann
78ede4f8b6 Fix glsl shader for Android Mali-GXXx GPUs and Vulkan API 1.3.xxx 2024-07-20 22:01:35 +02:00
Rémi Verschelde
e25f3c0d38
Merge pull request #94302 from TokageItLab/reset-after-change-animation-editor
Fix the behavior of after selecting animation on AnimationPlayerEditor to reset position to `0`
2024-07-20 21:43:50 +02:00
Rémi Verschelde
ab5ae8a188
Merge pull request #51372 from raulsntos/path-follow-3d-forward-tests
Fix PathFollow tests, Add PathFollow3D forward test
2024-07-20 21:43:42 +02:00
Raul Santos
c3a054fa0b
Fix PathFollow tests, Add forward vector test to PathFollow3D 2024-07-20 19:09:42 +02:00
Rémi Verschelde
a48b99af8d
Merge pull request #94557 from Riteo/they-just-keep-coming
Wayland: Fix error spam when interacting with decorations
2024-07-20 16:07:46 +02:00
Rémi Verschelde
e3b852559f
Merge pull request #94547 from clayjohn/DOCS-shadow_mesh
Add note to `shadow_mesh` docs to warn about improper usage
2024-07-20 16:07:43 +02:00
Rémi Verschelde
cd0731d7a6
Merge pull request #94541 from krdluzni/anim_player_queue_doc
Clarify documentation for `AnimationPlayer.queue`
2024-07-20 16:07:39 +02:00
Rémi Verschelde
cd74d778d6
Merge pull request #94535 from Garteal/sdfgi-data-nullptr
SDFGI: Fix crash if `update_data` is nullptr
2024-07-20 16:07:36 +02:00
Rémi Verschelde
6621d8e8cc
Merge pull request #93931 from /fix-compatibility-depth_prepass_alpha 2024-07-20 16:07:30 +02:00
Riteo
e307fd60d8 Wayland: Fix error spam when interacting with decorations
Also tried to make tablet handling a bit tidier (less whitespace).

That said I'll uniform tablet handling better once we're back in the dev
cycle.
2024-07-20 03:46:35 +02:00
David Snopek
22a6303fa0 OpenXR: Fix enabling passthrough via environment blend mode in project settings 2024-07-19 19:04:51 -05:00
clayjohn
cacb9d139e Add note to shadow_mesh docs to warn about improper usage 2024-07-19 13:26:51 -07:00
krdluzni
5626851f40 clarify animation queuing documentation 2024-07-19 12:36:25 -04:00
Garteal
2606831d71 SDFGI: fix crash if update_data is nullptr 2024-07-19 18:27:32 +02:00
Rémi Verschelde
a0943acda1
Merge pull request #94243 from Calinou/image-fix-large-cowdata-size-crash
Fix Image CowData crash when baking large lightmaps
2024-07-19 17:31:49 +02:00
Rémi Verschelde
cca22015d5
Merge pull request #94113 from jsjtxietian/project-dialog
Make `fdialog_project` up to become the child of `ProjectManager` instead of child of `ProjectDialog`
2024-07-19 17:31:45 +02:00
Rémi Verschelde
50eee00180
Merge pull request #94093 from Yahkub-R/94056-fix
Fix instanced .blend/GLTF scenes lose all children after update until .tscn is reopened
2024-07-19 17:31:39 +02:00
Hugo Locurcio
0445ccf428
Fix Image CowData crash when baking large lightmaps
This switches to 64-bit integers in select locations of the Image
class, so that image resolutions of 16384×16384 (used by
lightmap texture arrays) can be used properly. Values that are larger
should also work.

VRAM compression is also supported, although most VRAM-compressed
formats are limited to individual slices of 16384×16384. WebP
is limited to 16383×16383 due to format limitations.
2024-07-19 16:04:30 +02:00
jsjtxietian
092d21a2ec Make fdialog_project up to become sibling of ProjectDialog instead of child 2024-07-19 21:03:58 +08:00
Yahkub-R
66822a8948 Fix instanced .blend/GLTF scenes lose all children after update until .tscn is reopened
Co-Authored-By: Tomek <kobewi4e@gmail.com>
Co-Authored-By: A Thousand Ships <96648715+AThousandShips@users.noreply.github.com>
Co-Authored-By: Hilderin <81109165+Hilderin@users.noreply.github.com>
2024-07-19 08:51:23 -04:00
Rémi Verschelde
f135f729b9
Merge pull request #94533 from bruvzg/fix_arm64_win_rel
[Windows] Fix release export template build for ARM64 Windows.
2024-07-19 14:37:13 +02:00
Rémi Verschelde
566adc6025
Merge pull request #94527 from HolonProduction/who-needs-source-code
Add note about `Script.has_source_code` and GDScript binary tokenization
2024-07-19 14:37:06 +02:00
bruvzg
0e519118d2 [Windows] Fix release export template build for ARM64 Windows. 2024-07-19 14:33:40 +03:00
Rémi Verschelde
293c0f7646
Merge pull request #94526 from RandomShaper/wtp_rl_prize_prequel
Batch of fixes for WorkerThreadPool and ResourceLoader (safe set)
2024-07-19 11:11:03 +02:00
Rémi Verschelde
d9bfdfdd64
Merge pull request #94521 from jamie-pate/fix_92333
Fix dynamic-stack-buffer-overflow crash when executing random functions on random physics objects
2024-07-19 11:10:59 +02:00
Rémi Verschelde
cf9e485696
Merge pull request #94518 from bruvzg/mac_net_non_sandboxed_sign
[macOS] Fix codesigning of .NET helper executables when sandboxing is disabled.
2024-07-19 11:10:55 +02:00
Rémi Verschelde
2549205aa8
Merge pull request #94450 from jamie-pate/fix_94274
Fix crash when adding scenes with a group to the level scene
2024-07-19 11:10:51 +02:00
Rémi Verschelde
47e99d55b3
Merge pull request #94388 from BastiaanOlij/expose_more_methods_scene_buffers_rd
Expose more state in RenderSceneBuffersRD
2024-07-19 11:10:46 +02:00
Rémi Verschelde
edefcf6d1e
Merge pull request #94230 from CrazyRoka/optimize-gdscript-get-position
Optimize `Node::is_readable_from_caller_thread()` by prioritizing the most common case
2024-07-19 11:10:43 +02:00
Rémi Verschelde
f649112dfc
Merge pull request #94116 from bruvzg/ed_quit_unload
[Editor] Unload addons when using `--import` or `--quit`.
2024-07-19 11:10:37 +02:00
Rémi Verschelde
18da250ffb
Merge pull request #93737 from aitorciki/disable-windowed-gsync
[Windows] Disable G-SYNC in windowed mode
2024-07-19 11:10:31 +02:00
HolonProduction
f06504ca0b Add note about Script.has_source_code and GDScript binary tokenization 2024-07-19 10:38:55 +02:00
Pedro J. Estébanez
28a7a95531 ResourceLoader: Fix sync issues with error reporting
This is about not letting the resource format loader set the error code directly on the task anymore. Instead, it's stored locally and assigned only when it is right to do so.

Otherwise, other tasks may see an error code in the current one before it's state having transitioned to errored. While this, besides the technically true data race, may not be a problem in practice, it causes surprising situations during debugging as it breaks assumptions.
2024-07-19 10:00:41 +02:00
Jamie Pate
eb5f1299b2 Fix dynamic-stack-buffer-overflow crash when executing random functions on random physics objects
Fixes #92333

This looks correct, and fixes the ASAN assertion I'm currently getting
in my program.
2024-07-18 19:22:03 -07:00
Jamie Pate
8e1e0d4b42 Fix Crash when adding scenes with a group to the level scene
Fixes #94274
2024-07-18 17:02:39 -07:00
bruvzg
975ee76e2b
[macOS] Fix codesigning of .NET helper executables when sandboxing is disabled. 2024-07-18 23:40:49 +03:00
Adam Scott
b22783b9b3
Fix new stream types mix() not returning 0 when inactive 2024-07-18 11:18:38 -04:00
Rémi Verschelde
ff8a2780ee
Merge pull request #94506 from Jordyfel/handle-gltf-bin-missing
Fix handling of missing bin file in gltf separate
2024-07-18 15:38:32 +02:00
Rémi Verschelde
60966f5bcf
Merge pull request #94505 from mihe/speed-up-gdscript-shutdown
Speed up `GDScriptLanguage::finish`
2024-07-18 15:38:29 +02:00
Rémi Verschelde
caa1b6d991
Merge pull request #94498 from Chaosus/vs_fix_connection_bug
Fix internal connection count decreased if visual shader node removed
2024-07-18 15:38:27 +02:00
Rémi Verschelde
72e434bad4
Merge pull request #94497 from Chaosus/vs_rotation_by_axis
Few fixes for `VisualShaderNodeRotationByAxis`
2024-07-18 15:38:24 +02:00
Rémi Verschelde
fefd9537e6
Merge pull request #94424 from HolonProduction/completion-fix-depended-parsers
Autocompletion: Register depended parsers with the main parser
2024-07-18 15:38:20 +02:00
Rémi Verschelde
7d71b4be37
Merge pull request #94422 from m4gr3d/fix_input_locking_issue
Fix input lock issue when drag scrolling on a `Tree` element on touchscreen devices
2024-07-18 15:38:17 +02:00
Rémi Verschelde
1e81a946cc
Merge pull request #94412 from dsnopek/xr-always-render
Always render when XR is enabled, even if no OS windows can draw
2024-07-18 15:38:14 +02:00
Rémi Verschelde
d12030e6d7
Merge pull request #94365 from KoBeWi/every_single_time
Fix empty region in AtlasTexture
2024-07-18 15:38:11 +02:00