asgardius/virtualx-engine
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
virtualx-engine/scene/gui/line_edit.cpp

2717 lines
87 KiB
C++
Raw Normal View History

One Copyright Update to rule them all As many open source projects have started doing it, we're removing the current year from the copyright notice, so that we don't need to bump it every year. It seems like only the first year of publication is technically relevant for copyright notices, and even that seems to be something that many companies stopped listing altogether (in a version controlled codebase, the commits are a much better source of date of publication than a hardcoded copyright statement). We also now list Godot Engine contributors first as we're collectively the current maintainers of the project, and we clarify that the "exclusive" copyright of the co-founders covers the timespan before opensourcing (their further contributions are included as part of Godot Engine contributors). Also fixed "cf." Frenchism - it's meant as "refer to / see".
2023-01-05 13:25:55 +01:00
/**************************************************************************/
/* line_edit.cpp */
/**************************************************************************/
/* This file is part of: */
/* GODOT ENGINE */
/* https://godotengine.org */
/**************************************************************************/
/* Copyright (c) 2014-present Godot Engine contributors (see AUTHORS.md). */
/* Copyright (c) 2007-2014 Juan Linietsky, Ariel Manzur. */
/* */
/* Permission is hereby granted, free of charge, to any person obtaining */
/* a copy of this software and associated documentation files (the */
/* "Software"), to deal in the Software without restriction, including */
/* without limitation the rights to use, copy, modify, merge, publish, */
/* distribute, sublicense, and/or sell copies of the Software, and to */
/* permit persons to whom the Software is furnished to do so, subject to */
/* the following conditions: */
/* */
/* The above copyright notice and this permission notice shall be */
/* included in all copies or substantial portions of the Software. */
/* */
/* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, */
/* EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF */
/* MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. */
/* IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY */
/* CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, */
/* TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE */
/* SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE. */
/**************************************************************************/
Add missing copyright headers and fix formatting Using `misc/scripts/fix_headers.py` on all Godot files. Some missing header guards were added, and the header inclusion order was fixed in the Bullet module.
2018-01-05 00:50:27 +01:00
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
#include "line_edit.h"
Fix -Wimplicit-fallthrough warnings from GCC 8 Adds `FALLTHROUGH` macro to specify when a fallthrough is intentional. Can be replaced by `[[fallthrough]]` if/when we switch to C++17. The warning is now enabled by default for GCC on `extra` warnings level (part of GCC's `-Wextra`). It's not enabled in Clang's `-Wextra` yet, but we could enable it manually once we switch to C++11. There's no equivalent feature in MSVC for now. Fixes #26135.
2019-04-05 14:06:16 +02:00
Removed hardcoded shortcuts from /scene and converted to input actions This removes hardcoded actions from things like LineEdit and TextEdit. Previously, things like copy, paste, etc were all hardcoded to Ctrl+C, Ctrl+V, etc. They could not be changed. This allows the possibility of them being changed, by making them use the action map. This has the added benefit of greatly simplifying the input handling logic in those controls. The logic which was previously in a huge and hard to follow switch statement has been extracted to individual methods.
2020-12-07 12:32:00 +01:00
#include "core/input/input_map.h"
Make core/ includes absolute, remove subfolders from include path This allows more consistency in the manner we include core headers, where previously there would be a mix of absolute, relative and include path-dependent includes.
2018-09-11 18:13:45 +02:00
#include "core/os/keyboard.h"
#include "core/os/os.h"
Reorganized core/ directory, it was too fatty already -Removed FuncRef, since Callable makes it obsolete -Removed int_types.h as its obsolete in c++11+ -Changed color names code
2020-11-07 23:33:38 +01:00
#include "core/string/print_string.h"
#include "core/string/translation.h"
Register theme properties with ThemeDB
2023-09-08 21:00:10 +02:00
#include "scene/gui/label.h"
#include "scene/main/window.h"
#include "scene/theme/theme_db.h"
Effective DisplayServer separation, rename X11 -> LinuxBSD
2020-03-03 14:36:29 +01:00
#include "servers/display_server.h"
[Complex Text Layouts] Refactor Label and LineEdit controls.
2020-09-09 15:00:32 +02:00
#include "servers/text_server.h"
Register theme properties with ThemeDB
2023-09-08 21:00:10 +02:00
Added setting to toggle line edit caret blink
2016-06-21 15:38:35 +02:00
#ifdef TOOLS_ENABLED
Refactoring: rename tools/editor/ to editor/ The other subfolders of tools/ had already been moved to either editor/, misc/ or thirdparty/, so the hiding the editor code that deep was no longer meaningful.
2017-03-05 14:21:25 +01:00
#include "editor/editor_settings.h"
Added setting to toggle line edit caret blink
2016-06-21 15:38:35 +02:00
#endif
LineEdit: Word jumping and OSX hotkeys
2016-06-18 16:15:26 +02:00
Removed hardcoded shortcuts from /scene and converted to input actions This removes hardcoded actions from things like LineEdit and TextEdit. Previously, things like copy, paste, etc were all hardcoded to Ctrl+C, Ctrl+V, etc. They could not be changed. This allows the possibility of them being changed, by making them use the action map. This has the added benefit of greatly simplifying the input handling logic in those controls. The logic which was previously in a huge and hard to follow switch statement has been extracted to individual methods.
2020-12-07 12:32:00 +01:00
void LineEdit::_swap_current_input_direction() {
if (input_direction == TEXT_DIRECTION_LTR) {
input_direction = TEXT_DIRECTION_RTL;
} else {
input_direction = TEXT_DIRECTION_LTR;
}
Rename LineEdit caret_* properties getters and setters to match property
2021-03-28 20:31:25 +02:00
set_caret_column(get_caret_column());
Rename `CanvasItem.update()` to `queue_redraw()` Affects a lot of classes. Very thoroughly checked signal connections and deferred calls to this method, add_do_method/add_undo_method calls, and so on. Also renames the internal `_update_callback()` to `_redraw_callback()` for consistency. Just a few comments have also been changed to say "redraw". In CPUParticles2D, there was a private variable with the same name. It has been renamed to `do_redraw`.
2022-08-13 23:21:24 +02:00
queue_redraw();
Removed hardcoded shortcuts from /scene and converted to input actions This removes hardcoded actions from things like LineEdit and TextEdit. Previously, things like copy, paste, etc were all hardcoded to Ctrl+C, Ctrl+V, etc. They could not be changed. This allows the possibility of them being changed, by making them use the action map. This has the added benefit of greatly simplifying the input handling logic in those controls. The logic which was previously in a huge and hard to follow switch statement has been extracted to individual methods.
2020-12-07 12:32:00 +01:00
}
Rename LineEdit caret_* properties getters and setters to match property
2021-03-28 20:31:25 +02:00
void LineEdit::_move_caret_left(bool p_select, bool p_move_by_word) {
Removed hardcoded shortcuts from /scene and converted to input actions This removes hardcoded actions from things like LineEdit and TextEdit. Previously, things like copy, paste, etc were all hardcoded to Ctrl+C, Ctrl+V, etc. They could not be changed. This allows the possibility of them being changed, by making them use the action map. This has the added benefit of greatly simplifying the input handling logic in those controls. The logic which was previously in a huge and hard to follow switch statement has been extracted to individual methods.
2020-12-07 12:32:00 +01:00
if (selection.enabled && !p_select) {
Rename LineEdit caret_* properties getters and setters to match property
2021-03-28 20:31:25 +02:00
set_caret_column(selection.begin);
Removed hardcoded shortcuts from /scene and converted to input actions This removes hardcoded actions from things like LineEdit and TextEdit. Previously, things like copy, paste, etc were all hardcoded to Ctrl+C, Ctrl+V, etc. They could not be changed. This allows the possibility of them being changed, by making them use the action map. This has the added benefit of greatly simplifying the input handling logic in those controls. The logic which was previously in a huge and hard to follow switch statement has been extracted to individual methods.
2020-12-07 12:32:00 +01:00
deselect();
return;
}
shift_selection_check_pre(p_select);
if (p_move_by_word) {
Rename LineEdit caret_* properties getters and setters to match property
2021-03-28 20:31:25 +02:00
int cc = caret_column;
Removed hardcoded shortcuts from /scene and converted to input actions This removes hardcoded actions from things like LineEdit and TextEdit. Previously, things like copy, paste, etc were all hardcoded to Ctrl+C, Ctrl+V, etc. They could not be changed. This allows the possibility of them being changed, by making them use the action map. This has the added benefit of greatly simplifying the input handling logic in those controls. The logic which was previously in a huge and hard to follow switch statement has been extracted to individual methods.
2020-12-07 12:32:00 +01:00
Implement TextServer GDExtension interface, remove TextServer GDNative interface.
2021-08-27 23:19:51 +02:00
PackedInt32Array words = TS->shaped_text_get_word_breaks(text_rid);
for (int i = words.size() - 2; i >= 0; i = i - 2) {
if (words[i] < cc) {
cc = words[i];
Removed hardcoded shortcuts from /scene and converted to input actions This removes hardcoded actions from things like LineEdit and TextEdit. Previously, things like copy, paste, etc were all hardcoded to Ctrl+C, Ctrl+V, etc. They could not be changed. This allows the possibility of them being changed, by making them use the action map. This has the added benefit of greatly simplifying the input handling logic in those controls. The logic which was previously in a huge and hard to follow switch statement has been extracted to individual methods.
2020-12-07 12:32:00 +01:00
break;
}
}
Rename LineEdit caret_* properties getters and setters to match property
2021-03-28 20:31:25 +02:00
set_caret_column(cc);
Removed hardcoded shortcuts from /scene and converted to input actions This removes hardcoded actions from things like LineEdit and TextEdit. Previously, things like copy, paste, etc were all hardcoded to Ctrl+C, Ctrl+V, etc. They could not be changed. This allows the possibility of them being changed, by making them use the action map. This has the added benefit of greatly simplifying the input handling logic in those controls. The logic which was previously in a huge and hard to follow switch statement has been extracted to individual methods.
2020-12-07 12:32:00 +01:00
} else {
Rename LineEdit caret_* properties getters and setters to match property
2021-03-28 20:31:25 +02:00
if (caret_mid_grapheme_enabled) {
set_caret_column(get_caret_column() - 1);
Removed hardcoded shortcuts from /scene and converted to input actions This removes hardcoded actions from things like LineEdit and TextEdit. Previously, things like copy, paste, etc were all hardcoded to Ctrl+C, Ctrl+V, etc. They could not be changed. This allows the possibility of them being changed, by making them use the action map. This has the added benefit of greatly simplifying the input handling logic in those controls. The logic which was previously in a huge and hard to follow switch statement has been extracted to individual methods.
2020-12-07 12:32:00 +01:00
} else {
[TextServer] Fix system font fallback and caret/selection behavior for composite characters.
2023-08-15 10:42:40 +02:00
set_caret_column(TS->shaped_text_prev_character_pos(text_rid, get_caret_column()));
Removed hardcoded shortcuts from /scene and converted to input actions This removes hardcoded actions from things like LineEdit and TextEdit. Previously, things like copy, paste, etc were all hardcoded to Ctrl+C, Ctrl+V, etc. They could not be changed. This allows the possibility of them being changed, by making them use the action map. This has the added benefit of greatly simplifying the input handling logic in those controls. The logic which was previously in a huge and hard to follow switch statement has been extracted to individual methods.
2020-12-07 12:32:00 +01:00
}
}
shift_selection_check_post(p_select);
Always show caret when moving in LineEdit
2023-01-31 20:56:06 +01:00
_reset_caret_blink_timer();
Removed hardcoded shortcuts from /scene and converted to input actions This removes hardcoded actions from things like LineEdit and TextEdit. Previously, things like copy, paste, etc were all hardcoded to Ctrl+C, Ctrl+V, etc. They could not be changed. This allows the possibility of them being changed, by making them use the action map. This has the added benefit of greatly simplifying the input handling logic in those controls. The logic which was previously in a huge and hard to follow switch statement has been extracted to individual methods.
2020-12-07 12:32:00 +01:00
}
Rename LineEdit caret_* properties getters and setters to match property
2021-03-28 20:31:25 +02:00
void LineEdit::_move_caret_right(bool p_select, bool p_move_by_word) {
Removed hardcoded shortcuts from /scene and converted to input actions This removes hardcoded actions from things like LineEdit and TextEdit. Previously, things like copy, paste, etc were all hardcoded to Ctrl+C, Ctrl+V, etc. They could not be changed. This allows the possibility of them being changed, by making them use the action map. This has the added benefit of greatly simplifying the input handling logic in those controls. The logic which was previously in a huge and hard to follow switch statement has been extracted to individual methods.
2020-12-07 12:32:00 +01:00
if (selection.enabled && !p_select) {
Rename LineEdit caret_* properties getters and setters to match property
2021-03-28 20:31:25 +02:00
set_caret_column(selection.end);
Removed hardcoded shortcuts from /scene and converted to input actions This removes hardcoded actions from things like LineEdit and TextEdit. Previously, things like copy, paste, etc were all hardcoded to Ctrl+C, Ctrl+V, etc. They could not be changed. This allows the possibility of them being changed, by making them use the action map. This has the added benefit of greatly simplifying the input handling logic in those controls. The logic which was previously in a huge and hard to follow switch statement has been extracted to individual methods.
2020-12-07 12:32:00 +01:00
deselect();
return;
}
shift_selection_check_pre(p_select);
if (p_move_by_word) {
Rename LineEdit caret_* properties getters and setters to match property
2021-03-28 20:31:25 +02:00
int cc = caret_column;
Removed hardcoded shortcuts from /scene and converted to input actions This removes hardcoded actions from things like LineEdit and TextEdit. Previously, things like copy, paste, etc were all hardcoded to Ctrl+C, Ctrl+V, etc. They could not be changed. This allows the possibility of them being changed, by making them use the action map. This has the added benefit of greatly simplifying the input handling logic in those controls. The logic which was previously in a huge and hard to follow switch statement has been extracted to individual methods.
2020-12-07 12:32:00 +01:00
Implement TextServer GDExtension interface, remove TextServer GDNative interface.
2021-08-27 23:19:51 +02:00
PackedInt32Array words = TS->shaped_text_get_word_breaks(text_rid);
for (int i = 1; i < words.size(); i = i + 2) {
if (words[i] > cc) {
cc = words[i];
Removed hardcoded shortcuts from /scene and converted to input actions This removes hardcoded actions from things like LineEdit and TextEdit. Previously, things like copy, paste, etc were all hardcoded to Ctrl+C, Ctrl+V, etc. They could not be changed. This allows the possibility of them being changed, by making them use the action map. This has the added benefit of greatly simplifying the input handling logic in those controls. The logic which was previously in a huge and hard to follow switch statement has been extracted to individual methods.
2020-12-07 12:32:00 +01:00
break;
}
}
Rename LineEdit caret_* properties getters and setters to match property
2021-03-28 20:31:25 +02:00
set_caret_column(cc);
Removed hardcoded shortcuts from /scene and converted to input actions This removes hardcoded actions from things like LineEdit and TextEdit. Previously, things like copy, paste, etc were all hardcoded to Ctrl+C, Ctrl+V, etc. They could not be changed. This allows the possibility of them being changed, by making them use the action map. This has the added benefit of greatly simplifying the input handling logic in those controls. The logic which was previously in a huge and hard to follow switch statement has been extracted to individual methods.
2020-12-07 12:32:00 +01:00
} else {
Rename LineEdit caret_* properties getters and setters to match property
2021-03-28 20:31:25 +02:00
if (caret_mid_grapheme_enabled) {
set_caret_column(get_caret_column() + 1);
Removed hardcoded shortcuts from /scene and converted to input actions This removes hardcoded actions from things like LineEdit and TextEdit. Previously, things like copy, paste, etc were all hardcoded to Ctrl+C, Ctrl+V, etc. They could not be changed. This allows the possibility of them being changed, by making them use the action map. This has the added benefit of greatly simplifying the input handling logic in those controls. The logic which was previously in a huge and hard to follow switch statement has been extracted to individual methods.
2020-12-07 12:32:00 +01:00
} else {
[TextServer] Fix system font fallback and caret/selection behavior for composite characters.
2023-08-15 10:42:40 +02:00
set_caret_column(TS->shaped_text_next_character_pos(text_rid, get_caret_column()));
Removed hardcoded shortcuts from /scene and converted to input actions This removes hardcoded actions from things like LineEdit and TextEdit. Previously, things like copy, paste, etc were all hardcoded to Ctrl+C, Ctrl+V, etc. They could not be changed. This allows the possibility of them being changed, by making them use the action map. This has the added benefit of greatly simplifying the input handling logic in those controls. The logic which was previously in a huge and hard to follow switch statement has been extracted to individual methods.
2020-12-07 12:32:00 +01:00
}
}
shift_selection_check_post(p_select);
Always show caret when moving in LineEdit
2023-01-31 20:56:06 +01:00
_reset_caret_blink_timer();
Removed hardcoded shortcuts from /scene and converted to input actions This removes hardcoded actions from things like LineEdit and TextEdit. Previously, things like copy, paste, etc were all hardcoded to Ctrl+C, Ctrl+V, etc. They could not be changed. This allows the possibility of them being changed, by making them use the action map. This has the added benefit of greatly simplifying the input handling logic in those controls. The logic which was previously in a huge and hard to follow switch statement has been extracted to individual methods.
2020-12-07 12:32:00 +01:00
}
Rename LineEdit caret_* properties getters and setters to match property
2021-03-28 20:31:25 +02:00
void LineEdit::_move_caret_start(bool p_select) {
Removed hardcoded shortcuts from /scene and converted to input actions This removes hardcoded actions from things like LineEdit and TextEdit. Previously, things like copy, paste, etc were all hardcoded to Ctrl+C, Ctrl+V, etc. They could not be changed. This allows the possibility of them being changed, by making them use the action map. This has the added benefit of greatly simplifying the input handling logic in those controls. The logic which was previously in a huge and hard to follow switch statement has been extracted to individual methods.
2020-12-07 12:32:00 +01:00
shift_selection_check_pre(p_select);
Rename LineEdit caret_* properties getters and setters to match property
2021-03-28 20:31:25 +02:00
set_caret_column(0);
Removed hardcoded shortcuts from /scene and converted to input actions This removes hardcoded actions from things like LineEdit and TextEdit. Previously, things like copy, paste, etc were all hardcoded to Ctrl+C, Ctrl+V, etc. They could not be changed. This allows the possibility of them being changed, by making them use the action map. This has the added benefit of greatly simplifying the input handling logic in those controls. The logic which was previously in a huge and hard to follow switch statement has been extracted to individual methods.
2020-12-07 12:32:00 +01:00
shift_selection_check_post(p_select);
}
Rename LineEdit caret_* properties getters and setters to match property
2021-03-28 20:31:25 +02:00
void LineEdit::_move_caret_end(bool p_select) {
Removed hardcoded shortcuts from /scene and converted to input actions This removes hardcoded actions from things like LineEdit and TextEdit. Previously, things like copy, paste, etc were all hardcoded to Ctrl+C, Ctrl+V, etc. They could not be changed. This allows the possibility of them being changed, by making them use the action map. This has the added benefit of greatly simplifying the input handling logic in those controls. The logic which was previously in a huge and hard to follow switch statement has been extracted to individual methods.
2020-12-07 12:32:00 +01:00
shift_selection_check_pre(p_select);
Rename LineEdit caret_* properties getters and setters to match property
2021-03-28 20:31:25 +02:00
set_caret_column(text.length());
Removed hardcoded shortcuts from /scene and converted to input actions This removes hardcoded actions from things like LineEdit and TextEdit. Previously, things like copy, paste, etc were all hardcoded to Ctrl+C, Ctrl+V, etc. They could not be changed. This allows the possibility of them being changed, by making them use the action map. This has the added benefit of greatly simplifying the input handling logic in those controls. The logic which was previously in a huge and hard to follow switch statement has been extracted to individual methods.
2020-12-07 12:32:00 +01:00
shift_selection_check_post(p_select);
}
void LineEdit::_backspace(bool p_word, bool p_all_to_left) {
if (!editable) {
return;
}
Fix `LineEdit` delete all the way to the left/right when something is selected
2024-02-18 08:58:37 +01:00
if (selection.enabled) {
selection_delete();
return;
}
if (caret_column == 0) {
return; // Nothing to do.
}
Removed hardcoded shortcuts from /scene and converted to input actions This removes hardcoded actions from things like LineEdit and TextEdit. Previously, things like copy, paste, etc were all hardcoded to Ctrl+C, Ctrl+V, etc. They could not be changed. This allows the possibility of them being changed, by making them use the action map. This has the added benefit of greatly simplifying the input handling logic in those controls. The logic which was previously in a huge and hard to follow switch statement has been extracted to individual methods.
2020-12-07 12:32:00 +01:00
if (p_all_to_left) {
Fix LineEdit behavior for deleting all the way to the left/right
2024-02-07 13:11:48 +01:00
text = text.substr(caret_column);
_shape();
set_caret_column(0);
Removed hardcoded shortcuts from /scene and converted to input actions This removes hardcoded actions from things like LineEdit and TextEdit. Previously, things like copy, paste, etc were all hardcoded to Ctrl+C, Ctrl+V, etc. They could not be changed. This allows the possibility of them being changed, by making them use the action map. This has the added benefit of greatly simplifying the input handling logic in those controls. The logic which was previously in a huge and hard to follow switch statement has been extracted to individual methods.
2020-12-07 12:32:00 +01:00
_text_changed();
return;
}
if (p_word) {
Rename LineEdit caret_* properties getters and setters to match property
2021-03-28 20:31:25 +02:00
int cc = caret_column;
Removed hardcoded shortcuts from /scene and converted to input actions This removes hardcoded actions from things like LineEdit and TextEdit. Previously, things like copy, paste, etc were all hardcoded to Ctrl+C, Ctrl+V, etc. They could not be changed. This allows the possibility of them being changed, by making them use the action map. This has the added benefit of greatly simplifying the input handling logic in those controls. The logic which was previously in a huge and hard to follow switch statement has been extracted to individual methods.
2020-12-07 12:32:00 +01:00
Implement TextServer GDExtension interface, remove TextServer GDNative interface.
2021-08-27 23:19:51 +02:00
PackedInt32Array words = TS->shaped_text_get_word_breaks(text_rid);
for (int i = words.size() - 2; i >= 0; i = i - 2) {
if (words[i] < cc) {
cc = words[i];
Fixed issues with LineEdit Delete Word & Backspace Word. Backspace word was deleting all text before the cursor, and delete word was no updating until another action was performed on the LineEdit (in order to update it)
2021-04-03 13:23:18 +02:00
break;
Removed hardcoded shortcuts from /scene and converted to input actions This removes hardcoded actions from things like LineEdit and TextEdit. Previously, things like copy, paste, etc were all hardcoded to Ctrl+C, Ctrl+V, etc. They could not be changed. This allows the possibility of them being changed, by making them use the action map. This has the added benefit of greatly simplifying the input handling logic in those controls. The logic which was previously in a huge and hard to follow switch statement has been extracted to individual methods.
2020-12-07 12:32:00 +01:00
}
}
Rename LineEdit caret_* properties getters and setters to match property
2021-03-28 20:31:25 +02:00
delete_text(cc, caret_column);
Removed hardcoded shortcuts from /scene and converted to input actions This removes hardcoded actions from things like LineEdit and TextEdit. Previously, things like copy, paste, etc were all hardcoded to Ctrl+C, Ctrl+V, etc. They could not be changed. This allows the possibility of them being changed, by making them use the action map. This has the added benefit of greatly simplifying the input handling logic in those controls. The logic which was previously in a huge and hard to follow switch statement has been extracted to individual methods.
2020-12-07 12:32:00 +01:00
Rename LineEdit caret_* properties getters and setters to match property
2021-03-28 20:31:25 +02:00
set_caret_column(cc);
Removed hardcoded shortcuts from /scene and converted to input actions This removes hardcoded actions from things like LineEdit and TextEdit. Previously, things like copy, paste, etc were all hardcoded to Ctrl+C, Ctrl+V, etc. They could not be changed. This allows the possibility of them being changed, by making them use the action map. This has the added benefit of greatly simplifying the input handling logic in those controls. The logic which was previously in a huge and hard to follow switch statement has been extracted to individual methods.
2020-12-07 12:32:00 +01:00
} else {
delete_char();
}
}
void LineEdit::_delete(bool p_word, bool p_all_to_right) {
if (!editable) {
return;
}
if (selection.enabled) {
selection_delete();
return;
}
Fix `LineEdit` delete all the way to the left/right when something is selected
2024-02-18 08:58:37 +01:00
if (caret_column == text.length()) {
Removed hardcoded shortcuts from /scene and converted to input actions This removes hardcoded actions from things like LineEdit and TextEdit. Previously, things like copy, paste, etc were all hardcoded to Ctrl+C, Ctrl+V, etc. They could not be changed. This allows the possibility of them being changed, by making them use the action map. This has the added benefit of greatly simplifying the input handling logic in those controls. The logic which was previously in a huge and hard to follow switch statement has been extracted to individual methods.
2020-12-07 12:32:00 +01:00
return; // Nothing to do.
}
Fix `LineEdit` delete all the way to the left/right when something is selected
2024-02-18 08:58:37 +01:00
if (p_all_to_right) {
text = text.substr(0, caret_column);
_shape();
_text_changed();
return;
}
Removed hardcoded shortcuts from /scene and converted to input actions This removes hardcoded actions from things like LineEdit and TextEdit. Previously, things like copy, paste, etc were all hardcoded to Ctrl+C, Ctrl+V, etc. They could not be changed. This allows the possibility of them being changed, by making them use the action map. This has the added benefit of greatly simplifying the input handling logic in those controls. The logic which was previously in a huge and hard to follow switch statement has been extracted to individual methods.
2020-12-07 12:32:00 +01:00
if (p_word) {
Rename LineEdit caret_* properties getters and setters to match property
2021-03-28 20:31:25 +02:00
int cc = caret_column;
Implement TextServer GDExtension interface, remove TextServer GDNative interface.
2021-08-27 23:19:51 +02:00
PackedInt32Array words = TS->shaped_text_get_word_breaks(text_rid);
for (int i = 1; i < words.size(); i = i + 2) {
if (words[i] > cc) {
cc = words[i];
Removed hardcoded shortcuts from /scene and converted to input actions This removes hardcoded actions from things like LineEdit and TextEdit. Previously, things like copy, paste, etc were all hardcoded to Ctrl+C, Ctrl+V, etc. They could not be changed. This allows the possibility of them being changed, by making them use the action map. This has the added benefit of greatly simplifying the input handling logic in those controls. The logic which was previously in a huge and hard to follow switch statement has been extracted to individual methods.
2020-12-07 12:32:00 +01:00
break;
}
}
Rename LineEdit caret_* properties getters and setters to match property
2021-03-28 20:31:25 +02:00
delete_text(caret_column, cc);
Fixed issues with LineEdit Delete Word & Backspace Word. Backspace word was deleting all text before the cursor, and delete word was no updating until another action was performed on the LineEdit (in order to update it)
2021-04-03 13:23:18 +02:00
set_caret_column(caret_column);
Removed hardcoded shortcuts from /scene and converted to input actions This removes hardcoded actions from things like LineEdit and TextEdit. Previously, things like copy, paste, etc were all hardcoded to Ctrl+C, Ctrl+V, etc. They could not be changed. This allows the possibility of them being changed, by making them use the action map. This has the added benefit of greatly simplifying the input handling logic in those controls. The logic which was previously in a huge and hard to follow switch statement has been extracted to individual methods.
2020-12-07 12:32:00 +01:00
} else {
Rename LineEdit caret_* properties getters and setters to match property
2021-03-28 20:31:25 +02:00
if (caret_mid_grapheme_enabled) {
set_caret_column(caret_column + 1);
Removed hardcoded shortcuts from /scene and converted to input actions This removes hardcoded actions from things like LineEdit and TextEdit. Previously, things like copy, paste, etc were all hardcoded to Ctrl+C, Ctrl+V, etc. They could not be changed. This allows the possibility of them being changed, by making them use the action map. This has the added benefit of greatly simplifying the input handling logic in those controls. The logic which was previously in a huge and hard to follow switch statement has been extracted to individual methods.
2020-12-07 12:32:00 +01:00
delete_char();
} else {
Rename LineEdit caret_* properties getters and setters to match property
2021-03-28 20:31:25 +02:00
int cc = caret_column;
[TextServer] Fix system font fallback and caret/selection behavior for composite characters.
2023-08-15 10:42:40 +02:00
set_caret_column(TS->shaped_text_next_character_pos(text_rid, caret_column));
Rename LineEdit caret_* properties getters and setters to match property
2021-03-28 20:31:25 +02:00
delete_text(cc, caret_column);
Removed hardcoded shortcuts from /scene and converted to input actions This removes hardcoded actions from things like LineEdit and TextEdit. Previously, things like copy, paste, etc were all hardcoded to Ctrl+C, Ctrl+V, etc. They could not be changed. This allows the possibility of them being changed, by making them use the action map. This has the added benefit of greatly simplifying the input handling logic in those controls. The logic which was previously in a huge and hard to follow switch statement has been extracted to individual methods.
2020-12-07 12:32:00 +01:00
}
}
}
[Input] Add extra `shortcut_input` input processing step to process Unicode character input with Alt / Ctrl modifiers, after processing of shortcuts.
2022-01-11 14:59:52 +01:00
void LineEdit::unhandled_key_input(const Ref<InputEvent> &p_event) {
Ref<InputEventKey> k = p_event;
if (k.is_valid()) {
if (!k->is_pressed()) {
return;
}
// Handle Unicode (with modifiers active, process after shortcuts).
if (has_focus() && editable && (k->get_unicode() >= 32)) {
selection_delete();
char32_t ucodestr[2] = { (char32_t)k->get_unicode(), 0 };
int prev_len = text.length();
insert_text_at_caret(ucodestr);
if (text.length() != prev_len) {
_text_changed();
}
accept_event();
}
}
}
Entirely removes BIND_VMETHOD in favor of GDVIRTUAL * `_gui_input`, `_input`, `_unhandled_input` and `_unhandled_key_input` are now regular C++ virutal functions. * Everything else converted to GDVIRTUAL * BIND_VMETHOD is gone, always use the new syntax from now on. Creating `_gui_input` method and using the binder to register events will no longer work, simply override the virtual function now.
2021-08-22 17:37:22 +02:00
void LineEdit::gui_input(const Ref<InputEvent> &p_event) {
Fix crashes in *_input functions
2021-04-05 08:52:21 +02:00
ERR_FAIL_COND(p_event.is_null());
Removal of InputEvent as built-in Variant type.. this might cause bugs I haven't found yet..
2017-05-20 17:38:03 +02:00
Ref<InputEventMouseButton> b = p_event;
remove trailing whitespace
2016-03-09 00:00:52 +01:00
Removal of InputEvent as built-in Variant type.. this might cause bugs I haven't found yet..
2017-05-20 17:38:03 +02:00
if (b.is_valid()) {
[Complex Text Layouts] Refactor Label and LineEdit controls.
2020-09-09 15:00:32 +02:00
if (ime_text.length() != 0) {
// Ignore mouse clicks in IME input mode.
return;
}
Use "enum class" for input enums
2021-08-13 23:31:57 +02:00
if (b->is_pressed() && b->get_button_index() == MouseButton::RIGHT && context_menu_enabled) {
Fix `LineEdit` and `TextEdit` context menus not customizable
2023-01-26 18:59:41 +01:00
_update_context_menu();
Fix bad popups offset in editor with single window off Co-authored-by: Gil Arasa Verge <gilarasaverge@gmail.com> Co-authored-by: Tomasz Chabora <kobewi4e@gmail.com>
2021-08-31 17:43:35 +02:00
menu->set_position(get_screen_position() + get_local_mouse_position());
Added `reset_size` method to `Control` and `Window` classes
2021-11-20 09:04:57 +01:00
menu->reset_size();
Removal of InputEvent as built-in Variant type.. this might cause bugs I haven't found yet..
2017-05-20 17:38:03 +02:00
menu->popup();
grab_focus();
Accept also right-click event in LineEdit
2019-08-04 15:35:50 +02:00
accept_event();
Removal of InputEvent as built-in Variant type.. this might cause bugs I haven't found yet..
2017-05-20 17:38:03 +02:00
return;
}
Default editing popup for LineEdit and TextEdit
2016-05-17 01:25:17 +02:00
Use "enum class" for input enums
2021-08-13 23:31:57 +02:00
if (is_middle_mouse_paste_enabled() && b->is_pressed() && b->get_button_index() == MouseButton::MIDDLE && is_editable() && DisplayServer::get_singleton()->has_feature(DisplayServer::FEATURE_CLIPBOARD_PRIMARY)) {
Added primary clipboard for Linux
2021-10-12 09:43:50 +02:00
String paste_buffer = DisplayServer::get_singleton()->clipboard_get_primary().strip_escapes();
deselect();
set_caret_at_pixel_pos(b->get_position().x);
if (!paste_buffer.is_empty()) {
insert_text_at_caret(paste_buffer);
if (!text_changed_dirty) {
if (is_inside_tree()) {
Update deferred calls to use Callables
2023-12-18 15:46:56 +01:00
callable_mp(this, &LineEdit::_text_changed).call_deferred();
Added primary clipboard for Linux
2021-10-12 09:43:50 +02:00
}
text_changed_dirty = true;
}
}
grab_focus();
Fix LineEdit not consuming events The most important issue is LineEdit not consuming "ui_text_submit" event which makes pressing Enter after editing escape to other components causing unwanted interactions. Also fix handling mouse button interactions not consuming some events. Also implement early return in case we know which event type it is and there is no point in checking other event types. PS I'm also suspicious that mouse motion events also need to be consumed, but haven't explored those cases.
2023-01-30 14:03:34 +01:00
accept_event();
Added primary clipboard for Linux
2021-10-12 09:43:50 +02:00
return;
}
Use "enum class" for input enums
2021-08-13 23:31:57 +02:00
if (b->get_button_index() != MouseButton::LEFT) {
Removal of InputEvent as built-in Variant type.. this might cause bugs I haven't found yet..
2017-05-20 17:38:03 +02:00
return;
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
}
remove trailing whitespace
2016-03-09 00:00:52 +01:00
Removal of InputEvent as built-in Variant type.. this might cause bugs I haven't found yet..
2017-05-20 17:38:03 +02:00
_reset_caret_blink_timer();
if (b->is_pressed()) {
Code style improvements to text_edit and related
2023-03-08 23:00:27 +01:00
accept_event(); // Don't pass event further when clicked on text field.
Rename empty() to is_empty()
2020-12-15 13:04:21 +01:00
if (!text.is_empty() && is_editable() && _is_over_clear_button(b->get_position())) {
Add clear text button to LineEdit - Add pressed state to clear button - Enable clear button on all inputs with search icon - Remove duplicate clear buttons - Fix rendering of icon for center and right alignments - Add clear button to more search fields - Add clear icon to default theme - Add method to control enabled state of clear button - Add property to enable clear button from inspector
2018-07-26 13:45:38 +02:00
clear_button_status.press_attempt = true;
clear_button_status.pressing_inside = true;
Rename `CanvasItem.update()` to `queue_redraw()` Affects a lot of classes. Very thoroughly checked signal connections and deferred calls to this method, add_do_method/add_undo_method calls, and so on. Also renames the internal `_update_callback()` to `_redraw_callback()` for consistency. Just a few comments have also been changed to say "redraw". In CPUParticles2D, there was a private variable with the same name. It has been renamed to `do_redraw`.
2022-08-13 23:21:24 +02:00
queue_redraw();
Add clear text button to LineEdit - Add pressed state to clear button - Enable clear button on all inputs with search icon - Remove duplicate clear buttons - Fix rendering of icon for center and right alignments - Add clear button to more search fields - Add clear icon to default theme - Add method to control enabled state of clear button - Add property to enable clear button from inspector
2018-07-26 13:45:38 +02:00
return;
}
Fix drag and drop on LineEdit
2021-10-28 09:07:18 +02:00
if (b->is_shift_pressed()) {
shift_selection_check_pre(true);
}
LineEdit: Fix and improve selection behaviour
2016-06-18 16:14:43 +02:00
Rename LineEdit caret_* properties getters and setters to match property
2021-03-28 20:31:25 +02:00
set_caret_at_pixel_pos(b->get_position().x);
remove trailing whitespace
2016-03-09 00:00:52 +01:00
Rename "Control" key to "Ctrl" and add "_pressed" suffix to all InputEventWithModifiers properties/methods
2021-04-24 22:33:50 +02:00
if (b->is_shift_pressed()) {
Rename LineEdit caret_* properties getters and setters to match property
2021-03-28 20:31:25 +02:00
selection_fill_at_caret();
Removal of InputEvent as built-in Variant type.. this might cause bugs I haven't found yet..
2017-05-20 17:38:03 +02:00
selection.creating = true;
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
Removal of InputEvent as built-in Variant type.. this might cause bugs I haven't found yet..
2017-05-20 17:38:03 +02:00
} else {
LineEdit: Now double click to select a word, and triple click to select all the content using the new TextServer TextEdit: Update the method to search words with the new TextServer
2021-02-28 20:52:04 +01:00
if (selecting_enabled) {
Fix LineEdit and TextEdit double-click and triple-click selection
2021-09-23 18:54:14 +02:00
const int triple_click_timeout = 600;
const int triple_click_tolerance = 5;
const bool is_triple_click = !b->is_double_click() && (OS::get_singleton()->get_ticks_msec() - last_dblclk) < triple_click_timeout && b->get_position().distance_to(last_dblclk_pos) < triple_click_tolerance;
if (is_triple_click && text.length()) {
LineEdit: Now double click to select a word, and triple click to select all the content using the new TextServer TextEdit: Update the method to search words with the new TextServer
2021-02-28 20:52:04 +01:00
// Triple-click select all.
selection.enabled = true;
selection.begin = 0;
selection.end = text.length();
Rename `doubleclick` to `double_click`
2021-04-13 10:25:44 +02:00
selection.double_click = true;
Fix LineEdit and TextEdit double-click and triple-click selection
2021-09-23 18:54:14 +02:00
last_dblclk = 0;
Fix setting line edit caret after dobule and triple click
2022-06-10 00:02:48 +02:00
set_caret_column(selection.begin);
Fix primary clipboard warning
2021-10-20 21:25:09 +02:00
if (!pass && DisplayServer::get_singleton()->has_feature(DisplayServer::FEATURE_CLIPBOARD_PRIMARY)) {
Added primary clipboard for Linux
2021-10-12 09:43:50 +02:00
DisplayServer::get_singleton()->clipboard_set_primary(text);
}
Rename `doubleclick` to `double_click`
2021-04-13 10:25:44 +02:00
} else if (b->is_double_click()) {
LineEdit: Now double click to select a word, and triple click to select all the content using the new TextServer TextEdit: Update the method to search words with the new TextServer
2021-02-28 20:52:04 +01:00
// Double-click select word.
Fix LineEdit and TextEdit double-click and triple-click selection
2021-09-23 18:54:14 +02:00
last_dblclk = OS::get_singleton()->get_ticks_msec();
last_dblclk_pos = b->get_position();
Implement TextServer GDExtension interface, remove TextServer GDNative interface.
2021-08-27 23:19:51 +02:00
PackedInt32Array words = TS->shaped_text_get_word_breaks(text_rid);
for (int i = 0; i < words.size(); i = i + 2) {
if ((words[i] < caret_column && words[i + 1] > caret_column) || (i == words.size() - 2 && caret_column == words[i + 1])) {
LineEdit: Now double click to select a word, and triple click to select all the content using the new TextServer TextEdit: Update the method to search words with the new TextServer
2021-02-28 20:52:04 +01:00
selection.enabled = true;
Implement TextServer GDExtension interface, remove TextServer GDNative interface.
2021-08-27 23:19:51 +02:00
selection.begin = words[i];
selection.end = words[i + 1];
Rename `doubleclick` to `double_click`
2021-04-13 10:25:44 +02:00
selection.double_click = true;
Fix setting line edit caret after dobule and triple click
2022-06-10 00:02:48 +02:00
set_caret_column(selection.end);
LineEdit: Now double click to select a word, and triple click to select all the content using the new TextServer TextEdit: Update the method to search words with the new TextServer
2021-02-28 20:52:04 +01:00
break;
}
}
Fix primary clipboard warning
2021-10-20 21:25:09 +02:00
if (!pass && DisplayServer::get_singleton()->has_feature(DisplayServer::FEATURE_CLIPBOARD_PRIMARY)) {
Implement LineEdit.get_selected_text()
2023-03-30 17:07:28 +02:00
DisplayServer::get_singleton()->clipboard_set_primary(get_selected_text());
Added primary clipboard for Linux
2021-10-12 09:43:50 +02:00
}
LineEdit: Now double click to select a word, and triple click to select all the content using the new TextServer TextEdit: Update the method to search words with the new TextServer
2021-02-28 20:52:04 +01:00
}
Removal of InputEvent as built-in Variant type.. this might cause bugs I haven't found yet..
2017-05-20 17:38:03 +02:00
}
LineEdit: Fix and improve selection behaviour
2016-06-18 16:14:43 +02:00
Removal of InputEvent as built-in Variant type.. this might cause bugs I haven't found yet..
2017-05-20 17:38:03 +02:00
selection.drag_attempt = false;
Add drag and drop option for line edit and rich text label
2023-07-17 02:32:00 +02:00
if (!selection.double_click) {
bool is_inside_sel = selection.enabled && caret_column >= selection.begin && caret_column <= selection.end;
if (drag_and_drop_selection_enabled && is_inside_sel) {
selection.drag_attempt = true;
} else {
deselect();
selection.start_column = caret_column;
selection.creating = true;
}
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
}
Removal of InputEvent as built-in Variant type.. this might cause bugs I haven't found yet..
2017-05-20 17:38:03 +02:00
}
remove trailing whitespace
2016-03-09 00:00:52 +01:00
Rename `CanvasItem.update()` to `queue_redraw()` Affects a lot of classes. Very thoroughly checked signal connections and deferred calls to this method, add_do_method/add_undo_method calls, and so on. Also renames the internal `_update_callback()` to `_redraw_callback()` for consistency. Just a few comments have also been changed to say "redraw". In CPUParticles2D, there was a private variable with the same name. It has been renamed to `do_redraw`.
2022-08-13 23:21:24 +02:00
queue_redraw();
remove trailing whitespace
2016-03-09 00:00:52 +01:00
Removal of InputEvent as built-in Variant type.. this might cause bugs I haven't found yet..
2017-05-20 17:38:03 +02:00
} else {
Use "enum class" for input enums
2021-08-13 23:31:57 +02:00
if (selection.enabled && !pass && b->get_button_index() == MouseButton::LEFT && DisplayServer::get_singleton()->has_feature(DisplayServer::FEATURE_CLIPBOARD_PRIMARY)) {
Implement LineEdit.get_selected_text()
2023-03-30 17:07:28 +02:00
DisplayServer::get_singleton()->clipboard_set_primary(get_selected_text());
Added primary clipboard for Linux
2021-10-12 09:43:50 +02:00
}
Rename empty() to is_empty()
2020-12-15 13:04:21 +01:00
if (!text.is_empty() && is_editable() && clear_button_enabled) {
Add clear text button to LineEdit - Add pressed state to clear button - Enable clear button on all inputs with search icon - Remove duplicate clear buttons - Fix rendering of icon for center and right alignments - Add clear button to more search fields - Add clear icon to default theme - Add method to control enabled state of clear button - Add property to enable clear button from inspector
2018-07-26 13:45:38 +02:00
bool press_attempt = clear_button_status.press_attempt;
clear_button_status.press_attempt = false;
if (press_attempt && clear_button_status.pressing_inside && _is_over_clear_button(b->get_position())) {
clear();
return;
}
}
Rename `doubleclick` to `double_click`
2021-04-13 10:25:44 +02:00
if ((!selection.creating) && (!selection.double_click)) {
Exposed LineEdit's "selection_clear" and renamed it to "deselect".
2017-12-17 18:40:44 +01:00
deselect();
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
}
Removal of InputEvent as built-in Variant type.. this might cause bugs I haven't found yet..
2017-05-20 17:38:03 +02:00
selection.creating = false;
Rename `doubleclick` to `double_click`
2021-04-13 10:25:44 +02:00
selection.double_click = false;
Fix drag and drop on LineEdit
2021-10-28 09:07:18 +02:00
if (!drag_action) {
selection.drag_attempt = false;
}
remove trailing whitespace
2016-03-09 00:00:52 +01:00
Allow selecting SpinBox & LineEdit text when focus enters
2022-10-16 14:37:35 +02:00
if (pending_select_all_on_focus) {
select_all();
pending_select_all_on_focus = false;
}
[GUI] Enforce virtual keyboard redisplay on clear
2021-01-18 18:08:42 +01:00
show_virtual_keyboard();
Removal of InputEvent as built-in Variant type.. this might cause bugs I haven't found yet..
2017-05-20 17:38:03 +02:00
}
remove trailing whitespace
2016-03-09 00:00:52 +01:00
Rename `CanvasItem.update()` to `queue_redraw()` Affects a lot of classes. Very thoroughly checked signal connections and deferred calls to this method, add_do_method/add_undo_method calls, and so on. Also renames the internal `_update_callback()` to `_redraw_callback()` for consistency. Just a few comments have also been changed to say "redraw". In CPUParticles2D, there was a private variable with the same name. It has been renamed to `do_redraw`.
2022-08-13 23:21:24 +02:00
queue_redraw();
Fix LineEdit not consuming events The most important issue is LineEdit not consuming "ui_text_submit" event which makes pressing Enter after editing escape to other components causing unwanted interactions. Also fix handling mouse button interactions not consuming some events. Also implement early return in case we know which event type it is and there is no point in checking other event types. PS I'm also suspicious that mouse motion events also need to be consumed, but haven't explored those cases.
2023-01-30 14:03:34 +01:00
return;
Removal of InputEvent as built-in Variant type.. this might cause bugs I haven't found yet..
2017-05-20 17:38:03 +02:00
}
remove trailing whitespace
2016-03-09 00:00:52 +01:00
Removal of InputEvent as built-in Variant type.. this might cause bugs I haven't found yet..
2017-05-20 17:38:03 +02:00
Ref<InputEventMouseMotion> m = p_event;
remove trailing whitespace
2016-03-09 00:00:52 +01:00
Removal of InputEvent as built-in Variant type.. this might cause bugs I haven't found yet..
2017-05-20 17:38:03 +02:00
if (m.is_valid()) {
Rename empty() to is_empty()
2020-12-15 13:04:21 +01:00
if (!text.is_empty() && is_editable() && clear_button_enabled) {
Add clear text button to LineEdit - Add pressed state to clear button - Enable clear button on all inputs with search icon - Remove duplicate clear buttons - Fix rendering of icon for center and right alignments - Add clear button to more search fields - Add clear icon to default theme - Add method to control enabled state of clear button - Add property to enable clear button from inspector
2018-07-26 13:45:38 +02:00
bool last_press_inside = clear_button_status.pressing_inside;
clear_button_status.pressing_inside = clear_button_status.press_attempt && _is_over_clear_button(m->get_position());
if (last_press_inside != clear_button_status.pressing_inside) {
Rename `CanvasItem.update()` to `queue_redraw()` Affects a lot of classes. Very thoroughly checked signal connections and deferred calls to this method, add_do_method/add_undo_method calls, and so on. Also renames the internal `_update_callback()` to `_redraw_callback()` for consistency. Just a few comments have also been changed to say "redraw". In CPUParticles2D, there was a private variable with the same name. It has been renamed to `do_redraw`.
2022-08-13 23:21:24 +02:00
queue_redraw();
Add clear text button to LineEdit - Add pressed state to clear button - Enable clear button on all inputs with search icon - Remove duplicate clear buttons - Fix rendering of icon for center and right alignments - Add clear button to more search fields - Add clear icon to default theme - Add method to control enabled state of clear button - Add property to enable clear button from inspector
2018-07-26 13:45:38 +02:00
}
}
Use BitField<> in core type masks * All core types masks are now correctly marked as bitfields. * The enum hacks in MouseButtonMask and many other types are gone. This ensures that binders to other languages non C++ can actually implement type safe bitmasks. * Most bitmask operations replaced by functions in BitField<> * Key is still a problem because its enum and mask at the same time. While it kind of works in C++, this most likely can't be implemented safely in other languages and will have to be changed at some point. Mostly left as-is. * Documentation and API dump updated to reflect bitfields in core types.
2023-01-08 00:55:54 +01:00
if (m->get_button_mask().has_flag(MouseButtonMask::LEFT)) {
Removal of InputEvent as built-in Variant type.. this might cause bugs I haven't found yet..
2017-05-20 17:38:03 +02:00
if (selection.creating) {
Rename LineEdit caret_* properties getters and setters to match property
2021-03-28 20:31:25 +02:00
set_caret_at_pixel_pos(m->get_position().x);
selection_fill_at_caret();
Removal of InputEvent as built-in Variant type.. this might cause bugs I haven't found yet..
2017-05-20 17:38:03 +02:00
}
}
Fix drag and drop on LineEdit
2021-10-28 09:07:18 +02:00
if (drag_action && can_drop_data(m->get_position(), get_viewport()->gui_get_drag_data())) {
drag_caret_force_displayed = true;
set_caret_at_pixel_pos(m->get_position().x);
}
Fix LineEdit not consuming events The most important issue is LineEdit not consuming "ui_text_submit" event which makes pressing Enter after editing escape to other components causing unwanted interactions. Also fix handling mouse button interactions not consuming some events. Also implement early return in case we know which event type it is and there is no point in checking other event types. PS I'm also suspicious that mouse motion events also need to be consumed, but haven't explored those cases.
2023-01-30 14:03:34 +01:00
return;
Removal of InputEvent as built-in Variant type.. this might cause bugs I haven't found yet..
2017-05-20 17:38:03 +02:00
}
remove trailing whitespace
2016-03-09 00:00:52 +01:00
Removal of InputEvent as built-in Variant type.. this might cause bugs I haven't found yet..
2017-05-20 17:38:03 +02:00
Ref<InputEventKey> k = p_event;
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
Removal of InputEvent as built-in Variant type.. this might cause bugs I haven't found yet..
2017-05-20 17:38:03 +02:00
if (k.is_valid()) {
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
if (!k->is_pressed()) {
Add ALT NUM+ {hex code} character input support for LineEdit, TextEdit and CodeEdit.
2021-11-29 15:24:02 +01:00
if (alt_start && k->get_keycode() == Key::ALT) {
alt_start = false;
if ((alt_code > 0x31 && alt_code < 0xd800) || (alt_code > 0xdfff && alt_code <= 0x10ffff)) {
char32_t ucodestr[2] = { (char32_t)alt_code, 0 };
insert_text_at_caret(ucodestr);
}
accept_event();
return;
}
Removal of InputEvent as built-in Variant type.. this might cause bugs I haven't found yet..
2017-05-20 17:38:03 +02:00
return;
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
}
Support Mac OS hotkeys in line_edit
2019-05-06 21:59:34 +02:00
Code style improvements to text_edit and related
2023-03-08 23:00:27 +01:00
// Alt + Unicode input:
Add ALT NUM+ {hex code} character input support for LineEdit, TextEdit and CodeEdit.
2021-11-29 15:24:02 +01:00
if (k->is_alt_pressed()) {
if (!alt_start) {
if (k->get_keycode() == Key::KP_ADD) {
alt_start = true;
alt_code = 0;
accept_event();
return;
}
} else {
if (k->get_keycode() >= Key::KEY_0 && k->get_keycode() <= Key::KEY_9) {
alt_code = alt_code << 4;
alt_code += (uint32_t)(k->get_keycode() - Key::KEY_0);
}
if (k->get_keycode() >= Key::KP_0 && k->get_keycode() <= Key::KP_9) {
alt_code = alt_code << 4;
alt_code += (uint32_t)(k->get_keycode() - Key::KP_0);
}
if (k->get_keycode() >= Key::A && k->get_keycode() <= Key::F) {
alt_code = alt_code << 4;
alt_code += (uint32_t)(k->get_keycode() - Key::A) + 10;
}
accept_event();
return;
}
}
Removed hardcoded shortcuts from /scene and converted to input actions This removes hardcoded actions from things like LineEdit and TextEdit. Previously, things like copy, paste, etc were all hardcoded to Ctrl+C, Ctrl+V, etc. They could not be changed. This allows the possibility of them being changed, by making them use the action map. This has the added benefit of greatly simplifying the input handling logic in those controls. The logic which was previously in a huge and hard to follow switch statement has been extracted to individual methods.
2020-12-07 12:32:00 +01:00
if (context_menu_enabled) {
if (k->is_action("ui_menu", true)) {
Fix `LineEdit` and `TextEdit` context menus not customizable
2023-01-26 18:59:41 +01:00
_update_context_menu();
Add a lifecycle method for manual theme item caching to Control
2022-08-31 14:02:40 +02:00
Point2 pos = Point2(get_caret_pixel_pos().x, (get_size().y + theme_cache.font->get_height(theme_cache.font_size)) / 2);
Fix bad popups offset in editor with single window off Co-authored-by: Gil Arasa Verge <gilarasaverge@gmail.com> Co-authored-by: Tomasz Chabora <kobewi4e@gmail.com>
2021-08-31 17:43:35 +02:00
menu->set_position(get_screen_position() + pos);
Added `reset_size` method to `Control` and `Window` classes
2021-11-20 09:04:57 +01:00
menu->reset_size();
Removed hardcoded shortcuts from /scene and converted to input actions This removes hardcoded actions from things like LineEdit and TextEdit. Previously, things like copy, paste, etc were all hardcoded to Ctrl+C, Ctrl+V, etc. They could not be changed. This allows the possibility of them being changed, by making them use the action map. This has the added benefit of greatly simplifying the input handling logic in those controls. The logic which was previously in a huge and hard to follow switch statement has been extracted to individual methods.
2020-12-07 12:32:00 +01:00
menu->popup();
menu->grab_focus();
Fix LineEdit not consuming events The most important issue is LineEdit not consuming "ui_text_submit" event which makes pressing Enter after editing escape to other components causing unwanted interactions. Also fix handling mouse button interactions not consuming some events. Also implement early return in case we know which event type it is and there is no point in checking other event types. PS I'm also suspicious that mouse motion events also need to be consumed, but haven't explored those cases.
2023-01-30 14:03:34 +01:00
accept_event();
return;
Support Mac OS hotkeys in line_edit
2019-05-06 21:59:34 +02:00
}
Removed hardcoded shortcuts from /scene and converted to input actions This removes hardcoded actions from things like LineEdit and TextEdit. Previously, things like copy, paste, etc were all hardcoded to Ctrl+C, Ctrl+V, etc. They could not be changed. This allows the possibility of them being changed, by making them use the action map. This has the added benefit of greatly simplifying the input handling logic in those controls. The logic which was previously in a huge and hard to follow switch statement has been extracted to individual methods.
2020-12-07 12:32:00 +01:00
}
Support Mac OS hotkeys in line_edit
2019-05-06 21:59:34 +02:00
Code style improvements to text_edit and related
2023-03-08 23:00:27 +01:00
// Default is ENTER and KP_ENTER. Cannot use ui_accept as default includes SPACE.
Documentation search fixes Updates rich_text_label so that the built-in documentation can be searched Previously, it would only find the first result and would not select other results Renames "_entered" functions to "_submitted"
2021-06-16 18:43:34 +02:00
if (k->is_action("ui_text_submit", false)) {
Optimize StringName usage * Added a new macro SNAME() that constructs and caches a local stringname. * Subsequent usages use the cached version. * Since these use a global static variable, a second refcounter of static usages need to be kept for cleanup time. * Replaced all theme usages by this new macro. * Replace all signal emission usages by this new macro. * Replace all call_deferred usages by this new macro. This is part of ongoing work to optimize GUI and the editor.
2021-07-17 23:22:52 +02:00
emit_signal(SNAME("text_submitted"), text);
Removed hardcoded shortcuts from /scene and converted to input actions This removes hardcoded actions from things like LineEdit and TextEdit. Previously, things like copy, paste, etc were all hardcoded to Ctrl+C, Ctrl+V, etc. They could not be changed. This allows the possibility of them being changed, by making them use the action map. This has the added benefit of greatly simplifying the input handling logic in those controls. The logic which was previously in a huge and hard to follow switch statement has been extracted to individual methods.
2020-12-07 12:32:00 +01:00
if (DisplayServer::get_singleton()->has_feature(DisplayServer::FEATURE_VIRTUAL_KEYBOARD) && virtual_keyboard_enabled) {
DisplayServer::get_singleton()->virtual_keyboard_hide();
Support Mac OS hotkeys in line_edit
2019-05-06 21:59:34 +02:00
}
Fix LineEdit not consuming events The most important issue is LineEdit not consuming "ui_text_submit" event which makes pressing Enter after editing escape to other components causing unwanted interactions. Also fix handling mouse button interactions not consuming some events. Also implement early return in case we know which event type it is and there is no point in checking other event types. PS I'm also suspicious that mouse motion events also need to be consumed, but haven't explored those cases.
2023-01-30 14:03:34 +01:00
accept_event();
return;
Support Mac OS hotkeys in line_edit
2019-05-06 21:59:34 +02:00
}
Removal of InputEvent as built-in Variant type.. this might cause bugs I haven't found yet..
2017-05-20 17:38:03 +02:00
Unfocus LineEdit when pressing Escape
2023-08-22 16:29:00 +02:00
if (k->is_action("ui_cancel")) {
Fix FindReplaceBar losing focus too early
2023-09-08 14:38:44 +02:00
callable_mp((Control *)this, &Control::release_focus).call_deferred();
Accept cancel event when unfocusing LineEdit
2023-10-06 16:00:56 +02:00
accept_event();
Unfocus LineEdit when pressing Escape
2023-08-22 16:29:00 +02:00
return;
}
Removed hardcoded shortcuts from /scene and converted to input actions This removes hardcoded actions from things like LineEdit and TextEdit. Previously, things like copy, paste, etc were all hardcoded to Ctrl+C, Ctrl+V, etc. They could not be changed. This allows the possibility of them being changed, by making them use the action map. This has the added benefit of greatly simplifying the input handling logic in those controls. The logic which was previously in a huge and hard to follow switch statement has been extracted to individual methods.
2020-12-07 12:32:00 +01:00
if (is_shortcut_keys_enabled()) {
if (k->is_action("ui_copy", true)) {
copy_text();
accept_event();
return;
}
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
Removed hardcoded shortcuts from /scene and converted to input actions This removes hardcoded actions from things like LineEdit and TextEdit. Previously, things like copy, paste, etc were all hardcoded to Ctrl+C, Ctrl+V, etc. They could not be changed. This allows the possibility of them being changed, by making them use the action map. This has the added benefit of greatly simplifying the input handling logic in those controls. The logic which was previously in a huge and hard to follow switch statement has been extracted to individual methods.
2020-12-07 12:32:00 +01:00
if (k->is_action("ui_text_select_all", true)) {
select();
accept_event();
return;
}
Add Ability to Enable/Disable Shortcuts for LineEdit/TextEdit This PR adds the ability to enable/disable shortcut keys and selection for LineEdit/TextEdit. It also updates the context menu when you disable/enable the shortcut keys or selection.
2019-08-08 02:09:46 +02:00
Removed hardcoded shortcuts from /scene and converted to input actions This removes hardcoded actions from things like LineEdit and TextEdit. Previously, things like copy, paste, etc were all hardcoded to Ctrl+C, Ctrl+V, etc. They could not be changed. This allows the possibility of them being changed, by making them use the action map. This has the added benefit of greatly simplifying the input handling logic in those controls. The logic which was previously in a huge and hard to follow switch statement has been extracted to individual methods.
2020-12-07 12:32:00 +01:00
// Cut / Paste
if (k->is_action("ui_cut", true)) {
cut_text();
accept_event();
return;
}
[macOS] Command-backspace in line edit Make command-backspace in line edit work like other macOS applications. If there is a selection, command-backspace deletes the selection. If there isn't a selection, command-backspace deletes from the cursor to the beginning of the line edit. This addresses part of godotengine/godot#23548
2020-06-18 23:45:40 +02:00
Removed hardcoded shortcuts from /scene and converted to input actions This removes hardcoded actions from things like LineEdit and TextEdit. Previously, things like copy, paste, etc were all hardcoded to Ctrl+C, Ctrl+V, etc. They could not be changed. This allows the possibility of them being changed, by making them use the action map. This has the added benefit of greatly simplifying the input handling logic in those controls. The logic which was previously in a huge and hard to follow switch statement has been extracted to individual methods.
2020-12-07 12:32:00 +01:00
if (k->is_action("ui_paste", true)) {
paste_text();
accept_event();
return;
}
[macOS] Command-backspace in line edit Make command-backspace in line edit work like other macOS applications. If there is a selection, command-backspace deletes the selection. If there isn't a selection, command-backspace deletes from the cursor to the beginning of the line edit. This addresses part of godotengine/godot#23548
2020-06-18 23:45:40 +02:00
Removed hardcoded shortcuts from /scene and converted to input actions This removes hardcoded actions from things like LineEdit and TextEdit. Previously, things like copy, paste, etc were all hardcoded to Ctrl+C, Ctrl+V, etc. They could not be changed. This allows the possibility of them being changed, by making them use the action map. This has the added benefit of greatly simplifying the input handling logic in those controls. The logic which was previously in a huge and hard to follow switch statement has been extracted to individual methods.
2020-12-07 12:32:00 +01:00
// Undo / Redo
if (k->is_action("ui_undo", true)) {
undo();
accept_event();
return;
Removal of InputEvent as built-in Variant type.. this might cause bugs I haven't found yet..
2017-05-20 17:38:03 +02:00
}
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
Removed hardcoded shortcuts from /scene and converted to input actions This removes hardcoded actions from things like LineEdit and TextEdit. Previously, things like copy, paste, etc were all hardcoded to Ctrl+C, Ctrl+V, etc. They could not be changed. This allows the possibility of them being changed, by making them use the action map. This has the added benefit of greatly simplifying the input handling logic in those controls. The logic which was previously in a huge and hard to follow switch statement has been extracted to individual methods.
2020-12-07 12:32:00 +01:00
if (k->is_action("ui_redo", true)) {
redo();
Removal of InputEvent as built-in Variant type.. this might cause bugs I haven't found yet..
2017-05-20 17:38:03 +02:00
accept_event();
return;
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
}
Removal of InputEvent as built-in Variant type.. this might cause bugs I haven't found yet..
2017-05-20 17:38:03 +02:00
}
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
Removed hardcoded shortcuts from /scene and converted to input actions This removes hardcoded actions from things like LineEdit and TextEdit. Previously, things like copy, paste, etc were all hardcoded to Ctrl+C, Ctrl+V, etc. They could not be changed. This allows the possibility of them being changed, by making them use the action map. This has the added benefit of greatly simplifying the input handling logic in those controls. The logic which was previously in a huge and hard to follow switch statement has been extracted to individual methods.
2020-12-07 12:32:00 +01:00
// BACKSPACE
if (k->is_action("ui_text_backspace_all_to_left", true)) {
_backspace(false, true);
accept_event();
return;
}
if (k->is_action("ui_text_backspace_word", true)) {
_backspace(true);
accept_event();
return;
}
if (k->is_action("ui_text_backspace", true)) {
_backspace();
accept_event();
return;
}
LineEdit: Word jumping and OSX hotkeys
2016-06-18 16:15:26 +02:00
Removed hardcoded shortcuts from /scene and converted to input actions This removes hardcoded actions from things like LineEdit and TextEdit. Previously, things like copy, paste, etc were all hardcoded to Ctrl+C, Ctrl+V, etc. They could not be changed. This allows the possibility of them being changed, by making them use the action map. This has the added benefit of greatly simplifying the input handling logic in those controls. The logic which was previously in a huge and hard to follow switch statement has been extracted to individual methods.
2020-12-07 12:32:00 +01:00
// DELETE
if (k->is_action("ui_text_delete_all_to_right", true)) {
_delete(false, true);
accept_event();
return;
}
if (k->is_action("ui_text_delete_word", true)) {
_delete(true);
accept_event();
return;
}
if (k->is_action("ui_text_delete", true)) {
_delete();
accept_event();
return;
}
LineEdit: Word jumping and OSX hotkeys
2016-06-18 16:15:26 +02:00
Removed hardcoded shortcuts from /scene and converted to input actions This removes hardcoded actions from things like LineEdit and TextEdit. Previously, things like copy, paste, etc were all hardcoded to Ctrl+C, Ctrl+V, etc. They could not be changed. This allows the possibility of them being changed, by making them use the action map. This has the added benefit of greatly simplifying the input handling logic in those controls. The logic which was previously in a huge and hard to follow switch statement has been extracted to individual methods.
2020-12-07 12:32:00 +01:00
// Cursor Movement
LineEdit: Word jumping and OSX hotkeys
2016-06-18 16:15:26 +02:00
Removed hardcoded shortcuts from /scene and converted to input actions This removes hardcoded actions from things like LineEdit and TextEdit. Previously, things like copy, paste, etc were all hardcoded to Ctrl+C, Ctrl+V, etc. They could not be changed. This allows the possibility of them being changed, by making them use the action map. This has the added benefit of greatly simplifying the input handling logic in those controls. The logic which was previously in a huge and hard to follow switch statement has been extracted to individual methods.
2020-12-07 12:32:00 +01:00
k = k->duplicate();
Rename "Control" key to "Ctrl" and add "_pressed" suffix to all InputEventWithModifiers properties/methods
2021-04-24 22:33:50 +02:00
bool shift_pressed = k->is_shift_pressed();
Removed hardcoded shortcuts from /scene and converted to input actions This removes hardcoded actions from things like LineEdit and TextEdit. Previously, things like copy, paste, etc were all hardcoded to Ctrl+C, Ctrl+V, etc. They could not be changed. This allows the possibility of them being changed, by making them use the action map. This has the added benefit of greatly simplifying the input handling logic in those controls. The logic which was previously in a huge and hard to follow switch statement has been extracted to individual methods.
2020-12-07 12:32:00 +01:00
// Remove shift or else actions will not match. Use above variable for selection.
Rename "Control" key to "Ctrl" and add "_pressed" suffix to all InputEventWithModifiers properties/methods
2021-04-24 22:33:50 +02:00
k->set_shift_pressed(false);
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
Removed hardcoded shortcuts from /scene and converted to input actions This removes hardcoded actions from things like LineEdit and TextEdit. Previously, things like copy, paste, etc were all hardcoded to Ctrl+C, Ctrl+V, etc. They could not be changed. This allows the possibility of them being changed, by making them use the action map. This has the added benefit of greatly simplifying the input handling logic in those controls. The logic which was previously in a huge and hard to follow switch statement has been extracted to individual methods.
2020-12-07 12:32:00 +01:00
if (k->is_action("ui_text_caret_word_left", true)) {
Rename LineEdit caret_* properties getters and setters to match property
2021-03-28 20:31:25 +02:00
_move_caret_left(shift_pressed, true);
Removed hardcoded shortcuts from /scene and converted to input actions This removes hardcoded actions from things like LineEdit and TextEdit. Previously, things like copy, paste, etc were all hardcoded to Ctrl+C, Ctrl+V, etc. They could not be changed. This allows the possibility of them being changed, by making them use the action map. This has the added benefit of greatly simplifying the input handling logic in those controls. The logic which was previously in a huge and hard to follow switch statement has been extracted to individual methods.
2020-12-07 12:32:00 +01:00
accept_event();
return;
}
if (k->is_action("ui_text_caret_left", true)) {
Rename LineEdit caret_* properties getters and setters to match property
2021-03-28 20:31:25 +02:00
_move_caret_left(shift_pressed);
Removed hardcoded shortcuts from /scene and converted to input actions This removes hardcoded actions from things like LineEdit and TextEdit. Previously, things like copy, paste, etc were all hardcoded to Ctrl+C, Ctrl+V, etc. They could not be changed. This allows the possibility of them being changed, by making them use the action map. This has the added benefit of greatly simplifying the input handling logic in those controls. The logic which was previously in a huge and hard to follow switch statement has been extracted to individual methods.
2020-12-07 12:32:00 +01:00
accept_event();
return;
}
if (k->is_action("ui_text_caret_word_right", true)) {
Rename LineEdit caret_* properties getters and setters to match property
2021-03-28 20:31:25 +02:00
_move_caret_right(shift_pressed, true);
Removed hardcoded shortcuts from /scene and converted to input actions This removes hardcoded actions from things like LineEdit and TextEdit. Previously, things like copy, paste, etc were all hardcoded to Ctrl+C, Ctrl+V, etc. They could not be changed. This allows the possibility of them being changed, by making them use the action map. This has the added benefit of greatly simplifying the input handling logic in those controls. The logic which was previously in a huge and hard to follow switch statement has been extracted to individual methods.
2020-12-07 12:32:00 +01:00
accept_event();
return;
}
if (k->is_action("ui_text_caret_right", true)) {
Rename LineEdit caret_* properties getters and setters to match property
2021-03-28 20:31:25 +02:00
_move_caret_right(shift_pressed, false);
Removed hardcoded shortcuts from /scene and converted to input actions This removes hardcoded actions from things like LineEdit and TextEdit. Previously, things like copy, paste, etc were all hardcoded to Ctrl+C, Ctrl+V, etc. They could not be changed. This allows the possibility of them being changed, by making them use the action map. This has the added benefit of greatly simplifying the input handling logic in those controls. The logic which was previously in a huge and hard to follow switch statement has been extracted to individual methods.
2020-12-07 12:32:00 +01:00
accept_event();
return;
}
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
Removed hardcoded shortcuts from /scene and converted to input actions This removes hardcoded actions from things like LineEdit and TextEdit. Previously, things like copy, paste, etc were all hardcoded to Ctrl+C, Ctrl+V, etc. They could not be changed. This allows the possibility of them being changed, by making them use the action map. This has the added benefit of greatly simplifying the input handling logic in those controls. The logic which was previously in a huge and hard to follow switch statement has been extracted to individual methods.
2020-12-07 12:32:00 +01:00
// Up = Home, Down = End
if (k->is_action("ui_text_caret_up", true) || k->is_action("ui_text_caret_line_start", true) || k->is_action("ui_text_caret_page_up", true)) {
Rename LineEdit caret_* properties getters and setters to match property
2021-03-28 20:31:25 +02:00
_move_caret_start(shift_pressed);
Removed hardcoded shortcuts from /scene and converted to input actions This removes hardcoded actions from things like LineEdit and TextEdit. Previously, things like copy, paste, etc were all hardcoded to Ctrl+C, Ctrl+V, etc. They could not be changed. This allows the possibility of them being changed, by making them use the action map. This has the added benefit of greatly simplifying the input handling logic in those controls. The logic which was previously in a huge and hard to follow switch statement has been extracted to individual methods.
2020-12-07 12:32:00 +01:00
accept_event();
return;
}
if (k->is_action("ui_text_caret_down", true) || k->is_action("ui_text_caret_line_end", true) || k->is_action("ui_text_caret_page_down", true)) {
Rename LineEdit caret_* properties getters and setters to match property
2021-03-28 20:31:25 +02:00
_move_caret_end(shift_pressed);
Removed hardcoded shortcuts from /scene and converted to input actions This removes hardcoded actions from things like LineEdit and TextEdit. Previously, things like copy, paste, etc were all hardcoded to Ctrl+C, Ctrl+V, etc. They could not be changed. This allows the possibility of them being changed, by making them use the action map. This has the added benefit of greatly simplifying the input handling logic in those controls. The logic which was previously in a huge and hard to follow switch statement has been extracted to individual methods.
2020-12-07 12:32:00 +01:00
accept_event();
return;
}
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
Removed hardcoded shortcuts from /scene and converted to input actions This removes hardcoded actions from things like LineEdit and TextEdit. Previously, things like copy, paste, etc were all hardcoded to Ctrl+C, Ctrl+V, etc. They could not be changed. This allows the possibility of them being changed, by making them use the action map. This has the added benefit of greatly simplifying the input handling logic in those controls. The logic which was previously in a huge and hard to follow switch statement has been extracted to individual methods.
2020-12-07 12:32:00 +01:00
// Misc
if (k->is_action("ui_swap_input_direction", true)) {
_swap_current_input_direction();
accept_event();
return;
}
TextEdit/LineEdit: Handle numpad arrows if NumLock is disabled
2016-01-07 21:38:38 +01:00
Removed hardcoded shortcuts from /scene and converted to input actions This removes hardcoded actions from things like LineEdit and TextEdit. Previously, things like copy, paste, etc were all hardcoded to Ctrl+C, Ctrl+V, etc. They could not be changed. This allows the possibility of them being changed, by making them use the action map. This has the added benefit of greatly simplifying the input handling logic in those controls. The logic which was previously in a huge and hard to follow switch statement has been extracted to individual methods.
2020-12-07 12:32:00 +01:00
_reset_caret_blink_timer();
Removal of InputEvent as built-in Variant type.. this might cause bugs I haven't found yet..
2017-05-20 17:38:03 +02:00
Removed hardcoded shortcuts from /scene and converted to input actions This removes hardcoded actions from things like LineEdit and TextEdit. Previously, things like copy, paste, etc were all hardcoded to Ctrl+C, Ctrl+V, etc. They could not be changed. This allows the possibility of them being changed, by making them use the action map. This has the added benefit of greatly simplifying the input handling logic in those controls. The logic which was previously in a huge and hard to follow switch statement has been extracted to individual methods.
2020-12-07 12:32:00 +01:00
// Allow unicode handling if:
// * No Modifiers are pressed (except shift)
Replace Ctrl in editor shortcuts with Cmd or Ctrl depending on platform
2023-06-08 23:24:00 +02:00
bool allow_unicode_handling = !(k->is_ctrl_pressed() || k->is_alt_pressed() || k->is_meta_pressed());
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
Removed hardcoded shortcuts from /scene and converted to input actions This removes hardcoded actions from things like LineEdit and TextEdit. Previously, things like copy, paste, etc were all hardcoded to Ctrl+C, Ctrl+V, etc. They could not be changed. This allows the possibility of them being changed, by making them use the action map. This has the added benefit of greatly simplifying the input handling logic in those controls. The logic which was previously in a huge and hard to follow switch statement has been extracted to individual methods.
2020-12-07 12:32:00 +01:00
if (allow_unicode_handling && editable && k->get_unicode() >= 32) {
Code style improvements to text_edit and related
2023-03-08 23:00:27 +01:00
// Handle Unicode if no modifiers are active.
Removed hardcoded shortcuts from /scene and converted to input actions This removes hardcoded actions from things like LineEdit and TextEdit. Previously, things like copy, paste, etc were all hardcoded to Ctrl+C, Ctrl+V, etc. They could not be changed. This allows the possibility of them being changed, by making them use the action map. This has the added benefit of greatly simplifying the input handling logic in those controls. The logic which was previously in a huge and hard to follow switch statement has been extracted to individual methods.
2020-12-07 12:32:00 +01:00
selection_delete();
char32_t ucodestr[2] = { (char32_t)k->get_unicode(), 0 };
int prev_len = text.length();
Rename LineEdit caret_* properties getters and setters to match property
2021-03-28 20:31:25 +02:00
insert_text_at_caret(ucodestr);
Removed hardcoded shortcuts from /scene and converted to input actions This removes hardcoded actions from things like LineEdit and TextEdit. Previously, things like copy, paste, etc were all hardcoded to Ctrl+C, Ctrl+V, etc. They could not be changed. This allows the possibility of them being changed, by making them use the action map. This has the added benefit of greatly simplifying the input handling logic in those controls. The logic which was previously in a huge and hard to follow switch statement has been extracted to individual methods.
2020-12-07 12:32:00 +01:00
if (text.length() != prev_len) {
Fix double text_changed signal when overwriting selection in LineEdit The part of gui_input that handles unicode wasn't checking text_changed_dirty before emitting the signal, unlike the rest of the text editing functions. Fixes #86451
2023-12-22 22:42:24 +01:00
if (!text_changed_dirty) {
if (is_inside_tree()) {
callable_mp(this, &LineEdit::_text_changed).call_deferred();
}
text_changed_dirty = true;
}
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
}
Removed hardcoded shortcuts from /scene and converted to input actions This removes hardcoded actions from things like LineEdit and TextEdit. Previously, things like copy, paste, etc were all hardcoded to Ctrl+C, Ctrl+V, etc. They could not be changed. This allows the possibility of them being changed, by making them use the action map. This has the added benefit of greatly simplifying the input handling logic in those controls. The logic which was previously in a huge and hard to follow switch statement has been extracted to individual methods.
2020-12-07 12:32:00 +01:00
accept_event();
Fix LineEdit not consuming events The most important issue is LineEdit not consuming "ui_text_submit" event which makes pressing Enter after editing escape to other components causing unwanted interactions. Also fix handling mouse button interactions not consuming some events. Also implement early return in case we know which event type it is and there is no point in checking other event types. PS I'm also suspicious that mouse motion events also need to be consumed, but haven't explored those cases.
2023-01-30 14:03:34 +01:00
return;
Removal of InputEvent as built-in Variant type.. this might cause bugs I haven't found yet..
2017-05-20 17:38:03 +02:00
}
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
}
}
align to horizontal_alignment, valign to vertical_alignment, related
2021-11-25 03:58:47 +01:00
void LineEdit::set_horizontal_alignment(HorizontalAlignment p_alignment) {
ERR_FAIL_INDEX((int)p_alignment, 4);
Add some codes, returnes directly if the value is not changed. Avoid executing the following value-changed logics if the value does not really change.
2022-03-16 08:50:48 +01:00
if (alignment == p_alignment) {
return;
[Complex Text Layouts] Refactor Label and LineEdit controls.
2020-09-09 15:00:32 +02:00
}
Add some codes, returnes directly if the value is not changed. Avoid executing the following value-changed logics if the value does not really change.
2022-03-16 08:50:48 +01:00
alignment = p_alignment;
_shape();
Rename `CanvasItem.update()` to `queue_redraw()` Affects a lot of classes. Very thoroughly checked signal connections and deferred calls to this method, add_do_method/add_undo_method calls, and so on. Also renames the internal `_update_callback()` to `_redraw_callback()` for consistency. Just a few comments have also been changed to say "redraw". In CPUParticles2D, there was a private variable with the same name. It has been renamed to `do_redraw`.
2022-08-13 23:21:24 +02:00
queue_redraw();
Added alignment to LineEdit GUI control.
2015-08-15 08:47:22 +02:00
}
align to horizontal_alignment, valign to vertical_alignment, related
2021-11-25 03:58:47 +01:00
HorizontalAlignment LineEdit::get_horizontal_alignment() const {
return alignment;
Added alignment to LineEdit GUI control.
2015-08-15 08:47:22 +02:00
}
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
Variant LineEdit::get_drag_data(const Point2 &p_point) {
Fix get_drag_data not overridable in some Controls
2023-03-20 00:38:00 +01:00
Variant ret = Control::get_drag_data(p_point);
if (ret != Variant()) {
return ret;
}
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
if (selection.drag_attempt && selection.enabled) {
Implement LineEdit.get_selected_text()
2023-03-30 17:07:28 +02:00
String t = get_selected_text();
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
Label *l = memnew(Label);
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
l->set_text(t);
set_drag_preview(l);
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
return t;
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
}
return Variant();
}
Style: Enforce separation line between function definitions I couldn't find a tool that enforces it, so I went the manual route: ``` find -name "thirdparty" -prune \ -o -name "*.cpp" -o -name "*.h" -o -name "*.m" -o -name "*.mm" \ -o -name "*.glsl" > files perl -0777 -pi -e 's/\n}\n([^#])/\n}\n\n\1/g' $(cat files) misc/scripts/fix_style.sh -c ``` This adds a newline after all `}` on the first column, unless they are followed by `#` (typically `#endif`). This leads to having lots of places with two lines between function/class definitions, but clang-format then fixes it as we enforce max one line of separation. This doesn't fix potential occurrences of function definitions which are indented (e.g. for a helper class defined in a .cpp), but it's better than nothing. Also can't be made to run easily on CI/hooks so we'll have to be careful with new code. Part of #33027.
2020-05-14 14:29:06 +02:00
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
bool LineEdit::can_drop_data(const Point2 &p_point, const Variant &p_data) const {
Allow to override drop data in LineEdit
2020-12-13 20:16:56 +01:00
bool drop_override = Control::can_drop_data(p_point, p_data); // In case user wants to drop custom data.
if (drop_override) {
return drop_override;
}
Fix drag and drop on LineEdit
2021-10-28 09:07:18 +02:00
return is_editable() && p_data.get_type() == Variant::STRING;
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
}
Style: Enforce separation line between function definitions I couldn't find a tool that enforces it, so I went the manual route: ``` find -name "thirdparty" -prune \ -o -name "*.cpp" -o -name "*.h" -o -name "*.m" -o -name "*.mm" \ -o -name "*.glsl" > files perl -0777 -pi -e 's/\n}\n([^#])/\n}\n\n\1/g' $(cat files) misc/scripts/fix_style.sh -c ``` This adds a newline after all `}` on the first column, unless they are followed by `#` (typically `#endif`). This leads to having lots of places with two lines between function/class definitions, but clang-format then fixes it as we enforce max one line of separation. This doesn't fix potential occurrences of function definitions which are indented (e.g. for a helper class defined in a .cpp), but it's better than nothing. Also can't be made to run easily on CI/hooks so we'll have to be careful with new code. Part of #33027.
2020-05-14 14:29:06 +02:00
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
void LineEdit::drop_data(const Point2 &p_point, const Variant &p_data) {
Allow to override drop data in LineEdit
2020-12-13 20:16:56 +01:00
Control::drop_data(p_point, p_data);
Fix drag and drop on LineEdit
2021-10-28 09:07:18 +02:00
if (p_data.get_type() == Variant::STRING && is_editable()) {
Rename LineEdit caret_* properties getters and setters to match property
2021-03-28 20:31:25 +02:00
set_caret_at_pixel_pos(p_point.x);
Fix drag and drop on LineEdit
2021-10-28 09:07:18 +02:00
int caret_column_tmp = caret_column;
Add drag and drop to TextEdit
2021-11-24 22:22:40 +01:00
bool is_inside_sel = selection.enabled && caret_column >= selection.begin && caret_column <= selection.end;
Replace Ctrl in editor shortcuts with Cmd or Ctrl depending on platform
2023-06-08 23:24:00 +02:00
if (Input::get_singleton()->is_key_pressed(Key::CMD_OR_CTRL)) {
Add drag and drop to TextEdit
2021-11-24 22:22:40 +01:00
is_inside_sel = selection.enabled && caret_column > selection.begin && caret_column < selection.end;
}
Fix drag and drop on LineEdit
2021-10-28 09:07:18 +02:00
if (selection.drag_attempt) {
selection.drag_attempt = false;
Add drag and drop to TextEdit
2021-11-24 22:22:40 +01:00
if (!is_inside_sel) {
Replace Ctrl in editor shortcuts with Cmd or Ctrl depending on platform
2023-06-08 23:24:00 +02:00
if (!Input::get_singleton()->is_key_pressed(Key::CMD_OR_CTRL)) {
Add drag and drop to TextEdit
2021-11-24 22:22:40 +01:00
if (caret_column_tmp > selection.end) {
caret_column_tmp = caret_column_tmp - (selection.end - selection.begin);
}
selection_delete();
Fix drag and drop on LineEdit
2021-10-28 09:07:18 +02:00
}
Added alignment to LineEdit GUI control.
2015-08-15 08:47:22 +02:00
Fix drag and drop on LineEdit
2021-10-28 09:07:18 +02:00
set_caret_column(caret_column_tmp);
insert_text_at_caret(p_data);
}
} else if (selection.enabled && caret_column >= selection.begin && caret_column <= selection.end) {
caret_column_tmp = selection.begin;
selection_delete();
set_caret_column(caret_column_tmp);
insert_text_at_caret(p_data);
grab_focus();
} else {
insert_text_at_caret(p_data);
grab_focus();
}
select(caret_column_tmp, caret_column);
if (!text_changed_dirty) {
if (is_inside_tree()) {
Update deferred calls to use Callables
2023-12-18 15:46:56 +01:00
callable_mp(this, &LineEdit::_text_changed).call_deferred();
Fix drag and drop on LineEdit
2021-10-28 09:07:18 +02:00
}
text_changed_dirty = true;
}
Rename `CanvasItem.update()` to `queue_redraw()` Affects a lot of classes. Very thoroughly checked signal connections and deferred calls to this method, add_do_method/add_undo_method calls, and so on. Also renames the internal `_update_callback()` to `_redraw_callback()` for consistency. Just a few comments have also been changed to say "redraw". In CPUParticles2D, there was a private variable with the same name. It has been renamed to `do_redraw`.
2022-08-13 23:21:24 +02:00
queue_redraw();
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
}
}
Add clear text button to LineEdit - Add pressed state to clear button - Enable clear button on all inputs with search icon - Remove duplicate clear buttons - Fix rendering of icon for center and right alignments - Add clear button to more search fields - Add clear icon to default theme - Add method to control enabled state of clear button - Add property to enable clear button from inspector
2018-07-26 13:45:38 +02:00
Control::CursorShape LineEdit::get_cursor_shape(const Point2 &p_pos) const {
Display arrow cursor if text is not editable
2021-05-07 17:39:55 +02:00
if ((!text.is_empty() && is_editable() && _is_over_clear_button(p_pos)) || (!is_editable() && (!is_selecting_enabled() || text.is_empty()))) {
Add clear text button to LineEdit - Add pressed state to clear button - Enable clear button on all inputs with search icon - Remove duplicate clear buttons - Fix rendering of icon for center and right alignments - Add clear button to more search fields - Add clear icon to default theme - Add method to control enabled state of clear button - Add property to enable clear button from inspector
2018-07-26 13:45:38 +02:00
return CURSOR_ARROW;
}
return Control::get_cursor_shape(p_pos);
}
bool LineEdit::_is_over_clear_button(const Point2 &p_pos) const {
if (!clear_button_enabled || !has_point(p_pos)) {
return false;
}
Add a lifecycle method for manual theme item caching to Control
2022-08-31 14:02:40 +02:00
Ref<Texture2D> icon = theme_cache.clear_icon;
int x_ofs = theme_cache.normal->get_margin(SIDE_RIGHT);
Some code changed with Clang-Tidy
2019-06-26 15:08:25 +02:00
return p_pos.x > get_size().width - icon->get_width() - x_ofs;
Add clear text button to LineEdit - Add pressed state to clear button - Enable clear button on all inputs with search icon - Remove duplicate clear buttons - Fix rendering of icon for center and right alignments - Add clear button to more search fields - Add clear icon to default theme - Add method to control enabled state of clear button - Add property to enable clear button from inspector
2018-07-26 13:45:38 +02:00
}
Add a lifecycle method for manual theme item caching to Control
2022-08-31 14:02:40 +02:00
void LineEdit::_update_theme_item_cache() {
Control::_update_theme_item_cache();
theme_cache.base_scale = get_theme_default_base_scale();
}
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
void LineEdit::_notification(int p_what) {
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
switch (p_what) {
Added setting to toggle line edit caret blink
2016-06-21 15:38:35 +02:00
#ifdef TOOLS_ENABLED
case NOTIFICATION_ENTER_TREE: {
Fix crash when scene has LineEdit and run from editor
2017-09-26 09:19:02 +02:00
if (Engine::get_singleton()->is_editor_hint() && !get_tree()->is_node_being_edited(this)) {
Remove duplicate editor settings definitions
2022-03-06 21:39:19 +01:00
set_caret_blink_enabled(EDITOR_GET("text_editor/appearance/caret/caret_blink"));
Rename every instance of `caret_blink_speed` to `caret_blink_interval` It's been changed in EditorSettings, LineEdit, TextEdit. Affects setters and getters, and passed parameters, too.
2022-08-13 14:52:35 +02:00
set_caret_blink_interval(EDITOR_GET("text_editor/appearance/caret/caret_blink_interval"));
remove trailing whitespace
2016-03-09 00:00:52 +01:00
Signals: Port connect calls to use callable_mp Remove now unnecessary bindings of signal callbacks in the public API. There might be some false positives that need rebinding if they were meant to be public. No regular expressions were harmed in the making of this commit. (Nah, just kidding.)
2020-02-21 18:28:45 +01:00
if (!EditorSettings::get_singleton()->is_connected("settings_changed", callable_mp(this, &LineEdit::_editor_settings_changed))) {
EditorSettings::get_singleton()->connect("settings_changed", callable_mp(this, &LineEdit::_editor_settings_changed));
Fixed signal connection prints when moving docks, issue 5498
2016-06-30 16:12:14 +02:00
}
Added setting to toggle line edit caret blink
2016-06-21 15:38:35 +02:00
}
} break;
#endif
Use `switch` consistently in `_notification` (`scene` folder)
2022-02-15 18:06:48 +01:00
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
case NOTIFICATION_RESIZED: {
[Complex Text Layouts] Refactor Label and LineEdit controls.
2020-09-09 15:00:32 +02:00
_fit_to_width();
Fix LineEdit text incorrectly trimmed due to rounding errors.
2022-07-06 10:57:06 +02:00
scroll_offset = 0.0;
Rename LineEdit caret_* properties getters and setters to match property
2021-03-28 20:31:25 +02:00
set_caret_column(get_caret_column());
[Complex Text Layouts] Refactor Label and LineEdit controls.
2020-09-09 15:00:32 +02:00
} break;
Use `switch` consistently in `_notification` (`scene` folder)
2022-02-15 18:06:48 +01:00
[Complex Text Layouts] Refactor Label and LineEdit controls.
2020-09-09 15:00:32 +02:00
case NOTIFICATION_LAYOUT_DIRECTION_CHANGED:
case NOTIFICATION_THEME_CHANGED: {
_shape();
Rename `CanvasItem.update()` to `queue_redraw()` Affects a lot of classes. Very thoroughly checked signal connections and deferred calls to this method, add_do_method/add_undo_method calls, and so on. Also renames the internal `_update_callback()` to `_redraw_callback()` for consistency. Just a few comments have also been changed to say "redraw". In CPUParticles2D, there was a private variable with the same name. It has been renamed to `do_redraw`.
2022-08-13 23:21:24 +02:00
queue_redraw();
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
} break;
Use `switch` consistently in `_notification` (`scene` folder)
2022-02-15 18:06:48 +01:00
Line edit placeholders now react properly to translation changes.
2019-06-22 14:42:36 +02:00
case NOTIFICATION_TRANSLATION_CHANGED: {
Add `auto_translate` toggle for automatic translation
2021-05-27 19:31:33 +02:00
placeholder_translated = atr(placeholder);
[Complex Text Layouts] Refactor Label and LineEdit controls.
2020-09-09 15:00:32 +02:00
_shape();
Rename `CanvasItem.update()` to `queue_redraw()` Affects a lot of classes. Very thoroughly checked signal connections and deferred calls to this method, add_do_method/add_undo_method calls, and so on. Also renames the internal `_update_callback()` to `_redraw_callback()` for consistency. Just a few comments have also been changed to say "redraw". In CPUParticles2D, there was a private variable with the same name. It has been renamed to `do_redraw`.
2022-08-13 23:21:24 +02:00
queue_redraw();
Line edit placeholders now react properly to translation changes.
2019-06-22 14:42:36 +02:00
} break;
Use `switch` consistently in `_notification` (`scene` folder)
2022-02-15 18:06:48 +01:00
Add a separate application focus/in notification out from Window focus notification.
2020-06-30 01:47:18 +02:00
case NOTIFICATION_WM_WINDOW_FOCUS_IN: {
Line edit caret no longer draws on focus loss
2016-06-21 01:16:18 +02:00
window_has_focus = true;
Improve caret drawing conditions for `LineEdit` Now, `caret_can_draw` will be validated when a condition that affects the drawability of the `LineEdit`'s caret changes; `draw_caret` will be toggled when the caret's visibility is toggled due to blink, and `draw_caret` will be `false` when `caret_blink_enabled` is disabled. Fix toggling `caret_blink_enabled` could cause caret to no longer be displayed. Fix opening the context menu causing caret to no longer appear.
2022-10-09 10:51:01 +02:00
_validate_caret_can_draw();
Rename `CanvasItem.update()` to `queue_redraw()` Affects a lot of classes. Very thoroughly checked signal connections and deferred calls to this method, add_do_method/add_undo_method calls, and so on. Also renames the internal `_update_callback()` to `_redraw_callback()` for consistency. Just a few comments have also been changed to say "redraw". In CPUParticles2D, there was a private variable with the same name. It has been renamed to `do_redraw`.
2022-08-13 23:21:24 +02:00
queue_redraw();
Line edit caret no longer draws on focus loss
2016-06-21 01:16:18 +02:00
} break;
Use `switch` consistently in `_notification` (`scene` folder)
2022-02-15 18:06:48 +01:00
Add a separate application focus/in notification out from Window focus notification.
2020-06-30 01:47:18 +02:00
case NOTIFICATION_WM_WINDOW_FOCUS_OUT: {
Line edit caret no longer draws on focus loss
2016-06-21 01:16:18 +02:00
window_has_focus = false;
Improve caret drawing conditions for `LineEdit` Now, `caret_can_draw` will be validated when a condition that affects the drawability of the `LineEdit`'s caret changes; `draw_caret` will be toggled when the caret's visibility is toggled due to blink, and `draw_caret` will be `false` when `caret_blink_enabled` is disabled. Fix toggling `caret_blink_enabled` could cause caret to no longer be displayed. Fix opening the context menu causing caret to no longer appear.
2022-10-09 10:51:01 +02:00
_validate_caret_can_draw();
Rename `CanvasItem.update()` to `queue_redraw()` Affects a lot of classes. Very thoroughly checked signal connections and deferred calls to this method, add_do_method/add_undo_method calls, and so on. Also renames the internal `_update_callback()` to `_redraw_callback()` for consistency. Just a few comments have also been changed to say "redraw". In CPUParticles2D, there was a private variable with the same name. It has been renamed to `do_redraw`.
2022-08-13 23:21:24 +02:00
queue_redraw();
Line edit caret no longer draws on focus loss
2016-06-21 01:16:18 +02:00
} break;
Use `switch` consistently in `_notification` (`scene` folder)
2022-02-15 18:06:48 +01:00
Change LineEdit caret blink to use process Now using internal process for blinking instead of a Timer node
2022-07-04 23:17:34 +02:00
case NOTIFICATION_INTERNAL_PROCESS: {
Improve caret drawing conditions for `LineEdit` Now, `caret_can_draw` will be validated when a condition that affects the drawability of the `LineEdit`'s caret changes; `draw_caret` will be toggled when the caret's visibility is toggled due to blink, and `draw_caret` will be `false` when `caret_blink_enabled` is disabled. Fix toggling `caret_blink_enabled` could cause caret to no longer be displayed. Fix opening the context menu causing caret to no longer appear.
2022-10-09 10:51:01 +02:00
if (caret_blink_enabled && caret_can_draw) {
Change LineEdit caret blink to use process Now using internal process for blinking instead of a Timer node
2022-07-04 23:17:34 +02:00
caret_blink_timer += get_process_delta_time();
Rename every instance of `caret_blink_speed` to `caret_blink_interval` It's been changed in EditorSettings, LineEdit, TextEdit. Affects setters and getters, and passed parameters, too.
2022-08-13 14:52:35 +02:00
if (caret_blink_timer >= caret_blink_interval) {
Change LineEdit caret blink to use process Now using internal process for blinking instead of a Timer node
2022-07-04 23:17:34 +02:00
caret_blink_timer = 0.0;
_toggle_draw_caret();
}
}
} break;
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
case NOTIFICATION_DRAW: {
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
int width, height;
[Complex Text Layouts] Refactor Label and LineEdit controls.
2020-09-09 15:00:32 +02:00
bool rtl = is_layout_rtl();
remove trailing whitespace
2016-03-09 00:00:52 +01:00
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
Size2 size = get_size();
width = size.width;
height = size.height;
remove trailing whitespace
2016-03-09 00:00:52 +01:00
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
RID ci = get_canvas_item();
remove trailing whitespace
2016-03-09 00:00:52 +01:00
Add a lifecycle method for manual theme item caching to Control
2022-08-31 14:02:40 +02:00
Ref<StyleBox> style = theme_cache.normal;
Improvements and fixes for the default theme. Added customizable border size and window highlight.
2017-07-15 06:40:17 +02:00
if (!is_editable()) {
Add a lifecycle method for manual theme item caching to Control
2022-08-31 14:02:40 +02:00
style = theme_cache.read_only;
Improvements and fixes for the default theme. Added customizable border size and window highlight.
2017-07-15 06:40:17 +02:00
}
Add a lifecycle method for manual theme item caching to Control
2022-08-31 14:02:40 +02:00
Ref<Font> font = theme_cache.font;
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
Add functions for getting name and font style from dynamic and bitmap fonts. Add font selection toolbar editor plugin.
2021-10-26 08:40:11 +02:00
if (!flat) {
style->draw(ci, Rect2(Point2(), size));
}
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
if (has_focus()) {
Add a lifecycle method for manual theme item caching to Control
2022-08-31 14:02:40 +02:00
theme_cache.focus->draw(ci, Rect2(Point2(), size));
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
}
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
int x_ofs = 0;
Rename empty() to is_empty()
2020-12-15 13:04:21 +01:00
bool using_placeholder = text.is_empty() && ime_text.is_empty();
[Complex Text Layouts] Refactor Label and LineEdit controls.
2020-09-09 15:00:32 +02:00
float text_width = TS->shaped_text_get_size(text_rid).x;
Refactor Font configuration and import UI, and Font resources.
2022-05-09 11:47:10 +02:00
float text_height = TS->shaped_text_get_size(text_rid).y;
Added alignment to LineEdit GUI control.
2015-08-15 08:47:22 +02:00
align to horizontal_alignment, valign to vertical_alignment, related
2021-11-25 03:58:47 +01:00
switch (alignment) {
case HORIZONTAL_ALIGNMENT_FILL:
case HORIZONTAL_ALIGNMENT_LEFT: {
[Complex Text Layouts] Refactor Label and LineEdit controls.
2020-09-09 15:00:32 +02:00
if (rtl) {
fixed bug showing only two digits in color picker
2022-12-06 16:38:41 +01:00
x_ofs = MAX(style->get_margin(SIDE_LEFT), int(size.width - Math::ceil(style->get_margin(SIDE_RIGHT) + (text_width))));
[Complex Text Layouts] Refactor Label and LineEdit controls.
2020-09-09 15:00:32 +02:00
} else {
x_ofs = style->get_offset().x;
}
Added alignment to LineEdit GUI control.
2015-08-15 08:47:22 +02:00
} break;
align to horizontal_alignment, valign to vertical_alignment, related
2021-11-25 03:58:47 +01:00
case HORIZONTAL_ALIGNMENT_CENTER: {
Fix LineEdit text incorrectly trimmed due to rounding errors.
2022-07-06 10:57:06 +02:00
if (!Math::is_zero_approx(scroll_offset)) {
Fixed center align in LineEdit
2017-10-01 20:11:46 +02:00
x_ofs = style->get_offset().x;
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
} else {
Rename Control margin to offset
2020-12-22 17:24:29 +01:00
x_ofs = MAX(style->get_margin(SIDE_LEFT), int(size.width - (text_width)) / 2);
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
}
Added alignment to LineEdit GUI control.
2015-08-15 08:47:22 +02:00
} break;
align to horizontal_alignment, valign to vertical_alignment, related
2021-11-25 03:58:47 +01:00
case HORIZONTAL_ALIGNMENT_RIGHT: {
[Complex Text Layouts] Refactor Label and LineEdit controls.
2020-09-09 15:00:32 +02:00
if (rtl) {
x_ofs = style->get_offset().x;
} else {
fixed bug showing only two digits in color picker
2022-12-06 16:38:41 +01:00
x_ofs = MAX(style->get_margin(SIDE_LEFT), int(size.width - Math::ceil(style->get_margin(SIDE_RIGHT) + (text_width))));
[Complex Text Layouts] Refactor Label and LineEdit controls.
2020-09-09 15:00:32 +02:00
}
Added alignment to LineEdit GUI control.
2015-08-15 08:47:22 +02:00
} break;
}
Rename Control margin to offset
2020-12-22 17:24:29 +01:00
int ofs_max = width - style->get_margin(SIDE_RIGHT);
remove trailing whitespace
2016-03-09 00:00:52 +01:00
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
int y_area = height - style->get_minimum_size().height;
[Complex Text Layouts] Refactor Label and LineEdit controls.
2020-09-09 15:00:32 +02:00
int y_ofs = style->get_offset().y + (y_area - text_height) / 2;
remove trailing whitespace
2016-03-09 00:00:52 +01:00
Add a lifecycle method for manual theme item caching to Control
2022-08-31 14:02:40 +02:00
Color selection_color = theme_cache.selection_color;
Color font_color;
if (is_editable()) {
font_color = theme_cache.font_color;
} else {
font_color = theme_cache.font_uneditable_color;
}
Color font_selected_color = theme_cache.font_selected_color;
Color caret_color = theme_cache.caret_color;
remove trailing whitespace
2016-03-09 00:00:52 +01:00
Expose LineEdit's 'right_icon' and fix icon size
2019-09-09 03:46:57 +02:00
// Draw placeholder color.
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
if (using_placeholder) {
Add a lifecycle method for manual theme item caching to Control
2022-08-31 14:02:40 +02:00
font_color = theme_cache.font_placeholder_color;
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
}
Add placeholder property for line_edit this useful for user input tip
2016-06-27 13:47:40 +02:00
Add clear text button to LineEdit - Add pressed state to clear button - Enable clear button on all inputs with search icon - Remove duplicate clear buttons - Fix rendering of icon for center and right alignments - Add clear button to more search fields - Add clear icon to default theme - Add method to control enabled state of clear button - Add property to enable clear button from inspector
2018-07-26 13:45:38 +02:00
bool display_clear_icon = !using_placeholder && is_editable() && clear_button_enabled;
Do not use theme to set LineEdit right_icon
2018-08-11 12:04:19 +02:00
if (right_icon.is_valid() || display_clear_icon) {
Add a lifecycle method for manual theme item caching to Control
2022-08-31 14:02:40 +02:00
Ref<Texture2D> r_icon = display_clear_icon ? theme_cache.clear_icon : right_icon;
Give LineEdit a custom font color when un-editable By default the LineEdit's text when editable is unchecked had some transparency hardcoded. This change adds a custom color to LineEdit for adjusting the font when editable is off. Addresses issue 29814
2019-06-22 01:16:38 +02:00
Color color_icon(1, 1, 1, !is_editable() ? .5 * .9 : .9);
Add clear text button to LineEdit - Add pressed state to clear button - Enable clear button on all inputs with search icon - Remove duplicate clear buttons - Fix rendering of icon for center and right alignments - Add clear button to more search fields - Add clear icon to default theme - Add method to control enabled state of clear button - Add property to enable clear button from inspector
2018-07-26 13:45:38 +02:00
if (display_clear_icon) {
if (clear_button_status.press_attempt && clear_button_status.pressing_inside) {
Add a lifecycle method for manual theme item caching to Control
2022-08-31 14:02:40 +02:00
color_icon = theme_cache.clear_button_color_pressed;
Add clear text button to LineEdit - Add pressed state to clear button - Enable clear button on all inputs with search icon - Remove duplicate clear buttons - Fix rendering of icon for center and right alignments - Add clear button to more search fields - Add clear icon to default theme - Add method to control enabled state of clear button - Add property to enable clear button from inspector
2018-07-26 13:45:38 +02:00
} else {
Add a lifecycle method for manual theme item caching to Control
2022-08-31 14:02:40 +02:00
color_icon = theme_cache.clear_button_color;
Add clear text button to LineEdit - Add pressed state to clear button - Enable clear button on all inputs with search icon - Remove duplicate clear buttons - Fix rendering of icon for center and right alignments - Add clear button to more search fields - Add clear icon to default theme - Add method to control enabled state of clear button - Add property to enable clear button from inspector
2018-07-26 13:45:38 +02:00
}
}
Expose LineEdit's 'right_icon' and fix icon size
2019-09-09 03:46:57 +02:00
Rename Control margin to offset
2020-12-22 17:24:29 +01:00
r_icon->draw(ci, Point2(width - r_icon->get_width() - style->get_margin(SIDE_RIGHT), height / 2 - r_icon->get_height() / 2), color_icon);
Add clear text button to LineEdit - Add pressed state to clear button - Enable clear button on all inputs with search icon - Remove duplicate clear buttons - Fix rendering of icon for center and right alignments - Add clear button to more search fields - Add clear icon to default theme - Add method to control enabled state of clear button - Add property to enable clear button from inspector
2018-07-26 13:45:38 +02:00
align to horizontal_alignment, valign to vertical_alignment, related
2021-11-25 03:58:47 +01:00
if (alignment == HORIZONTAL_ALIGNMENT_CENTER) {
Fix LineEdit text incorrectly trimmed due to rounding errors.
2022-07-06 10:57:06 +02:00
if (Math::is_zero_approx(scroll_offset)) {
Rename Control margin to offset
2020-12-22 17:24:29 +01:00
x_ofs = MAX(style->get_margin(SIDE_LEFT), int(size.width - text_width - r_icon->get_width() - style->get_margin(SIDE_RIGHT) * 2) / 2);
Add clear text button to LineEdit - Add pressed state to clear button - Enable clear button on all inputs with search icon - Remove duplicate clear buttons - Fix rendering of icon for center and right alignments - Add clear button to more search fields - Add clear icon to default theme - Add method to control enabled state of clear button - Add property to enable clear button from inspector
2018-07-26 13:45:38 +02:00
}
} else {
Rename Control margin to offset
2020-12-22 17:24:29 +01:00
x_ofs = MAX(style->get_margin(SIDE_LEFT), x_ofs - r_icon->get_width() - style->get_margin(SIDE_RIGHT));
Add clear text button to LineEdit - Add pressed state to clear button - Enable clear button on all inputs with search icon - Remove duplicate clear buttons - Fix rendering of icon for center and right alignments - Add clear button to more search fields - Add clear icon to default theme - Add method to control enabled state of clear button - Add property to enable clear button from inspector
2018-07-26 13:45:38 +02:00
}
Fix 'LineEdit' offset limit not accounting for the right/clear icon width Fully fixes #28242.
2019-04-21 18:55:40 +02:00
Make LineEdit's minimal size adapt to its icons
2019-09-25 04:21:35 +02:00
ofs_max -= r_icon->get_width();
Icons can now be added inside line edits (Search icon). Fixed window title bar margins. fixed compilation error
2017-07-18 21:35:37 +02:00
}
[Complex Text Layouts] Refactor Label and LineEdit controls.
2020-09-09 15:00:32 +02:00
// Draw selections rects.
Vector2 ofs = Point2(x_ofs + scroll_offset, y_ofs);
if (selection.enabled) {
Vector<Vector2> sel = TS->shaped_text_get_selection(text_rid, selection.begin, selection.end);
for (int i = 0; i < sel.size(); i++) {
Rect2 rect = Rect2(sel[i].x + ofs.x, ofs.y, sel[i].y - sel[i].x, text_height);
if (rect.position.x + rect.size.x <= x_ofs || rect.position.x > ofs_max) {
continue;
}
if (rect.position.x < x_ofs) {
rect.size.x -= (x_ofs - rect.position.x);
rect.position.x = x_ofs;
} else if (rect.position.x + rect.size.x > ofs_max) {
rect.size.x = ofs_max - rect.position.x;
}
RenderingServer::get_singleton()->canvas_item_add_rect(ci, rect, selection_color);
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
}
[Complex Text Layouts] Refactor Label and LineEdit controls.
2020-09-09 15:00:32 +02:00
}
Implement TextServer GDExtension interface, remove TextServer GDNative interface.
2021-08-27 23:19:51 +02:00
const Glyph *glyphs = TS->shaped_text_get_glyphs(text_rid);
int gl_size = TS->shaped_text_get_glyph_count(text_rid);
[Complex Text Layouts] Refactor Label and LineEdit controls.
2020-09-09 15:00:32 +02:00
// Draw text.
ofs.y += TS->shaped_text_get_ascent(text_rid);
Add a lifecycle method for manual theme item caching to Control
2022-08-31 14:02:40 +02:00
Color font_outline_color = theme_cache.font_outline_color;
int outline_size = theme_cache.font_outline_size;
[CTL] Add missing font outline drawing routines and theme constants.
2020-12-25 22:45:28 +01:00
if (outline_size > 0 && font_outline_color.a > 0) {
Vector2 oofs = ofs;
for (int i = 0; i < gl_size; i++) {
for (int j = 0; j < glyphs[i].repeat; j++) {
if (ceil(oofs.x) >= x_ofs && (oofs.x + glyphs[i].advance) <= ofs_max) {
if (glyphs[i].font_rid != RID()) {
TS->font_draw_glyph_outline(glyphs[i].font_rid, ci, glyphs[i].font_size, outline_size, oofs + Vector2(glyphs[i].x_off, glyphs[i].y_off), glyphs[i].index, font_outline_color);
}
}
oofs.x += glyphs[i].advance;
}
if (oofs.x >= ofs_max) {
break;
}
}
}
[Complex Text Layouts] Performance optimizations.
2020-12-01 14:03:31 +01:00
for (int i = 0; i < gl_size; i++) {
[Complex Text Layouts] Refactor Label and LineEdit controls.
2020-09-09 15:00:32 +02:00
bool selected = selection.enabled && glyphs[i].start >= selection.begin && glyphs[i].end <= selection.end;
for (int j = 0; j < glyphs[i].repeat; j++) {
[Complex Text Layouts] Align glyph offsets and advances to the pixel grid.
2020-12-01 08:11:41 +01:00
if (ceil(ofs.x) >= x_ofs && (ofs.x + glyphs[i].advance) <= ofs_max) {
[Complex Text Layouts] Refactor Label and LineEdit controls.
2020-09-09 15:00:32 +02:00
if (glyphs[i].font_rid != RID()) {
Change themes *_color_* to *_*_color Changed: font_color_accel -> font_accelerator_color font_color_bg -> font_unselected_color font_color_disabled -> font_disabled_color font_color_fg -> font_selected_color font_color_hover -> font_hover_color font_color_hover_pressed -> font_hover_pressed_color font_color_pressed -> font_pressed_color font_color_readonly -> font_readonly_color font_color_selected -> font_selected_color font_color_shadow -> font_shadow_color font_color_uneditable -> font_uneditable_color icon_color_disabled -> icon_disabled_color icon_color_hover -> icon_hover_color icon_color_hover_pressed -> icon_hover_pressed_color icon_color_normal -> icon_normal_color icon_color_pressed -> icon_pressed_color Also includes: font_outline_modulate -> font_outline_color tab_fg -> tab_selected tab_bg -> tab_unselected
2020-12-08 14:11:45 +01:00
TS->font_draw_glyph(glyphs[i].font_rid, ci, glyphs[i].font_size, ofs + Vector2(glyphs[i].x_off, glyphs[i].y_off), glyphs[i].index, selected ? font_selected_color : font_color);
[TextServer] Use dedicated flag for object replacement characters.
2023-04-12 09:08:51 +02:00
} else if (((glyphs[i].flags & TextServer::GRAPHEME_IS_VIRTUAL) != TextServer::GRAPHEME_IS_VIRTUAL) && ((glyphs[i].flags & TextServer::GRAPHEME_IS_EMBEDDED_OBJECT) != TextServer::GRAPHEME_IS_EMBEDDED_OBJECT)) {
Change themes *_color_* to *_*_color Changed: font_color_accel -> font_accelerator_color font_color_bg -> font_unselected_color font_color_disabled -> font_disabled_color font_color_fg -> font_selected_color font_color_hover -> font_hover_color font_color_hover_pressed -> font_hover_pressed_color font_color_pressed -> font_pressed_color font_color_readonly -> font_readonly_color font_color_selected -> font_selected_color font_color_shadow -> font_shadow_color font_color_uneditable -> font_uneditable_color icon_color_disabled -> icon_disabled_color icon_color_hover -> icon_hover_color icon_color_hover_pressed -> icon_hover_pressed_color icon_color_normal -> icon_normal_color icon_color_pressed -> icon_pressed_color Also includes: font_outline_modulate -> font_outline_color tab_fg -> tab_selected tab_bg -> tab_unselected
2020-12-08 14:11:45 +01:00
TS->draw_hex_code_box(ci, glyphs[i].font_size, ofs + Vector2(glyphs[i].x_off, glyphs[i].y_off), glyphs[i].index, selected ? font_selected_color : font_color);
Implement NSTextInputClient protocol for IME
2017-08-07 13:09:56 +02:00
}
}
[Complex Text Layouts] Refactor Label and LineEdit controls.
2020-09-09 15:00:32 +02:00
ofs.x += glyphs[i].advance;
Implement NSTextInputClient protocol for IME
2017-08-07 13:09:56 +02:00
}
[Complex Text Layouts] Refactor Label and LineEdit controls.
2020-09-09 15:00:32 +02:00
if (ofs.x >= ofs_max) {
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
break;
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
}
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
}
[Complex Text Layouts] Refactor Label and LineEdit controls.
2020-09-09 15:00:32 +02:00
// Draw carets.
ofs.x = x_ofs + scroll_offset;
Improve caret drawing conditions for `LineEdit` Now, `caret_can_draw` will be validated when a condition that affects the drawability of the `LineEdit`'s caret changes; `draw_caret` will be toggled when the caret's visibility is toggled due to blink, and `draw_caret` will be `false` when `caret_blink_enabled` is disabled. Fix toggling `caret_blink_enabled` could cause caret to no longer be displayed. Fix opening the context menu causing caret to no longer appear.
2022-10-09 10:51:01 +02:00
if ((caret_can_draw && draw_caret) || drag_caret_force_displayed) {
Fix LineEdit and TextEdit carets disappearing at theme scales below 1.0 This fixes carets disappearing in the editor when the Editor Scale setting is set below 100%.
2022-03-03 00:15:48 +01:00
// Prevent carets from disappearing at theme scales below 1.0 (if the caret width is 1).
Add a lifecycle method for manual theme item caching to Control
2022-08-31 14:02:40 +02:00
const int caret_width = theme_cache.caret_width * MAX(1, theme_cache.base_scale);
Add a theme constant to change LineEdit and TextEdit's caret width This can be useful to improve caret visibility, especially at larger font sizes. This can also be used for accessibility purposes.
2021-11-13 23:06:47 +01:00
Cleanup and unify keyboard input. - Unify keycode values (secondary label printed on a key), remove unused hardcoded Latin-1 codes. - Unify IME behaviour, add inline composition string display on Windows and X11. - Add key_label (localized label printed on a key) value to the key events, and allow mapping actions to the unshifted Unicode events. - Add support for physical keyboard (Bluetooth or Sidecar) handling on iOS. - Add support for media key handling on macOS. Co-authored-by: Raul Santos <raulsntos@gmail.com>
2022-12-11 00:21:22 +01:00
if (ime_text.is_empty() || ime_selection.y == 0) {
[Complex Text Layouts] Refactor Label and LineEdit controls.
2020-09-09 15:00:32 +02:00
// Normal caret.
Cleanup and unify keyboard input. - Unify keycode values (secondary label printed on a key), remove unused hardcoded Latin-1 codes. - Unify IME behaviour, add inline composition string display on Windows and X11. - Add key_label (localized label printed on a key) value to the key events, and allow mapping actions to the unshifted Unicode events. - Add support for physical keyboard (Bluetooth or Sidecar) handling on iOS. - Add support for media key handling on macOS. Co-authored-by: Raul Santos <raulsntos@gmail.com>
2022-12-11 00:21:22 +01:00
CaretInfo caret = TS->shaped_text_get_carets(text_rid, ime_text.is_empty() ? caret_column : caret_column + ime_selection.x);
[Line Edit] Ignore placeholder text when drawing caret.
2022-11-08 14:15:13 +01:00
if (using_placeholder || (caret.l_caret == Rect2() && caret.t_caret == Rect2())) {
[Complex Text Layouts] Refactor Label and LineEdit controls.
2020-09-09 15:00:32 +02:00
// No carets, add one at the start.
Add a lifecycle method for manual theme item caching to Control
2022-08-31 14:02:40 +02:00
int h = theme_cache.font->get_height(theme_cache.font_size);
[Complex Text Layouts] Refactor Label and LineEdit controls.
2020-09-09 15:00:32 +02:00
int y = style->get_offset().y + (y_area - h) / 2;
[Line Edit] Ignore placeholder text when drawing caret.
2022-11-08 14:15:13 +01:00
caret.l_dir = (rtl) ? TextServer::DIRECTION_RTL : TextServer::DIRECTION_LTR;
switch (alignment) {
case HORIZONTAL_ALIGNMENT_FILL:
case HORIZONTAL_ALIGNMENT_LEFT: {
if (rtl) {
caret.l_caret = Rect2(Vector2(ofs_max, y), Size2(caret_width, h));
} else {
caret.l_caret = Rect2(Vector2(style->get_offset().x, y), Size2(caret_width, h));
}
} break;
case HORIZONTAL_ALIGNMENT_CENTER: {
caret.l_caret = Rect2(Vector2(size.x / 2, y), Size2(caret_width, h));
} break;
case HORIZONTAL_ALIGNMENT_RIGHT: {
if (rtl) {
caret.l_caret = Rect2(Vector2(style->get_offset().x, y), Size2(caret_width, h));
} else {
caret.l_caret = Rect2(Vector2(ofs_max, y), Size2(caret_width, h));
}
} break;
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
}
Cleanup and unify keyboard input. - Unify keycode values (secondary label printed on a key), remove unused hardcoded Latin-1 codes. - Unify IME behaviour, add inline composition string display on Windows and X11. - Add key_label (localized label printed on a key) value to the key events, and allow mapping actions to the unshifted Unicode events. - Add support for physical keyboard (Bluetooth or Sidecar) handling on iOS. - Add support for media key handling on macOS. Co-authored-by: Raul Santos <raulsntos@gmail.com>
2022-12-11 00:21:22 +01:00
Implement TextServer GDExtension interface, remove TextServer GDNative interface.
2021-08-27 23:19:51 +02:00
RenderingServer::get_singleton()->canvas_item_add_rect(ci, caret.l_caret, caret_color);
[Complex Text Layouts] Refactor Label and LineEdit controls.
2020-09-09 15:00:32 +02:00
} else {
Implement TextServer GDExtension interface, remove TextServer GDNative interface.
2021-08-27 23:19:51 +02:00
if (caret.l_caret != Rect2() && caret.l_dir == TextServer::DIRECTION_AUTO) {
[Complex Text Layouts] Refactor Label and LineEdit controls.
2020-09-09 15:00:32 +02:00
// Draw extra marker on top of mid caret.
Add split caret direction markers. Fix block/overtype caret size.
2022-10-06 13:30:50 +02:00
Rect2 trect = Rect2(caret.l_caret.position.x - 2.5 * caret_width, caret.l_caret.position.y, 6 * caret_width, caret_width);
trect.position += ofs;
RenderingServer::get_singleton()->canvas_item_add_rect(ci, trect, caret_color);
} else if (caret.l_caret != Rect2() && caret.t_caret != Rect2() && caret.l_dir != caret.t_dir) {
// Draw extra direction marker on top of split caret.
float d = (caret.l_dir == TextServer::DIRECTION_LTR) ? 0.5 : -3;
Rect2 trect = Rect2(caret.l_caret.position.x + d * caret_width, caret.l_caret.position.y + caret.l_caret.size.y - caret_width, 3 * caret_width, caret_width);
trect.position += ofs;
RenderingServer::get_singleton()->canvas_item_add_rect(ci, trect, caret_color);
d = (caret.t_dir == TextServer::DIRECTION_LTR) ? 0.5 : -3;
trect = Rect2(caret.t_caret.position.x + d * caret_width, caret.t_caret.position.y, 3 * caret_width, caret_width);
[Complex Text Layouts] Refactor Label and LineEdit controls.
2020-09-09 15:00:32 +02:00
trect.position += ofs;
Rename LineEdit caret_* properties getters and setters to match property
2021-03-28 20:31:25 +02:00
RenderingServer::get_singleton()->canvas_item_add_rect(ci, trect, caret_color);
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
}
Implement NSTextInputClient protocol for IME
2017-08-07 13:09:56 +02:00
Implement TextServer GDExtension interface, remove TextServer GDNative interface.
2021-08-27 23:19:51 +02:00
caret.l_caret.position += ofs;
caret.l_caret.size.x = caret_width;
RenderingServer::get_singleton()->canvas_item_add_rect(ci, caret.l_caret, caret_color);
Implement NSTextInputClient protocol for IME
2017-08-07 13:09:56 +02:00
Implement TextServer GDExtension interface, remove TextServer GDNative interface.
2021-08-27 23:19:51 +02:00
caret.t_caret.position += ofs;
caret.t_caret.size.x = caret_width;
Implement NSTextInputClient protocol for IME
2017-08-07 13:09:56 +02:00
Implement TextServer GDExtension interface, remove TextServer GDNative interface.
2021-08-27 23:19:51 +02:00
RenderingServer::get_singleton()->canvas_item_add_rect(ci, caret.t_caret, caret_color);
Implement NSTextInputClient protocol for IME
2017-08-07 13:09:56 +02:00
}
Cleanup and unify keyboard input. - Unify keycode values (secondary label printed on a key), remove unused hardcoded Latin-1 codes. - Unify IME behaviour, add inline composition string display on Windows and X11. - Add key_label (localized label printed on a key) value to the key events, and allow mapping actions to the unshifted Unicode events. - Add support for physical keyboard (Bluetooth or Sidecar) handling on iOS. - Add support for media key handling on macOS. Co-authored-by: Raul Santos <raulsntos@gmail.com>
2022-12-11 00:21:22 +01:00
}
if (!ime_text.is_empty()) {
[Complex Text Layouts] Refactor Label and LineEdit controls.
2020-09-09 15:00:32 +02:00
{
Fixes small typos and grammar correction
2021-03-12 14:35:16 +01:00
// IME intermediate text range.
Rename LineEdit caret_* properties getters and setters to match property
2021-03-28 20:31:25 +02:00
Vector<Vector2> sel = TS->shaped_text_get_selection(text_rid, caret_column, caret_column + ime_text.length());
[Complex Text Layouts] Refactor Label and LineEdit controls.
2020-09-09 15:00:32 +02:00
for (int i = 0; i < sel.size(); i++) {
Rect2 rect = Rect2(sel[i].x + ofs.x, ofs.y, sel[i].y - sel[i].x, text_height);
if (rect.position.x + rect.size.x <= x_ofs || rect.position.x > ofs_max) {
continue;
}
if (rect.position.x < x_ofs) {
rect.size.x -= (x_ofs - rect.position.x);
rect.position.x = x_ofs;
} else if (rect.position.x + rect.size.x > ofs_max) {
rect.size.x = ofs_max - rect.position.x;
}
rect.size.y = caret_width;
Rename LineEdit caret_* properties getters and setters to match property
2021-03-28 20:31:25 +02:00
RenderingServer::get_singleton()->canvas_item_add_rect(ci, rect, caret_color);
[Complex Text Layouts] Refactor Label and LineEdit controls.
2020-09-09 15:00:32 +02:00
}
}
{
// IME caret.
Cleanup and unify keyboard input. - Unify keycode values (secondary label printed on a key), remove unused hardcoded Latin-1 codes. - Unify IME behaviour, add inline composition string display on Windows and X11. - Add key_label (localized label printed on a key) value to the key events, and allow mapping actions to the unshifted Unicode events. - Add support for physical keyboard (Bluetooth or Sidecar) handling on iOS. - Add support for media key handling on macOS. Co-authored-by: Raul Santos <raulsntos@gmail.com>
2022-12-11 00:21:22 +01:00
if (ime_selection.y > 0) {
Vector<Vector2> sel = TS->shaped_text_get_selection(text_rid, caret_column + ime_selection.x, caret_column + ime_selection.x + ime_selection.y);
for (int i = 0; i < sel.size(); i++) {
Rect2 rect = Rect2(sel[i].x + ofs.x, ofs.y, sel[i].y - sel[i].x, text_height);
if (rect.position.x + rect.size.x <= x_ofs || rect.position.x > ofs_max) {
continue;
}
if (rect.position.x < x_ofs) {
rect.size.x -= (x_ofs - rect.position.x);
rect.position.x = x_ofs;
} else if (rect.position.x + rect.size.x > ofs_max) {
rect.size.x = ofs_max - rect.position.x;
}
rect.size.y = caret_width * 3;
RenderingServer::get_singleton()->canvas_item_add_rect(ci, rect, caret_color);
[Complex Text Layouts] Refactor Label and LineEdit controls.
2020-09-09 15:00:32 +02:00
}
Fixed caret alignment with placeholder text
2019-12-01 15:27:39 +01:00
}
}
Implement NSTextInputClient protocol for IME
2017-08-07 13:09:56 +02:00
}
Added caret blink to line edit
2016-06-21 01:05:52 +02:00
}
IME window follow the input cursor. Abstruct set_ime_position to OS class. Update ime position for LineEdit and TextEdit.
2017-06-25 17:50:45 +02:00
if (has_focus()) {
Add IME support checks in LineEdit/TextEdit. Avoid spamming "IME is unsupported" when the DisplayServer report it as such.
2021-03-11 20:31:40 +01:00
if (get_viewport()->get_window_id() != DisplayServer::INVALID_WINDOW_ID && DisplayServer::get_singleton()->has_feature(DisplayServer::FEATURE_IME)) {
Add macOS DisplayServer implementation. Change global menu to use Callable, add support for check items and submenus.
2020-03-07 17:02:54 +01:00
DisplayServer::get_singleton()->window_set_ime_active(true, get_viewport()->get_window_id());
Fix IME position in the single window mode sub-windows.
2023-03-06 08:19:21 +01:00
Point2 pos = Point2(get_caret_pixel_pos().x, (get_size().y + theme_cache.font->get_height(theme_cache.font_size)) / 2) + get_global_position();
if (get_window()->get_embedder()) {
pos += get_viewport()->get_popup_base_transform().get_origin();
}
DisplayServer::get_singleton()->window_set_ime_position(pos, get_viewport()->get_window_id());
Add macOS DisplayServer implementation. Change global menu to use Callable, add support for check items and submenus.
2020-03-07 17:02:54 +01:00
}
IME window follow the input cursor. Abstruct set_ime_position to OS class. Update ime position for LineEdit and TextEdit.
2017-06-25 17:50:45 +02:00
}
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
} break;
Use `switch` consistently in `_notification` (`scene` folder)
2022-02-15 18:06:48 +01:00
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
case NOTIFICATION_FOCUS_ENTER: {
Improve caret drawing conditions for `LineEdit` Now, `caret_can_draw` will be validated when a condition that affects the drawability of the `LineEdit`'s caret changes; `draw_caret` will be toggled when the caret's visibility is toggled due to blink, and `draw_caret` will be `false` when `caret_blink_enabled` is disabled. Fix toggling `caret_blink_enabled` could cause caret to no longer be displayed. Fix opening the context menu causing caret to no longer appear.
2022-10-09 10:51:01 +02:00
_validate_caret_can_draw();
Line edit caret no longer draws on focus loss
2016-06-21 01:16:18 +02:00
Allow selecting SpinBox & LineEdit text when focus enters
2022-10-16 14:37:35 +02:00
if (select_all_on_focus) {
if (Input::get_singleton()->is_mouse_button_pressed(MouseButton::LEFT)) {
// Select all when the mouse button is up.
pending_select_all_on_focus = true;
} else {
select_all();
}
}
Add IME support checks in LineEdit/TextEdit. Avoid spamming "IME is unsupported" when the DisplayServer report it as such.
2021-03-11 20:31:40 +01:00
if (get_viewport()->get_window_id() != DisplayServer::INVALID_WINDOW_ID && DisplayServer::get_singleton()->has_feature(DisplayServer::FEATURE_IME)) {
Add macOS DisplayServer implementation. Change global menu to use Callable, add support for check items and submenus.
2020-03-07 17:02:54 +01:00
DisplayServer::get_singleton()->window_set_ime_active(true, get_viewport()->get_window_id());
Fix IME position in the single window mode sub-windows.
2023-03-06 08:19:21 +01:00
Point2 pos = Point2(get_caret_pixel_pos().x, (get_size().y + theme_cache.font->get_height(theme_cache.font_size)) / 2) + get_global_position();
if (get_window()->get_embedder()) {
pos += get_viewport()->get_popup_base_transform().get_origin();
}
DisplayServer::get_singleton()->window_set_ime_position(pos, get_viewport()->get_window_id());
Add macOS DisplayServer implementation. Change global menu to use Callable, add support for check items and submenus.
2020-03-07 17:02:54 +01:00
}
IME window follow the input cursor. Abstruct set_ime_position to OS class. Update ime position for LineEdit and TextEdit.
2017-06-25 17:50:45 +02:00
[GUI] Enforce virtual keyboard redisplay on clear
2021-01-18 18:08:42 +01:00
show_virtual_keyboard();
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
} break;
Use `switch` consistently in `_notification` (`scene` folder)
2022-02-15 18:06:48 +01:00
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
case NOTIFICATION_FOCUS_EXIT: {
Improve caret drawing conditions for `LineEdit` Now, `caret_can_draw` will be validated when a condition that affects the drawability of the `LineEdit`'s caret changes; `draw_caret` will be toggled when the caret's visibility is toggled due to blink, and `draw_caret` will be `false` when `caret_blink_enabled` is disabled. Fix toggling `caret_blink_enabled` could cause caret to no longer be displayed. Fix opening the context menu causing caret to no longer appear.
2022-10-09 10:51:01 +02:00
_validate_caret_can_draw();
TextEdit & LineEdit caret blink timers run only when focused (fixes #31936)
2019-09-04 13:06:15 +02:00
Add IME support checks in LineEdit/TextEdit. Avoid spamming "IME is unsupported" when the DisplayServer report it as such.
2021-03-11 20:31:40 +01:00
if (get_viewport()->get_window_id() != DisplayServer::INVALID_WINDOW_ID && DisplayServer::get_singleton()->has_feature(DisplayServer::FEATURE_IME)) {
Add macOS DisplayServer implementation. Change global menu to use Callable, add support for check items and submenus.
2020-03-07 17:02:54 +01:00
DisplayServer::get_singleton()->window_set_ime_position(Point2(), get_viewport()->get_window_id());
DisplayServer::get_singleton()->window_set_ime_active(false, get_viewport()->get_window_id());
}
Implement NSTextInputClient protocol for IME
2017-08-07 13:09:56 +02:00
ime_text = "";
ime_selection = Point2();
[Complex Text Layouts] Refactor Label and LineEdit controls.
2020-09-09 15:00:32 +02:00
_shape();
Code style improvements to text_edit and related
2023-03-08 23:00:27 +01:00
set_caret_column(caret_column); // Update scroll_offset.
IME window follow the input cursor. Abstruct set_ime_position to OS class. Update ime position for LineEdit and TextEdit.
2017-06-25 17:50:45 +02:00
Add option to disable virtual keyboard for LineEdit Co-authored-by: Alexander Holland <alexander.holland@live.de>
2020-07-22 08:04:48 +02:00
if (DisplayServer::get_singleton()->has_feature(DisplayServer::FEATURE_VIRTUAL_KEYBOARD) && virtual_keyboard_enabled) {
Effective DisplayServer separation, rename X11 -> LinuxBSD
2020-03-03 14:36:29 +01:00
DisplayServer::get_singleton()->virtual_keyboard_hide();
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
}
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
Fix drag and drop on LineEdit
2021-10-28 09:07:18 +02:00
if (deselect_on_focus_loss_enabled && !selection.drag_attempt) {
Add option to make selection unique
2021-10-21 23:02:46 +02:00
deselect();
}
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
} break;
Use `switch` consistently in `_notification` (`scene` folder)
2022-02-15 18:06:48 +01:00
Changes IME input to use notification instead of callback, exposes IME methods to gdscript/gdnative.
2018-11-23 13:07:48 +01:00
case MainLoop::NOTIFICATION_OS_IME_UPDATE: {
Update IME text only for focused input controls.
2019-01-08 21:52:56 +01:00
if (has_focus()) {
Effective DisplayServer separation, rename X11 -> LinuxBSD
2020-03-03 14:36:29 +01:00
ime_text = DisplayServer::get_singleton()->ime_get_text();
ime_selection = DisplayServer::get_singleton()->ime_get_selection();
Cleanup and unify keyboard input. - Unify keycode values (secondary label printed on a key), remove unused hardcoded Latin-1 codes. - Unify IME behaviour, add inline composition string display on Windows and X11. - Add key_label (localized label printed on a key) value to the key events, and allow mapping actions to the unshifted Unicode events. - Add support for physical keyboard (Bluetooth or Sidecar) handling on iOS. - Add support for media key handling on macOS. Co-authored-by: Raul Santos <raulsntos@gmail.com>
2022-12-11 00:21:22 +01:00
if (!ime_text.is_empty()) {
selection_delete();
}
[Complex Text Layouts] Refactor Label and LineEdit controls.
2020-09-09 15:00:32 +02:00
_shape();
Code style improvements to text_edit and related
2023-03-08 23:00:27 +01:00
set_caret_column(caret_column); // Update scroll_offset.
[Complex Text Layouts] Refactor Label and LineEdit controls.
2020-09-09 15:00:32 +02:00
Rename `CanvasItem.update()` to `queue_redraw()` Affects a lot of classes. Very thoroughly checked signal connections and deferred calls to this method, add_do_method/add_undo_method calls, and so on. Also renames the internal `_update_callback()` to `_redraw_callback()` for consistency. Just a few comments have also been changed to say "redraw". In CPUParticles2D, there was a private variable with the same name. It has been renamed to `do_redraw`.
2022-08-13 23:21:24 +02:00
queue_redraw();
Update IME text only for focused input controls.
2019-01-08 21:52:56 +01:00
}
Changes IME input to use notification instead of callback, exposes IME methods to gdscript/gdnative.
2018-11-23 13:07:48 +01:00
} break;
Use `switch` consistently in `_notification` (`scene` folder)
2022-02-15 18:06:48 +01:00
case NOTIFICATION_DRAG_BEGIN: {
Fix drag and drop on LineEdit
2021-10-28 09:07:18 +02:00
drag_action = true;
} break;
Use `switch` consistently in `_notification` (`scene` folder)
2022-02-15 18:06:48 +01:00
case NOTIFICATION_DRAG_END: {
Fix drag and drop on LineEdit
2021-10-28 09:07:18 +02:00
if (is_drag_successful()) {
if (selection.drag_attempt) {
selection.drag_attempt = false;
Replace Ctrl in editor shortcuts with Cmd or Ctrl depending on platform
2023-06-08 23:24:00 +02:00
if (is_editable() && !Input::get_singleton()->is_key_pressed(Key::CMD_OR_CTRL)) {
Fix drag and drop on LineEdit
2021-10-28 09:07:18 +02:00
selection_delete();
} else if (deselect_on_focus_loss_enabled) {
deselect();
}
}
} else {
selection.drag_attempt = false;
}
drag_action = false;
drag_caret_force_displayed = false;
} break;
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
}
}
void LineEdit::copy_text() {
Disable ability to copy or cut text from LineEdit if secret mode is enabled.
2018-08-24 11:35:46 +02:00
if (selection.enabled && !pass) {
Implement LineEdit.get_selected_text()
2023-03-30 17:07:28 +02:00
DisplayServer::get_singleton()->clipboard_set(get_selected_text());
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
}
}
void LineEdit::cut_text() {
Removed hardcoded shortcuts from /scene and converted to input actions This removes hardcoded actions from things like LineEdit and TextEdit. Previously, things like copy, paste, etc were all hardcoded to Ctrl+C, Ctrl+V, etc. They could not be changed. This allows the possibility of them being changed, by making them use the action map. This has the added benefit of greatly simplifying the input handling logic in those controls. The logic which was previously in a huge and hard to follow switch statement has been extracted to individual methods.
2020-12-07 12:32:00 +01:00
if (editable && selection.enabled && !pass) {
Implement LineEdit.get_selected_text()
2023-03-30 17:07:28 +02:00
DisplayServer::get_singleton()->clipboard_set(get_selected_text());
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
selection_delete();
}
}
void LineEdit::paste_text() {
Removed hardcoded shortcuts from /scene and converted to input actions This removes hardcoded actions from things like LineEdit and TextEdit. Previously, things like copy, paste, etc were all hardcoded to Ctrl+C, Ctrl+V, etc. They could not be changed. This allows the possibility of them being changed, by making them use the action map. This has the added benefit of greatly simplifying the input handling logic in those controls. The logic which was previously in a huge and hard to follow switch statement has been extracted to individual methods.
2020-12-07 12:32:00 +01:00
if (!editable) {
return;
}
Fix and expose String::strip_escapes(), use it in LineEdit paste Supersedes #27736.
2019-05-31 15:27:53 +02:00
// Strip escape characters like \n and \t as they can't be displayed on LineEdit.
Effective DisplayServer separation, rename X11 -> LinuxBSD
2020-03-03 14:36:29 +01:00
String paste_buffer = DisplayServer::get_singleton()->clipboard_get().strip_escapes();
remove trailing whitespace
2016-03-09 00:00:52 +01:00
Replace String comparisons with "", String() to is_empty() Also: - Adds two stress tests to test_string.h - Changes to .empty() on std::strings
2021-12-09 10:42:46 +01:00
if (!paste_buffer.is_empty()) {
Add signal for LineEdit overflow event
2020-01-10 21:07:00 +01:00
int prev_len = text.length();
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
if (selection.enabled) {
Style: clang-format: Disable AllowShortIfStatementsOnASingleLine Part of #33027, also discussed in #29848. Enforcing the use of brackets even on single line statements would be preferred, but `clang-format` doesn't have this functionality yet.
2020-05-10 12:56:01 +02:00
selection_delete();
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
}
Rename LineEdit caret_* properties getters and setters to match property
2021-03-28 20:31:25 +02:00
insert_text_at_caret(paste_buffer);
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
Fixed #15082: line edit emits two "text_changed" signals when pasting while text is selected
2018-02-05 16:22:34 +01:00
if (!text_changed_dirty) {
Add signal for LineEdit overflow event
2020-01-10 21:07:00 +01:00
if (is_inside_tree() && text.length() != prev_len) {
Update deferred calls to use Callables
2023-12-18 15:46:56 +01:00
callable_mp(this, &LineEdit::_text_changed).call_deferred();
Fixed #15082: line edit emits two "text_changed" signals when pasting while text is selected
2018-02-05 16:22:34 +01:00
}
text_changed_dirty = true;
}
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
}
Default editing popup for LineEdit and TextEdit
2016-05-17 01:25:17 +02:00
}
Improve Undo/Redo menu items * Make Undo/Redo menu items disabled when clicking it does nothing. * Context menu of `TextEdit` * Context menu of `LineEdit` * Editor's Scene menu * Script editor's Edit menu and context menu (for Script and Text) * Make editor undo/redo log messages translatable. * Mark `UndoRedo`'s `has_{un,re}do()` methods as `const`. * Expose `TextEdit`'s `has_{un,re}do()` to scripts since `{un,re}do()` are already available.
2021-08-17 05:41:46 +02:00
bool LineEdit::has_undo() const {
if (undo_stack_pos == nullptr) {
return undo_stack.size() > 1;
}
return undo_stack_pos != undo_stack.front();
}
bool LineEdit::has_redo() const {
return undo_stack_pos != nullptr && undo_stack_pos != undo_stack.back();
}
Default editing popup for LineEdit and TextEdit
2016-05-17 01:25:17 +02:00
void LineEdit::undo() {
Removed hardcoded shortcuts from /scene and converted to input actions This removes hardcoded actions from things like LineEdit and TextEdit. Previously, things like copy, paste, etc were all hardcoded to Ctrl+C, Ctrl+V, etc. They could not be changed. This allows the possibility of them being changed, by making them use the action map. This has the added benefit of greatly simplifying the input handling logic in those controls. The logic which was previously in a huge and hard to follow switch statement has been extracted to individual methods.
2020-12-07 12:32:00 +01:00
if (!editable) {
return;
}
Replace NULL with nullptr
2020-04-02 01:20:12 +02:00
if (undo_stack_pos == nullptr) {
Added multi level undo redo to line edit
2017-10-30 00:14:33 +01:00
if (undo_stack.size() <= 1) {
return;
}
undo_stack_pos = undo_stack.back();
} else if (undo_stack_pos == undo_stack.front()) {
return;
Default editing popup for LineEdit and TextEdit
2016-05-17 01:25:17 +02:00
}
Fix drag and drop on LineEdit
2021-10-28 09:07:18 +02:00
deselect();
Added multi level undo redo to line edit
2017-10-30 00:14:33 +01:00
undo_stack_pos = undo_stack_pos->prev();
TextOperation op = undo_stack_pos->get();
text = op.text;
Expose LineEdit scroll offset to scripts
2020-11-11 09:26:55 +01:00
scroll_offset = op.scroll_offset;
Call minimum_size_changed() on redo/undo if expand_to_text_length is true Fixes #28241
2019-04-21 10:51:10 +02:00
[Complex Text Layouts] Refactor Label and LineEdit controls.
2020-09-09 15:00:32 +02:00
_shape();
Fix LineEdit caret rendering/positioning on Undo.
2024-01-09 18:14:55 +01:00
set_caret_column(op.caret_column);
Added multi level undo redo to line edit
2017-10-30 00:14:33 +01:00
_emit_text_change();
}
Default editing popup for LineEdit and TextEdit
2016-05-17 01:25:17 +02:00
Added multi level undo redo to line edit
2017-10-30 00:14:33 +01:00
void LineEdit::redo() {
Removed hardcoded shortcuts from /scene and converted to input actions This removes hardcoded actions from things like LineEdit and TextEdit. Previously, things like copy, paste, etc were all hardcoded to Ctrl+C, Ctrl+V, etc. They could not be changed. This allows the possibility of them being changed, by making them use the action map. This has the added benefit of greatly simplifying the input handling logic in those controls. The logic which was previously in a huge and hard to follow switch statement has been extracted to individual methods.
2020-12-07 12:32:00 +01:00
if (!editable) {
return;
}
Replace NULL with nullptr
2020-04-02 01:20:12 +02:00
if (undo_stack_pos == nullptr) {
Added multi level undo redo to line edit
2017-10-30 00:14:33 +01:00
return;
}
if (undo_stack_pos == undo_stack.back()) {
return;
}
Fix drag and drop on LineEdit
2021-10-28 09:07:18 +02:00
deselect();
Added multi level undo redo to line edit
2017-10-30 00:14:33 +01:00
undo_stack_pos = undo_stack_pos->next();
TextOperation op = undo_stack_pos->get();
text = op.text;
Expose LineEdit scroll offset to scripts
2020-11-11 09:26:55 +01:00
scroll_offset = op.scroll_offset;
Call minimum_size_changed() on redo/undo if expand_to_text_length is true Fixes #28241
2019-04-21 10:51:10 +02:00
[Complex Text Layouts] Refactor Label and LineEdit controls.
2020-09-09 15:00:32 +02:00
_shape();
Fix LineEdit caret rendering/positioning on Undo.
2024-01-09 18:14:55 +01:00
set_caret_column(op.caret_column);
Added multi level undo redo to line edit
2017-10-30 00:14:33 +01:00
_emit_text_change();
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
}
void LineEdit::shift_selection_check_pre(bool p_shift) {
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
if (!selection.enabled && p_shift) {
Rename LineEdit caret_* properties getters and setters to match property
2021-03-28 20:31:25 +02:00
selection.start_column = caret_column;
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
}
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
if (!p_shift) {
Exposed LineEdit's "selection_clear" and renamed it to "deselect".
2017-12-17 18:40:44 +01:00
deselect();
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
}
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
}
void LineEdit::shift_selection_check_post(bool p_shift) {
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
if (p_shift) {
Rename LineEdit caret_* properties getters and setters to match property
2021-03-28 20:31:25 +02:00
selection_fill_at_caret();
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
}
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
}
Rename LineEdit caret_* properties getters and setters to match property
2021-03-28 20:31:25 +02:00
void LineEdit::set_caret_at_pixel_pos(int p_x) {
Add a lifecycle method for manual theme item caching to Control
2022-08-31 14:02:40 +02:00
Ref<StyleBox> style = theme_cache.normal;
[Complex Text Layouts] Refactor Label and LineEdit controls.
2020-09-09 15:00:32 +02:00
bool rtl = is_layout_rtl();
Added alignment to LineEdit GUI control.
2015-08-15 08:47:22 +02:00
[Complex Text Layouts] Refactor Label and LineEdit controls.
2020-09-09 15:00:32 +02:00
int x_ofs = 0;
float text_width = TS->shaped_text_get_size(text_rid).x;
align to horizontal_alignment, valign to vertical_alignment, related
2021-11-25 03:58:47 +01:00
switch (alignment) {
case HORIZONTAL_ALIGNMENT_FILL:
case HORIZONTAL_ALIGNMENT_LEFT: {
[Complex Text Layouts] Refactor Label and LineEdit controls.
2020-09-09 15:00:32 +02:00
if (rtl) {
Rename Control margin to offset
2020-12-22 17:24:29 +01:00
x_ofs = MAX(style->get_margin(SIDE_LEFT), int(get_size().width - style->get_margin(SIDE_RIGHT) - (text_width)));
[Complex Text Layouts] Refactor Label and LineEdit controls.
2020-09-09 15:00:32 +02:00
} else {
x_ofs = style->get_offset().x;
}
Added alignment to LineEdit GUI control.
2015-08-15 08:47:22 +02:00
} break;
align to horizontal_alignment, valign to vertical_alignment, related
2021-11-25 03:58:47 +01:00
case HORIZONTAL_ALIGNMENT_CENTER: {
Fix LineEdit text incorrectly trimmed due to rounding errors.
2022-07-06 10:57:06 +02:00
if (!Math::is_zero_approx(scroll_offset)) {
[Complex Text Layouts] Refactor Label and LineEdit controls.
2020-09-09 15:00:32 +02:00
x_ofs = style->get_offset().x;
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
} else {
Rename Control margin to offset
2020-12-22 17:24:29 +01:00
x_ofs = MAX(style->get_margin(SIDE_LEFT), int(get_size().width - (text_width)) / 2);
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
}
Added alignment to LineEdit GUI control.
2015-08-15 08:47:22 +02:00
} break;
align to horizontal_alignment, valign to vertical_alignment, related
2021-11-25 03:58:47 +01:00
case HORIZONTAL_ALIGNMENT_RIGHT: {
[Complex Text Layouts] Refactor Label and LineEdit controls.
2020-09-09 15:00:32 +02:00
if (rtl) {
x_ofs = style->get_offset().x;
} else {
Rename Control margin to offset
2020-12-22 17:24:29 +01:00
x_ofs = MAX(style->get_margin(SIDE_LEFT), int(get_size().width - style->get_margin(SIDE_RIGHT) - (text_width)));
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
}
Added alignment to LineEdit GUI control.
2015-08-15 08:47:22 +02:00
} break;
}
Rename empty() to is_empty()
2020-12-15 13:04:21 +01:00
bool using_placeholder = text.is_empty() && ime_text.is_empty();
[Complex Text Layouts] Refactor Label and LineEdit controls.
2020-09-09 15:00:32 +02:00
bool display_clear_icon = !using_placeholder && is_editable() && clear_button_enabled;
if (right_icon.is_valid() || display_clear_icon) {
Add a lifecycle method for manual theme item caching to Control
2022-08-31 14:02:40 +02:00
Ref<Texture2D> r_icon = display_clear_icon ? theme_cache.clear_icon : right_icon;
align to horizontal_alignment, valign to vertical_alignment, related
2021-11-25 03:58:47 +01:00
if (alignment == HORIZONTAL_ALIGNMENT_CENTER) {
Fix LineEdit text incorrectly trimmed due to rounding errors.
2022-07-06 10:57:06 +02:00
if (Math::is_zero_approx(scroll_offset)) {
Rename Control margin to offset
2020-12-22 17:24:29 +01:00
x_ofs = MAX(style->get_margin(SIDE_LEFT), int(get_size().width - text_width - r_icon->get_width() - style->get_margin(SIDE_RIGHT) * 2) / 2);
[Complex Text Layouts] Refactor Label and LineEdit controls.
2020-09-09 15:00:32 +02:00
}
} else {
Rename Control margin to offset
2020-12-22 17:24:29 +01:00
x_ofs = MAX(style->get_margin(SIDE_LEFT), x_ofs - r_icon->get_width() - style->get_margin(SIDE_RIGHT));
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
}
}
remove trailing whitespace
2016-03-09 00:00:52 +01:00
Fix LineEdit text incorrectly trimmed due to rounding errors.
2022-07-06 10:57:06 +02:00
int ofs = ceil(TS->shaped_text_hit_test_position(text_rid, p_x - x_ofs - scroll_offset));
[TextServer] Fix system font fallback and caret/selection behavior for composite characters.
2023-08-15 10:42:40 +02:00
if (!caret_mid_grapheme_enabled) {
ofs = TS->shaped_text_closest_character_pos(text_rid, ofs);
}
Rename LineEdit caret_* properties getters and setters to match property
2021-03-28 20:31:25 +02:00
set_caret_column(ofs);
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
}
Fix LineEdit text incorrectly trimmed due to rounding errors.
2022-07-06 10:57:06 +02:00
Vector2 LineEdit::get_caret_pixel_pos() {
Add a lifecycle method for manual theme item caching to Control
2022-08-31 14:02:40 +02:00
Ref<StyleBox> style = theme_cache.normal;
[Complex Text Layouts] Refactor Label and LineEdit controls.
2020-09-09 15:00:32 +02:00
bool rtl = is_layout_rtl();
Support menu key in TextEdit and LineEdit controls Related to #15542
2019-06-22 20:22:52 +02:00
[Complex Text Layouts] Refactor Label and LineEdit controls.
2020-09-09 15:00:32 +02:00
int x_ofs = 0;
float text_width = TS->shaped_text_get_size(text_rid).x;
align to horizontal_alignment, valign to vertical_alignment, related
2021-11-25 03:58:47 +01:00
switch (alignment) {
case HORIZONTAL_ALIGNMENT_FILL:
case HORIZONTAL_ALIGNMENT_LEFT: {
[Complex Text Layouts] Refactor Label and LineEdit controls.
2020-09-09 15:00:32 +02:00
if (rtl) {
Rename Control margin to offset
2020-12-22 17:24:29 +01:00
x_ofs = MAX(style->get_margin(SIDE_LEFT), int(get_size().width - style->get_margin(SIDE_RIGHT) - (text_width)));
[Complex Text Layouts] Refactor Label and LineEdit controls.
2020-09-09 15:00:32 +02:00
} else {
x_ofs = style->get_offset().x;
}
Support menu key in TextEdit and LineEdit controls Related to #15542
2019-06-22 20:22:52 +02:00
} break;
align to horizontal_alignment, valign to vertical_alignment, related
2021-11-25 03:58:47 +01:00
case HORIZONTAL_ALIGNMENT_CENTER: {
Fix LineEdit text incorrectly trimmed due to rounding errors.
2022-07-06 10:57:06 +02:00
if (!Math::is_zero_approx(scroll_offset)) {
[Complex Text Layouts] Refactor Label and LineEdit controls.
2020-09-09 15:00:32 +02:00
x_ofs = style->get_offset().x;
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
} else {
Rename Control margin to offset
2020-12-22 17:24:29 +01:00
x_ofs = MAX(style->get_margin(SIDE_LEFT), int(get_size().width - (text_width)) / 2);
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
}
Support menu key in TextEdit and LineEdit controls Related to #15542
2019-06-22 20:22:52 +02:00
} break;
align to horizontal_alignment, valign to vertical_alignment, related
2021-11-25 03:58:47 +01:00
case HORIZONTAL_ALIGNMENT_RIGHT: {
[Complex Text Layouts] Refactor Label and LineEdit controls.
2020-09-09 15:00:32 +02:00
if (rtl) {
x_ofs = style->get_offset().x;
} else {
Rename Control margin to offset
2020-12-22 17:24:29 +01:00
x_ofs = MAX(style->get_margin(SIDE_LEFT), int(get_size().width - style->get_margin(SIDE_RIGHT) - (text_width)));
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
}
Support menu key in TextEdit and LineEdit controls Related to #15542
2019-06-22 20:22:52 +02:00
} break;
}
Rename empty() to is_empty()
2020-12-15 13:04:21 +01:00
bool using_placeholder = text.is_empty() && ime_text.is_empty();
[Complex Text Layouts] Refactor Label and LineEdit controls.
2020-09-09 15:00:32 +02:00
bool display_clear_icon = !using_placeholder && is_editable() && clear_button_enabled;
if (right_icon.is_valid() || display_clear_icon) {
Add a lifecycle method for manual theme item caching to Control
2022-08-31 14:02:40 +02:00
Ref<Texture2D> r_icon = display_clear_icon ? theme_cache.clear_icon : right_icon;
align to horizontal_alignment, valign to vertical_alignment, related
2021-11-25 03:58:47 +01:00
if (alignment == HORIZONTAL_ALIGNMENT_CENTER) {
Fix LineEdit text incorrectly trimmed due to rounding errors.
2022-07-06 10:57:06 +02:00
if (Math::is_zero_approx(scroll_offset)) {
Rename Control margin to offset
2020-12-22 17:24:29 +01:00
x_ofs = MAX(style->get_margin(SIDE_LEFT), int(get_size().width - text_width - r_icon->get_width() - style->get_margin(SIDE_RIGHT) * 2) / 2);
[Complex Text Layouts] Refactor Label and LineEdit controls.
2020-09-09 15:00:32 +02:00
}
} else {
Rename Control margin to offset
2020-12-22 17:24:29 +01:00
x_ofs = MAX(style->get_margin(SIDE_LEFT), x_ofs - r_icon->get_width() - style->get_margin(SIDE_RIGHT));
[Complex Text Layouts] Refactor Label and LineEdit controls.
2020-09-09 15:00:32 +02:00
}
}
Fix LineEdit text incorrectly trimmed due to rounding errors.
2022-07-06 10:57:06 +02:00
Vector2 ret;
Implement TextServer GDExtension interface, remove TextServer GDNative interface.
2021-08-27 23:19:51 +02:00
CaretInfo caret;
[Complex Text Layouts] Refactor Label and LineEdit controls.
2020-09-09 15:00:32 +02:00
// Get position of the start of caret.
if (ime_text.length() != 0 && ime_selection.x != 0) {
Implement TextServer GDExtension interface, remove TextServer GDNative interface.
2021-08-27 23:19:51 +02:00
caret = TS->shaped_text_get_carets(text_rid, caret_column + ime_selection.x);
[Complex Text Layouts] Refactor Label and LineEdit controls.
2020-09-09 15:00:32 +02:00
} else {
Implement TextServer GDExtension interface, remove TextServer GDNative interface.
2021-08-27 23:19:51 +02:00
caret = TS->shaped_text_get_carets(text_rid, caret_column);
[Complex Text Layouts] Refactor Label and LineEdit controls.
2020-09-09 15:00:32 +02:00
}
Implement TextServer GDExtension interface, remove TextServer GDNative interface.
2021-08-27 23:19:51 +02:00
if ((caret.l_caret != Rect2() && (caret.l_dir == TextServer::DIRECTION_AUTO || caret.l_dir == (TextServer::Direction)input_direction)) || (caret.t_caret == Rect2())) {
ret.x = x_ofs + caret.l_caret.position.x + scroll_offset;
[Complex Text Layouts] Refactor Label and LineEdit controls.
2020-09-09 15:00:32 +02:00
} else {
Implement TextServer GDExtension interface, remove TextServer GDNative interface.
2021-08-27 23:19:51 +02:00
ret.x = x_ofs + caret.t_caret.position.x + scroll_offset;
[Complex Text Layouts] Refactor Label and LineEdit controls.
2020-09-09 15:00:32 +02:00
}
// Get position of the end of caret.
if (ime_text.length() != 0) {
if (ime_selection.y != 0) {
Implement TextServer GDExtension interface, remove TextServer GDNative interface.
2021-08-27 23:19:51 +02:00
caret = TS->shaped_text_get_carets(text_rid, caret_column + ime_selection.x + ime_selection.y);
[Complex Text Layouts] Refactor Label and LineEdit controls.
2020-09-09 15:00:32 +02:00
} else {
Implement TextServer GDExtension interface, remove TextServer GDNative interface.
2021-08-27 23:19:51 +02:00
caret = TS->shaped_text_get_carets(text_rid, caret_column + ime_text.size());
[Complex Text Layouts] Refactor Label and LineEdit controls.
2020-09-09 15:00:32 +02:00
}
Implement TextServer GDExtension interface, remove TextServer GDNative interface.
2021-08-27 23:19:51 +02:00
if ((caret.l_caret != Rect2() && (caret.l_dir == TextServer::DIRECTION_AUTO || caret.l_dir == (TextServer::Direction)input_direction)) || (caret.t_caret == Rect2())) {
ret.y = x_ofs + caret.l_caret.position.x + scroll_offset;
[Complex Text Layouts] Refactor Label and LineEdit controls.
2020-09-09 15:00:32 +02:00
} else {
Implement TextServer GDExtension interface, remove TextServer GDNative interface.
2021-08-27 23:19:51 +02:00
ret.y = x_ofs + caret.t_caret.position.x + scroll_offset;
Support menu key in TextEdit and LineEdit controls Related to #15542
2019-06-22 20:22:52 +02:00
}
[Complex Text Layouts] Refactor Label and LineEdit controls.
2020-09-09 15:00:32 +02:00
} else {
ret.y = ret.x;
Support menu key in TextEdit and LineEdit controls Related to #15542
2019-06-22 20:22:52 +02:00
}
[Complex Text Layouts] Refactor Label and LineEdit controls.
2020-09-09 15:00:32 +02:00
return ret;
}
Rename LineEdit caret_* properties getters and setters to match property
2021-03-28 20:31:25 +02:00
void LineEdit::set_caret_mid_grapheme_enabled(const bool p_enabled) {
caret_mid_grapheme_enabled = p_enabled;
[Complex Text Layouts] Refactor Label and LineEdit controls.
2020-09-09 15:00:32 +02:00
}
Rename LineEdit caret_* properties getters and setters to match property
2021-03-28 20:31:25 +02:00
bool LineEdit::is_caret_mid_grapheme_enabled() const {
return caret_mid_grapheme_enabled;
Support menu key in TextEdit and LineEdit controls Related to #15542
2019-06-22 20:22:52 +02:00
}
Rename LineEdit caret_* properties getters and setters to match property
2021-03-28 20:31:25 +02:00
bool LineEdit::is_caret_blink_enabled() const {
Added caret blink to line edit
2016-06-21 01:05:52 +02:00
return caret_blink_enabled;
}
Rename LineEdit caret_* properties getters and setters to match property
2021-03-28 20:31:25 +02:00
void LineEdit::set_caret_blink_enabled(const bool p_enabled) {
Improve caret drawing conditions for `LineEdit` Now, `caret_can_draw` will be validated when a condition that affects the drawability of the `LineEdit`'s caret changes; `draw_caret` will be toggled when the caret's visibility is toggled due to blink, and `draw_caret` will be `false` when `caret_blink_enabled` is disabled. Fix toggling `caret_blink_enabled` could cause caret to no longer be displayed. Fix opening the context menu causing caret to no longer appear.
2022-10-09 10:51:01 +02:00
if (caret_blink_enabled == p_enabled) {
return;
}
Added caret blink to line edit
2016-06-21 01:05:52 +02:00
caret_blink_enabled = p_enabled;
Change LineEdit caret blink to use process Now using internal process for blinking instead of a Timer node
2022-07-04 23:17:34 +02:00
set_process_internal(p_enabled);
TextEdit & LineEdit caret blink timers run only when focused (fixes #31936)
2019-09-04 13:06:15 +02:00
Improve caret drawing conditions for `LineEdit` Now, `caret_can_draw` will be validated when a condition that affects the drawability of the `LineEdit`'s caret changes; `draw_caret` will be toggled when the caret's visibility is toggled due to blink, and `draw_caret` will be `false` when `caret_blink_enabled` is disabled. Fix toggling `caret_blink_enabled` could cause caret to no longer be displayed. Fix opening the context menu causing caret to no longer appear.
2022-10-09 10:51:01 +02:00
draw_caret = !caret_blink_enabled;
if (caret_blink_enabled) {
caret_blink_timer = 0.0;
Added caret blink to line edit
2016-06-21 01:05:52 +02:00
}
Improve caret drawing conditions for `LineEdit` Now, `caret_can_draw` will be validated when a condition that affects the drawability of the `LineEdit`'s caret changes; `draw_caret` will be toggled when the caret's visibility is toggled due to blink, and `draw_caret` will be `false` when `caret_blink_enabled` is disabled. Fix toggling `caret_blink_enabled` could cause caret to no longer be displayed. Fix opening the context menu causing caret to no longer appear.
2022-10-09 10:51:01 +02:00
queue_redraw();
Hide more options of disabled properties
2021-03-04 00:51:35 +01:00
notify_property_list_changed();
Added caret blink to line edit
2016-06-21 01:05:52 +02:00
}
Rename LineEdit caret_* properties getters and setters to match property
2021-03-28 20:31:25 +02:00
bool LineEdit::is_caret_force_displayed() const {
add force caret display to line edit
2020-06-21 19:15:57 +02:00
return caret_force_displayed;
}
Rename LineEdit caret_* properties getters and setters to match property
2021-03-28 20:31:25 +02:00
void LineEdit::set_caret_force_displayed(const bool p_enabled) {
Improve caret drawing conditions for `LineEdit` Now, `caret_can_draw` will be validated when a condition that affects the drawability of the `LineEdit`'s caret changes; `draw_caret` will be toggled when the caret's visibility is toggled due to blink, and `draw_caret` will be `false` when `caret_blink_enabled` is disabled. Fix toggling `caret_blink_enabled` could cause caret to no longer be displayed. Fix opening the context menu causing caret to no longer appear.
2022-10-09 10:51:01 +02:00
if (caret_force_displayed == p_enabled) {
return;
}
add force caret display to line edit
2020-06-21 19:15:57 +02:00
caret_force_displayed = p_enabled;
Improve caret drawing conditions for `LineEdit` Now, `caret_can_draw` will be validated when a condition that affects the drawability of the `LineEdit`'s caret changes; `draw_caret` will be toggled when the caret's visibility is toggled due to blink, and `draw_caret` will be `false` when `caret_blink_enabled` is disabled. Fix toggling `caret_blink_enabled` could cause caret to no longer be displayed. Fix opening the context menu causing caret to no longer appear.
2022-10-09 10:51:01 +02:00
_validate_caret_can_draw();
Rename `CanvasItem.update()` to `queue_redraw()` Affects a lot of classes. Very thoroughly checked signal connections and deferred calls to this method, add_do_method/add_undo_method calls, and so on. Also renames the internal `_update_callback()` to `_redraw_callback()` for consistency. Just a few comments have also been changed to say "redraw". In CPUParticles2D, there was a private variable with the same name. It has been renamed to `do_redraw`.
2022-08-13 23:21:24 +02:00
queue_redraw();
add force caret display to line edit
2020-06-21 19:15:57 +02:00
}
Rename every instance of `caret_blink_speed` to `caret_blink_interval` It's been changed in EditorSettings, LineEdit, TextEdit. Affects setters and getters, and passed parameters, too.
2022-08-13 14:52:35 +02:00
float LineEdit::get_caret_blink_interval() const {
return caret_blink_interval;
Added caret blink to line edit
2016-06-21 01:05:52 +02:00
}
Rename every instance of `caret_blink_speed` to `caret_blink_interval` It's been changed in EditorSettings, LineEdit, TextEdit. Affects setters and getters, and passed parameters, too.
2022-08-13 14:52:35 +02:00
void LineEdit::set_caret_blink_interval(const float p_interval) {
ERR_FAIL_COND(p_interval <= 0);
caret_blink_interval = p_interval;
Added caret blink to line edit
2016-06-21 01:05:52 +02:00
}
void LineEdit::_reset_caret_blink_timer() {
if (caret_blink_enabled) {
draw_caret = true;
Improve caret drawing conditions for `LineEdit` Now, `caret_can_draw` will be validated when a condition that affects the drawability of the `LineEdit`'s caret changes; `draw_caret` will be toggled when the caret's visibility is toggled due to blink, and `draw_caret` will be `false` when `caret_blink_enabled` is disabled. Fix toggling `caret_blink_enabled` could cause caret to no longer be displayed. Fix opening the context menu causing caret to no longer appear.
2022-10-09 10:51:01 +02:00
if (caret_can_draw) {
Change LineEdit caret blink to use process Now using internal process for blinking instead of a Timer node
2022-07-04 23:17:34 +02:00
caret_blink_timer = 0.0;
Rename `CanvasItem.update()` to `queue_redraw()` Affects a lot of classes. Very thoroughly checked signal connections and deferred calls to this method, add_do_method/add_undo_method calls, and so on. Also renames the internal `_update_callback()` to `_redraw_callback()` for consistency. Just a few comments have also been changed to say "redraw". In CPUParticles2D, there was a private variable with the same name. It has been renamed to `do_redraw`.
2022-08-13 23:21:24 +02:00
queue_redraw();
TextEdit & LineEdit caret blink timers run only when focused (fixes #31936)
2019-09-04 13:06:15 +02:00
}
Added caret blink to line edit
2016-06-21 01:05:52 +02:00
}
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
}
Added caret blink to line edit
2016-06-21 01:05:52 +02:00
void LineEdit::_toggle_draw_caret() {
draw_caret = !draw_caret;
Improve caret drawing conditions for `LineEdit` Now, `caret_can_draw` will be validated when a condition that affects the drawability of the `LineEdit`'s caret changes; `draw_caret` will be toggled when the caret's visibility is toggled due to blink, and `draw_caret` will be `false` when `caret_blink_enabled` is disabled. Fix toggling `caret_blink_enabled` could cause caret to no longer be displayed. Fix opening the context menu causing caret to no longer appear.
2022-10-09 10:51:01 +02:00
if (is_visible_in_tree() && caret_can_draw) {
Rename `CanvasItem.update()` to `queue_redraw()` Affects a lot of classes. Very thoroughly checked signal connections and deferred calls to this method, add_do_method/add_undo_method calls, and so on. Also renames the internal `_update_callback()` to `_redraw_callback()` for consistency. Just a few comments have also been changed to say "redraw". In CPUParticles2D, there was a private variable with the same name. It has been renamed to `do_redraw`.
2022-08-13 23:21:24 +02:00
queue_redraw();
Added caret blink to line edit
2016-06-21 01:05:52 +02:00
}
}
Improve caret drawing conditions for `LineEdit` Now, `caret_can_draw` will be validated when a condition that affects the drawability of the `LineEdit`'s caret changes; `draw_caret` will be toggled when the caret's visibility is toggled due to blink, and `draw_caret` will be `false` when `caret_blink_enabled` is disabled. Fix toggling `caret_blink_enabled` could cause caret to no longer be displayed. Fix opening the context menu causing caret to no longer appear.
2022-10-09 10:51:01 +02:00
void LineEdit::_validate_caret_can_draw() {
if (caret_blink_enabled) {
draw_caret = true;
caret_blink_timer = 0.0;
}
caret_can_draw = editable && (window_has_focus || (menu && menu->has_focus())) && (has_focus() || caret_force_displayed);
}
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
void LineEdit::delete_char() {
Rename LineEdit caret_* properties getters and setters to match property
2021-03-28 20:31:25 +02:00
if ((text.length() <= 0) || (caret_column == 0)) {
Style: clang-format: Disable AllowShortIfStatementsOnASingleLine Part of #33027, also discussed in #29848. Enforcing the use of brackets even on single line statements would be preferred, but `clang-format` doesn't have this functionality yet.
2020-05-10 12:56:01 +02:00
return;
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
}
remove trailing whitespace
2016-03-09 00:00:52 +01:00
String: Remove `erase` method, bindings can't mutate String
2021-11-11 09:08:08 +01:00
text = text.left(caret_column - 1) + text.substr(caret_column);
[Complex Text Layouts] Refactor Label and LineEdit controls.
2020-09-09 15:00:32 +02:00
_shape();
remove trailing whitespace
2016-03-09 00:00:52 +01:00
Rename LineEdit caret_* properties getters and setters to match property
2021-03-28 20:31:25 +02:00
set_caret_column(get_caret_column() - 1);
remove trailing whitespace
2016-03-09 00:00:52 +01:00
-Added diectly editable expressions on node to VSEditor, closes #6392 -Added ability for LineEdit to expand to fit text
2016-09-07 01:34:24 +02:00
_text_changed();
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
}
LineEdit: Word jumping and OSX hotkeys
2016-06-18 16:15:26 +02:00
void LineEdit::delete_text(int p_from_column, int p_to_column) {
Make text deletion methods public for LineEdit
2020-06-06 17:39:53 +02:00
ERR_FAIL_COND_MSG(p_from_column < 0 || p_from_column > p_to_column || p_to_column > text.length(),
vformat("Positional parameters (from: %d, to: %d) are inverted or outside the text length (%d).", p_from_column, p_to_column, text.length()));
LineEdit: Word jumping and OSX hotkeys
2016-06-18 16:15:26 +02:00
String: Remove `erase` method, bindings can't mutate String
2021-11-11 09:08:08 +01:00
text = text.left(p_from_column) + text.substr(p_to_column);
[Complex Text Layouts] Refactor Label and LineEdit controls.
2020-09-09 15:00:32 +02:00
_shape();
[LineEdit] Update line edit offset on text delete.
2023-09-08 07:58:51 +02:00
set_caret_column(caret_column - CLAMP(caret_column - p_from_column, 0, p_to_column - p_from_column));
Fixed LineEdit alignment when removing text or undo / redo
2019-12-01 14:54:09 +01:00
Fixed #15082: line edit emits two "text_changed" signals when pasting while text is selected
2018-02-05 16:22:34 +01:00
if (!text_changed_dirty) {
if (is_inside_tree()) {
Update deferred calls to use Callables
2023-12-18 15:46:56 +01:00
callable_mp(this, &LineEdit::_text_changed).call_deferred();
Fixed #15082: line edit emits two "text_changed" signals when pasting while text is selected
2018-02-05 16:22:34 +01:00
}
text_changed_dirty = true;
}
LineEdit: Word jumping and OSX hotkeys
2016-06-18 16:15:26 +02:00
}
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
void LineEdit::set_text(String p_text) {
clear_internal();
Rename LineEdit caret_* properties getters and setters to match property
2021-03-28 20:31:25 +02:00
insert_text_at_caret(p_text);
Fix LineEdit undo behaves strangely
2021-04-08 17:43:50 +02:00
_create_undo_state();
Updates LineEdit's min size when necessary These properties will affect the minimum size of LineEdit: * The right icon (`set_right_icon`) * The clear button (`set_editable` and `set_clear_button_enabled`) * The text, when "expand to text length" is enabled (`set_text`)
2020-01-15 02:42:06 +01:00
Rename `CanvasItem.update()` to `queue_redraw()` Affects a lot of classes. Very thoroughly checked signal connections and deferred calls to this method, add_do_method/add_undo_method calls, and so on. Also renames the internal `_update_callback()` to `_redraw_callback()` for consistency. Just a few comments have also been changed to say "redraw". In CPUParticles2D, there was a private variable with the same name. It has been renamed to `do_redraw`.
2022-08-13 23:21:24 +02:00
queue_redraw();
Rename LineEdit caret_* properties getters and setters to match property
2021-03-28 20:31:25 +02:00
caret_column = 0;
Fix LineEdit text incorrectly trimmed due to rounding errors.
2022-07-06 10:57:06 +02:00
scroll_offset = 0.0;
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
}
Preserve selection when focusing SpinBox
2023-06-10 21:29:24 +02:00
void LineEdit::set_text_with_selection(const String &p_text) {
Selection selection_copy = selection;
clear_internal();
insert_text_at_caret(p_text);
_create_undo_state();
int tlen = text.length();
selection = selection_copy;
selection.begin = MIN(selection.begin, tlen);
selection.end = MIN(selection.end, tlen);
selection.start_column = MIN(selection.start_column, tlen);
queue_redraw();
}
[Complex Text Layouts] Refactor Label and LineEdit controls.
2020-09-09 15:00:32 +02:00
void LineEdit::set_text_direction(Control::TextDirection p_text_direction) {
ERR_FAIL_COND((int)p_text_direction < -1 || (int)p_text_direction > 3);
if (text_direction != p_text_direction) {
text_direction = p_text_direction;
if (text_direction != TEXT_DIRECTION_AUTO && text_direction != TEXT_DIRECTION_INHERITED) {
input_direction = text_direction;
}
_shape();
Create many types of popups on demand * LineEdit popups created on demand. * TextEdit popups created on demand. * SpinSlider popups created on demand. * ResourcePicker popups created on demand. Improves editor responsiveness.
2021-07-16 23:36:05 +02:00
if (menu_dir) {
menu_dir->set_item_checked(menu_dir->get_item_index(MENU_DIR_INHERITED), text_direction == TEXT_DIRECTION_INHERITED);
menu_dir->set_item_checked(menu_dir->get_item_index(MENU_DIR_AUTO), text_direction == TEXT_DIRECTION_AUTO);
menu_dir->set_item_checked(menu_dir->get_item_index(MENU_DIR_LTR), text_direction == TEXT_DIRECTION_LTR);
menu_dir->set_item_checked(menu_dir->get_item_index(MENU_DIR_RTL), text_direction == TEXT_DIRECTION_RTL);
}
Rename `CanvasItem.update()` to `queue_redraw()` Affects a lot of classes. Very thoroughly checked signal connections and deferred calls to this method, add_do_method/add_undo_method calls, and so on. Also renames the internal `_update_callback()` to `_redraw_callback()` for consistency. Just a few comments have also been changed to say "redraw". In CPUParticles2D, there was a private variable with the same name. It has been renamed to `do_redraw`.
2022-08-13 23:21:24 +02:00
queue_redraw();
[Complex Text Layouts] Refactor Label and LineEdit controls.
2020-09-09 15:00:32 +02:00
}
}
Control::TextDirection LineEdit::get_text_direction() const {
return text_direction;
}
void LineEdit::set_language(const String &p_language) {
if (language != p_language) {
language = p_language;
_shape();
Rename `CanvasItem.update()` to `queue_redraw()` Affects a lot of classes. Very thoroughly checked signal connections and deferred calls to this method, add_do_method/add_undo_method calls, and so on. Also renames the internal `_update_callback()` to `_redraw_callback()` for consistency. Just a few comments have also been changed to say "redraw". In CPUParticles2D, there was a private variable with the same name. It has been renamed to `do_redraw`.
2022-08-13 23:21:24 +02:00
queue_redraw();
[Complex Text Layouts] Refactor Label and LineEdit controls.
2020-09-09 15:00:32 +02:00
}
}
String LineEdit::get_language() const {
return language;
}
void LineEdit::set_draw_control_chars(bool p_draw_control_chars) {
if (draw_control_chars != p_draw_control_chars) {
draw_control_chars = p_draw_control_chars;
Create many types of popups on demand * LineEdit popups created on demand. * TextEdit popups created on demand. * SpinSlider popups created on demand. * ResourcePicker popups created on demand. Improves editor responsiveness.
2021-07-16 23:36:05 +02:00
if (menu && menu->get_item_index(MENU_DISPLAY_UCC) >= 0) {
menu->set_item_checked(menu->get_item_index(MENU_DISPLAY_UCC), draw_control_chars);
}
[Complex Text Layouts] Refactor Label and LineEdit controls.
2020-09-09 15:00:32 +02:00
_shape();
Rename `CanvasItem.update()` to `queue_redraw()` Affects a lot of classes. Very thoroughly checked signal connections and deferred calls to this method, add_do_method/add_undo_method calls, and so on. Also renames the internal `_update_callback()` to `_redraw_callback()` for consistency. Just a few comments have also been changed to say "redraw". In CPUParticles2D, there was a private variable with the same name. It has been renamed to `do_redraw`.
2022-08-13 23:21:24 +02:00
queue_redraw();
[Complex Text Layouts] Refactor Label and LineEdit controls.
2020-09-09 15:00:32 +02:00
}
}
bool LineEdit::get_draw_control_chars() const {
return draw_control_chars;
}
Implement Label3D node. Add "generate_mipmap" font import option. Add some missing features to the Sprite3D. Move BiDi override code from Control to TextServer. Add functions to access TextServer font cache textures. Add MSDF related flags and shader to the standard material. Change standard material cache to use HashMap instead of Vector.
2022-04-19 12:27:18 +02:00
void LineEdit::set_structured_text_bidi_override(TextServer::StructuredTextParser p_parser) {
[Complex Text Layouts] Refactor Label and LineEdit controls.
2020-09-09 15:00:32 +02:00
if (st_parser != p_parser) {
st_parser = p_parser;
_shape();
Rename `CanvasItem.update()` to `queue_redraw()` Affects a lot of classes. Very thoroughly checked signal connections and deferred calls to this method, add_do_method/add_undo_method calls, and so on. Also renames the internal `_update_callback()` to `_redraw_callback()` for consistency. Just a few comments have also been changed to say "redraw". In CPUParticles2D, there was a private variable with the same name. It has been renamed to `do_redraw`.
2022-08-13 23:21:24 +02:00
queue_redraw();
[Complex Text Layouts] Refactor Label and LineEdit controls.
2020-09-09 15:00:32 +02:00
}
}
Implement Label3D node. Add "generate_mipmap" font import option. Add some missing features to the Sprite3D. Move BiDi override code from Control to TextServer. Add functions to access TextServer font cache textures. Add MSDF related flags and shader to the standard material. Change standard material cache to use HashMap instead of Vector.
2022-04-19 12:27:18 +02:00
TextServer::StructuredTextParser LineEdit::get_structured_text_bidi_override() const {
[Complex Text Layouts] Refactor Label and LineEdit controls.
2020-09-09 15:00:32 +02:00
return st_parser;
}
void LineEdit::set_structured_text_bidi_override_options(Array p_args) {
st_args = p_args;
_shape();
Rename `CanvasItem.update()` to `queue_redraw()` Affects a lot of classes. Very thoroughly checked signal connections and deferred calls to this method, add_do_method/add_undo_method calls, and so on. Also renames the internal `_update_callback()` to `_redraw_callback()` for consistency. Just a few comments have also been changed to say "redraw". In CPUParticles2D, there was a private variable with the same name. It has been renamed to `do_redraw`.
2022-08-13 23:21:24 +02:00
queue_redraw();
[Complex Text Layouts] Refactor Label and LineEdit controls.
2020-09-09 15:00:32 +02:00
}
Array LineEdit::get_structured_text_bidi_override_options() const {
return st_args;
}
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
void LineEdit::clear() {
clear_internal();
-Added diectly editable expressions on node to VSEditor, closes #6392 -Added ability for LineEdit to expand to fit text
2016-09-07 01:34:24 +02:00
_text_changed();
[GUI] Enforce virtual keyboard redisplay on clear
2021-01-18 18:08:42 +01:00
// This should reset virtual keyboard state if needed.
if (has_focus()) {
show_virtual_keyboard();
}
}
void LineEdit::show_virtual_keyboard() {
if (DisplayServer::get_singleton()->has_feature(DisplayServer::FEATURE_VIRTUAL_KEYBOARD) && virtual_keyboard_enabled) {
if (selection.enabled) {
Add support for multiple virtual keyboard types
2022-07-07 20:20:10 +02:00
DisplayServer::get_singleton()->virtual_keyboard_show(text, get_global_rect(), DisplayServer::VirtualKeyboardType(virtual_keyboard_type), max_length, selection.begin, selection.end);
[GUI] Enforce virtual keyboard redisplay on clear
2021-01-18 18:08:42 +01:00
} else {
Add support for multiple virtual keyboard types
2022-07-07 20:20:10 +02:00
DisplayServer::get_singleton()->virtual_keyboard_show(text, get_global_rect(), DisplayServer::VirtualKeyboardType(virtual_keyboard_type), max_length, caret_column);
[GUI] Enforce virtual keyboard redisplay on clear
2021-01-18 18:08:42 +01:00
}
}
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
}
String LineEdit::get_text() const {
return text;
}
Add placeholder property for line_edit this useful for user input tip
2016-06-27 13:47:40 +02:00
void LineEdit::set_placeholder(String p_text) {
Add some codes, returnes directly if the value is not changed. Avoid executing the following value-changed logics if the value does not really change.
2022-03-16 08:50:48 +01:00
if (placeholder == p_text) {
return;
}
Line edit placeholders now react properly to translation changes.
2019-06-22 14:42:36 +02:00
placeholder = p_text;
Add `auto_translate` toggle for automatic translation
2021-05-27 19:31:33 +02:00
placeholder_translated = atr(placeholder);
[Complex Text Layouts] Refactor Label and LineEdit controls.
2020-09-09 15:00:32 +02:00
_shape();
Rename `CanvasItem.update()` to `queue_redraw()` Affects a lot of classes. Very thoroughly checked signal connections and deferred calls to this method, add_do_method/add_undo_method calls, and so on. Also renames the internal `_update_callback()` to `_redraw_callback()` for consistency. Just a few comments have also been changed to say "redraw". In CPUParticles2D, there was a private variable with the same name. It has been renamed to `do_redraw`.
2022-08-13 23:21:24 +02:00
queue_redraw();
Add placeholder property for line_edit this useful for user input tip
2016-06-27 13:47:40 +02:00
}
String LineEdit::get_placeholder() const {
return placeholder;
}
Rename LineEdit caret_* properties getters and setters to match property
2021-03-28 20:31:25 +02:00
void LineEdit::set_caret_column(int p_column) {
if (p_column > (int)text.length()) {
p_column = text.length();
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
}
remove trailing whitespace
2016-03-09 00:00:52 +01:00
Rename LineEdit caret_* properties getters and setters to match property
2021-03-28 20:31:25 +02:00
if (p_column < 0) {
p_column = 0;
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
}
remove trailing whitespace
2016-03-09 00:00:52 +01:00
Rename LineEdit caret_* properties getters and setters to match property
2021-03-28 20:31:25 +02:00
caret_column = p_column;
remove trailing whitespace
2016-03-09 00:00:52 +01:00
[Complex Text Layouts] Refactor Label and LineEdit controls.
2020-09-09 15:00:32 +02:00
// Fit to window.
SceneMainLoop -> SceneTree -=-=-=-=-=-=-=-=-=-=-=-=-=- *YOUR SOURCE MIGHT NOT WORK* For mor information on fix: https://github.com/okamstudio/godot/wiki/devel_scene_tree Other stuff: -Shower of bullets demo -Fixes all around
2014-11-06 01:20:42 +01:00
if (!is_inside_tree()) {
Fix LineEdit text incorrectly trimmed due to rounding errors.
2022-07-06 10:57:06 +02:00
scroll_offset = 0.0;
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
return;
}
remove trailing whitespace
2016-03-09 00:00:52 +01:00
Add a lifecycle method for manual theme item caching to Control
2022-08-31 14:02:40 +02:00
Ref<StyleBox> style = theme_cache.normal;
[Complex Text Layouts] Refactor Label and LineEdit controls.
2020-09-09 15:00:32 +02:00
bool rtl = is_layout_rtl();
remove trailing whitespace
2016-03-09 00:00:52 +01:00
[Complex Text Layouts] Refactor Label and LineEdit controls.
2020-09-09 15:00:32 +02:00
int x_ofs = 0;
float text_width = TS->shaped_text_get_size(text_rid).x;
align to horizontal_alignment, valign to vertical_alignment, related
2021-11-25 03:58:47 +01:00
switch (alignment) {
case HORIZONTAL_ALIGNMENT_FILL:
case HORIZONTAL_ALIGNMENT_LEFT: {
[Complex Text Layouts] Refactor Label and LineEdit controls.
2020-09-09 15:00:32 +02:00
if (rtl) {
Rename Control margin to offset
2020-12-22 17:24:29 +01:00
x_ofs = MAX(style->get_margin(SIDE_LEFT), int(get_size().width - style->get_margin(SIDE_RIGHT) - (text_width)));
[Complex Text Layouts] Refactor Label and LineEdit controls.
2020-09-09 15:00:32 +02:00
} else {
x_ofs = style->get_offset().x;
}
} break;
align to horizontal_alignment, valign to vertical_alignment, related
2021-11-25 03:58:47 +01:00
case HORIZONTAL_ALIGNMENT_CENTER: {
Fix LineEdit text incorrectly trimmed due to rounding errors.
2022-07-06 10:57:06 +02:00
if (!Math::is_zero_approx(scroll_offset)) {
[Complex Text Layouts] Refactor Label and LineEdit controls.
2020-09-09 15:00:32 +02:00
x_ofs = style->get_offset().x;
} else {
Rename Control margin to offset
2020-12-22 17:24:29 +01:00
x_ofs = MAX(style->get_margin(SIDE_LEFT), int(get_size().width - (text_width)) / 2);
[Complex Text Layouts] Refactor Label and LineEdit controls.
2020-09-09 15:00:32 +02:00
}
} break;
align to horizontal_alignment, valign to vertical_alignment, related
2021-11-25 03:58:47 +01:00
case HORIZONTAL_ALIGNMENT_RIGHT: {
[Complex Text Layouts] Refactor Label and LineEdit controls.
2020-09-09 15:00:32 +02:00
if (rtl) {
x_ofs = style->get_offset().x;
} else {
Rename Control margin to offset
2020-12-22 17:24:29 +01:00
x_ofs = MAX(style->get_margin(SIDE_LEFT), int(get_size().width - style->get_margin(SIDE_RIGHT) - (text_width)));
[Complex Text Layouts] Refactor Label and LineEdit controls.
2020-09-09 15:00:32 +02:00
}
} break;
}
Aligned line edit fix.
2015-09-02 13:36:52 +02:00
Rename Control margin to offset
2020-12-22 17:24:29 +01:00
int ofs_max = get_size().width - style->get_margin(SIDE_RIGHT);
Rename empty() to is_empty()
2020-12-15 13:04:21 +01:00
bool using_placeholder = text.is_empty() && ime_text.is_empty();
[Complex Text Layouts] Refactor Label and LineEdit controls.
2020-09-09 15:00:32 +02:00
bool display_clear_icon = !using_placeholder && is_editable() && clear_button_enabled;
if (right_icon.is_valid() || display_clear_icon) {
Add a lifecycle method for manual theme item caching to Control
2022-08-31 14:02:40 +02:00
Ref<Texture2D> r_icon = display_clear_icon ? theme_cache.clear_icon : right_icon;
align to horizontal_alignment, valign to vertical_alignment, related
2021-11-25 03:58:47 +01:00
if (alignment == HORIZONTAL_ALIGNMENT_CENTER) {
Fix LineEdit text incorrectly trimmed due to rounding errors.
2022-07-06 10:57:06 +02:00
if (Math::is_zero_approx(scroll_offset)) {
Rename Control margin to offset
2020-12-22 17:24:29 +01:00
x_ofs = MAX(style->get_margin(SIDE_LEFT), int(get_size().width - text_width - r_icon->get_width() - style->get_margin(SIDE_RIGHT) * 2) / 2);
Aligned line edit fix.
2015-09-02 13:36:52 +02:00
}
[Complex Text Layouts] Refactor Label and LineEdit controls.
2020-09-09 15:00:32 +02:00
} else {
Rename Control margin to offset
2020-12-22 17:24:29 +01:00
x_ofs = MAX(style->get_margin(SIDE_LEFT), x_ofs - r_icon->get_width() - style->get_margin(SIDE_RIGHT));
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
}
[Complex Text Layouts] Refactor Label and LineEdit controls.
2020-09-09 15:00:32 +02:00
ofs_max -= r_icon->get_width();
}
remove trailing whitespace
2016-03-09 00:00:52 +01:00
Fixes small typos and grammar correction
2021-03-12 14:35:16 +01:00
// Note: Use two coordinates to fit IME input range.
Fix LineEdit text incorrectly trimmed due to rounding errors.
2022-07-06 10:57:06 +02:00
Vector2 primary_caret_offset = get_caret_pixel_pos();
[Complex Text Layouts] Refactor Label and LineEdit controls.
2020-09-09 15:00:32 +02:00
Fix LineEdit text incorrectly trimmed due to rounding errors.
2022-07-06 10:57:06 +02:00
if (MIN(primary_caret_offset.x, primary_caret_offset.y) <= x_ofs) {
scroll_offset += x_ofs - MIN(primary_caret_offset.x, primary_caret_offset.y);
} else if (MAX(primary_caret_offset.x, primary_caret_offset.y) >= ofs_max) {
scroll_offset += ofs_max - MAX(primary_caret_offset.x, primary_caret_offset.y);
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
}
Make LineEdit scrolling show as much text as possible
2024-01-03 01:28:42 +01:00
// Scroll to show as much text as possible
if (text_width + scroll_offset + x_ofs < ofs_max) {
scroll_offset = ofs_max - x_ofs - text_width;
}
[Complex Text Layouts] Refactor Label and LineEdit controls.
2020-09-09 15:00:32 +02:00
scroll_offset = MIN(0, scroll_offset);
Rename `CanvasItem.update()` to `queue_redraw()` Affects a lot of classes. Very thoroughly checked signal connections and deferred calls to this method, add_do_method/add_undo_method calls, and so on. Also renames the internal `_update_callback()` to `_redraw_callback()` for consistency. Just a few comments have also been changed to say "redraw". In CPUParticles2D, there was a private variable with the same name. It has been renamed to `do_redraw`.
2022-08-13 23:21:24 +02:00
queue_redraw();
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
}
Rename LineEdit caret_* properties getters and setters to match property
2021-03-28 20:31:25 +02:00
int LineEdit::get_caret_column() const {
return caret_column;
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
}
Fix LineEdit text incorrectly trimmed due to rounding errors.
2022-07-06 10:57:06 +02:00
void LineEdit::set_scroll_offset(float p_pos) {
Expose LineEdit scroll offset to scripts
2020-11-11 09:26:55 +01:00
scroll_offset = p_pos;
Fix LineEdit text incorrectly trimmed due to rounding errors.
2022-07-06 10:57:06 +02:00
if (scroll_offset < 0.0) {
scroll_offset = 0.0;
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
}
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
}
Fix LineEdit text incorrectly trimmed due to rounding errors.
2022-07-06 10:57:06 +02:00
float LineEdit::get_scroll_offset() const {
Expose LineEdit scroll offset to scripts
2020-11-11 09:26:55 +01:00
return scroll_offset;
}
Rename LineEdit caret_* properties getters and setters to match property
2021-03-28 20:31:25 +02:00
void LineEdit::insert_text_at_caret(String p_text) {
LineEdit: Respect `max_length` by truncating text to append When appending text (either via `set_text()` or by pasting from clipboard), if the input would make the `LineEdit` exceed its configured `max_length`, the input text is truncated to fit. The discard part is passed as a parameter in the `text_change_rejected` signal. Fixes #33321. Fixes #41278. Also cleaned up unimplemented `max_chars` property in `TextEdit`. Co-authored-by: Tony-Goat <70238376+Tony-Goat@users.noreply.github.com>
2021-07-06 12:49:27 +02:00
if (max_length > 0) {
// Truncate text to append to fit in max_length, if needed.
int available_chars = max_length - text.length();
if (p_text.length() > available_chars) {
Optimize StringName usage * Added a new macro SNAME() that constructs and caches a local stringname. * Subsequent usages use the cached version. * Since these use a global static variable, a second refcounter of static usages need to be kept for cleanup time. * Replaced all theme usages by this new macro. * Replace all signal emission usages by this new macro. * Replace all call_deferred usages by this new macro. This is part of ongoing work to optimize GUI and the editor.
2021-07-17 23:22:52 +02:00
emit_signal(SNAME("text_change_rejected"), p_text.substr(available_chars));
LineEdit: Respect `max_length` by truncating text to append When appending text (either via `set_text()` or by pasting from clipboard), if the input would make the `LineEdit` exceed its configured `max_length`, the input text is truncated to fit. The discard part is passed as a parameter in the `text_change_rejected` signal. Fixes #33321. Fixes #41278. Also cleaned up unimplemented `max_chars` property in `TextEdit`. Co-authored-by: Tony-Goat <70238376+Tony-Goat@users.noreply.github.com>
2021-07-06 12:49:27 +02:00
p_text = p_text.substr(0, available_chars);
[Complex Text Layouts] Refactor Label and LineEdit controls.
2020-09-09 15:00:32 +02:00
}
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
}
LineEdit: Respect `max_length` by truncating text to append When appending text (either via `set_text()` or by pasting from clipboard), if the input would make the `LineEdit` exceed its configured `max_length`, the input text is truncated to fit. The discard part is passed as a parameter in the `text_change_rejected` signal. Fixes #33321. Fixes #41278. Also cleaned up unimplemented `max_chars` property in `TextEdit`. Co-authored-by: Tony-Goat <70238376+Tony-Goat@users.noreply.github.com>
2021-07-06 12:49:27 +02:00
String pre = text.substr(0, caret_column);
String post = text.substr(caret_column, text.length() - caret_column);
text = pre + p_text + post;
_shape();
Implement TextServer GDExtension interface, remove TextServer GDNative interface.
2021-08-27 23:19:51 +02:00
TextServer::Direction dir = TS->shaped_text_get_dominant_direction_in_range(text_rid, caret_column, caret_column + p_text.length());
LineEdit: Respect `max_length` by truncating text to append When appending text (either via `set_text()` or by pasting from clipboard), if the input would make the `LineEdit` exceed its configured `max_length`, the input text is truncated to fit. The discard part is passed as a parameter in the `text_change_rejected` signal. Fixes #33321. Fixes #41278. Also cleaned up unimplemented `max_chars` property in `TextEdit`. Co-authored-by: Tony-Goat <70238376+Tony-Goat@users.noreply.github.com>
2021-07-06 12:49:27 +02:00
if (dir != TextServer::DIRECTION_AUTO) {
input_direction = (TextDirection)dir;
}
set_caret_column(caret_column + p_text.length());
[Windows] Fix committing IME text without IME deactivation.
2023-01-26 08:09:53 +01:00
if (!ime_text.is_empty()) {
_shape();
}
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
}
void LineEdit::clear_internal() {
Fixed not deselecting when clearing lineedit.
2019-03-31 17:32:24 +02:00
deselect();
Added multi level undo redo to line edit
2017-10-30 00:14:33 +01:00
_clear_undo_stack();
Rename LineEdit caret_* properties getters and setters to match property
2021-03-28 20:31:25 +02:00
caret_column = 0;
Fix LineEdit text incorrectly trimmed due to rounding errors.
2022-07-06 10:57:06 +02:00
scroll_offset = 0.0;
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
undo_text = "";
text = "";
[Complex Text Layouts] Refactor Label and LineEdit controls.
2020-09-09 15:00:32 +02:00
_shape();
Rename `CanvasItem.update()` to `queue_redraw()` Affects a lot of classes. Very thoroughly checked signal connections and deferred calls to this method, add_do_method/add_undo_method calls, and so on. Also renames the internal `_update_callback()` to `_redraw_callback()` for consistency. Just a few comments have also been changed to say "redraw". In CPUParticles2D, there was a private variable with the same name. It has been renamed to `do_redraw`.
2022-08-13 23:21:24 +02:00
queue_redraw();
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
}
Size2 LineEdit::get_minimum_size() const {
Add a lifecycle method for manual theme item caching to Control
2022-08-31 14:02:40 +02:00
Ref<StyleBox> style = theme_cache.normal;
Ref<Font> font = theme_cache.font;
int font_size = theme_cache.font_size;
remove trailing whitespace
2016-03-09 00:00:52 +01:00
Make LineEdit's minimal size adapt to its icons
2019-09-25 04:21:35 +02:00
Size2 min_size;
-Added diectly editable expressions on node to VSEditor, closes #6392 -Added ability for LineEdit to expand to fit text
2016-09-07 01:34:24 +02:00
Expose LineEdit's 'right_icon' and fix icon size
2019-09-09 03:46:57 +02:00
// Minimum size of text.
Refactor Font configuration and import UI, and Font resources.
2022-05-09 11:47:10 +02:00
float em_space_size = font->get_char_size('M', font_size).x;
Add a lifecycle method for manual theme item caching to Control
2022-08-31 14:02:40 +02:00
min_size.width = theme_cache.minimum_character_width * em_space_size;
-Added diectly editable expressions on node to VSEditor, closes #6392 -Added ability for LineEdit to expand to fit text
2016-09-07 01:34:24 +02:00
if (expand_to_text_length) {
Fix LineEdit expanding to text length Fix for issue #77474 Remove wrong tab Change the comment to more relevant Co-authored-by: Rémi Verschelde <rverschelde@gmail.com>
2023-05-26 10:51:32 +02:00
// Ensure some space for the caret when placed at the end.
min_size.width = MAX(min_size.width, full_width + theme_cache.caret_width);
-Added diectly editable expressions on node to VSEditor, closes #6392 -Added ability for LineEdit to expand to fit text
2016-09-07 01:34:24 +02:00
}
Refactor Font configuration and import UI, and Font resources.
2022-05-09 11:47:10 +02:00
min_size.height = MAX(TS->shaped_text_get_size(text_rid).y, font->get_height(font_size));
Make LineEdit's minimal size adapt to its icons
2019-09-25 04:21:35 +02:00
// Take icons into account.
Take into account the clear icon's size even when not visible in `LineEdit`s
2022-06-05 20:13:19 +02:00
int icon_max_width = 0;
if (right_icon.is_valid()) {
min_size.height = MAX(min_size.height, right_icon->get_height());
icon_max_width = right_icon->get_width();
}
if (clear_button_enabled) {
Add a lifecycle method for manual theme item caching to Control
2022-08-31 14:02:40 +02:00
min_size.height = MAX(min_size.height, theme_cache.clear_icon->get_height());
icon_max_width = MAX(icon_max_width, theme_cache.clear_icon->get_width());
Make LineEdit's minimal size adapt to its icons
2019-09-25 04:21:35 +02:00
}
Take into account the clear icon's size even when not visible in `LineEdit`s
2022-06-05 20:13:19 +02:00
min_size.width += icon_max_width;
-Added diectly editable expressions on node to VSEditor, closes #6392 -Added ability for LineEdit to expand to fit text
2016-09-07 01:34:24 +02:00
Make LineEdit's minimal size adapt to its icons
2019-09-25 04:21:35 +02:00
return style->get_minimum_size() + min_size;
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
}
Exposed LineEdit's "selection_clear" and renamed it to "deselect".
2017-12-17 18:40:44 +01:00
void LineEdit::deselect() {
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
selection.begin = 0;
selection.end = 0;
Rename LineEdit caret_* properties getters and setters to match property
2021-03-28 20:31:25 +02:00
selection.start_column = 0;
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
selection.enabled = false;
selection.creating = false;
Rename `doubleclick` to `double_click`
2021-04-13 10:25:44 +02:00
selection.double_click = false;
Rename `CanvasItem.update()` to `queue_redraw()` Affects a lot of classes. Very thoroughly checked signal connections and deferred calls to this method, add_do_method/add_undo_method calls, and so on. Also renames the internal `_update_callback()` to `_redraw_callback()` for consistency. Just a few comments have also been changed to say "redraw". In CPUParticles2D, there was a private variable with the same name. It has been renamed to `do_redraw`.
2022-08-13 23:21:24 +02:00
queue_redraw();
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
}
Add selection getter methods to `LineEdit`
2021-09-24 10:00:45 +02:00
bool LineEdit::has_selection() const {
return selection.enabled;
}
Implement LineEdit.get_selected_text()
2023-03-30 17:07:28 +02:00
String LineEdit::get_selected_text() {
if (selection.enabled) {
return text.substr(selection.begin, selection.end - selection.begin);
} else {
return String();
}
}
Add selection getter methods to `LineEdit`
2021-09-24 10:00:45 +02:00
int LineEdit::get_selection_from_column() const {
ERR_FAIL_COND_V(!selection.enabled, -1);
return selection.begin;
}
int LineEdit::get_selection_to_column() const {
ERR_FAIL_COND_V(!selection.enabled, -1);
return selection.end;
}
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
void LineEdit::selection_delete() {
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
if (selection.enabled) {
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
delete_text(selection.begin, selection.end);
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
}
remove trailing whitespace
2016-03-09 00:00:52 +01:00
Exposed LineEdit's "selection_clear" and renamed it to "deselect".
2017-12-17 18:40:44 +01:00
deselect();
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
}
void LineEdit::set_max_length(int p_max_length) {
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
ERR_FAIL_COND(p_max_length < 0);
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
max_length = p_max_length;
set_text(text);
}
int LineEdit::get_max_length() const {
return max_length;
}
Rename LineEdit caret_* properties getters and setters to match property
2021-03-28 20:31:25 +02:00
void LineEdit::selection_fill_at_caret() {
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
if (!selecting_enabled) {
Add Ability to Enable/Disable Shortcuts for LineEdit/TextEdit This PR adds the ability to enable/disable shortcut keys and selection for LineEdit/TextEdit. It also updates the context menu when you disable/enable the shortcut keys or selection.
2019-08-08 02:09:46 +02:00
return;
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
}
remove trailing whitespace
2016-03-09 00:00:52 +01:00
Rename LineEdit caret_* properties getters and setters to match property
2021-03-28 20:31:25 +02:00
selection.begin = caret_column;
selection.end = selection.start_column;
remove trailing whitespace
2016-03-09 00:00:52 +01:00
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
if (selection.end < selection.begin) {
Appease some CppCheck warns for files in the "scene" directory
2019-01-14 23:04:47 +01:00
int aux = selection.end;
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
selection.end = selection.begin;
selection.begin = aux;
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
}
remove trailing whitespace
2016-03-09 00:00:52 +01:00
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
selection.enabled = (selection.begin != selection.end);
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
}
void LineEdit::select_all() {
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
if (!selecting_enabled) {
Add Ability to Enable/Disable Shortcuts for LineEdit/TextEdit This PR adds the ability to enable/disable shortcut keys and selection for LineEdit/TextEdit. It also updates the context menu when you disable/enable the shortcut keys or selection.
2019-08-08 02:09:46 +02:00
return;
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
}
remove trailing whitespace
2016-03-09 00:00:52 +01:00
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
if (!text.length()) {
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
return;
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
}
remove trailing whitespace
2016-03-09 00:00:52 +01:00
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
selection.begin = 0;
selection.end = text.length();
selection.enabled = true;
Rename `CanvasItem.update()` to `queue_redraw()` Affects a lot of classes. Very thoroughly checked signal connections and deferred calls to this method, add_do_method/add_undo_method calls, and so on. Also renames the internal `_update_callback()` to `_redraw_callback()` for consistency. Just a few comments have also been changed to say "redraw". In CPUParticles2D, there was a private variable with the same name. It has been renamed to `do_redraw`.
2022-08-13 23:21:24 +02:00
queue_redraw();
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
}
Make the LineEdit "secret" character customizable
2018-04-28 20:24:48 +02:00
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
void LineEdit::set_editable(bool p_editable) {
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
if (editable == p_editable) {
Make 'Line/TextEdit's context menus hide their editing options when in readonly mode Fixes #28243.
2019-04-22 01:09:52 +02:00
return;
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
}
Make 'Line/TextEdit's context menus hide their editing options when in readonly mode Fixes #28243.
2019-04-22 01:09:52 +02:00
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
editable = p_editable;
Improve caret drawing conditions for `LineEdit` Now, `caret_can_draw` will be validated when a condition that affects the drawability of the `LineEdit`'s caret changes; `draw_caret` will be toggled when the caret's visibility is toggled due to blink, and `draw_caret` will be `false` when `caret_blink_enabled` is disabled. Fix toggling `caret_blink_enabled` could cause caret to no longer be displayed. Fix opening the context menu causing caret to no longer appear.
2022-10-09 10:51:01 +02:00
_validate_caret_can_draw();
Make 'Line/TextEdit's context menus hide their editing options when in readonly mode Fixes #28243.
2019-04-22 01:09:52 +02:00
Rename minimum_size_changed() method
2021-12-06 14:02:34 +01:00
update_minimum_size();
Rename `CanvasItem.update()` to `queue_redraw()` Affects a lot of classes. Very thoroughly checked signal connections and deferred calls to this method, add_do_method/add_undo_method calls, and so on. Also renames the internal `_update_callback()` to `_redraw_callback()` for consistency. Just a few comments have also been changed to say "redraw". In CPUParticles2D, there was a private variable with the same name. It has been renamed to `do_redraw`.
2022-08-13 23:21:24 +02:00
queue_redraw();
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
}
bool LineEdit::is_editable() const {
return editable;
}
void LineEdit::set_secret(bool p_secret) {
Add some codes, returnes directly if the value is not changed. Avoid executing the following value-changed logics if the value does not really change.
2022-03-16 08:50:48 +01:00
if (pass == p_secret) {
return;
[Complex Text Layouts] Refactor Label and LineEdit controls.
2020-09-09 15:00:32 +02:00
}
Add some codes, returnes directly if the value is not changed. Avoid executing the following value-changed logics if the value does not really change.
2022-03-16 08:50:48 +01:00
pass = p_secret;
_shape();
Rename `CanvasItem.update()` to `queue_redraw()` Affects a lot of classes. Very thoroughly checked signal connections and deferred calls to this method, add_do_method/add_undo_method calls, and so on. Also renames the internal `_update_callback()` to `_redraw_callback()` for consistency. Just a few comments have also been changed to say "redraw". In CPUParticles2D, there was a private variable with the same name. It has been renamed to `do_redraw`.
2022-08-13 23:21:24 +02:00
queue_redraw();
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
}
Make the LineEdit "secret" character customizable
2018-04-28 20:24:48 +02:00
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
bool LineEdit::is_secret() const {
return pass;
}
Make the LineEdit "secret" character customizable
2018-04-28 20:24:48 +02:00
void LineEdit::set_secret_character(const String &p_string) {
[Text Overrun] Add option to set custom ellipsis character, add support for system font fallback.
2023-10-01 12:39:13 +02:00
String c = p_string;
if (c.length() > 1) {
WARN_PRINT("Secret character must be exactly one character long (" + itos(c.length()) + " characters given).");
c = c.left(1);
}
if (secret_character == c) {
Add some codes, returnes directly if the value is not changed. Avoid executing the following value-changed logics if the value does not really change.
2022-03-16 08:50:48 +01:00
return;
[Complex Text Layouts] Refactor Label and LineEdit controls.
2020-09-09 15:00:32 +02:00
}
[Text Overrun] Add option to set custom ellipsis character, add support for system font fallback.
2023-10-01 12:39:13 +02:00
secret_character = c;
Add some codes, returnes directly if the value is not changed. Avoid executing the following value-changed logics if the value does not really change.
2022-03-16 08:50:48 +01:00
_shape();
Rename `CanvasItem.update()` to `queue_redraw()` Affects a lot of classes. Very thoroughly checked signal connections and deferred calls to this method, add_do_method/add_undo_method calls, and so on. Also renames the internal `_update_callback()` to `_redraw_callback()` for consistency. Just a few comments have also been changed to say "redraw". In CPUParticles2D, there was a private variable with the same name. It has been renamed to `do_redraw`.
2022-08-13 23:21:24 +02:00
queue_redraw();
Make the LineEdit "secret" character customizable
2018-04-28 20:24:48 +02:00
}
String LineEdit::get_secret_character() const {
return secret_character;
}
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
void LineEdit::select(int p_from, int p_to) {
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
if (!selecting_enabled) {
Add Ability to Enable/Disable Shortcuts for LineEdit/TextEdit This PR adds the ability to enable/disable shortcut keys and selection for LineEdit/TextEdit. It also updates the context menu when you disable/enable the shortcut keys or selection.
2019-08-08 02:09:46 +02:00
return;
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
}
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
if (p_from == 0 && p_to == 0) {
Exposed LineEdit's "selection_clear" and renamed it to "deselect".
2017-12-17 18:40:44 +01:00
deselect();
Auto select custom property value field when pop up, user can start typing to change value right away.
2014-02-27 15:16:00 +01:00
return;
}
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
int len = text.length();
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
if (p_from < 0) {
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
p_from = 0;
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
}
if (p_from > len) {
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
p_from = len;
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
}
if (p_to < 0 || p_to > len) {
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
p_to = len;
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
}
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
if (p_from >= p_to) {
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
return;
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
}
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
selection.enabled = true;
selection.begin = p_from;
selection.end = p_to;
selection.creating = false;
Rename `doubleclick` to `double_click`
2021-04-13 10:25:44 +02:00
selection.double_click = false;
Rename `CanvasItem.update()` to `queue_redraw()` Affects a lot of classes. Very thoroughly checked signal connections and deferred calls to this method, add_do_method/add_undo_method calls, and so on. Also renames the internal `_update_callback()` to `_redraw_callback()` for consistency. Just a few comments have also been changed to say "redraw". In CPUParticles2D, there was a private variable with the same name. It has been renamed to `do_redraw`.
2022-08-13 23:21:24 +02:00
queue_redraw();
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
}
misc cleanup
2015-10-17 15:29:54 +02:00
bool LineEdit::is_text_field() const {
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
return true;
misc cleanup
2015-10-17 15:29:54 +02:00
}
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
Default editing popup for LineEdit and TextEdit
2016-05-17 01:25:17 +02:00
void LineEdit::menu_option(int p_option) {
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
switch (p_option) {
Default editing popup for LineEdit and TextEdit
2016-05-17 01:25:17 +02:00
case MENU_CUT: {
Fix ability to cut/paste text in LineEdit/TextEdit in readonly mode. Fixes #6466
2016-09-19 14:17:48 +02:00
if (editable) {
cut_text();
}
Default editing popup for LineEdit and TextEdit
2016-05-17 01:25:17 +02:00
} break;
case MENU_COPY: {
copy_text();
} break;
case MENU_PASTE: {
Fix ability to cut/paste text in LineEdit/TextEdit in readonly mode. Fixes #6466
2016-09-19 14:17:48 +02:00
if (editable) {
paste_text();
}
Default editing popup for LineEdit and TextEdit
2016-05-17 01:25:17 +02:00
} break;
case MENU_CLEAR: {
Fix ability to cut/paste text in LineEdit/TextEdit in readonly mode. Fixes #6466
2016-09-19 14:17:48 +02:00
if (editable) {
clear();
}
Default editing popup for LineEdit and TextEdit
2016-05-17 01:25:17 +02:00
} break;
case MENU_SELECT_ALL: {
select_all();
} break;
case MENU_UNDO: {
LineEdit: don't undo uneditable LineEdit
2017-07-17 15:00:01 +02:00
if (editable) {
undo();
}
Default editing popup for LineEdit and TextEdit
2016-05-17 01:25:17 +02:00
} break;
Added multi level undo redo to line edit
2017-10-30 00:14:33 +01:00
case MENU_REDO: {
if (editable) {
redo();
}
[Complex Text Layouts] Refactor Label and LineEdit controls.
2020-09-09 15:00:32 +02:00
} break;
case MENU_DIR_INHERITED: {
set_text_direction(TEXT_DIRECTION_INHERITED);
} break;
case MENU_DIR_AUTO: {
set_text_direction(TEXT_DIRECTION_AUTO);
} break;
case MENU_DIR_LTR: {
set_text_direction(TEXT_DIRECTION_LTR);
} break;
case MENU_DIR_RTL: {
set_text_direction(TEXT_DIRECTION_RTL);
} break;
case MENU_DISPLAY_UCC: {
set_draw_control_chars(!get_draw_control_chars());
} break;
case MENU_INSERT_LRM: {
if (editable) {
Rename LineEdit caret_* properties getters and setters to match property
2021-03-28 20:31:25 +02:00
insert_text_at_caret(String::chr(0x200E));
[Complex Text Layouts] Refactor Label and LineEdit controls.
2020-09-09 15:00:32 +02:00
}
} break;
case MENU_INSERT_RLM: {
if (editable) {
Rename LineEdit caret_* properties getters and setters to match property
2021-03-28 20:31:25 +02:00
insert_text_at_caret(String::chr(0x200F));
[Complex Text Layouts] Refactor Label and LineEdit controls.
2020-09-09 15:00:32 +02:00
}
} break;
case MENU_INSERT_LRE: {
if (editable) {
Rename LineEdit caret_* properties getters and setters to match property
2021-03-28 20:31:25 +02:00
insert_text_at_caret(String::chr(0x202A));
[Complex Text Layouts] Refactor Label and LineEdit controls.
2020-09-09 15:00:32 +02:00
}
} break;
case MENU_INSERT_RLE: {
if (editable) {
Rename LineEdit caret_* properties getters and setters to match property
2021-03-28 20:31:25 +02:00
insert_text_at_caret(String::chr(0x202B));
[Complex Text Layouts] Refactor Label and LineEdit controls.
2020-09-09 15:00:32 +02:00
}
} break;
case MENU_INSERT_LRO: {
if (editable) {
Rename LineEdit caret_* properties getters and setters to match property
2021-03-28 20:31:25 +02:00
insert_text_at_caret(String::chr(0x202D));
[Complex Text Layouts] Refactor Label and LineEdit controls.
2020-09-09 15:00:32 +02:00
}
} break;
case MENU_INSERT_RLO: {
if (editable) {
Rename LineEdit caret_* properties getters and setters to match property
2021-03-28 20:31:25 +02:00
insert_text_at_caret(String::chr(0x202E));
[Complex Text Layouts] Refactor Label and LineEdit controls.
2020-09-09 15:00:32 +02:00
}
} break;
case MENU_INSERT_PDF: {
if (editable) {
Rename LineEdit caret_* properties getters and setters to match property
2021-03-28 20:31:25 +02:00
insert_text_at_caret(String::chr(0x202C));
[Complex Text Layouts] Refactor Label and LineEdit controls.
2020-09-09 15:00:32 +02:00
}
} break;
case MENU_INSERT_ALM: {
if (editable) {
Rename LineEdit caret_* properties getters and setters to match property
2021-03-28 20:31:25 +02:00
insert_text_at_caret(String::chr(0x061C));
[Complex Text Layouts] Refactor Label and LineEdit controls.
2020-09-09 15:00:32 +02:00
}
} break;
case MENU_INSERT_LRI: {
if (editable) {
Rename LineEdit caret_* properties getters and setters to match property
2021-03-28 20:31:25 +02:00
insert_text_at_caret(String::chr(0x2066));
[Complex Text Layouts] Refactor Label and LineEdit controls.
2020-09-09 15:00:32 +02:00
}
} break;
case MENU_INSERT_RLI: {
if (editable) {
Rename LineEdit caret_* properties getters and setters to match property
2021-03-28 20:31:25 +02:00
insert_text_at_caret(String::chr(0x2067));
[Complex Text Layouts] Refactor Label and LineEdit controls.
2020-09-09 15:00:32 +02:00
}
} break;
case MENU_INSERT_FSI: {
if (editable) {
Rename LineEdit caret_* properties getters and setters to match property
2021-03-28 20:31:25 +02:00
insert_text_at_caret(String::chr(0x2068));
[Complex Text Layouts] Refactor Label and LineEdit controls.
2020-09-09 15:00:32 +02:00
}
} break;
case MENU_INSERT_PDI: {
if (editable) {
Rename LineEdit caret_* properties getters and setters to match property
2021-03-28 20:31:25 +02:00
insert_text_at_caret(String::chr(0x2069));
[Complex Text Layouts] Refactor Label and LineEdit controls.
2020-09-09 15:00:32 +02:00
}
} break;
case MENU_INSERT_ZWJ: {
if (editable) {
Rename LineEdit caret_* properties getters and setters to match property
2021-03-28 20:31:25 +02:00
insert_text_at_caret(String::chr(0x200D));
[Complex Text Layouts] Refactor Label and LineEdit controls.
2020-09-09 15:00:32 +02:00
}
} break;
case MENU_INSERT_ZWNJ: {
if (editable) {
Rename LineEdit caret_* properties getters and setters to match property
2021-03-28 20:31:25 +02:00
insert_text_at_caret(String::chr(0x200C));
[Complex Text Layouts] Refactor Label and LineEdit controls.
2020-09-09 15:00:32 +02:00
}
} break;
case MENU_INSERT_WJ: {
if (editable) {
Rename LineEdit caret_* properties getters and setters to match property
2021-03-28 20:31:25 +02:00
insert_text_at_caret(String::chr(0x2060));
[Complex Text Layouts] Refactor Label and LineEdit controls.
2020-09-09 15:00:32 +02:00
}
} break;
case MENU_INSERT_SHY: {
if (editable) {
Rename LineEdit caret_* properties getters and setters to match property
2021-03-28 20:31:25 +02:00
insert_text_at_caret(String::chr(0x00AD));
[Complex Text Layouts] Refactor Label and LineEdit controls.
2020-09-09 15:00:32 +02:00
}
Added multi level undo redo to line edit
2017-10-30 00:14:33 +01:00
}
Default editing popup for LineEdit and TextEdit
2016-05-17 01:25:17 +02:00
}
}
add context menu enable getters, setters, and properties in LineEdit and TextEdit
2017-11-09 21:46:29 +01:00
void LineEdit::set_context_menu_enabled(bool p_enable) {
context_menu_enabled = p_enable;
}
bool LineEdit::is_context_menu_enabled() {
return context_menu_enabled;
}
Create many types of popups on demand * LineEdit popups created on demand. * TextEdit popups created on demand. * SpinSlider popups created on demand. * ResourcePicker popups created on demand. Improves editor responsiveness.
2021-07-16 23:36:05 +02:00
bool LineEdit::is_menu_visible() const {
return menu && menu->is_visible();
}
Default editing popup for LineEdit and TextEdit
2016-05-17 01:25:17 +02:00
PopupMenu *LineEdit::get_menu() const {
Fix `LineEdit` and `TextEdit` context menus not customizable
2023-01-26 18:59:41 +01:00
if (!menu) {
const_cast<LineEdit *>(this)->_generate_context_menu();
}
Default editing popup for LineEdit and TextEdit
2016-05-17 01:25:17 +02:00
return menu;
}
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
void LineEdit::_editor_settings_changed() {
Fix binding some core API methods only in tools builds
2018-04-29 19:49:26 +02:00
#ifdef TOOLS_ENABLED
Use check_changed_settings_in_group() everywhere
2022-11-23 00:14:08 +01:00
if (!EditorSettings::get_singleton()->check_changed_settings_in_group("text_editor/appearance/caret")) {
return;
}
Remove duplicate editor settings definitions
2022-03-06 21:39:19 +01:00
set_caret_blink_enabled(EDITOR_GET("text_editor/appearance/caret/caret_blink"));
Rename every instance of `caret_blink_speed` to `caret_blink_interval` It's been changed in EditorSettings, LineEdit, TextEdit. Affects setters and getters, and passed parameters, too.
2022-08-13 14:52:35 +02:00
set_caret_blink_interval(EDITOR_GET("text_editor/appearance/caret/caret_blink_interval"));
Added setting to toggle line edit caret blink
2016-06-21 15:38:35 +02:00
#endif
Fix binding some core API methods only in tools builds
2018-04-29 19:49:26 +02:00
}
Added setting to toggle line edit caret blink
2016-06-21 15:38:35 +02:00
Rename LineEdit caret_* properties getters and setters to match property
2021-03-28 20:31:25 +02:00
void LineEdit::set_expand_to_text_length_enabled(bool p_enabled) {
LineEdit: Quick fix to set_expand_to_text_length argument name
2016-09-07 08:52:42 +02:00
expand_to_text_length = p_enabled;
Rename minimum_size_changed() method
2021-12-06 14:02:34 +01:00
update_minimum_size();
Rename LineEdit caret_* properties getters and setters to match property
2021-03-28 20:31:25 +02:00
set_caret_column(caret_column);
-Added diectly editable expressions on node to VSEditor, closes #6392 -Added ability for LineEdit to expand to fit text
2016-09-07 01:34:24 +02:00
}
Rename LineEdit caret_* properties getters and setters to match property
2021-03-28 20:31:25 +02:00
bool LineEdit::is_expand_to_text_length_enabled() const {
-Added diectly editable expressions on node to VSEditor, closes #6392 -Added ability for LineEdit to expand to fit text
2016-09-07 01:34:24 +02:00
return expand_to_text_length;
}
Add clear text button to LineEdit - Add pressed state to clear button - Enable clear button on all inputs with search icon - Remove duplicate clear buttons - Fix rendering of icon for center and right alignments - Add clear button to more search fields - Add clear icon to default theme - Add method to control enabled state of clear button - Add property to enable clear button from inspector
2018-07-26 13:45:38 +02:00
void LineEdit::set_clear_button_enabled(bool p_enabled) {
Updates LineEdit's min size when necessary These properties will affect the minimum size of LineEdit: * The right icon (`set_right_icon`) * The clear button (`set_editable` and `set_clear_button_enabled`) * The text, when "expand to text length" is enabled (`set_text`)
2020-01-15 02:42:06 +01:00
if (clear_button_enabled == p_enabled) {
return;
}
Add clear text button to LineEdit - Add pressed state to clear button - Enable clear button on all inputs with search icon - Remove duplicate clear buttons - Fix rendering of icon for center and right alignments - Add clear button to more search fields - Add clear icon to default theme - Add method to control enabled state of clear button - Add property to enable clear button from inspector
2018-07-26 13:45:38 +02:00
clear_button_enabled = p_enabled;
[Complex Text Layouts] Refactor Label and LineEdit controls.
2020-09-09 15:00:32 +02:00
_fit_to_width();
Rename minimum_size_changed() method
2021-12-06 14:02:34 +01:00
update_minimum_size();
Rename `CanvasItem.update()` to `queue_redraw()` Affects a lot of classes. Very thoroughly checked signal connections and deferred calls to this method, add_do_method/add_undo_method calls, and so on. Also renames the internal `_update_callback()` to `_redraw_callback()` for consistency. Just a few comments have also been changed to say "redraw". In CPUParticles2D, there was a private variable with the same name. It has been renamed to `do_redraw`.
2022-08-13 23:21:24 +02:00
queue_redraw();
Add clear text button to LineEdit - Add pressed state to clear button - Enable clear button on all inputs with search icon - Remove duplicate clear buttons - Fix rendering of icon for center and right alignments - Add clear button to more search fields - Add clear icon to default theme - Add method to control enabled state of clear button - Add property to enable clear button from inspector
2018-07-26 13:45:38 +02:00
}
bool LineEdit::is_clear_button_enabled() const {
return clear_button_enabled;
}
Add Ability to Enable/Disable Shortcuts for LineEdit/TextEdit This PR adds the ability to enable/disable shortcut keys and selection for LineEdit/TextEdit. It also updates the context menu when you disable/enable the shortcut keys or selection.
2019-08-08 02:09:46 +02:00
void LineEdit::set_shortcut_keys_enabled(bool p_enabled) {
shortcut_keys_enabled = p_enabled;
}
bool LineEdit::is_shortcut_keys_enabled() const {
return shortcut_keys_enabled;
}
Add option to disable virtual keyboard for LineEdit Co-authored-by: Alexander Holland <alexander.holland@live.de>
2020-07-22 08:04:48 +02:00
void LineEdit::set_virtual_keyboard_enabled(bool p_enable) {
virtual_keyboard_enabled = p_enable;
}
bool LineEdit::is_virtual_keyboard_enabled() const {
return virtual_keyboard_enabled;
}
Add support for multiple virtual keyboard types
2022-07-07 20:20:10 +02:00
void LineEdit::set_virtual_keyboard_type(VirtualKeyboardType p_type) {
virtual_keyboard_type = p_type;
}
LineEdit::VirtualKeyboardType LineEdit::get_virtual_keyboard_type() const {
return virtual_keyboard_type;
}
Added primary clipboard for Linux
2021-10-12 09:43:50 +02:00
void LineEdit::set_middle_mouse_paste_enabled(bool p_enabled) {
middle_mouse_paste_enabled = p_enabled;
}
bool LineEdit::is_middle_mouse_paste_enabled() const {
return middle_mouse_paste_enabled;
}
Add Ability to Enable/Disable Shortcuts for LineEdit/TextEdit This PR adds the ability to enable/disable shortcut keys and selection for LineEdit/TextEdit. It also updates the context menu when you disable/enable the shortcut keys or selection.
2019-08-08 02:09:46 +02:00
void LineEdit::set_selecting_enabled(bool p_enabled) {
Add some codes, returnes directly if the value is not changed. Avoid executing the following value-changed logics if the value does not really change.
2022-03-16 08:50:48 +01:00
if (selecting_enabled == p_enabled) {
return;
}
Add Ability to Enable/Disable Shortcuts for LineEdit/TextEdit This PR adds the ability to enable/disable shortcut keys and selection for LineEdit/TextEdit. It also updates the context menu when you disable/enable the shortcut keys or selection.
2019-08-08 02:09:46 +02:00
selecting_enabled = p_enabled;
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
if (!selecting_enabled) {
Add Ability to Enable/Disable Shortcuts for LineEdit/TextEdit This PR adds the ability to enable/disable shortcut keys and selection for LineEdit/TextEdit. It also updates the context menu when you disable/enable the shortcut keys or selection.
2019-08-08 02:09:46 +02:00
deselect();
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
}
Add Ability to Enable/Disable Shortcuts for LineEdit/TextEdit This PR adds the ability to enable/disable shortcut keys and selection for LineEdit/TextEdit. It also updates the context menu when you disable/enable the shortcut keys or selection.
2019-08-08 02:09:46 +02:00
}
bool LineEdit::is_selecting_enabled() const {
return selecting_enabled;
}
Add option to make selection unique
2021-10-21 23:02:46 +02:00
void LineEdit::set_deselect_on_focus_loss_enabled(const bool p_enabled) {
Add some codes, returnes directly if the value is not changed. Avoid executing the following value-changed logics if the value does not really change.
2022-03-16 08:50:48 +01:00
if (deselect_on_focus_loss_enabled == p_enabled) {
return;
}
Add option to make selection unique
2021-10-21 23:02:46 +02:00
deselect_on_focus_loss_enabled = p_enabled;
if (p_enabled && selection.enabled && !has_focus()) {
deselect();
}
}
bool LineEdit::is_deselect_on_focus_loss_enabled() const {
return deselect_on_focus_loss_enabled;
}
Add drag and drop option for line edit and rich text label
2023-07-17 02:32:00 +02:00
void LineEdit::set_drag_and_drop_selection_enabled(const bool p_enabled) {
drag_and_drop_selection_enabled = p_enabled;
}
bool LineEdit::is_drag_and_drop_selection_enabled() const {
return drag_and_drop_selection_enabled;
}
Texture refactor -Texture renamed to Texture2D -TextureLayered as base now inherits 2Darray, cubemap and cubemap array -Removed all references to flags in textures (they will go in the shader) -Texture3D gone for now (will come back later done properly) -Create base rasterizer for RenderDevice, RasterizerRD
2019-06-11 20:43:37 +02:00
void LineEdit::set_right_icon(const Ref<Texture2D> &p_icon) {
Do not use theme to set LineEdit right_icon
2018-08-11 12:04:19 +02:00
if (right_icon == p_icon) {
return;
}
right_icon = p_icon;
[Complex Text Layouts] Refactor Label and LineEdit controls.
2020-09-09 15:00:32 +02:00
_fit_to_width();
Rename minimum_size_changed() method
2021-12-06 14:02:34 +01:00
update_minimum_size();
Rename `CanvasItem.update()` to `queue_redraw()` Affects a lot of classes. Very thoroughly checked signal connections and deferred calls to this method, add_do_method/add_undo_method calls, and so on. Also renames the internal `_update_callback()` to `_redraw_callback()` for consistency. Just a few comments have also been changed to say "redraw". In CPUParticles2D, there was a private variable with the same name. It has been renamed to `do_redraw`.
2022-08-13 23:21:24 +02:00
queue_redraw();
Do not use theme to set LineEdit right_icon
2018-08-11 12:04:19 +02:00
}
Texture refactor -Texture renamed to Texture2D -TextureLayered as base now inherits 2Darray, cubemap and cubemap array -Removed all references to flags in textures (they will go in the shader) -Texture3D gone for now (will come back later done properly) -Create base rasterizer for RenderDevice, RasterizerRD
2019-06-11 20:43:37 +02:00
Ref<Texture2D> LineEdit::get_right_icon() {
Expose LineEdit's 'right_icon' and fix icon size
2019-09-09 03:46:57 +02:00
return right_icon;
}
-Added diectly editable expressions on node to VSEditor, closes #6392 -Added ability for LineEdit to expand to fit text
2016-09-07 01:34:24 +02:00
Add functions for getting name and font style from dynamic and bitmap fonts. Add font selection toolbar editor plugin.
2021-10-26 08:40:11 +02:00
void LineEdit::set_flat(bool p_enabled) {
if (flat != p_enabled) {
flat = p_enabled;
Rename `CanvasItem.update()` to `queue_redraw()` Affects a lot of classes. Very thoroughly checked signal connections and deferred calls to this method, add_do_method/add_undo_method calls, and so on. Also renames the internal `_update_callback()` to `_redraw_callback()` for consistency. Just a few comments have also been changed to say "redraw". In CPUParticles2D, there was a private variable with the same name. It has been renamed to `do_redraw`.
2022-08-13 23:21:24 +02:00
queue_redraw();
Add functions for getting name and font style from dynamic and bitmap fonts. Add font selection toolbar editor plugin.
2021-10-26 08:40:11 +02:00
}
}
bool LineEdit::is_flat() const {
return flat;
}
Allow selecting SpinBox & LineEdit text when focus enters
2022-10-16 14:37:35 +02:00
void LineEdit::set_select_all_on_focus(bool p_enabled) {
select_all_on_focus = p_enabled;
}
bool LineEdit::is_select_all_on_focus() const {
return select_all_on_focus;
}
void LineEdit::clear_pending_select_all_on_focus() {
pending_select_all_on_focus = false;
}
Expose LineEdit's 'right_icon' and fix icon size
2019-09-09 03:46:57 +02:00
void LineEdit::_text_changed() {
Added multi level undo redo to line edit
2017-10-30 00:14:33 +01:00
_emit_text_change();
_clear_redo();
}
void LineEdit::_emit_text_change() {
Optimize StringName usage * Added a new macro SNAME() that constructs and caches a local stringname. * Subsequent usages use the cached version. * Since these use a global static variable, a second refcounter of static usages need to be kept for cleanup time. * Replaced all theme usages by this new macro. * Replace all signal emission usages by this new macro. * Replace all call_deferred usages by this new macro. This is part of ongoing work to optimize GUI and the editor.
2021-07-17 23:22:52 +02:00
emit_signal(SNAME("text_changed"), text);
Fixed #15082: line edit emits two "text_changed" signals when pasting while text is selected
2018-02-05 16:22:34 +01:00
text_changed_dirty = false;
-Added diectly editable expressions on node to VSEditor, closes #6392 -Added ability for LineEdit to expand to fit text
2016-09-07 01:34:24 +02:00
}
Revert "Update Node::get_configuration_warnings signature" This reverts commit d3852deaa450d77edb30df2bb1c77bd7bc45befc.
2024-02-17 19:03:21 +01:00
PackedStringArray LineEdit::get_configuration_warnings() const {
PackedStringArray warnings = Control::get_configuration_warnings();
Make LineEdit secret character easier to change and enter 1. Allow values longer than 1 character in the property, but trim characters after the first one. 2. Allow empty strings, this acts like if a space was used as a secret character, so that an error isn't printed when you erase all characters in the property.
2023-09-16 09:24:08 +02:00
if (secret_character.length() > 1) {
warnings.push_back("Secret Character property supports only one character. Extra characters will be ignored.");
}
return warnings;
}
-Added diectly editable expressions on node to VSEditor, closes #6392 -Added ability for LineEdit to expand to fit text
2016-09-07 01:34:24 +02:00
[Complex Text Layouts] Refactor Label and LineEdit controls.
2020-09-09 15:00:32 +02:00
void LineEdit::_shape() {
Abort LineEdit shaping if no font is set to avoid unnecessary error messages.
2022-10-14 11:57:20 +02:00
const Ref<Font> &font = theme_cache.font;
int font_size = theme_cache.font_size;
if (font.is_null()) {
return;
}
[Complex Text Layouts] Refactor Label and LineEdit controls.
2020-09-09 15:00:32 +02:00
Size2 old_size = TS->shaped_text_get_size(text_rid);
TS->shaped_text_clear(text_rid);
String t;
Fix inline IME input not working in the empty LineEdit with the placeholder.
2021-10-11 07:21:34 +02:00
if (text.length() == 0 && ime_text.length() == 0) {
[Complex Text Layouts] Refactor Label and LineEdit controls.
2020-09-09 15:00:32 +02:00
t = placeholder_translated;
} else if (pass) {
[Text Overrun] Add option to set custom ellipsis character, add support for system font fallback.
2023-10-01 12:39:13 +02:00
String s = (secret_character.length() > 0) ? secret_character.left(1) : U"•";
t = s.repeat(text.length() + ime_text.length());
[Complex Text Layouts] Refactor Label and LineEdit controls.
2020-09-09 15:00:32 +02:00
} else {
if (ime_text.length() > 0) {
Rename LineEdit caret_* properties getters and setters to match property
2021-03-28 20:31:25 +02:00
t = text.substr(0, caret_column) + ime_text + text.substr(caret_column, text.length());
[Complex Text Layouts] Refactor Label and LineEdit controls.
2020-09-09 15:00:32 +02:00
} else {
t = text;
Update cached_width of the line_edit element when setting it to be secret
2020-01-29 20:46:49 +01:00
}
}
[Complex Text Layouts] Refactor Label and LineEdit controls.
2020-09-09 15:00:32 +02:00
if (text_direction == Control::TEXT_DIRECTION_INHERITED) {
TS->shaped_text_set_direction(text_rid, is_layout_rtl() ? TextServer::DIRECTION_RTL : TextServer::DIRECTION_LTR);
} else {
TS->shaped_text_set_direction(text_rid, (TextServer::Direction)text_direction);
}
TS->shaped_text_set_preserve_control(text_rid, draw_control_chars);
Refactor Font configuration and import UI, and Font resources.
2022-05-09 11:47:10 +02:00
TS->shaped_text_add_string(text_rid, t, font->get_rids(), font_size, font->get_opentype_features(), language);
[Complex Text Layouts] Refactor Label and LineEdit controls.
2020-09-09 15:00:32 +02:00
TS->shaped_text_set_bidi_override(text_rid, structured_text_parser(st_parser, st_args, t));
full_width = TS->shaped_text_get_size(text_rid).x;
_fit_to_width();
Size2 size = TS->shaped_text_get_size(text_rid);
if ((expand_to_text_length && old_size.x != size.x) || (old_size.y != size.y)) {
Rename minimum_size_changed() method
2021-12-06 14:02:34 +01:00
update_minimum_size();
[Complex Text Layouts] Refactor Label and LineEdit controls.
2020-09-09 15:00:32 +02:00
}
Update cached_width of the line_edit element when setting it to be secret
2020-01-29 20:46:49 +01:00
}
[Complex Text Layouts] Refactor Label and LineEdit controls.
2020-09-09 15:00:32 +02:00
void LineEdit::_fit_to_width() {
align to horizontal_alignment, valign to vertical_alignment, related
2021-11-25 03:58:47 +01:00
if (alignment == HORIZONTAL_ALIGNMENT_FILL) {
Add a lifecycle method for manual theme item caching to Control
2022-08-31 14:02:40 +02:00
Ref<StyleBox> style = theme_cache.normal;
Rename Control margin to offset
2020-12-22 17:24:29 +01:00
int t_width = get_size().width - style->get_margin(SIDE_RIGHT) - style->get_margin(SIDE_LEFT);
Rename empty() to is_empty()
2020-12-15 13:04:21 +01:00
bool using_placeholder = text.is_empty() && ime_text.is_empty();
[Complex Text Layouts] Refactor Label and LineEdit controls.
2020-09-09 15:00:32 +02:00
bool display_clear_icon = !using_placeholder && is_editable() && clear_button_enabled;
if (right_icon.is_valid() || display_clear_icon) {
Add a lifecycle method for manual theme item caching to Control
2022-08-31 14:02:40 +02:00
Ref<Texture2D> r_icon = display_clear_icon ? theme_cache.clear_icon : right_icon;
[Complex Text Layouts] Refactor Label and LineEdit controls.
2020-09-09 15:00:32 +02:00
t_width -= r_icon->get_width();
Line edit placeholders now react properly to translation changes.
2019-06-22 14:42:36 +02:00
}
[Complex Text Layouts] Refactor Label and LineEdit controls.
2020-09-09 15:00:32 +02:00
TS->shaped_text_fit_to_width(text_rid, MAX(t_width, full_width));
Line edit placeholders now react properly to translation changes.
2019-06-22 14:42:36 +02:00
}
}
Added multi level undo redo to line edit
2017-10-30 00:14:33 +01:00
void LineEdit::_clear_redo() {
_create_undo_state();
Replace NULL with nullptr
2020-04-02 01:20:12 +02:00
if (undo_stack_pos == nullptr) {
Added multi level undo redo to line edit
2017-10-30 00:14:33 +01:00
return;
}
undo_stack_pos = undo_stack_pos->next();
while (undo_stack_pos) {
List<TextOperation>::Element *elem = undo_stack_pos;
undo_stack_pos = undo_stack_pos->next();
undo_stack.erase(elem);
}
_create_undo_state();
}
void LineEdit::_clear_undo_stack() {
undo_stack.clear();
Replace NULL with nullptr
2020-04-02 01:20:12 +02:00
undo_stack_pos = nullptr;
Added multi level undo redo to line edit
2017-10-30 00:14:33 +01:00
_create_undo_state();
}
void LineEdit::_create_undo_state() {
TextOperation op;
op.text = text;
Rename LineEdit caret_* properties getters and setters to match property
2021-03-28 20:31:25 +02:00
op.caret_column = caret_column;
Expose LineEdit scroll offset to scripts
2020-11-11 09:26:55 +01:00
op.scroll_offset = scroll_offset;
Added multi level undo redo to line edit
2017-10-30 00:14:33 +01:00
undo_stack.push_back(op);
}
Use "enum class" for input enums
2021-08-13 23:31:57 +02:00
Key LineEdit::_get_menu_action_accelerator(const String &p_action) {
Removed hardcoded shortcuts from /scene and converted to input actions This removes hardcoded actions from things like LineEdit and TextEdit. Previously, things like copy, paste, etc were all hardcoded to Ctrl+C, Ctrl+V, etc. They could not be changed. This allows the possibility of them being changed, by making them use the action map. This has the added benefit of greatly simplifying the input handling logic in those controls. The logic which was previously in a huge and hard to follow switch statement has been extracted to individual methods.
2020-12-07 12:32:00 +01:00
const List<Ref<InputEvent>> *events = InputMap::get_singleton()->action_get_events(p_action);
if (!events) {
Use "enum class" for input enums
2021-08-13 23:31:57 +02:00
return Key::NONE;
Removed hardcoded shortcuts from /scene and converted to input actions This removes hardcoded actions from things like LineEdit and TextEdit. Previously, things like copy, paste, etc were all hardcoded to Ctrl+C, Ctrl+V, etc. They could not be changed. This allows the possibility of them being changed, by making them use the action map. This has the added benefit of greatly simplifying the input handling logic in those controls. The logic which was previously in a huge and hard to follow switch statement has been extracted to individual methods.
2020-12-07 12:32:00 +01:00
}
// Use first event in the list for the accelerator.
const List<Ref<InputEvent>>::Element *first_event = events->front();
if (!first_event) {
Use "enum class" for input enums
2021-08-13 23:31:57 +02:00
return Key::NONE;
Removed hardcoded shortcuts from /scene and converted to input actions This removes hardcoded actions from things like LineEdit and TextEdit. Previously, things like copy, paste, etc were all hardcoded to Ctrl+C, Ctrl+V, etc. They could not be changed. This allows the possibility of them being changed, by making them use the action map. This has the added benefit of greatly simplifying the input handling logic in those controls. The logic which was previously in a huge and hard to follow switch statement has been extracted to individual methods.
2020-12-07 12:32:00 +01:00
}
const Ref<InputEventKey> event = first_event->get();
if (event.is_null()) {
Use "enum class" for input enums
2021-08-13 23:31:57 +02:00
return Key::NONE;
Removed hardcoded shortcuts from /scene and converted to input actions This removes hardcoded actions from things like LineEdit and TextEdit. Previously, things like copy, paste, etc were all hardcoded to Ctrl+C, Ctrl+V, etc. They could not be changed. This allows the possibility of them being changed, by making them use the action map. This has the added benefit of greatly simplifying the input handling logic in those controls. The logic which was previously in a huge and hard to follow switch statement has been extracted to individual methods.
2020-12-07 12:32:00 +01:00
}
Code style improvements to text_edit and related
2023-03-08 23:00:27 +01:00
// Use physical keycode if non-zero.
Use "enum class" for input enums
2021-08-13 23:31:57 +02:00
if (event->get_physical_keycode() != Key::NONE) {
Removed hardcoded shortcuts from /scene and converted to input actions This removes hardcoded actions from things like LineEdit and TextEdit. Previously, things like copy, paste, etc were all hardcoded to Ctrl+C, Ctrl+V, etc. They could not be changed. This allows the possibility of them being changed, by making them use the action map. This has the added benefit of greatly simplifying the input handling logic in those controls. The logic which was previously in a huge and hard to follow switch statement has been extracted to individual methods.
2020-12-07 12:32:00 +01:00
return event->get_physical_keycode_with_modifiers();
} else {
return event->get_keycode_with_modifiers();
}
}
Fix `LineEdit` and `TextEdit` context menus not customizable
2023-01-26 18:59:41 +01:00
void LineEdit::_generate_context_menu() {
menu = memnew(PopupMenu);
add_child(menu, false, INTERNAL_MODE_FRONT);
menu_dir = memnew(PopupMenu);
menu_dir->add_radio_check_item(RTR("Same as Layout Direction"), MENU_DIR_INHERITED);
menu_dir->add_radio_check_item(RTR("Auto-Detect Direction"), MENU_DIR_AUTO);
menu_dir->add_radio_check_item(RTR("Left-to-Right"), MENU_DIR_LTR);
menu_dir->add_radio_check_item(RTR("Right-to-Left"), MENU_DIR_RTL);
menu_ctl = memnew(PopupMenu);
menu_ctl->add_item(RTR("Left-to-Right Mark (LRM)"), MENU_INSERT_LRM);
menu_ctl->add_item(RTR("Right-to-Left Mark (RLM)"), MENU_INSERT_RLM);
menu_ctl->add_item(RTR("Start of Left-to-Right Embedding (LRE)"), MENU_INSERT_LRE);
menu_ctl->add_item(RTR("Start of Right-to-Left Embedding (RLE)"), MENU_INSERT_RLE);
menu_ctl->add_item(RTR("Start of Left-to-Right Override (LRO)"), MENU_INSERT_LRO);
menu_ctl->add_item(RTR("Start of Right-to-Left Override (RLO)"), MENU_INSERT_RLO);
menu_ctl->add_item(RTR("Pop Direction Formatting (PDF)"), MENU_INSERT_PDF);
menu_ctl->add_separator();
menu_ctl->add_item(RTR("Arabic Letter Mark (ALM)"), MENU_INSERT_ALM);
menu_ctl->add_item(RTR("Left-to-Right Isolate (LRI)"), MENU_INSERT_LRI);
menu_ctl->add_item(RTR("Right-to-Left Isolate (RLI)"), MENU_INSERT_RLI);
menu_ctl->add_item(RTR("First Strong Isolate (FSI)"), MENU_INSERT_FSI);
menu_ctl->add_item(RTR("Pop Direction Isolate (PDI)"), MENU_INSERT_PDI);
menu_ctl->add_separator();
menu_ctl->add_item(RTR("Zero-Width Joiner (ZWJ)"), MENU_INSERT_ZWJ);
menu_ctl->add_item(RTR("Zero-Width Non-Joiner (ZWNJ)"), MENU_INSERT_ZWNJ);
menu_ctl->add_item(RTR("Word Joiner (WJ)"), MENU_INSERT_WJ);
menu_ctl->add_item(RTR("Soft Hyphen (SHY)"), MENU_INSERT_SHY);
menu->add_item(RTR("Cut"), MENU_CUT);
menu->add_item(RTR("Copy"), MENU_COPY);
menu->add_item(RTR("Paste"), MENU_PASTE);
menu->add_separator();
menu->add_item(RTR("Select All"), MENU_SELECT_ALL);
menu->add_item(RTR("Clear"), MENU_CLEAR);
menu->add_separator();
menu->add_item(RTR("Undo"), MENU_UNDO);
menu->add_item(RTR("Redo"), MENU_REDO);
menu->add_separator();
Add methods to add submenus without using names
2023-11-28 17:33:04 +01:00
menu->add_submenu_node_item(RTR("Text Writing Direction"), menu_dir, MENU_SUBMENU_TEXT_DIR);
Fix `LineEdit` and `TextEdit` context menus not customizable
2023-01-26 18:59:41 +01:00
menu->add_separator();
menu->add_check_item(RTR("Display Control Characters"), MENU_DISPLAY_UCC);
Add methods to add submenus without using names
2023-11-28 17:33:04 +01:00
menu->add_submenu_node_item(RTR("Insert Control Character"), menu_ctl, MENU_SUBMENU_INSERT_UCC);
Fix `LineEdit` and `TextEdit` context menus not customizable
2023-01-26 18:59:41 +01:00
menu->connect("id_pressed", callable_mp(this, &LineEdit::menu_option));
menu_dir->connect("id_pressed", callable_mp(this, &LineEdit::menu_option));
menu_ctl->connect("id_pressed", callable_mp(this, &LineEdit::menu_option));
menu->connect(SNAME("focus_entered"), callable_mp(this, &LineEdit::_validate_caret_can_draw));
menu->connect(SNAME("focus_exited"), callable_mp(this, &LineEdit::_validate_caret_can_draw));
}
void LineEdit::_update_context_menu() {
if (!menu) {
_generate_context_menu();
}
int idx = -1;
#define MENU_ITEM_ACTION_DISABLED(m_menu, m_id, m_action, m_disabled) \
idx = m_menu->get_item_index(m_id); \
if (idx >= 0) { \
m_menu->set_item_accelerator(idx, shortcut_keys_enabled ? _get_menu_action_accelerator(m_action) : Key::NONE); \
m_menu->set_item_disabled(idx, m_disabled); \
}
#define MENU_ITEM_ACTION(m_menu, m_id, m_action) \
idx = m_menu->get_item_index(m_id); \
if (idx >= 0) { \
m_menu->set_item_accelerator(idx, shortcut_keys_enabled ? _get_menu_action_accelerator(m_action) : Key::NONE); \
}
#define MENU_ITEM_DISABLED(m_menu, m_id, m_disabled) \
idx = m_menu->get_item_index(m_id); \
if (idx >= 0) { \
m_menu->set_item_disabled(idx, m_disabled); \
}
#define MENU_ITEM_CHECKED(m_menu, m_id, m_checked) \
idx = m_menu->get_item_index(m_id); \
if (idx >= 0) { \
m_menu->set_item_checked(idx, m_checked); \
}
MENU_ITEM_ACTION_DISABLED(menu, MENU_CUT, "ui_cut", !editable)
MENU_ITEM_ACTION(menu, MENU_COPY, "ui_copy")
MENU_ITEM_ACTION_DISABLED(menu, MENU_PASTE, "ui_paste", !editable)
MENU_ITEM_ACTION_DISABLED(menu, MENU_SELECT_ALL, "ui_text_select_all", !selecting_enabled)
MENU_ITEM_DISABLED(menu, MENU_CLEAR, !editable)
MENU_ITEM_ACTION_DISABLED(menu, MENU_UNDO, "ui_undo", !editable || !has_undo())
MENU_ITEM_ACTION_DISABLED(menu, MENU_REDO, "ui_redo", !editable || !has_redo())
MENU_ITEM_CHECKED(menu_dir, MENU_DIR_INHERITED, text_direction == TEXT_DIRECTION_INHERITED)
MENU_ITEM_CHECKED(menu_dir, MENU_DIR_AUTO, text_direction == TEXT_DIRECTION_AUTO)
MENU_ITEM_CHECKED(menu_dir, MENU_DIR_LTR, text_direction == TEXT_DIRECTION_LTR)
MENU_ITEM_CHECKED(menu_dir, MENU_DIR_RTL, text_direction == TEXT_DIRECTION_RTL)
MENU_ITEM_CHECKED(menu, MENU_DISPLAY_UCC, draw_control_chars)
MENU_ITEM_DISABLED(menu, MENU_SUBMENU_INSERT_UCC, !editable)
#undef MENU_ITEM_ACTION_DISABLED
#undef MENU_ITEM_ACTION
#undef MENU_ITEM_DISABLED
#undef MENU_ITEM_CHECKED
}
Make `_validate_property` a multilevel method
2022-08-12 22:57:11 +02:00
void LineEdit::_validate_property(PropertyInfo &p_property) const {
Rename every instance of `caret_blink_speed` to `caret_blink_interval` It's been changed in EditorSettings, LineEdit, TextEdit. Affects setters and getters, and passed parameters, too.
2022-08-13 14:52:35 +02:00
if (!caret_blink_enabled && p_property.name == "caret_blink_interval") {
Make `_validate_property` a multilevel method
2022-08-12 22:57:11 +02:00
p_property.usage = PROPERTY_USAGE_NO_EDITOR;
Hide more options of disabled properties
2021-03-04 00:51:35 +01:00
}
}
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
void LineEdit::_bind_methods() {
align to horizontal_alignment, valign to vertical_alignment, related
2021-11-25 03:58:47 +01:00
ClassDB::bind_method(D_METHOD("set_horizontal_alignment", "alignment"), &LineEdit::set_horizontal_alignment);
ClassDB::bind_method(D_METHOD("get_horizontal_alignment"), &LineEdit::get_horizontal_alignment);
Rename the _MD macro to D_METHOD This new name also makes its purpose a little clearer This is a step towards fixing #56
2017-02-13 12:47:24 +01:00
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
ClassDB::bind_method(D_METHOD("clear"), &LineEdit::clear);
Exposed LineEdit's "selection_clear" and renamed it to "deselect".
2017-12-17 18:40:44 +01:00
ClassDB::bind_method(D_METHOD("select", "from", "to"), &LineEdit::select, DEFVAL(0), DEFVAL(-1));
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
ClassDB::bind_method(D_METHOD("select_all"), &LineEdit::select_all);
Exposed LineEdit's "selection_clear" and renamed it to "deselect".
2017-12-17 18:40:44 +01:00
ClassDB::bind_method(D_METHOD("deselect"), &LineEdit::deselect);
Add selection getter methods to `LineEdit`
2021-09-24 10:00:45 +02:00
ClassDB::bind_method(D_METHOD("has_selection"), &LineEdit::has_selection);
Implement LineEdit.get_selected_text()
2023-03-30 17:07:28 +02:00
ClassDB::bind_method(D_METHOD("get_selected_text"), &LineEdit::get_selected_text);
Add selection getter methods to `LineEdit`
2021-09-24 10:00:45 +02:00
ClassDB::bind_method(D_METHOD("get_selection_from_column"), &LineEdit::get_selection_from_column);
ClassDB::bind_method(D_METHOD("get_selection_to_column"), &LineEdit::get_selection_to_column);
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
ClassDB::bind_method(D_METHOD("set_text", "text"), &LineEdit::set_text);
ClassDB::bind_method(D_METHOD("get_text"), &LineEdit::get_text);
[Complex Text Layouts] Refactor Label and LineEdit controls.
2020-09-09 15:00:32 +02:00
ClassDB::bind_method(D_METHOD("get_draw_control_chars"), &LineEdit::get_draw_control_chars);
ClassDB::bind_method(D_METHOD("set_draw_control_chars", "enable"), &LineEdit::set_draw_control_chars);
ClassDB::bind_method(D_METHOD("set_text_direction", "direction"), &LineEdit::set_text_direction);
ClassDB::bind_method(D_METHOD("get_text_direction"), &LineEdit::get_text_direction);
ClassDB::bind_method(D_METHOD("set_language", "language"), &LineEdit::set_language);
ClassDB::bind_method(D_METHOD("get_language"), &LineEdit::get_language);
ClassDB::bind_method(D_METHOD("set_structured_text_bidi_override", "parser"), &LineEdit::set_structured_text_bidi_override);
ClassDB::bind_method(D_METHOD("get_structured_text_bidi_override"), &LineEdit::get_structured_text_bidi_override);
ClassDB::bind_method(D_METHOD("set_structured_text_bidi_override_options", "args"), &LineEdit::set_structured_text_bidi_override_options);
ClassDB::bind_method(D_METHOD("get_structured_text_bidi_override_options"), &LineEdit::get_structured_text_bidi_override_options);
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
ClassDB::bind_method(D_METHOD("set_placeholder", "text"), &LineEdit::set_placeholder);
ClassDB::bind_method(D_METHOD("get_placeholder"), &LineEdit::get_placeholder);
Rename LineEdit caret_* properties getters and setters to match property
2021-03-28 20:31:25 +02:00
ClassDB::bind_method(D_METHOD("set_caret_column", "position"), &LineEdit::set_caret_column);
ClassDB::bind_method(D_METHOD("get_caret_column"), &LineEdit::get_caret_column);
Expose LineEdit scroll offset to scripts
2020-11-11 09:26:55 +01:00
ClassDB::bind_method(D_METHOD("get_scroll_offset"), &LineEdit::get_scroll_offset);
Rename LineEdit caret_* properties getters and setters to match property
2021-03-28 20:31:25 +02:00
ClassDB::bind_method(D_METHOD("set_expand_to_text_length_enabled", "enabled"), &LineEdit::set_expand_to_text_length_enabled);
ClassDB::bind_method(D_METHOD("is_expand_to_text_length_enabled"), &LineEdit::is_expand_to_text_length_enabled);
ClassDB::bind_method(D_METHOD("set_caret_blink_enabled", "enabled"), &LineEdit::set_caret_blink_enabled);
ClassDB::bind_method(D_METHOD("is_caret_blink_enabled"), &LineEdit::is_caret_blink_enabled);
ClassDB::bind_method(D_METHOD("set_caret_mid_grapheme_enabled", "enabled"), &LineEdit::set_caret_mid_grapheme_enabled);
ClassDB::bind_method(D_METHOD("is_caret_mid_grapheme_enabled"), &LineEdit::is_caret_mid_grapheme_enabled);
ClassDB::bind_method(D_METHOD("set_caret_force_displayed", "enabled"), &LineEdit::set_caret_force_displayed);
ClassDB::bind_method(D_METHOD("is_caret_force_displayed"), &LineEdit::is_caret_force_displayed);
Rename every instance of `caret_blink_speed` to `caret_blink_interval` It's been changed in EditorSettings, LineEdit, TextEdit. Affects setters and getters, and passed parameters, too.
2022-08-13 14:52:35 +02:00
ClassDB::bind_method(D_METHOD("set_caret_blink_interval", "interval"), &LineEdit::set_caret_blink_interval);
ClassDB::bind_method(D_METHOD("get_caret_blink_interval"), &LineEdit::get_caret_blink_interval);
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
ClassDB::bind_method(D_METHOD("set_max_length", "chars"), &LineEdit::set_max_length);
ClassDB::bind_method(D_METHOD("get_max_length"), &LineEdit::get_max_length);
Rename LineEdit caret_* properties getters and setters to match property
2021-03-28 20:31:25 +02:00
ClassDB::bind_method(D_METHOD("insert_text_at_caret", "text"), &LineEdit::insert_text_at_caret);
ClassDB::bind_method(D_METHOD("delete_char_at_caret"), &LineEdit::delete_char);
Make text deletion methods public for LineEdit
2020-06-06 17:39:53 +02:00
ClassDB::bind_method(D_METHOD("delete_text", "from_column", "to_column"), &LineEdit::delete_text);
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
ClassDB::bind_method(D_METHOD("set_editable", "enabled"), &LineEdit::set_editable);
ClassDB::bind_method(D_METHOD("is_editable"), &LineEdit::is_editable);
ClassDB::bind_method(D_METHOD("set_secret", "enabled"), &LineEdit::set_secret);
ClassDB::bind_method(D_METHOD("is_secret"), &LineEdit::is_secret);
Make the LineEdit "secret" character customizable
2018-04-28 20:24:48 +02:00
ClassDB::bind_method(D_METHOD("set_secret_character", "character"), &LineEdit::set_secret_character);
ClassDB::bind_method(D_METHOD("get_secret_character"), &LineEdit::get_secret_character);
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
ClassDB::bind_method(D_METHOD("menu_option", "option"), &LineEdit::menu_option);
Removes type information from method binds
2017-08-09 13:19:41 +02:00
ClassDB::bind_method(D_METHOD("get_menu"), &LineEdit::get_menu);
Create many types of popups on demand * LineEdit popups created on demand. * TextEdit popups created on demand. * SpinSlider popups created on demand. * ResourcePicker popups created on demand. Improves editor responsiveness.
2021-07-16 23:36:05 +02:00
ClassDB::bind_method(D_METHOD("is_menu_visible"), &LineEdit::is_menu_visible);
add context menu enable getters, setters, and properties in LineEdit and TextEdit
2017-11-09 21:46:29 +01:00
ClassDB::bind_method(D_METHOD("set_context_menu_enabled", "enable"), &LineEdit::set_context_menu_enabled);
ClassDB::bind_method(D_METHOD("is_context_menu_enabled"), &LineEdit::is_context_menu_enabled);
Add option to disable virtual keyboard for LineEdit Co-authored-by: Alexander Holland <alexander.holland@live.de>
2020-07-22 08:04:48 +02:00
ClassDB::bind_method(D_METHOD("set_virtual_keyboard_enabled", "enable"), &LineEdit::set_virtual_keyboard_enabled);
ClassDB::bind_method(D_METHOD("is_virtual_keyboard_enabled"), &LineEdit::is_virtual_keyboard_enabled);
Add support for multiple virtual keyboard types
2022-07-07 20:20:10 +02:00
ClassDB::bind_method(D_METHOD("set_virtual_keyboard_type", "type"), &LineEdit::set_virtual_keyboard_type);
ClassDB::bind_method(D_METHOD("get_virtual_keyboard_type"), &LineEdit::get_virtual_keyboard_type);
Add clear text button to LineEdit - Add pressed state to clear button - Enable clear button on all inputs with search icon - Remove duplicate clear buttons - Fix rendering of icon for center and right alignments - Add clear button to more search fields - Add clear icon to default theme - Add method to control enabled state of clear button - Add property to enable clear button from inspector
2018-07-26 13:45:38 +02:00
ClassDB::bind_method(D_METHOD("set_clear_button_enabled", "enable"), &LineEdit::set_clear_button_enabled);
ClassDB::bind_method(D_METHOD("is_clear_button_enabled"), &LineEdit::is_clear_button_enabled);
Add Ability to Enable/Disable Shortcuts for LineEdit/TextEdit This PR adds the ability to enable/disable shortcut keys and selection for LineEdit/TextEdit. It also updates the context menu when you disable/enable the shortcut keys or selection.
2019-08-08 02:09:46 +02:00
ClassDB::bind_method(D_METHOD("set_shortcut_keys_enabled", "enable"), &LineEdit::set_shortcut_keys_enabled);
ClassDB::bind_method(D_METHOD("is_shortcut_keys_enabled"), &LineEdit::is_shortcut_keys_enabled);
Added primary clipboard for Linux
2021-10-12 09:43:50 +02:00
ClassDB::bind_method(D_METHOD("set_middle_mouse_paste_enabled", "enable"), &LineEdit::set_middle_mouse_paste_enabled);
ClassDB::bind_method(D_METHOD("is_middle_mouse_paste_enabled"), &LineEdit::is_middle_mouse_paste_enabled);
Add Ability to Enable/Disable Shortcuts for LineEdit/TextEdit This PR adds the ability to enable/disable shortcut keys and selection for LineEdit/TextEdit. It also updates the context menu when you disable/enable the shortcut keys or selection.
2019-08-08 02:09:46 +02:00
ClassDB::bind_method(D_METHOD("set_selecting_enabled", "enable"), &LineEdit::set_selecting_enabled);
ClassDB::bind_method(D_METHOD("is_selecting_enabled"), &LineEdit::is_selecting_enabled);
Add option to make selection unique
2021-10-21 23:02:46 +02:00
ClassDB::bind_method(D_METHOD("set_deselect_on_focus_loss_enabled", "enable"), &LineEdit::set_deselect_on_focus_loss_enabled);
ClassDB::bind_method(D_METHOD("is_deselect_on_focus_loss_enabled"), &LineEdit::is_deselect_on_focus_loss_enabled);
Add drag and drop option for line edit and rich text label
2023-07-17 02:32:00 +02:00
ClassDB::bind_method(D_METHOD("set_drag_and_drop_selection_enabled", "enable"), &LineEdit::set_drag_and_drop_selection_enabled);
ClassDB::bind_method(D_METHOD("is_drag_and_drop_selection_enabled"), &LineEdit::is_drag_and_drop_selection_enabled);
Expose LineEdit's 'right_icon' and fix icon size
2019-09-09 03:46:57 +02:00
ClassDB::bind_method(D_METHOD("set_right_icon", "icon"), &LineEdit::set_right_icon);
ClassDB::bind_method(D_METHOD("get_right_icon"), &LineEdit::get_right_icon);
Add functions for getting name and font style from dynamic and bitmap fonts. Add font selection toolbar editor plugin.
2021-10-26 08:40:11 +02:00
ClassDB::bind_method(D_METHOD("set_flat", "enabled"), &LineEdit::set_flat);
ClassDB::bind_method(D_METHOD("is_flat"), &LineEdit::is_flat);
Allow selecting SpinBox & LineEdit text when focus enters
2022-10-16 14:37:35 +02:00
ClassDB::bind_method(D_METHOD("set_select_all_on_focus", "enabled"), &LineEdit::set_select_all_on_focus);
ClassDB::bind_method(D_METHOD("is_select_all_on_focus"), &LineEdit::is_select_all_on_focus);
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
Fix signal arguments shadowing member variables Fixes #10212.
2018-01-09 16:39:43 +01:00
ADD_SIGNAL(MethodInfo("text_changed", PropertyInfo(Variant::STRING, "new_text")));
LineEdit: Respect `max_length` by truncating text to append When appending text (either via `set_text()` or by pasting from clipboard), if the input would make the `LineEdit` exceed its configured `max_length`, the input text is truncated to fit. The discard part is passed as a parameter in the `text_change_rejected` signal. Fixes #33321. Fixes #41278. Also cleaned up unimplemented `max_chars` property in `TextEdit`. Co-authored-by: Tony-Goat <70238376+Tony-Goat@users.noreply.github.com>
2021-07-06 12:49:27 +02:00
ADD_SIGNAL(MethodInfo("text_change_rejected", PropertyInfo(Variant::STRING, "rejected_substring")));
Documentation search fixes Updates rich_text_label so that the built-in documentation can be searched Previously, it would only find the first result and would not select other results Renames "_entered" functions to "_submitted"
2021-06-16 18:43:34 +02:00
ADD_SIGNAL(MethodInfo("text_submitted", PropertyInfo(Variant::STRING, "new_text")));
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
ClassDB: Provide the enum name of integer constants
2017-08-20 17:45:01 +02:00
BIND_ENUM_CONSTANT(MENU_CUT);
BIND_ENUM_CONSTANT(MENU_COPY);
BIND_ENUM_CONSTANT(MENU_PASTE);
BIND_ENUM_CONSTANT(MENU_CLEAR);
BIND_ENUM_CONSTANT(MENU_SELECT_ALL);
BIND_ENUM_CONSTANT(MENU_UNDO);
Added multi level undo redo to line edit
2017-10-30 00:14:33 +01:00
BIND_ENUM_CONSTANT(MENU_REDO);
Fix `LineEdit` and `TextEdit` context menus not customizable
2023-01-26 18:59:41 +01:00
BIND_ENUM_CONSTANT(MENU_SUBMENU_TEXT_DIR);
[Complex Text Layouts] Refactor Label and LineEdit controls.
2020-09-09 15:00:32 +02:00
BIND_ENUM_CONSTANT(MENU_DIR_INHERITED);
BIND_ENUM_CONSTANT(MENU_DIR_AUTO);
BIND_ENUM_CONSTANT(MENU_DIR_LTR);
BIND_ENUM_CONSTANT(MENU_DIR_RTL);
BIND_ENUM_CONSTANT(MENU_DISPLAY_UCC);
Fix `LineEdit` and `TextEdit` context menus not customizable
2023-01-26 18:59:41 +01:00
BIND_ENUM_CONSTANT(MENU_SUBMENU_INSERT_UCC);
[Complex Text Layouts] Refactor Label and LineEdit controls.
2020-09-09 15:00:32 +02:00
BIND_ENUM_CONSTANT(MENU_INSERT_LRM);
BIND_ENUM_CONSTANT(MENU_INSERT_RLM);
BIND_ENUM_CONSTANT(MENU_INSERT_LRE);
BIND_ENUM_CONSTANT(MENU_INSERT_RLE);
BIND_ENUM_CONSTANT(MENU_INSERT_LRO);
BIND_ENUM_CONSTANT(MENU_INSERT_RLO);
BIND_ENUM_CONSTANT(MENU_INSERT_PDF);
BIND_ENUM_CONSTANT(MENU_INSERT_ALM);
BIND_ENUM_CONSTANT(MENU_INSERT_LRI);
BIND_ENUM_CONSTANT(MENU_INSERT_RLI);
BIND_ENUM_CONSTANT(MENU_INSERT_FSI);
BIND_ENUM_CONSTANT(MENU_INSERT_PDI);
BIND_ENUM_CONSTANT(MENU_INSERT_ZWJ);
BIND_ENUM_CONSTANT(MENU_INSERT_ZWNJ);
BIND_ENUM_CONSTANT(MENU_INSERT_WJ);
BIND_ENUM_CONSTANT(MENU_INSERT_SHY);
ClassDB: Provide the enum name of integer constants
2017-08-20 17:45:01 +02:00
BIND_ENUM_CONSTANT(MENU_MAX);
Default editing popup for LineEdit and TextEdit
2016-05-17 01:25:17 +02:00
Add support for multiple virtual keyboard types
2022-07-07 20:20:10 +02:00
BIND_ENUM_CONSTANT(KEYBOARD_TYPE_DEFAULT);
BIND_ENUM_CONSTANT(KEYBOARD_TYPE_MULTILINE);
BIND_ENUM_CONSTANT(KEYBOARD_TYPE_NUMBER);
BIND_ENUM_CONSTANT(KEYBOARD_TYPE_NUMBER_DECIMAL);
BIND_ENUM_CONSTANT(KEYBOARD_TYPE_PHONE);
BIND_ENUM_CONSTANT(KEYBOARD_TYPE_EMAIL_ADDRESS);
BIND_ENUM_CONSTANT(KEYBOARD_TYPE_PASSWORD);
BIND_ENUM_CONSTANT(KEYBOARD_TYPE_URL);
-Moved EditorDefaultValue to ClassDB, made it core -Removed one and zero hints for properties, replaced by default value
2018-11-08 15:30:02 +01:00
ADD_PROPERTY(PropertyInfo(Variant::STRING, "text"), "set_text", "get_text");
Move placeholder color to theme item
2022-01-30 18:56:23 +01:00
ADD_PROPERTY(PropertyInfo(Variant::STRING, "placeholder_text"), "set_placeholder", "get_placeholder");
align to horizontal_alignment, valign to vertical_alignment, related
2021-11-25 03:58:47 +01:00
ADD_PROPERTY(PropertyInfo(Variant::INT, "alignment", PROPERTY_HINT_ENUM, "Left,Center,Right,Fill"), "set_horizontal_alignment", "get_horizontal_alignment");
LineEdit: Respect `max_length` by truncating text to append When appending text (either via `set_text()` or by pasting from clipboard), if the input would make the `LineEdit` exceed its configured `max_length`, the input text is truncated to fit. The discard part is passed as a parameter in the `text_change_rejected` signal. Fixes #33321. Fixes #41278. Also cleaned up unimplemented `max_chars` property in `TextEdit`. Co-authored-by: Tony-Goat <70238376+Tony-Goat@users.noreply.github.com>
2021-07-06 12:49:27 +02:00
ADD_PROPERTY(PropertyInfo(Variant::INT, "max_length", PROPERTY_HINT_RANGE, "0,1000,1,or_greater"), "set_max_length", "get_max_length");
-Moved EditorDefaultValue to ClassDB, made it core -Removed one and zero hints for properties, replaced by default value
2018-11-08 15:30:02 +01:00
ADD_PROPERTY(PropertyInfo(Variant::BOOL, "editable"), "set_editable", "is_editable");
Rename LineEdit caret_* properties getters and setters to match property
2021-03-28 20:31:25 +02:00
ADD_PROPERTY(PropertyInfo(Variant::BOOL, "expand_to_text_length"), "set_expand_to_text_length_enabled", "is_expand_to_text_length_enabled");
Bind many more properties to scripts Notable potentially breaking changes: - PROPERTY_USAGE_NOEDITOR is now PROPERTY_USAGE_STORAGE | PROPERTY_USAGE_NETWORK, without PROPERTY_USAGE_INTERNAL - Some properties were renamed, and sometimes even shadowed by new ones - New getter methods (some virtual) were added
2018-01-11 23:35:12 +01:00
ADD_PROPERTY(PropertyInfo(Variant::BOOL, "context_menu_enabled"), "set_context_menu_enabled", "is_context_menu_enabled");
Add option to disable virtual keyboard for LineEdit Co-authored-by: Alexander Holland <alexander.holland@live.de>
2020-07-22 08:04:48 +02:00
ADD_PROPERTY(PropertyInfo(Variant::BOOL, "virtual_keyboard_enabled"), "set_virtual_keyboard_enabled", "is_virtual_keyboard_enabled");
Add support for multiple virtual keyboard types
2022-07-07 20:20:10 +02:00
ADD_PROPERTY(PropertyInfo(Variant::INT, "virtual_keyboard_type", PROPERTY_HINT_ENUM, "Default,Multiline,Number,Decimal,Phone,Email,Password,URL"), "set_virtual_keyboard_type", "get_virtual_keyboard_type");
Add clear text button to LineEdit - Add pressed state to clear button - Enable clear button on all inputs with search icon - Remove duplicate clear buttons - Fix rendering of icon for center and right alignments - Add clear button to more search fields - Add clear icon to default theme - Add method to control enabled state of clear button - Add property to enable clear button from inspector
2018-07-26 13:45:38 +02:00
ADD_PROPERTY(PropertyInfo(Variant::BOOL, "clear_button_enabled"), "set_clear_button_enabled", "is_clear_button_enabled");
Add Ability to Enable/Disable Shortcuts for LineEdit/TextEdit This PR adds the ability to enable/disable shortcut keys and selection for LineEdit/TextEdit. It also updates the context menu when you disable/enable the shortcut keys or selection.
2019-08-08 02:09:46 +02:00
ADD_PROPERTY(PropertyInfo(Variant::BOOL, "shortcut_keys_enabled"), "set_shortcut_keys_enabled", "is_shortcut_keys_enabled");
Added primary clipboard for Linux
2021-10-12 09:43:50 +02:00
ADD_PROPERTY(PropertyInfo(Variant::BOOL, "middle_mouse_paste_enabled"), "set_middle_mouse_paste_enabled", "is_middle_mouse_paste_enabled");
Add Ability to Enable/Disable Shortcuts for LineEdit/TextEdit This PR adds the ability to enable/disable shortcut keys and selection for LineEdit/TextEdit. It also updates the context menu when you disable/enable the shortcut keys or selection.
2019-08-08 02:09:46 +02:00
ADD_PROPERTY(PropertyInfo(Variant::BOOL, "selecting_enabled"), "set_selecting_enabled", "is_selecting_enabled");
Add option to make selection unique
2021-10-21 23:02:46 +02:00
ADD_PROPERTY(PropertyInfo(Variant::BOOL, "deselect_on_focus_loss_enabled"), "set_deselect_on_focus_loss_enabled", "is_deselect_on_focus_loss_enabled");
Add drag and drop option for line edit and rich text label
2023-07-17 02:32:00 +02:00
ADD_PROPERTY(PropertyInfo(Variant::BOOL, "drag_and_drop_selection_enabled"), "set_drag_and_drop_selection_enabled", "is_drag_and_drop_selection_enabled");
Change dropdown type filter to Texture2D in certain nodes
2023-10-28 15:52:11 +02:00
ADD_PROPERTY(PropertyInfo(Variant::OBJECT, "right_icon", PROPERTY_HINT_RESOURCE_TYPE, "Texture2D"), "set_right_icon", "get_right_icon");
Add functions for getting name and font style from dynamic and bitmap fonts. Add font selection toolbar editor plugin.
2021-10-26 08:40:11 +02:00
ADD_PROPERTY(PropertyInfo(Variant::BOOL, "flat"), "set_flat", "is_flat");
[Complex Text Layouts] Refactor Label and LineEdit controls.
2020-09-09 15:00:32 +02:00
ADD_PROPERTY(PropertyInfo(Variant::BOOL, "draw_control_chars"), "set_draw_control_chars", "get_draw_control_chars");
Allow selecting SpinBox & LineEdit text when focus enters
2022-10-16 14:37:35 +02:00
ADD_PROPERTY(PropertyInfo(Variant::BOOL, "select_all_on_focus"), "set_select_all_on_focus", "is_select_all_on_focus");
Refactor Font configuration and import UI, and Font resources.
2022-05-09 11:47:10 +02:00
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
ADD_GROUP("Caret", "caret_");
Rename LineEdit caret_* properties getters and setters to match property
2021-03-28 20:31:25 +02:00
ADD_PROPERTY(PropertyInfo(Variant::BOOL, "caret_blink"), "set_caret_blink_enabled", "is_caret_blink_enabled");
Rename every instance of `caret_blink_speed` to `caret_blink_interval` It's been changed in EditorSettings, LineEdit, TextEdit. Affects setters and getters, and passed parameters, too.
2022-08-13 14:52:35 +02:00
ADD_PROPERTY(PropertyInfo(Variant::FLOAT, "caret_blink_interval", PROPERTY_HINT_RANGE, "0.1,10,0.01"), "set_caret_blink_interval", "get_caret_blink_interval");
LineEdit: Respect `max_length` by truncating text to append When appending text (either via `set_text()` or by pasting from clipboard), if the input would make the `LineEdit` exceed its configured `max_length`, the input text is truncated to fit. The discard part is passed as a parameter in the `text_change_rejected` signal. Fixes #33321. Fixes #41278. Also cleaned up unimplemented `max_chars` property in `TextEdit`. Co-authored-by: Tony-Goat <70238376+Tony-Goat@users.noreply.github.com>
2021-07-06 12:49:27 +02:00
ADD_PROPERTY(PropertyInfo(Variant::INT, "caret_column", PROPERTY_HINT_RANGE, "0,1000,1,or_greater"), "set_caret_column", "get_caret_column");
Rename LineEdit caret_* properties getters and setters to match property
2021-03-28 20:31:25 +02:00
ADD_PROPERTY(PropertyInfo(Variant::BOOL, "caret_force_displayed"), "set_caret_force_displayed", "is_caret_force_displayed");
ADD_PROPERTY(PropertyInfo(Variant::BOOL, "caret_mid_grapheme"), "set_caret_mid_grapheme_enabled", "is_caret_mid_grapheme_enabled");
Refactor Font configuration and import UI, and Font resources.
2022-05-09 11:47:10 +02:00
Place LineEdit secret in its own section
2023-10-04 21:41:45 +02:00
ADD_GROUP("Secret", "");
ADD_PROPERTY(PropertyInfo(Variant::BOOL, "secret"), "set_secret", "is_secret");
ADD_PROPERTY(PropertyInfo(Variant::STRING, "secret_character"), "set_secret_character", "get_secret_character");
Refactor Font configuration and import UI, and Font resources.
2022-05-09 11:47:10 +02:00
ADD_GROUP("BiDi", "");
ADD_PROPERTY(PropertyInfo(Variant::INT, "text_direction", PROPERTY_HINT_ENUM, "Auto,Left-to-Right,Right-to-Left,Inherited"), "set_text_direction", "get_text_direction");
ADD_PROPERTY(PropertyInfo(Variant::STRING, "language", PROPERTY_HINT_LOCALE_ID, ""), "set_language", "get_language");
ADD_PROPERTY(PropertyInfo(Variant::INT, "structured_text_bidi_override", PROPERTY_HINT_ENUM, "Default,URI,File,Email,List,None,Custom"), "set_structured_text_bidi_override", "get_structured_text_bidi_override");
ADD_PROPERTY(PropertyInfo(Variant::ARRAY, "structured_text_bidi_override_options"), "set_structured_text_bidi_override_options", "get_structured_text_bidi_override_options");
Register theme properties with ThemeDB
2023-09-08 21:00:10 +02:00
BIND_THEME_ITEM(Theme::DATA_TYPE_STYLEBOX, LineEdit, normal);
BIND_THEME_ITEM(Theme::DATA_TYPE_STYLEBOX, LineEdit, read_only);
BIND_THEME_ITEM(Theme::DATA_TYPE_STYLEBOX, LineEdit, focus);
BIND_THEME_ITEM(Theme::DATA_TYPE_FONT, LineEdit, font);
BIND_THEME_ITEM(Theme::DATA_TYPE_FONT_SIZE, LineEdit, font_size);
BIND_THEME_ITEM(Theme::DATA_TYPE_COLOR, LineEdit, font_color);
BIND_THEME_ITEM(Theme::DATA_TYPE_COLOR, LineEdit, font_uneditable_color);
BIND_THEME_ITEM(Theme::DATA_TYPE_COLOR, LineEdit, font_selected_color);
BIND_THEME_ITEM_CUSTOM(Theme::DATA_TYPE_CONSTANT, LineEdit, font_outline_size, "outline_size");
BIND_THEME_ITEM(Theme::DATA_TYPE_COLOR, LineEdit, font_outline_color);
BIND_THEME_ITEM(Theme::DATA_TYPE_COLOR, LineEdit, font_placeholder_color);
BIND_THEME_ITEM(Theme::DATA_TYPE_CONSTANT, LineEdit, caret_width);
BIND_THEME_ITEM(Theme::DATA_TYPE_COLOR, LineEdit, caret_color);
BIND_THEME_ITEM(Theme::DATA_TYPE_CONSTANT, LineEdit, minimum_character_width);
BIND_THEME_ITEM(Theme::DATA_TYPE_COLOR, LineEdit, selection_color);
BIND_THEME_ITEM_CUSTOM(Theme::DATA_TYPE_ICON, LineEdit, clear_icon, "clear");
BIND_THEME_ITEM(Theme::DATA_TYPE_COLOR, LineEdit, clear_button_color);
BIND_THEME_ITEM(Theme::DATA_TYPE_COLOR, LineEdit, clear_button_color_pressed);
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
}
Add optional constructor arguments to more Control nodes This can be used to make editor code more compact. However, as of writing, these constructor arguments cannot be used from the scripting API. This was already provided for Label and CheckBox, but it was missing for other Control nodes where it made sense to provide a default value.
2022-03-04 09:18:44 +01:00
LineEdit::LineEdit(const String &p_placeholder) {
Create many types of popups on demand * LineEdit popups created on demand. * TextEdit popups created on demand. * SpinSlider popups created on demand. * ResourcePicker popups created on demand. Improves editor responsiveness.
2021-07-16 23:36:05 +02:00
text_rid = TS->create_shaped_text();
_create_undo_state();
deselect();
set_focus_mode(FOCUS_ALL);
set_default_cursor_shape(CURSOR_IBEAM);
set_mouse_filter(MOUSE_FILTER_STOP);
[Input] Add extra `shortcut_input` input processing step to process Unicode character input with Alt / Ctrl modifiers, after processing of shortcuts.
2022-01-11 14:59:52 +01:00
set_process_unhandled_key_input(true);
Create many types of popups on demand * LineEdit popups created on demand. * TextEdit popups created on demand. * SpinSlider popups created on demand. * ResourcePicker popups created on demand. Improves editor responsiveness.
2021-07-16 23:36:05 +02:00
set_caret_blink_enabled(false);
Add optional constructor arguments to more Control nodes This can be used to make editor code more compact. However, as of writing, these constructor arguments cannot be used from the scripting API. This was already provided for Label and CheckBox, but it was missing for other Control nodes where it made sense to provide a default value.
2022-03-04 09:18:44 +01:00
set_placeholder(p_placeholder);
Convert en_GB spelling to en_US with codespell
2023-01-21 12:25:29 +01:00
set_editable(true); // Initialize to opposite first, so we get past the early-out in set_editable.
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
}
LineEdit::~LineEdit() {
Unify TextServer built-in module and GDExtension code.
2022-02-13 13:41:29 +01:00
TS->free_rid(text_rid);
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
}
Reference in a new issue Copy permalink