asgardius/virtualx-engine
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
31694 commits 1 branch 0 tags 2.2 GiB
Commit graph

2759 commits

Author SHA1 Message Date
kobewi
b82d5688b9 Deselect column only if belongs to deselected item 
(cherry picked from commit 5cd5722f6a)
 2021-03-04 12:20:35 +01:00
Rémi Verschelde
9ee835ac93
Merge pull request #46409 from asheraryam/fix-scale-pivot-jitter 
Fix flicker in control nodes due to pivot offset
 2021-03-02 16:15:21 +01:00
Yuri Sizov
59dfd084ab Properly hide GraphEdit's minimap 2021-03-01 18:18:05 +03:00
Mateo Kuruk Miccino
74b3021691 LineEdit: Now double click to select a word, and triple click to select all the content 2021-02-28 17:41:11 -03:00
asheraryam
25f35b2c9f Fix jitter in control nodes when using pivot-offset and animating scale 
This is based on suggested fix from this comment
https://github.com/godotengine/godot/issues/36087#issuecomment-771593146 -- basically the old rounding workaround is removed, and rounding is now done locally in the scroll_container instead.

Fixes #28804

Co-authored-by: Georg Wacker <contact@georgwacker.com>
 2021-02-28 15:30:48 +03:00
Eric M
3b2c43312c Fixed issues with slider focus and scroll input 
(cherry picked from commit 707cf278a5)
 2021-02-26 15:27:42 +01:00
Rémi Verschelde
96d38d9751 Revert "Warn when setting Control size inside ready()" 
This reverts commit a8105d73c7.

We need to improve the logic somewhat to make the warning more specific to
actual problematic scenarios. Will likely be cherry-picked again + fixes
for the next release.

Fixes #46376.
 2021-02-25 15:14:32 +01:00
Jummit
0a9190134d expose edit_selected in Tree 
(cherry picked from commit 13fb24cb6f)
 2021-02-25 15:14:32 +01:00
kleonc
566ad4fd22 Label::set_lines_skipped Fail if passed a negative value 
(cherry picked from commit d7bb7cad47)
 2021-02-22 10:16:54 +01:00
Kongfa Waroros
af5fe70623 Keep Hue value when Saturation or Value is zero 
(cherry picked from commit 27749711b2)
 2021-02-22 10:15:29 +01:00
Tomasz Chabora
a8105d73c7 Warn when setting Control size inside ready() 
(cherry picked from commit 84da090a69)
 2021-02-22 10:15:00 +01:00
Kongfa Waroros
5ec1eee6b1 Avoid function signals in ColorPicker to access the tree when it isn't in the tree 2021-02-18 16:57:47 +07:00
kobewi
6440b7fcae
Select TreeItem if none is selected 
(cherry picked from commit 282639d653)
 2021-02-16 14:27:40 +01:00
kleonc
e40682c32d
RichTextLabel::add_image Fail if passed image has no area 
(cherry picked from commit a4afdd4a77)
 2021-02-16 14:27:39 +01:00
PouleyKetchoupp
ac9e5d9c60
Fix TextEdit autoscroll with wrapped lines 
Index to find the last line wrap index was off by one, which prevented the first wrapped line to trigger autoscroll.

(cherry picked from commit 121030940c)
 2021-02-16 14:27:38 +01:00
PouleyKetchoupp
018008ce81 TextEdit respects content margin from StyleBox 
Backport from PR #45858 on master.
 2021-02-15 10:47:38 -07:00
Kongfa Waroros
adb93d7120
Update GraphEdit when GraphNode's slot is updated 
(cherry picked from commit fe6c8d48e6)
 2021-02-11 13:14:33 +01:00
Filip
9c4f16f4c1 Fixed completion box not showing properly [3.2] 2021-02-10 20:40:00 +01:00
Rémi Verschelde
daa0fe101e
Merge pull request #45813 from RandomShaper/keep_selected_visible_3.2 
Keep selected node visible after filter change (3.2)
 2021-02-09 10:43:37 +01:00
kobewi
2863c6117e
Set selected Tree item to null when deselected 
Co-authored-by: Brody Eller <wviper3@gmail.com>
(cherry picked from commit ef8ec59f2f)
 2021-02-08 22:36:37 +01:00
Kanabenki
dad0d4a8ee
Update ColorPicker controls when entering tree 
(cherry picked from commit 03d4ebf129)
 2021-02-08 22:36:37 +01:00
Oliver Dick
db57f32194
TextEdit: When left mouse is pressed to place the cursor, do not immediately adjust the viewport when cursor_set_line is called, but afterwards on cursor_set_column (effectively when the cursor reached its final position) 
Fixes #45770

(cherry picked from commit 8d598693fc)
 2021-02-08 22:36:36 +01:00
Pedro J. Estébanez
e1054a17b5 Expose Tree::scroll_to_item() 2021-02-08 02:19:23 +01:00
Volka
c6824ec09d
Fix unintended SpinBox mouse capture 
(cherry picked from commit ae2cf8eb38)
 2021-02-02 13:02:42 +01:00
Rémi Verschelde
0b6dd929c6
Merge pull request #45169 from fmazan/3.2-completion-panel-positioning 
[3.2] Fixed completion and hint panel positioning in TextExit
 2021-02-01 20:50:38 +01:00
HaSa1002
4ff0df702d Expose bookmark, breakpoint, and mark safe functions in TextEdit 2021-01-27 22:41:07 +01:00
kobewi
a7a490e650 Fix popup_centered() for scaled popups 2021-01-27 18:12:09 +01:00
kobewi
7ede2f36fe
Allow to override drop data in LineEdit 
(cherry picked from commit a3a31591b5)
 2021-01-26 17:24:55 +01:00
Hugo Locurcio
76bd7d796b
Make Range return 1.0 ratio if minimum and maximum values are equal 
An error message is also no longer printed.
This matches the behavior found in most UI frameworks where having
equal minimum and maximum values is considered acceptable.

This closes #43179.

(cherry picked from commit 44204ec32d)
 2021-01-26 17:00:17 +01:00
Nils Reid
349f25429b
Exposed find_next_valid_focus and find_prev_valid_focus. 
(cherry picked from commit 3e94c23fa5)
 2021-01-26 17:00:16 +01:00
Rémi Verschelde
07be68e904
Merge pull request #45370 from naithar/fix/line_edit_clear 
[3.2] [GUI] Fix LineEdit clearing
 2021-01-26 12:30:58 +01:00
Sergey Minakov
7b8d6d2413 [GUI] Enforce virtual keyboard redisplay on clear 2021-01-26 13:18:14 +03:00
Yuri Sizov
a9552cefa2 Fix minimap capturing events and improve its theme 
Add an editor setting for minimap opacity in visual editors
 2021-01-25 21:49:34 +03:00
Alexander Pech
d73281a350
Keep RichTextLabel visible character properties in sync 
The RichTextLabel class is inconsistent in how it updates the
visible_characters and percent_visible properties when either is changed.

To keep both properties consistent, update percent_visible when setting the
visible_characters property.
For both properties, when setting one, notify change for the other.

Docs updated for member set_visible_characters on RichTextLabel class.

(cherry picked from commit 463e2002ab)
 2021-01-15 16:49:46 +01:00
Rémi Verschelde
258f41c024
Merge pull request #45150 from pycbouh/ge-disconnect-crash-3.2 
[3.2] Prevent signal disconnection attempts on invalid references
 2021-01-15 12:49:17 +01:00
Yuri Sizov
6b13c8482a Prevent signal disconnection attempts on invalid references 2021-01-14 15:21:12 +03:00
Filip
f1d00522f5 Fixed completion and hint panel positioning in TextExit [3.2] 2021-01-13 21:44:05 +01:00
Rémi Verschelde
b9c5e2f9eb
doc: Sync classref with current source 
And fix copyright headers in new code.
 2021-01-13 16:55:27 +01:00
Rafał Mikrut
8f19d50e27
Fix errors when removing non Control node from TabContainer 
(cherry picked from commit 56734f44e5)
 2021-01-13 16:17:10 +01:00
Rémi Verschelde
49646383f1
Update copyright statements to 2021 
Happy new year to the wonderful Godot community!

2020 has been a tough year for most of us personally, but a good year for
Godot development nonetheless with a huge amount of work done towards Godot
4.0 and great improvements backported to the long-lived 3.2 branch.

We've had close to 400 contributors to engine code this year, authoring near
7,000 commit! (And that's only for the `master` branch and for the engine code,
there's a lot more when counting docs, demos and other first-party repos.)

Here's to a great year 2021 for all Godot users 🎆

(cherry picked from commit b5334d14f7)
 2021-01-13 16:17:06 +01:00
Andrii Doroshenko (Xrayez)
acd9abe507 Add AspectRatioContainer class 
Backported from ba68383706.

Co-authored-by: Ugis Brekis <ugis.brekis@productmadness.com>
 2021-01-12 16:25:26 +02:00
Rémi Verschelde
5c80c94449
Revert "solved ctrl + alt + special character Issue #6851" 
(cherry picked from commit 8b7f582f22)
 2021-01-05 21:33:33 +01:00
Yuri Roubinsky
adfc646f8c
Added optional id parameter to PopupMenu::add_separator 
(cherry picked from commit ca8c794d04)
 2020-12-30 09:57:01 +01:00
Yuri Sizov
816fef21f9 Add a minimap to the GraphEdit 2020-12-18 01:31:17 +03:00
Sergey Minakov
f1fd0440f3 GUI: use cursor in TextEdit for non selected text. 2020-12-16 05:33:10 +03:00
Sergey Minakov
4c3b84b3d7 GUI: send cursor data from TextEdit 2020-12-16 05:05:38 +03:00
Michael Alexsander
4fe554933c
Allow to circle back in 'PopupMenu' even if the first/last item is non-selectable 
(cherry picked from commit bb39088201)
 2020-12-10 14:02:06 +01:00
volzhs
c904cf612a
Add option to draw all tabs in front 
(cherry picked from commit 814f9015f8)
 2020-12-10 13:07:49 +01:00
Michael Alexsander
32da9dc1e9
Add "font_color_separator" theme property to 'PopupMenu' 
(cherry picked from commit 383e8919e0)
 2020-12-10 13:06:15 +01:00
volzhs
1663a9e87c
Update page value properly of ScrollContainer 
(cherry picked from commit d89677442b)
 2020-12-09 11:22:04 +01:00
Rémi Verschelde
f7061fd559
Buttons: Don't use deprecated set_enabled_focus_mode 
It's better to use the equivalent, non-deprecated API.
Follow-up to #43974.
 2020-11-30 11:16:15 +01:00
Rémi Verschelde
4f30cdfc33
Merge pull request #43972 from volzhs/fix-tab-container-3 
Fix TabContainer crashes
 2020-11-30 09:41:39 +01:00
FIF15
f07fb4e595 fix #43695 by revert part of #41577 
Restore the default focus mode for MenuButton and LinkButton,
since it is different from the default of BaseButton.
 2020-11-30 10:47:26 +08:00
volzhs
efade4034b Fix no padding between icon and text in TabContainer 2020-11-30 11:36:57 +09:00
volzhs
8e10e33762 Fix TabContainer crashes 2020-11-30 11:02:18 +09:00
Tomasz Chabora
0c50509326
Update clear button when clicked 
(cherry picked from commit 836b78f329)
 2020-11-26 09:38:47 +01:00
volzhs
8aeeec034d
Fix to update scroll bar has correct max value in ScrollContainer 
(cherry picked from commit 67c2f2445f)
 2020-11-26 09:38:47 +01:00
Rémi Verschelde
94c31175de
Merge pull request #43152 from Chaosus/color_autocompletion_3.2 
[3.2] Shows ColorRect in Color constants autocompletion
 2020-11-26 09:32:32 +01:00
PouleyKetchoupp
9b64646bc3
Expose LineEdit scroll offset to scripts 
(cherry picked from commit 4775db1600)
 2020-11-11 15:44:18 +01:00
Rémi Verschelde
05143ca39a
Tooltips: Improve code clarity and docs 
The return type for `_make_custom_tooltip` is clarified as Control, and users
should make sure to return a visible node for proper size calculations.

Moreover in the current master branch, a PopupPanel will be added as parent
to the provided tooltip to make it a sub-window.

Clarifies documentation for `Control._make_custom_tooltip`, and shows how to
use the (until now undocumented) "TooltipPanel" and "TooltipLabel" theme types
to style tooltips.

Fixes #39677.

(cherry picked from commit c5d8dafec4)
 2020-11-11 15:30:56 +01:00
volzhs
f4d181179c
Put unselected tabs back in TabContainer control 
(cherry picked from commits 9eaa5ffab5
and 8a588343db)
 2020-11-11 15:30:54 +01:00
Andrii Doroshenko (Xrayez)
921046c822
Add border_width to ReferenceRect 
Exposes a hidden parameter behind `CanvasItem.draw_rect()`.

(cherry picked from commit aef00021a9)
 2020-10-28 14:05:40 +01:00
Gabriel Van Eyck
7735cdaf8f
Fix emit_signal timing for GraphEdit's begin/end node move 
(cherry picked from commit fbc095dc78)
 2020-10-28 14:05:40 +01:00
Dominik 'dreamsComeTrue' Jasiński
ba00ced445
TextEdit - fix valid bounds in 'set_line'. Fixes #41967 
(cherry picked from commit 99c8a07919)
 2020-10-28 14:05:39 +01:00
Yuri Roubinsky
374253242d [3.2] Shows ColorRect in Color constants autocompletion 2020-10-28 12:39:41 +03:00
Rémi Verschelde
150f9ce807
Merge pull request #42009 from Calinou/theme-node-type-3.2 
Rename the `type` parameter to `node_type` in Theme and Control (3.2)
 2020-10-20 15:58:41 +02:00
volzhs
78143ee93e
Respect Tree.set_icon_max_width size for drawing selection box 
(cherry picked from commit cac4fedb2a)
 2020-10-19 16:10:00 +02:00
Dashcell
c43e8d8fbd
Dropping file on parrent dirrectory fixed 
(cherry picked from commit 1ac936f035)
 2020-10-19 15:14:13 +02:00
Rémi Verschelde
3495cb91d8
Merge pull request #41577 from FIF15/deprecate-redundant-property-enabled-focus-mode 
Deprecate Redundant property enabled_focus_mode
 2020-10-19 14:15:43 +02:00
FIF15
8311a37ed9 Deprecate Redundant property enabled_focus_mode 
of BaseButton
see #41529 for details
this closes #41529
 2020-10-16 14:14:04 +08:00
Rémi Verschelde
e40b4eeeea
Merge pull request #37226 from arrowinaknee/fix-node-config-warnings 
[3.2] Update get_configuration_warning() overrides to retrieve warnings from parent class
 2020-10-01 14:04:26 +02:00
Danil Alexeev
44bdd8f16c
Improvement for the Copy button in the Output Log 
Now if no text is selected, pressing the Copy button copies the entire text.

(cherry picked from commit fb6eb21afc)
 2020-09-29 08:54:45 +02:00
Michael Alexsander
2d848227cf
Add 'get_previous_tab()' to 'Tabs' 
(cherry picked from commit 2b319889cb)
 2020-09-24 14:43:10 +02:00
HellonLegs
9340385731
LineEdit/TextEdit: solved control + alt issue 
(cherry picked from commit f412237f38)
 2020-09-24 14:43:08 +02:00
mvl
be13df0a08
Fix bug where leading and trailing spaces werent taken into account with center and right allignment. 
(cherry picked from commit 4318ad94ac)
 2020-09-24 14:43:05 +02:00
Eric M
e24b9f0520
Fixed bug where spinbox would not update to it's actual value after non-numeric input 
(cherry picked from commit e76e39d5f5)
 2020-09-24 12:08:10 +02:00
Rémi Verschelde
c8859f0463
Fix typos with codespell 
Using codespell 1.17.1.

Method:
```
$ cat > ../godot-word-whitelist.txt << EOF
ang
curvelinear
dof
doubleclick
fave
findn
leapyear
lod
merchantibility
nd
numer
ois
ony
que
seeked
synching
te
uint
unselect
webp
EOF

$ codespell -w -q 3 -I ../godot-word-whitelist.txt --skip="./thirdparty,*.po"
$ git diff // undo unwanted changes
```
 2020-09-18 14:09:51 +02:00
Hugo Locurcio
e36587751f
Rename the type parameter to node_type in Theme and Control 
This makes it clearer that it expects a node type as a string (such as "Label")
instead of a type like "TYPE_ARRAY". This is backwards-compatible since only
the name of the parameter is changed, not its order.

See https://github.com/godotengine/godot-proposals/issues/1495#issuecomment-691507839
 2020-09-12 18:42:45 +02:00
Wilson E. Alvarez
2b7c9d9070
Disconnect item_rect_changed when removing a child of GraphEdit 2020-09-11 17:36:55 -04:00
PouleyKetchoupp
819765130d
Fix RichTextLabel alignment for clickable regions 
Fixes #41006 (regression from #39164).

The original alignment fix was limited to PROCESS_DRAW mode, which
caused some discrepancies with PROCESS_POINTER mode.
Now only PROCESS_CACHE is excluded with a condition a few lines above.

(cherry picked from commit b783fa1416)
 2020-09-11 11:15:40 +02:00
Marcel Admiraal
f26131fca5
Check if old mouse column is still available. 
(cherry picked from commit 79802b31a9)
 2020-09-08 13:39:32 +02:00
PouleyKetchoupp
c21d14fe69
Fix LineEdit not consuming enter events 
LineEdit should not return early when processing KEY_ENTER, so it can
consume the event properly.

Regression introduced by mistake while fixing enter events for Android
(PR #40487 - c0b394572f)

(cherry picked from commit 5c63dec36e)
 2020-09-08 13:38:58 +02:00
Rémi Verschelde
8a66ea7cb0
Revert "Updated LineEdit to address #41278" 
This reverts commit 1b6d116dfb.
 2020-09-01 14:01:50 +02:00
Tony-Goat
1b6d116dfb
Updated LineEdit to address #41278 
Updated set_max_length() function to actually pull a substring of the current text so it's not all thrown away when the new max length is shorter than the current length.

(cherry picked from commit 71febfd6e2)
 2020-08-31 15:53:56 +02:00
Rémi Verschelde
a6ef6b10b2 Revert "Fixes the get_visible_line_count() of rich text label" 
This reverts commit dc7e9d46e6.
 2020-08-17 11:21:36 +02:00
Cheeseness
e70b165c61 Skip indentation of empty lines when indenting a selection. 
(cherry picked from commit 1f159306ed)
 2020-08-17 11:04:36 +02:00
Umang Kalra
330afdd6cb Fix RichTextLabel center alignment bug 
Fixes #40207.

(cherry picked from commit cec21ab82c)
 2020-08-14 00:32:05 +02:00
Martin Capitanio
71bad8dba6 Add option to disable virtual keyboard for TextEdit 
Adding support for disabling virtual keyboard on mobile platforms, in
order to make it consistent with LineEdit.

It allows implementing a custom virtual keyboard.

See: https://github.com/godotengine/godot/pull/41139
 2020-08-09 18:22:11 +02:00
Daniel Ting
6f71bc2a06 Evenly distribute stretched Nodes in BoxContainer 
Add any leftover fractional pixels to an error accumulator. When the
accumulator is greater or equal to one, add one pixel to the current
Node's size and subtract one from the accumulator.

Closes #36522

(cherry picked from commit 04ea6ec88d)
 2020-07-28 00:39:21 +02:00
Rémi Verschelde
a2edf04fd2
Merge pull request #40469 from nekomatata/virtual-keyboard-enter-fixes-3.2 
[3.2] Fix Return key events in LineEdit & TextEdit on Android
 2020-07-26 20:26:02 +02:00
PouleyKetchoupp
930c880fa6 Add option to disable virtual keyboard for LineEdit 
Co-authored-by: Alexander Holland <alexander.holland@live.de>
(cherry picked from commit 0aa56e3ab8)
 2020-07-24 10:31:57 +02:00
Tomasz Chabora
e511e0f16a Prevent infinite loop in Tree incremental search 
(cherry picked from commit c0479496fa)
 2020-07-24 10:31:57 +02:00
Umang Kalra
dc7e9d46e6 Fixes the get_visible_line_count() of rich text label 
(cherry picked from commit bd32c273ff)
 2020-07-24 10:31:56 +02:00
PouleyKetchoupp
c0b394572f Fix Return key events in LineEdit & TextEdit on Android 
Depending on the device implementation, editor actions could be
received with different action ids or not at all for multi-line.

Added a parameter to virtual keyboards to properly handle single-line
and multi-line cases in all situations.

Single-line:
Input type set to text without multiline to make sure actions are sent.
IME options are set to DONE action to force action id consistency.

Multi-line:
Input type set to text and multiline to make sure enter triggers new lines.
Actions are disabled by the multiline flag, so '\n' characters are
handled in text changed callbacks.
 2020-07-17 18:25:40 +02:00
Maganty Rushyendra
e76a9a51df Emit signals for GraphEdit multi-node selection and unselection 
Emit `node_selected` and `node_deselected` signals where appropriate
when selecting or unselecting multiple GraphEdit nodes at once.

(cherry picked from commit c1d5c7727c)
 2020-07-13 15:12:50 +02:00
ArrowInAKnee
e48430b1d4 Make all get_configuration_warning() overrides retrieve warnings from parent 2020-07-13 01:50:02 +03:00
lrgilbert
c0db0749f7 Fixed separation of ports on GraphNode 
Fixes #32474.

(cherry picked from commit 47c929c972)
 2020-07-03 15:34:30 +02:00
PouleyKetchoupp
d6b23306c8 Fix RichTextLabel fill alignment regression 
Fixes #40068 (regression from #39164) by not applying the line offset
change in the case of fill alignment mode.

(cherry picked from commit 44f88999c7)
 2020-07-03 15:34:30 +02:00
Michael Alexsander
32c154d297 Fix Tree's 'scroll_to_item()' not working correctly on some cases 
(cherry picked from commit 144a4cc39f)
 2020-07-03 13:17:57 +02:00
Mark Kuo
46590fa3b0 VideoPlayer: fix possible race condition 
In set_stream() we write to 'playback' while accessing the same object
in _mix_audio() in audio thread. Protect the 'write' part in
set_stream() to avoid possible crash in _mix_audio() function.

(cherry picked from commit e435d57758)
 2020-07-03 13:17:57 +02:00
Haoyu Qiu
38509f1a89 Prevent dragging from SceneTree buttons 
(cherry picked from commit 45d0799b5b)
 2020-07-03 13:17:57 +02:00
Stijn Hinlopen
65155c2855 No longer scroll vertically when scrollbars are unavailable 
(cherry picked from commit 5f7499beac)
 2020-06-29 10:47:43 +02:00
Pedro J. Estébanez
0f0360702b Handle gone TabContainer popup nicely 2020-06-24 19:31:26 +02:00
PouleyKetchoupp
b3af0b2a39 Option in RichTextLabel for height to fit content 
(cherry picked from commit ad8081216c)
 2020-06-19 16:17:27 +02:00
Andy Maloney
5bbb15418f [3.2][macOS] Command-backspace in line edit 
Make command-backspace in line edit work like other macOS applications.

If there is a selection, command-backspace deletes the selection.

If there isn't a selection, command-backspace deletes from the cursor to the beginning of the line edit.

This addresses part of godotengine/godot#23548
 2020-06-18 17:42:51 -04:00
Umang Kalra
1d0c39e395 Fixes the stopping of animation effects in bbcode after appending 
(cherry picked from commit 88b30a29bf)
 2020-06-15 14:34:35 +02:00
Lisandro Lorea
cb119e349a Fix TabContainer emitting spurious tab_selected signals when a theme is changed 
- The repaint code was moved outside of set_current_tab() and to a "_repaint()" private function
- _on_theme_changed() will now only call _repaint() and update()
This means _on_theme_changed() will do only what it needs (repainting the TabContainer to account for the new theme)

fixes #39498

(cherry picked from commit 5123006f06)
 2020-06-15 14:34:35 +02:00
Tomasz Chabora
2f04896b0e Re-enable scroll follow on RichTextLabel clear 
(cherry picked from commit 46fd51056a)
 2020-06-15 14:34:35 +02:00
Thibault Truffert
24b3bf0637 Make text deletion methods public for LineEdit 
(cherry picked from commit 2bb44ea5bd)
 2020-06-11 09:42:23 +02:00
Rémi Verschelde
7bf9787921 SCons: Format buildsystem files with psf/black 
Configured for a max line length of 120 characters.

psf/black is very opinionated and purposely doesn't leave much room for
configuration. The output is mostly OK so that should be fine for us,
but some things worth noting:

- Manually wrapped strings will be reflowed, so by using a line length
  of 120 for the sake of preserving readability for our long command
  calls, it also means that some manually wrapped strings are back on
  the same line and should be manually merged again.

- Code generators using string concatenation extensively look awful,
  since black puts each operand on a single line. We need to refactor
  these generators to use more pythonic string formatting, for which
  many options are available (`%`, `format` or f-strings).

- CI checks and a pre-commit hook will be added to ensure that future
  buildsystem changes are well-formatted.

(cherry picked from commit cd4e46ee65)
 2020-06-10 15:30:52 +02:00
Michael Alexsander
2652a2d184 Add generic file icon and its modulation to the 'FileDialog' 
(cherry picked from commit 637927f803)
 2020-06-10 15:30:52 +02:00
Giuliano Barberi
221051d523 Tree: Calling update in _gui_input less frequently 
(cherry picked from commit d443a13244)
 2020-06-10 15:30:51 +02:00
Umang Kalra
c1f6854ada Fixes the right and center alignment bug of rich text label 
(cherry picked from commit b2a32d007d)
 2020-06-04 12:09:40 +02:00
Dominik 'dreamsComeTrue' Jasiński
d15e9c2126 Allow scroll_to_line when scroll_active is 'false' 
Fix #36134

(cherry picked from commit 8f11a91917)
 2020-06-04 12:09:39 +02:00
Thakee Nathees
25ed0d4366 colorpicker margin bug fixed 
(cherry picked from commit 9d224ac429)
 2020-06-04 11:14:16 +02:00
SkyJJ
2197ef0566 Fix Android LineEdit editing bugs 
(cherry picked from commit cc473b948f)
 2020-05-20 12:07:08 +02:00
Marcus Brummer
4779d289d5 Fixed text editor drawing if smooth scrolling is disabled. 
Fixes #38778

(cherry picked from commit b048eb05ad)
 2020-05-18 16:40:33 +02:00
smartin015
8cab02ec06 Remove get_local_mouse_position() hack in GraphEdit 
(cherry picked from commit 00457c68bc)
 2020-05-18 16:40:33 +02:00
etienne.frank
46327d48a2 Fix minimap selection offset 
The minimap selection was shifted of 1 line too late.

(cherry picked from commit 72ab355945)
 2020-05-13 16:10:12 +02:00
Eduardo Nunes Pereira
55ab98233a Using the common behaviour when use command+shift on text line for osx 
* On press left+command+shift or right+command+shift it should behave like shift+home or shift+end and select the text
* Using home and end events as reference

(cherry picked from commit d8f8a3c606)
 2020-05-11 11:13:22 +02:00
janglee
d16abbdee4 Improved go-to definition (Ctrl + Click) 
Co-Authored-By: Bojidar Marinov <bojidar.marinov.bg@gmail.com>
(cherry picked from commit be7a353c70)
 2020-05-11 09:33:21 +05:30
Thakee Nathees
1a39b4ea22 method bind TextEdit::set_line() added 
(cherry picked from commit b9acf1cedf)
 2020-05-07 13:43:43 +02:00
nobuyuki_nyuu
12386a2d80 PopupMenu.get_current_index() bound to ClassDB 
(cherry picked from commit 35f30086de)
 2020-05-07 13:36:53 +02:00
Stanislav Labzyuk
e3712cf689 Bind set_suffix/get_suffix in Tree 
(cherry picked from commit ac8814624d)
 2020-05-06 23:31:02 +02:00
Eric M
b7fbdf4bed Updated editor spin slider to have better behaviour and adjusted control's size_flags_stretch_ratio value range 
(cherry picked from commit 915ab50673)
 2020-05-06 23:30:28 +02:00
Darenn
3c26de316e Fixed bbcode parsing for built-in RichTextEffects in RichTextLabel 
RichTextEffect can now have a bbcode string starting like one of the built-in.
It was impossible before as the built-in would take precedence over the custom effect that has the same bbcode start.

Example : [fade] would take precedence over [fade_in]
(cherry picked from commit b4e3042cba)
 2020-05-01 10:57:00 +02:00
John Wigg
ee8b3bef2d Limit undo stack size 
The stack size of the undo history of a TextEdit was not limited leading
to potential memory leaks when doing lots of operations on a TextEdit.

This commit adds the option gui/common/text_edit_undo_stack_max_size
to the project settings. The first element of the undo stack is popped
if the stack's size exceeds this value ensuring limited memory usage.

The default stack size setting is 1024.

Fixes #37838.

(cherry picked from commit 4a82390aaf)
 2020-05-01 10:56:58 +02:00
Pedro J. Estébanez
07c4dc1b30 Avoid invocation to Object's copy constructor 
Needed for the next commit. That's the only place in all the Godot code base
where that's attempted and it's not needed because Objects are not meant to
be copied that way.
 2020-04-23 12:44:47 +02:00
asheraryam
93f7e8d8fc Add "node_unselected" signal for GraphEdit 2020-04-16 16:56:58 +03:00
Michael Alexsander
b4429c325a Fix incorrect TabContainer documentation for 'get_tab_control()' 
(cherry picked from commit 8f925b1970)
 2020-04-16 12:57:22 +02:00
Dominik 'dreamsComeTrue' Jasiński
5fdecebee1 Calculate strike-through position correctly 
Fixes: #37637
(cherry picked from commit 06a79f260c)
 2020-04-16 12:57:22 +02:00
theludovyc
58fcbc2b06 Remove unused ofs variable 
(cherry picked from commit 875c994109)
 2020-04-16 12:47:18 +02:00
Guilherme Felipe
ddde3819d6 Fix TextureRect::flip_* when used with atlas texture 
Fix #37526

(cherry picked from commit fb2d2dd5d0)
 2020-04-16 12:47:18 +02:00
PouleyKetchoupp
18c5ef5473 Add style for highlighted Slider grab area 
(cherry picked from commit 4c8173af0f)
 2020-04-16 12:47:17 +02:00
Leleat
8da00fbfc7 fixed PopupMenus letterjumping on any InputEvent 
(cherry picked from commit 8a5660f3d1)
 2020-04-16 11:58:14 +02:00
Zak Grumbles
5d9108c9c6 Fix OptionButton docs godotengine#36803 
* item_selected and item_focused docs incorrectly had 'id' as the parameter. Changed to
'index'.
* Fix parameter name in ADD_SIGNAL callin code.

(cherry picked from commit a8de034f78)
 2020-04-16 11:45:19 +02:00
Thakee Nathees
324213a6db fix project manager don't consume Enter key #17620 
(cherry picked from commit b98153886f)
 2020-04-16 11:44:44 +02:00
janglee
e1ca49b4b6 Corrected text selection in color picker 
Fixes #35603

(cherry picked from commit 77b70aa79d)
 2020-04-16 11:43:35 +02:00
qarmin
57952d562c Fixes leak with drives [3.2] 2020-04-12 14:05:47 +02:00
Eoin O'Neill
c18381119e Correction to RichTextLabel Tabulation 
Correct backtrack assignment to prevent excessive tabulation. Worth
noting that tabulation is treated differently in RichTextLabel because
of custom user-asignable tab variable which creates problems with
dynamic fonts specifically.

(cherry picked from commit 2000e110a9)
 2020-04-06 18:19:14 +02:00
Gil Arasa Verge
f144ec9e67 Clicking backgrd. dimming of editor popup stops input event propagation 
A click on the dimmed background of a popup in the editor should stop the input event from propagating to the background.

This solution reuses the system introduced in commit efc3ffb8, taking advantage of the hide() notifications from the modal where we will set the flag "pass_on_modal_close_click(false)" to stop event handling at the viewport input event handling.
The viewport first hides the modal and after marks the input as handled if the flag mentioned above is set.

Fixes #36341

(cherry picked from commit 35bc88ca34)
 2020-03-25 11:38:54 +01:00
nathanwfranke
b95a2306db Fix tab container too large when tabs are hidden 
(cherry picked from commit c0a84f747e)
 2020-03-25 11:38:54 +01:00
Rémi Verschelde
86ecefa1a2 Fix potential divisions by 0 reported by MSVC 
The `TextEdit` one was indeed a potential bug.
The `PCKPacker` one seems to be a false positive, it's already in a
`for` loop that depends on `files.size()`.

(cherry picked from commit ca4e4506db)
 2020-03-25 11:38:54 +01:00
Tomasz Chabora
c8318012a8 Make search in RichTextLabel case-insensitive 
(cherry picked from commit b3f83ac115)
 2020-03-25 11:38:53 +01:00
simpuid
223d0abd7e Remove update condition from LineEdit::update_placeholder_width 
Placeholder with length greater than `max_length` are allowed, so there is no reason for those update condition.
It fixes the odd alignment of placeholder when it's length is greater than `max_length`

(cherry picked from commit 43b2f75d64)
 2020-03-25 11:38:53 +01:00
Darren Kaste
53c8d8a5fb Use LineEdit secret character width everywhere 
(cherry picked from commit c7c47410aa)
 2020-03-25 11:38:53 +01:00
Darren Kaste
f657614760 Calculate LineEdit selection with secret character 
(cherry picked from commit 395a038c85)
 2020-03-25 11:38:53 +01:00
Dominik 'dreamsComeTrue' Jasiński
e590a33d45 Allow single quotes in comments 
Fixes: #36638
(cherry picked from commit ab6456d1bc)
 2020-03-25 09:45:08 +01:00
Rémi Verschelde
c01e840f03
Merge pull request #36639 from RandomShaper/imvu/improve_drives_ux_3.2 
Improve UX of drive letters (3.2)
 2020-03-17 16:27:33 +01:00
Pedro J. Estébanez
6105dfdac9 Improve UX of drive letters 
Namely, move the drive dropdown to just the left of the path text box and don't include the former
in the latter.

This improves the UX on Windows.

In the UNIX case, since its concept of drives is (ab)used to provide shortcuts to useful paths, its
dropdown is kept at the original location.
 2020-03-17 14:48:54 +01:00
Dominik 'dreamsComeTrue' Jasiński
f328ac36d6 Fix: auto brace complete for quoted strings 
Fixes #36002

(cherry picked from commit 6a404a88e4)
 2020-03-04 09:53:44 +01:00
Rémi Verschelde
2bae35353d Revert "Fix control node transform animation jitter with pivot offset" 
This reverts commit 15315f118c.

It caused a regression: #36087.
 2020-03-04 09:50:21 +01:00
Dominik 'dreamsComeTrue' Jasiński
eb22bcead7 RichTextLabel: proper handling of internal key events 
Fixes #36211

(cherry picked from commit ff030afc93)
 2020-02-19 10:09:28 +01:00
Michael Alexsander
18eba898f8 Fix hiding ColorPicker's presets not fully hiding its controls 
(cherry picked from commit 5f5ccfc361)
 2020-02-18 14:20:04 +01:00
Haoyu Qiu
be34e45233 Uses split cursor for SplitContainer 
(cherry picked from commit 206b9f2d23)
 2020-02-14 16:02:56 +01:00
Haoyu Qiu
0a3bf2b627 Fixes add group in Group Editor dialog 
Before this fix, new group can't be created if any existing group starts
with the new name.

(cherry picked from commit 421ea09195)
 2020-02-14 15:58:36 +01:00
Eoin O'Neill
0dedc0a1a3 Fix RichTextEffect visibility to Account for Skipped Characters. 
A picture is easier to describe this issue than words. Basically, rich
text effects allowed for character visibility changes. While doing so
would work properly, the rich text label would render the next `word` in
an offset accounting for the hidden characters (leaving a huge space.)

This patch fixes this issue by keeping track of the amount of
`backtrack` necessary per line.

(cherry picked from commit b3fd4884d7)
 2020-02-14 15:57:47 +01:00
sumit0190
58a940e5aa Update cached_width of the line_edit element when setting it to be secret 
(cherry picked from commit 2e08578985)
 2020-02-14 15:56:48 +01:00
Georg Wacker
15315f118c Fix control node transform animation jitter with pivot offset 
The workaround for moving the pivot is not needed anymore, in fact it causes all transforms applied to control nodes to jitter while animating (if a pivot offset is set).

This can be observed via AnimationPlayer and Tween.

The fix is to remove the obsolete workaround that causes this bug.

Fixes #28804

(cherry picked from commit dfb7d46a2a)
 2020-02-06 13:02:07 +01:00
Haoyu Qiu
808a0bac33 Fixes OptionButton min size 
(cherry picked from commit ddc397d9ff)
 2020-02-06 13:02:07 +01:00
Rémi Verschelde
11d28b2d10 Revert "make Label consider spaces for visible_characters" 
This reverts commit 695980a0f2.

Fixes #35668.
 2020-01-28 19:37:04 +01:00
Haoyu Qiu
71b1a1c7d9 Updates minimum size on VideoPlayer::set_stream 2020-01-26 10:24:56 +08:00
Rémi Verschelde
c2e07db071
Merge pull request #35438 from MadEqua/virtual-keyboard-line-edit 
Android virtual keyboard respecting LineEdit max length.
 2020-01-23 08:20:24 +01:00
Bruno Lourenço
a3bcdbeb78 Android virtual keyboard respecting LineEdit max length. 2020-01-23 01:52:49 +00:00
Ricardo Buring
40542b0b0f Fix Control::_window_find_focus_neighbor 
Due to a typo, the size of a candidate neighbor was confused with the
size of the control itself.

Fixes #34936.
 2020-01-19 23:38:50 +01:00
Rémi Verschelde
dd3779c12e
Merge pull request #35183 from YeldhamDev/scrollbar_regression 
Fix scrollbar regression on large scales
 2020-01-16 07:56:05 +01:00
Michael Alexsander
76e03f9b4d Fix scrollbar regression on large scales 2020-01-16 00:59:46 -03:00
Haoyu Qiu
574918f344 Updates ScrollContainer min size when toggle scrollbars 2020-01-16 09:42:31 +08:00
Haoyu Qiu
26e3b4a58a Updates LineEdit's min size when necessary 
These properties will affect the minimum size of LineEdit:

* The right icon (`set_right_icon`)
* The clear button (`set_editable` and `set_clear_button_enabled`)
* The text, when "expand to text length" is enabled (`set_text`)
 2020-01-15 10:15:32 +08:00
Michael Alexsander
db8c4c2a22 Fix regression on scrollbar raising in ScrollContainer 2020-01-14 19:55:12 -03:00
Michael Alexsander
34bf81fa7c Cleanup unnecessary code from before the scrollbar overlapping fixes 2020-01-14 18:19:12 -03:00
Rémi Verschelde
57986208f3
Merge pull request #35130 from qarmin/crash_item_bad_index 
Don't allow to use too big index in ItemList
 2020-01-14 21:03:25 +01:00
Rafał Mikrut
724f5f3178 Don't allow to use too big index in ItemList 2020-01-14 20:17:48 +01:00
Rémi Verschelde
63112b5090
Merge pull request #35106 from YeldhamDev/scrollbar_overlap_fixes 
Fix more instances of overlapping scrollbars
 2020-01-14 08:12:20 +01:00
Michael Alexsander
712cd8a97e Fix more instances of overlapping scrollbars 2020-01-13 22:49:17 -03:00
Haoyu Qiu
66a54582ee Updates min size on CenterContainer::set_use_top_left 2020-01-14 08:35:21 +08:00
Rémi Verschelde
04a1ae90df
Merge pull request #35080 from malbach/scrollbars_overlap 
Fix #33309 Overlapping Scrollbars in ScrollContainer
 2020-01-13 16:10:12 +01:00
malbach
bc8ce836e3 Fix overlapping scrollbars in ScrollContainer (#33309) 2020-01-13 14:37:55 +01:00
Rémi Verschelde
100f50b7df Control/Light2D: Preventing setting 0 as scale as for Node2D 
Triggers errors in `Transform2D::affine_invert()`.

Fixes #26510.
Fixes https://github.com/godotengine/godot/issues/24997#issuecomment-457951639.
 2020-01-13 12:20:15 +01:00
Rémi Verschelde
478ab8b45b
Merge pull request #34960 from johannesgunnar/spin_box-apply-method 
Spinbox apply input method
 2020-01-12 14:16:14 +01:00
Paulb23
22c15083af Fix empty LineEdit crash on ctrl+backspace 2020-01-11 17:57:36 +00:00
Jóhannes Gunnar Þorsteinsson
083637a901 Add apply method to SpinBox 2020-01-11 10:47:51 +00:00
Tomasz Chabora
60cd3df337 Add signal for LineEdit overflow event 2020-01-10 21:07:00 +01:00
Rémi Verschelde
59a2fed1e6
Merge pull request #34938 from OverloadedOrama/fix-basebutton-button-press 
Fixes BaseButton not triggering the pressed signal on "Button Press"…
 2020-01-10 10:35:11 +01:00
Haoyu Qiu
fbd937bd30 Update minimum size on Label::set_autowrap 
If `clip_text` is true, the minimum height is one line if `autowrap` is
true , or one pixel otherwise.
 2020-01-10 17:08:27 +08:00
Gilles Roudière
b5251eb00f Don't compile editor-only function when tools=no 2020-01-09 22:15:48 +01:00
OverloadedOrama
bf4a0242ff Fixes BaseButton not triggering the "pressed" signal on "Button Press" Action Mode 
This should fix #34935
 2020-01-09 02:17:53 +02:00
Haoyu Qiu
4293f76cf1 Emits meta_hover_ended when mouse exit RichTextLabel 2020-01-08 21:01:08 +08:00
Rémi Verschelde
1de54bb388
Merge pull request #34874 from wingedadventurer/bugfix-label-visible-characters 
Make Label node consider spaces for visible_characters property
 2020-01-08 08:18:59 +01:00
Rémi Verschelde
033fb72c03
Merge pull request #34871 from lentsius-bark/textEdit-vertical-horizontal-scroll-expose 
expose scroll_vertical and scroll_horizontal in TextEdit
 2020-01-08 08:18:12 +01:00
Rémi Verschelde
90c487ebf3
Merge pull request #34900 from timothyqiu/rtl-cell-wrap 
Fixes RichTextLabel click issue when cell text wraps
 2020-01-08 07:08:02 +01:00
Michael Alexsander
8b5992f665 Make possible to edit the GraphEdit's selection rect colors 2020-01-07 23:20:48 -03:00
Haoyu Qiu
d17a4efc43 Fixes RichTextLabel click issue when cell text wraps 2020-01-08 09:08:03 +08:00
Kanabenki
d79f0e7d40 Check if cursor is inside meta when getting cursor shape 2020-01-07 15:46:11 +01:00
Krystof Klestil
c475f11018 expose scroll_vertical and scroll_horizontal in TextEdit + documentation 2020-01-07 15:16:07 +01:00
wingedadventurer
695980a0f2 make Label consider spaces for visible_characters 2020-01-06 23:29:00 +01:00
volzhs
e5a0018621 Calculate label size more accurately 2020-01-07 04:21:02 +09:00
volzhs
3f0c7b89ec Fix calculating label size 2020-01-06 01:06:26 +09:00
Haoyu Qiu
78e9ca58af Makes more strings translatable 2020-01-04 13:46:38 +08:00
Rémi Verschelde
6f279ed6eb
Merge pull request #34781 from fossegutten/button-flash 
Fixes button flashing when releasing mousebutton outside
 2020-01-03 16:23:57 +01:00