Rémi Verschelde
4be5660223
Merge pull request #67145 from Paulb23/tab_textedit
...
Fix inserting tabs in TextEdit
2022-10-10 13:52:42 +02:00
Rémi Verschelde
104af08e9d
Merge pull request #65805 from MewPurPur/improve-breakpoint-hovering
...
Improve bookmark and breakpoint indicators
2022-10-10 10:03:26 +02:00
VolTer
d6e60f45a1
Improved breakpoints hover indicator
2022-10-10 04:36:45 +02:00
Haoyu Qiu
eac9adf7a1
Don't allow removing TextEdit's main caret
2022-10-10 08:30:23 +08:00
Paulb23
7333aa68f4
Handle tab in TextEdit
2022-10-09 17:46:40 +01:00
Jummit
a6c1cfae99
Allow drag-clicking before symbol lookup
...
This makes it easier for touch and tablet users to do symbol lookups in
the code editor.
2022-10-09 18:42:54 +02:00
Rémi Verschelde
6f6482e82b
Merge pull request #67083 from RedMser/label-font-warning
...
Add warning for missing characters in label font
2022-10-09 18:29:06 +02:00
Rémi Verschelde
49be2d2cf8
Merge pull request #66524 from microaeris/aeris/text-edit-get-scroll-bar
...
Getters for TextEdit scroll bars
2022-10-09 18:27:30 +02:00
Rindbee
3f20108703
Improve caret drawing conditions for LineEdit
...
Now, `caret_can_draw` will be validated when a condition that affects
the drawability of the `LineEdit`'s caret changes; `draw_caret` will
be toggled when the caret's visibility is toggled due to blink, and
`draw_caret` will be `false` when `caret_blink_enabled` is disabled.
Fix toggling `caret_blink_enabled` could cause caret to no longer be
displayed.
Fix opening the context menu causing caret to no longer appear.
2022-10-09 22:14:40 +08:00
Jummit
1e28675560
Expose TreeItem::set_button_color
2022-10-09 10:37:55 +02:00
Haoyu Qiu
2a921cc9f8
Fix Label text length mismatch after localization
2022-10-08 23:07:19 +08:00
RedMser
9579d49820
Add warning for missing characters in label font
2022-10-08 17:02:25 +02:00
microaeris
215fe852b8
Getters for TextEdit scrollbars
2022-10-07 23:16:04 -07:00
bruvzg
0103af1ddd
Fix MSVC warnings, rename shadowed variables, fix uninitialized values, change warnings=all to use /W4.
2022-10-07 11:32:33 +03:00
Rémi Verschelde
5b7f62af55
Merge pull request #62910 from Vitika9/gsoc-colorpicker-ux
...
ColorPicker UX
2022-10-07 09:49:29 +02:00
bruvzg
a750ca7ec1
Add split caret direction markers. Fix block/overtype caret size.
2022-10-07 08:45:52 +03:00
Rémi Verschelde
d414872bfe
Merge pull request #66961 from Rindbee/fix-set_custom_color
...
Fix wrong condition used in `set_custom_color`
2022-10-06 08:56:52 +02:00
Rémi Verschelde
f5903215d0
Merge pull request #61902 from Paulb23/multi-caret
...
Add Multi-caret support to TextEdit
2022-10-06 08:56:34 +02:00
Rindbee
f359abbe01
Fix wrong condition used in set_custom_color
2022-10-06 12:09:02 +08:00
Markus Sauermann
c0f0f26615
Fix Control not disconnecting signal
...
If a Control has not parent CanvasItem and is set as top_level, then it does not disconnect from the "size_changed" signal when it leaves the Canvas.
This patch corrects this.
2022-10-05 23:35:44 +02:00
Paulb23
e9180241e8
Add multi caret support to CodeEdit
2022-10-05 17:19:26 +01:00
Paulb23
4a9d4e3dad
Add mutliple Caret support to TextEdit
2022-10-05 17:19:26 +01:00
Rémi Verschelde
132a0e3242
Merge pull request #66770 from EricEzaM/search-by-event
...
Add searching by event in Editor Settings shortcuts and Project Settings input map.
2022-10-05 08:34:45 +02:00
Rémi Verschelde
02e9e2d3c0
Merge pull request #66559 from zaevi/fix_ScrollContainer_touch_scroll
...
Fix ScrollContainer touch-scrolling not working.
2022-10-04 10:30:31 +02:00
Paulb23
7dd3857f7e
Move selecion into caret
2022-10-03 14:09:27 +01:00
EricEzaM
272c297931
Improve MenuButton and OptionButton
...
* MenuButton + OptionButton: Add method `show_popup()` which performs required popup setup before showing (prefer use of this over `get_popup()->popup()`, otherwise GH #66308 occurs)
* MenuButton: Ensure that the menu can be opened with a shortcut, if one is set for the button. (GH #66403 ). Ensure that popupmenu item shortcuts are checked first before the MenuButton shortcut.
2022-10-03 20:07:39 +10:00
EricEzaM
cb6d7fd059
Add searching by event for Editor Settings shortcuts and Project Settings input map.
...
* Focus into the LineEdit, then perform input to search the list of events by the events assigned.
* New specialised editor-only control for this: EventListenerLineEdit. Line edit is a good candidate for such a control because you can focus it, override it's input handling, and show the event all in one control.
Update InputEventConfigurationDialog to use event listener line edit rather than the separate tabs.
* Cleaner look - no need for tabs.
* Simpler code.
2022-10-03 19:56:34 +10:00
Rémi Verschelde
e3464c8fc8
Merge pull request #58995 from Sauermann/fix-mouse-cursor-change-2
...
Update mouse cursor shape after changes
2022-09-28 20:50:05 +02:00
Rémi Verschelde
a9591f3039
Merge pull request #66543 from akien-mga/msvc-warning-c4702
...
Fix MSVC warning C4702: unreachable code
2022-09-28 20:47:30 +02:00
Zae
186ca020b3
Fix ScrollContainer touch-scrolling not working.
2022-09-29 01:47:03 +08:00
Rémi Verschelde
7ab01450cf
Fix MSVC warning C4702: unreachable code
...
Part of #66537 .
2022-09-28 16:46:48 +02:00
Rémi Verschelde
0e53dd642c
Fix MSVC warning C4706: assignment within conditional expression
...
Part of #66537 .
2022-09-28 16:05:07 +02:00
Rémi Verschelde
7562932eb2
Merge pull request #66160 from dpalais/double_time
...
Use double instead of real_t type for time-related parameters and variables
2022-09-27 10:04:10 +02:00
Rémi Verschelde
92371880bd
Merge pull request #66445 from EricEzaM/GH-66442-shortcut-change-popupmenu-update
...
Ensure popup menu redraws items when shortcuts update.
2022-09-27 09:53:52 +02:00
Dave Palais
0c46068af0
Change time parameters and variables to double type
...
Addresses #65313
2022-09-26 13:52:54 -05:00
Eric M
af438ae742
Ensure popup menu redraws items when shortcuts update.
2022-09-26 23:21:32 +10:00
bruvzg
970592274d
[RTL] Fix font variations / OpenType features of theme default font not updated when default font is changed.
2022-09-26 13:04:40 +03:00
Rémi Verschelde
1b31241445
Merge pull request #65540 from MewPurPur/easier-bookmarks
...
Implement Shift+LMB as a Way to Toggle Bookmarks
2022-09-26 08:20:40 +02:00
Rémi Verschelde
56c7305f70
Merge pull request #66288 from bruvzg/te_fix_color
...
[TextEdit] Use error/selection font color for the current glyph only, instead of updating cached font color.
2022-09-25 11:04:14 +02:00
Micky
544727ac1e
Fix ColorPicker always emitting color_changed on html submit
...
The color change was always emitted when the the modal was closed, even if it was exactly the same as before.
2022-09-24 18:15:06 +02:00
Eric M
2eda77c682
Ensure all checks of is_action
in the editor which are for 'shortcut' use, check the action exactly.
2022-09-24 18:01:02 +10:00
bruvzg
3278917c7a
[TextEdit] Use error/selection font color for the current glyph only, instead of updating cached font color.
2022-09-23 11:25:39 +03:00
Rémi Verschelde
1928492b41
Merge pull request #65158 from nongvantinh/fixed-infinite-loop
...
Fixes engine runs into an infinite loop when searching using FindBar
2022-09-23 09:45:34 +02:00
Aaron Franke
c3970f8fe5
Revert custom_minimum_size type back to Vector2 instead of Vector2i
2022-09-22 19:09:12 -05:00
Rémi Verschelde
9f2748f63c
Merge pull request #66213 from KoBeWi/not_right_but_works™
...
Remove duplicate code in ItemList
2022-09-21 18:55:12 +02:00
kobewi
4a0e03cea5
Remove duplicate code in ItemList
2022-09-21 15:37:01 +02:00
Ninni Pipping
df9eaf5f47
Tree recursive folding
2022-09-21 13:28:29 +02:00
Rémi Verschelde
11602cbcfd
Merge pull request #66126 from RedMser/shortcut-context-inspector
...
Fix editing `shortcut_context` in inspector
2022-09-21 11:04:44 +02:00
Rémi Verschelde
bcf754d735
Merge pull request #66068 from bruvzg/rtl_fx_connected
...
[RTL] Add option to apply built-in effects to the individual connected glyphs.
2022-09-19 22:05:47 +02:00
Rémi Verschelde
209a837f79
Merge pull request #66112 from Zylann/get_configuration_warnings_psa
...
Change return type of `get_configuration_warnings` to `PackedStringArray`
2022-09-19 22:03:44 +02:00
RedMser
a12c71fff1
Fix #66062 : editing shortcut_context in inspector
2022-09-19 19:13:52 +02:00
Marc Gilleron
aed3822a93
Change return type of get_configuration_warnings
to PackedStringArray
2022-09-19 16:43:15 +01:00
bruvzg
46af7cbfdd
[RTL] Add option to apply built-in effects to the individual connected glyphs.
2022-09-19 18:10:32 +03:00
Markus Sauermann
52da6f1a44
Update mouse cursor shape after changes
...
This fixes some cases where the mouse cursor shape did not change automatically, but instead required a MouseMove to update.
2022-09-18 17:15:38 +02:00
Rindbee
65f97c671c
Make the inner TabBar in a TabContainer behave as if it were in a Container
2022-09-18 20:55:13 +08:00
Rémi Verschelde
6e8638683e
Merge pull request #66012 from Rindbee/fix-TabContainer-minimum_size
...
Fix minimum size calculation for `TabContainer`
2022-09-18 10:48:08 +02:00
Rindbee
464c374372
Fix minimum size calculation for TabContainer
2022-09-18 06:59:48 +08:00
bruvzg
2a0b4244b7
Fix RichTextLabel not updating on theme/theme override change until text is updated.
2022-09-16 22:24:11 +03:00
Hendrik Brucker
299585fcde
Add configuration warning to GraphEdit regarding future refactoring
2022-09-14 18:09:21 +02:00
bruvzg
2aa226f5e1
RTL Improvements
...
Do not apply negative line separation to the last line.
Ensure all methods immediately update cache in a single thread mode.
Fix bbcode_enabled change not being applied until text is changed.
Fix crash if line height is zero or less.
2022-09-13 11:40:20 +03:00
Yuri Sizov
29c8504dd9
Improve parameter naming and documentation in GraphEdit and GraphNode
...
Co-authored-by: Maganty Rushyendra <mrushyendra@yahoo.com.sg>
2022-09-09 17:50:44 +03:00
VolTer
c8cb93d022
Shift+LMB to Toggle Bookmarks
2022-09-08 22:23:14 +02:00
Michael Alexsander
c4c9e41073
Make Vector2i
values paired with EDSCALE
be just Vector2
2022-09-08 14:46:32 -03:00
Rémi Verschelde
69233093d7
Merge pull request #65241 from bruvzg/no_keymap_ambiguity
...
Fix key mapping changes when moving from macOS to other platform.
2022-09-08 09:24:24 +02:00
Rémi Verschelde
7936b3cc4c
Merge pull request #60108 from KoBeWi/arise_to_top
...
Rename raise() to move_to_front()
2022-09-08 09:23:31 +02:00
bruvzg
ac1f2b378f
[RTL] Stop threaded RTL auto-redrawing as soon as text processing is finished, instead of waiting for first redraw.
2022-09-07 22:24:30 +02:00
bruvzg
6f4d233062
Fix key mapping changes when moving from macOS to other platform
...
Removes separate `Command` key (use `Meta` instead).
Adds an event flag to automatically remap `Command` <-> `Control` (cannot be set alongside `Control` or `Meta`).
2022-09-07 18:45:35 +02:00
Rémi Verschelde
81de16890e
Merge pull request #65375 from ItsNL/fix-accep-dialog-its_inside_tree-false
...
Condition "!is_inside_tree()" is true" when AcceptDialog was visible from the editor.
2022-09-07 17:53:46 +02:00
Rémi Verschelde
54942038ac
Merge pull request #65389 from Rindbee/fix-file-list-in-FileDialog-not-updating
...
Fix file list in FileDialog not updating on first run
2022-09-07 17:53:09 +02:00
Rémi Verschelde
48705b1f03
Merge pull request #65355 from groud/split_container_min_grab_thickness
...
Allow SplitContainer to have a grab area larger than its visual grabber
2022-09-07 17:51:52 +02:00
=
2de52c74ae
Fix "grab_focus: Condition "!is_inside_tree()" is true" when AcceptDialog was visible from the editor.
2022-09-07 17:04:26 +02:00
Rindbee
88b72c3de4
Fix file list in FileDialog not updating on first run
2022-09-07 21:36:21 +08:00
Gilles Roudière
4cbcb5acda
Allow SplitContainer to have a grab area larger than its visual grabber
2022-09-07 12:33:02 +02:00
Micky
08c2aab169
Rename ProgressBar.percent_visible
to show_percentage
...
`percent_visible` -> `show_percentage`
`set_percent_visible` -> `set_show_percentage`
`is_percent_visible` -> `is_percentage_shown`
2022-09-07 11:58:30 +02:00
Rémi Verschelde
2841bc358c
Merge pull request #65446 from YuriSizov/dialogs-make-styleboxes-matter
...
Make `AcceptDialog` and derivatives utilize `StyleBox` fully
2022-09-07 09:09:15 +02:00
Rémi Verschelde
80dacac90c
Merge pull request #65437 from YuriSizov/theme-gui-renames
...
Improve naming of theme properties throughout GUI code
2022-09-07 08:58:00 +02:00
Rémi Verschelde
5c5079b398
Merge pull request #65197 from Mickeon/rename-connect-one-shot
...
Rename CONNECT_ONESHOT to CONNECT_ONE_SHOT
2022-09-07 08:51:10 +02:00
Rémi Verschelde
3515382390
Merge pull request #64361 from Mickeon/rename-caret-blink
...
Rename every instance of `caret_blink_speed` to `caret_blink_interval`
2022-09-07 08:51:02 +02:00
Yuri Sizov
5eaf82b4f0
Make AcceptDialog and derivatives utilize StyleBox fully
2022-09-07 01:42:11 +03:00
kobewi
b218727599
Rename raise() to move_to_front()
2022-09-06 22:13:06 +02:00
Yuri Sizov
39ef611a7d
Fix theming code in Panel, SplitContainer, RichTextLabel
2022-09-06 22:53:19 +03:00
Yuri Sizov
43f03e2ce6
Improve naming of theme properties throughout GUI code
...
Rename ItemList's bg -> panel
Rename ItemList's bg_focus -> focus
Rename ProgressBar's bg -> background
Rename ProgressBar's fg -> fill
Rename Tree's bg -> panel
Rename Tree's bg_focus -> focus
Rename ScrollContainer's bg -> panel
Rename FileDialog's *_icon_modulate -> *_icon_color
Rename FileDialog's files_disabled -> file_disabled_color
Rename CheckButton's on/off -> checked/unchecked
Rename check_v_adjust -> check_v_offset
2022-09-06 22:53:17 +03:00
Micky
dd26ecdd31
Rename CONNECT_ONESHOT TO CONNECT_ONE_SHOT
...
For consistency. Every other exposed `one_shot` is spaced out like this.
2022-09-06 19:00:33 +02:00
Micky
6dbd283ae5
Rename every instance of caret_blink_speed
to caret_blink_interval
...
It's been changed in EditorSettings, LineEdit, TextEdit.
Affects setters and getters, and passed parameters, too.
2022-09-06 18:37:17 +02:00
Vitika9
1dce43d417
ColorPicker UX improvements
...
- Tabs and MenuButton for mode selection and enabling/disabling colorized sliders
- MenuButton for shape selection with new icon for each shape
- Drag and drop functionality for presets to arrange order
- A chronological list of recently selected presets which are global for the editor
- Presets are now highlighted as being active or inactive
- Thicker sliders for easy targeting
- `grabber_offset` theme constant for Slider
- Uncolorized sliders
2022-09-06 21:42:20 +05:30
Rémi Verschelde
49d18f0725
Merge pull request #65423 from YeldhamDev/i_want_to_ride_my_bycicle
...
Rename `PopupMenu`'s `set/get_current_index()` to `set/get_focused_item()`
2022-09-06 17:00:58 +02:00
Rémi Verschelde
5062aafc2d
Merge pull request #64417 from aaronfranke/has-space
...
Replace AABB/Rect2/Rect2i has_no_* methods with has_* methods
2022-09-06 17:00:44 +02:00
Michael Alexsander
9507e91c07
Rename PopupMenu
's set/get_current_index()
to set/get_focused_item()
2022-09-06 10:51:14 -03:00
Micky
b6daad8d4b
Rename range_lerp
to remap
2022-09-06 07:19:20 +02:00
Rémi Verschelde
b5c053321c
Merge pull request #64840 from maximkulkin/graph-edit-node-selection
...
Add GraphNode 'selected' and 'deselected' signals, simplify GraphEdit
2022-09-05 08:36:10 +02:00
Maxim Kulkin
9a35ede23f
Add GraphNode 'selected' and 'deselected' signals, simplify GraphEdit
2022-09-05 02:32:06 -04:00
Rémi Verschelde
1499840f75
Merge pull request #65028 from groud/fix_split_container
...
Improve SplitContainer behavior, keeping asked split position whenever possible
2022-09-05 08:30:11 +02:00
Aaron Franke
995b9f94e8
Replace Rect2(i) has_no_area with has_area
2022-09-04 23:03:36 -05:00
Rémi Verschelde
597bc949a4
Merge pull request #65250 from YuriSizov/theme-owner-rises
2022-09-02 23:20:49 +02:00
Rémi Verschelde
77ca96fd73
Merge pull request #59589 from Calinou/rename-or-lesser-range-property-hint
2022-09-02 23:13:20 +02:00
Yuri Sizov
8b128081e8
Un-defer the initial theme changed notification
...
Co-authored-by: Rindbee <idleman@yeah.net>
2022-09-02 23:44:23 +03:00
Yuri Sizov
ddc55ef746
Add ThemeOwner type for managing theme propagation and lookup
2022-09-02 23:44:23 +03:00
Rémi Verschelde
33b4153764
Merge pull request #64917 from Tim-Fronsee/fix/add-gutter-total-width
2022-09-02 20:52:11 +02:00
Gilles Roudière
2ddda13339
Improve SplitContainer behavior, keeping asked split whenever possible
2022-09-02 20:48:50 +02:00
Hugo Locurcio
f7292dbeb3
Rename or_lesser
range property hint to or_less
...
"less" should be used for quantity, rather than "lesser".
Existing scripts that use `or_lesser` in `_get_property_list()`
will need to be updated to account for this change.
2022-09-02 19:08:20 +02:00
Rémi Verschelde
fe2cf6e406
Merge pull request #65210 from YuriSizov/control-customizable-cache-p3
2022-09-02 13:51:52 +02:00
Rémi Verschelde
c82bbc38a5
Merge pull request #64952 from Chaosus/vs_rename_uniform_to_param
2022-09-02 13:49:53 +02:00
Yuri Sizov
fc7cef8dec
Fix theme propagation in various parts of the editor
2022-09-02 13:18:31 +03:00
Rémi Verschelde
5a136ee490
Merge pull request #64724 from KoBeWi/HVBoxContainer
2022-09-02 08:44:42 +02:00
Jonathan Nicholl
15d057c521
Add is_zero_approx
methods to Vector2
, 3
, and 4
2022-09-02 00:29:50 -04:00
Rémi Verschelde
7e3afc3d09
Merge pull request #65213 from Mickeon/fix-label-visible-ratio
2022-09-01 23:49:28 +02:00
Rémi Verschelde
5263fd5343
Merge pull request #64198 from Geometror/add-bitmap-tests
2022-09-01 23:46:38 +02:00
kobewi
73929bef73
Rework oriented containers
2022-09-01 22:13:46 +02:00
Micky
511134f55f
Fix Label & RichTextLabel's visible_ratio not working
2022-09-01 19:22:12 +02:00
Rémi Verschelde
8c7be63588
Merge pull request #65192 from YuriSizov/control-customizable-cache-p2
2022-09-01 19:09:33 +02:00
Rémi Verschelde
dcd74563b6
Merge pull request #65156 from YuriSizov/control-customizable-cache-p1
2022-09-01 19:08:02 +02:00
Hendrik Brucker
ea0472fecf
Refactor BitMap and add tests
...
Co-authored-by: Resul Çelik <resul_celik@hotmail.com>
2022-09-01 18:39:17 +02:00
Rémi Verschelde
027415312e
Merge pull request #65132 from bruvzg/global_menu_shortcuts_context
2022-09-01 17:02:04 +02:00
Yuri Sizov
3b1aa240dc
Add a lifecycle method for manual theme item caching to Control
2022-09-01 16:35:36 +03:00
Yuri Sizov
15fd025f90
Add dumb and manual theme caching systems to Window
2022-09-01 16:05:02 +03:00
Yuri Rubinsky
8191b3c110
Rename uniform
to parameter
across the engine
2022-09-01 11:42:57 +03:00
Rémi Verschelde
0a34994720
Merge pull request #65117 from YeldhamDev/menubar_key_fix
...
Fix switching `MenuBar`'s menus with the keys while mouse hovering
2022-09-01 08:46:01 +02:00
Rémi Verschelde
d22f2612f9
Merge pull request #65162 from YuriSizov/editor-gradients-united
...
Unite `GradientEdit` and `GradientEditor` as editor-only widget
2022-09-01 08:30:16 +02:00
bruvzg
b85a4c5d79
[macOS] Handle accelerator and click events of the global menu items separately.
2022-09-01 08:13:56 +03:00
bruvzg
7aad14a4b6
[TextServer] Add support for trimming edge spaces on line break.
2022-09-01 08:11:55 +03:00
Yuri Sizov
93078ea551
Unite GradientEdit and GradientEditor as editor-only widget
2022-08-31 23:45:04 +03:00
Nong Van Tinh
97c0b0c74a
Fixes #64962 that cause program run into infinite loop
2022-09-01 01:26:08 +07:00
Tim Fronsee
e5c183b01e
Fix TextEdit::gutters_width (total gutter width) when adding & removing a gutter by calling TextEdit::_update_gutter_width in TextEdit::add_gutter & TextEdit::remove_gutter
...
Update TextEdit gutters subcase, gutter add and remove to ensure gutter total width is correct
Fix test_code_edit symbol lookup test case to include padding (+2)
2022-08-31 10:01:40 +09:00
Michael Alexsander
9e0de4e2cb
Fix switching MenuBar
's menus with the keys while mouse hovering
2022-08-30 20:18:35 -03:00
Rémi Verschelde
e27b61d291
Merge pull request #65042 from YuriSizov/editor-docks-tabbar-bg
2022-08-30 18:53:54 +02:00
Rémi Verschelde
ae349d8227
Merge pull request #64377 from Mickeon/rename-canvas-redraw
...
Rename `CanvasItem.update()` to `queue_redraw()`
2022-08-30 14:47:41 +02:00
Rémi Verschelde
ebe4f8d3a4
Merge pull request #65039 from Mickeon/rename-treeitem-tooltip
2022-08-30 14:05:08 +02:00
Micky
97f8c9b97c
Rename TreeItem's set_tooltip
to set_tooltip_text
...
`set_tooltip` -> `set_tooltip_text`
`get_tooltip` -> `get_tooltip_text`
For consistency:
`get_button_tooltip` -> `get_button_tooltip_text`
And the `tooltip` parameter in `add_button` was renamed to `tooltip_text`
2022-08-30 11:16:23 +02:00
Aaron Franke
10a56981dc
Rename String plus_file
to path_join
2022-08-29 19:38:13 -05:00
Yuri Sizov
8b196be855
Add background to TabContainer's tabbar and editor docks
2022-08-29 23:43:32 +03:00
Micky
e31bb5ffeb
Rename CanvasItem.update()
to queue_redraw()
...
Affects a lot of classes. Very thoroughly checked signal connections and deferred calls to this method, add_do_method/add_undo_method calls, and so on.
Also renames the internal `_update_callback()` to `_redraw_callback()` for consistency.
Just a few comments have also been changed to say "redraw".
In CPUParticles2D, there was a private variable with the same name. It has been renamed to `do_redraw`.
2022-08-29 14:59:47 +02:00
Rémi Verschelde
e60086f98b
Merge pull request #64119 from YuriSizov/theme-init-database
2022-08-29 14:02:21 +02:00
Rémi Verschelde
fd6453c45e
Revert "Remove NOTIFICATION_ENTER_TREE when paired with NOTIFICATION_THEME_CHANGED"
...
This reverts commit 4b817a565c
.
Fixes #64988 .
Fixes #64997 .
This caused several regressions (#64988 , #64997 ,
https://github.com/godotengine/godot/issues/64997#issuecomment-1229970605 )
which point at a flaw in the current logic:
- `Control::NOTIFICATION_ENTER_TREE` triggers a *deferred* notification with
`NOTIFCATION_THEME_CHANGED` as introduced in #62845 .
- Some classes use their `THEME_CHANGED` to cache theme items in
member variables (e.g. `style_normal`, etc.), and use those member
variables in `ENTER_TREE`, `READY`, `DRAW`, etc. Since the `THEME_CHANGE`
notification is now deferred, they end up accessing invalid state and this
can lead to not applying theme properly (e.g. for EditorHelp) or crashing
(e.g. for EditorLog or CodeEdit).
So we need to go back to the drawing board and see if `THEME_CHANGED` can be
called earlier so that the previous logic still works?
Or can we refactor all engine code to make sure that:
- `ENTER_TREE` and similar do not depend on theme properties cached in member
variables.
- Or `THEME_CHANGE` does trigger a general UI update to make sure that any
bad theme handling in `ENTER_TREE` and co. gets fixed when `THEME_CHANGE`
does arrive for the first time. But that means having a temporary invalid
(and possibly still crashing) state, and doing some computations twice
which might be heavy (e.g. `EditorHelp::_update_doc()`).
2022-08-29 11:11:29 +02:00
Rémi Verschelde
223e083d36
Merge pull request #64964 from MewPurPur/reorganize-label-properties
...
Reorganize Label and RichTextLabel properties
2022-08-29 09:52:04 +02:00
Rémi Verschelde
f647292df5
Merge pull request #64960 from YeldhamDev/more_hl_stuff
2022-08-29 08:05:33 +02:00
Rémi Verschelde
34f45d7b28
Merge pull request #64967 from YeldhamDev/pm_up_fix
2022-08-29 07:56:03 +02:00
Rémi Verschelde
93cf259834
Merge pull request #64972 from YeldhamDev/you_too_menubar
2022-08-29 07:55:46 +02:00
Rémi Verschelde
f7f8af232c
Merge pull request #64885 from Mickeon/rename-tooltip-hint
...
Rename `hint_tooltip` to `tooltip_text` & setter getter
2022-08-28 17:43:01 +02:00
VolTer
832950d1f2
Reorganized Label and RichTextLabel properties
2022-08-28 10:26:04 +02:00
Michael Alexsander
44c64b912f
Add item auto-highlighting to MenuBar
2022-08-28 01:49:22 -03:00
Michael Alexsander
221344b9e2
Fix some corner cases in the Menu/OptionButton
item auto-highlight
2022-08-28 01:15:03 -03:00
Michael Alexsander
06df59887b
Fix crash when pressing up on an empty PopupMenu
2022-08-27 18:13:27 -03:00
Rémi Verschelde
d3db8bbebd
Merge pull request #62846 from AaronRecord/remove_redundant_theme_updates_in_enter_tree
...
Remove `NOTIFICATION_ENTER_TREE` when paired with `NOTIFICATION_THEME_CHANGED`
2022-08-27 21:56:14 +02:00
Aaron Record
4b817a565c
Remove NOTIFICATION_ENTER_TREE when paired with NOTIFICATION_THEME_CHANGED
2022-08-27 11:52:29 -06:00
Phnix
fe1f8443a4
incorrect range value with min value and step
...
If the minimum value and the steps are greater than 0, the value will not be calculated correctly.
Co-Authored-By: Astral-Sheep <109028693+Astral-Sheep@users.noreply.github.com>
2022-08-27 18:55:58 +02:00
Rémi Verschelde
f9998455ce
Merge pull request #63249 from V-Sekai/animation_tree_editor_read_only
...
Add read-only mode to AnimationTreeEditor plugins
2022-08-27 08:14:30 +02:00
Micky
ef5b9a06a9
Rename hint_tooltip
to tooltip_text
& setget
...
`hint_tooltip` -> `tooltip_text`
`set_tooltip` -> `set_tooltip_text`
`_get_tooltip` -> `get_tooltip_text`
Updates documentation, too.
2022-08-27 01:35:01 +02:00
Rémi Verschelde
f9f2446972
Merge pull request #64367 from Mickeon/rename-var-to-str
...
Rename `str2var` to `str_to_var` and similar
2022-08-26 23:04:06 +02:00
Rémi Verschelde
4f60fd0480
Merge pull request #64777 from bruvzg/extend_to_title
...
[macOS] Extend editor contents to the window title bar for better space usage.
2022-08-26 23:03:31 +02:00
Yuri Sizov
6320a0fc18
Add ThemeDB, expose previously static Theme methods
2022-08-26 19:23:05 +03:00
Rémi Verschelde
ecfff5b75e
Revert SplitContainer minimum size splitting changes ( #64676 and #64800 )
...
This reverts commits 185b1a5bd3
and 19ad31b89f
.
The original PR and its fixup still had regressions, so we're going back
to the drawing board to reattempt fixing #43749 .
Fixes #64785 .
Fixes #64851 .
Fixes #64866 .
2022-08-26 15:57:17 +02:00
Micky
59e11934d8
Rename str2var
to str_to_var
and similar
...
Affects the Math class, a good chunk of the audio code, and a lot of other miscellaneous classes, too.
- `var2str` -> `var_to_str`
- `str2var` -> `str_to_var`
- `bytes2var` -> `bytes_to_var`
- `bytes2var_with_objects` -> `bytes_to_var_with_objects`
- `var2bytes` -> `var_to_bytes`
- `var2bytes_with_objects` -> `var_to_bytes_with_objects`
- `linear2db` -> `linear_to_db`
- `db2linear` -> `db_to_linear`
- `deg2rad` -> `deg_to_rad`
- `rad2deg` -> `rad_to_deg`
- `dict2inst` -> `dict_to_inst`
- `inst2dict` -> `inst_to_dict`
2022-08-26 14:58:22 +02:00
Rémi Verschelde
c8ef12a03a
Merge pull request #64665 from Mickeon/rename-label-visible
2022-08-26 14:54:37 +02:00
bruvzg
bc4ba6cb78
[macOS] Extend editor contents to the window titlebar for better space usage.
2022-08-26 15:12:43 +03:00
Rémi Verschelde
ff612b6916
Merge pull request #64574 from Begah/fix_transient_window_wrap_mouse
2022-08-26 13:54:23 +02:00
Rémi Verschelde
0c639428dd
Merge pull request #64529 from KoBeWi/suffix_begone
2022-08-26 13:39:14 +02:00
Micky
64bd36ecee
Rename Label & RichTextLabel.percent_visible
to visible_ratio
...
Also updates the documentation of both `visible_characters` and `visible_ratio` to, better describe what they do and improve consistency between the two Classes.
2022-08-26 12:15:57 +02:00
Rémi Verschelde
ac7b5111f5
Merge pull request #64768 from bruvzg/popups_hide_if_visible
2022-08-26 11:59:50 +02:00
Rémi Verschelde
fed1189099
Merge pull request #62771 from bruvzg/line_edit_trim
2022-08-26 11:43:28 +02:00
Aaron Record
74eb2a70bd
Refactor and remove excessive calls of NOTIFICATION_THEME_CHANGED
2022-08-25 14:50:49 -06:00
SaracenOne
75f1357ced
Add read-only mode to AnimationTreeEditor plugins
2022-08-25 16:29:36 +01:00
MathieuRoux
5ac5c8bc06
Fix warp_mouse for transient windows, smoother mouse positioning when releasing mouse for spinbox
2022-08-25 11:30:49 +02:00
Rémi Verschelde
0a5f5c8558
Merge pull request #64536 from Mickeon/editor-tree-icon-size
...
Account for TreeItem's Cell icon and center the text Popup vertically
2022-08-25 09:56:08 +02:00
Rémi Verschelde
1adcd0327f
Merge pull request #64806 from Zylann/graph_node_protected_validate_property
...
Make GraphNode::_validate_property protected so GraphNode can be inherited
2022-08-25 07:30:42 +02:00
Rémi Verschelde
efedef8eb1
Merge pull request #64837 from YuriSizov/control-disconnect-from-everything-and-free-yourself
...
Disconnect Control from theme resources to avoid issues on destruction
2022-08-25 00:04:17 +02:00
Marc Gilleron
22fcdffd17
Make GraphNode::_validate_property protected so GraphNode can be inherited.
...
It's not about overriding or accessing `_validate_property`,
but since `_validate_property` became a multilevel method,
the GDCLASS macro now tries to access the one from the parent class,
which causes a compiling error if the parent class declares
`_validate_property` as private.
2022-08-24 21:29:32 +01:00
Rémi Verschelde
b7d2ba12c8
Merge pull request #64635 from YeldhamDev/menu_buttons_popup_fix
...
Make `Menu/OptionButton` item auto-highlight behave better
2022-08-24 19:07:25 +02:00
Yuri Sizov
bb5fa91a6b
Disconnect Control from theme resources to avoid issues on destruction
2022-08-24 18:50:04 +03:00
Rémi Verschelde
4698dc67b5
Merge pull request #64082 from KoBeWi/array3k
2022-08-24 16:05:59 +02:00
Yuri Sizov
5d14d08702
Merge pull request #59226 from Rindbee/better-setters-in-gui-controls
...
Improve the setters in gui, return directly if the value does not change.
2022-08-24 17:03:54 +03:00
Yuri Sizov
78f3e4cb6a
Merge pull request #64369 from derammo/derammo_tree_right_click_title
...
Replace Tree control left click on title signal with new signal for either left or right click
2022-08-24 16:16:53 +03:00
derammo
0ba2e999df
implemented right click on Tree control header
2022-08-24 08:10:40 -04:00
kobewi
f7f4873ed0
Replace Array return types with TypedArray 3
2022-08-24 12:53:36 +02:00
Rémi Verschelde
c3a8ec3cbb
Merge pull request #64800 from KoBeWi/split_hax
...
Handle child control size changes in SplitContainer
2022-08-24 09:50:46 +02:00
Rémi Verschelde
854eb58074
Merge pull request #64783 from bruvzg/fix_rtl_min_size
...
Fix RTL min. size not triggering text cache update.
2022-08-24 09:49:00 +02:00
Rémi Verschelde
91e5f48ea7
Merge pull request #64009 from KoBeWi/arrayy_lmao
...
Replace Array return types with TypedArray (part 2)
2022-08-24 08:18:56 +02:00
kobewi
1abdffe7a0
Replace Array return types with TypedArray 2
2022-08-23 23:21:32 +02:00
kobewi
19ad31b89f
Handle child control size changes in SplitContainer
2022-08-23 20:41:10 +02:00
Rémi Verschelde
bbe8d2b03e
Merge pull request #64767 from bruvzg/meta_click
2022-08-23 18:15:44 +02:00
风青山
e561c68256
Add some codes, returnes directly if the value is not changed.
...
Avoid executing the following value-changed logics if the value does not really change.
2022-08-23 23:25:22 +08:00
bruvzg
f02d45ce0c
Fix RTL min. size not triggering text cache update.
2022-08-23 16:27:45 +03:00
Rémi Verschelde
11506eb24d
Merge pull request #64676 from KoBeWi/split_and_conquer
2022-08-23 10:28:09 +02:00
bruvzg
cd095ab64a
Hide MenuButton / OptionButton popup on click if it's already visible.
2022-08-23 10:38:51 +03:00
bruvzg
80a47ab0f9
[RTL] Improve meta click position.
2022-08-23 09:57:22 +03:00
Rémi Verschelde
62c3e72b6f
Merge pull request #63959 from KoBeWi/typo_arrray
...
Replace Array return types with TypedArray (part 1)
2022-08-23 08:52:13 +02:00
kobewi
8be27dc59e
Replace Array return types with TypedArray
2022-08-22 22:42:36 +02:00
Rémi Verschelde
9744becc39
Merge pull request #63891 from derammo/derammo_tree_cache
2022-08-22 22:41:28 +02:00
Rémi Verschelde
b9ea0e1338
Merge pull request #64218 from Rindbee/fix-button-minimum-size-calculation
2022-08-22 22:40:59 +02:00
Rémi Verschelde
1f61d47766
Merge pull request #64339 from YuriSizov/core-multilevel-validate-property
2022-08-22 21:39:48 +02:00
Rémi Verschelde
acd8fb7bf0
Merge pull request #64626 from YuriSizov/control-farewell-meta
...
Replace meta properties with regular properties in `Control`
2022-08-22 19:26:32 +02:00
Rémi Verschelde
99548e521d
Merge pull request #64711 from YeldhamDev/itemlist_scroll_fix
2022-08-22 17:37:38 +02:00
Yuri Sizov
1a24c9e14b
Make _validate_property
a multilevel method
2022-08-22 18:35:11 +03:00
Rémi Verschelde
dabc982393
Merge pull request #64618 from bruvzg/fix_menu_min_size
2022-08-22 17:33:27 +02:00
Micky
9a63792a08
Clamp Label's percent_visible
properly between 0 and 1.0
...
Also applies to RichTextLabel
2022-08-22 12:03:03 +02:00
Michael Alexsander
e298144a41
Fix ItemList
selection visual when the scrollbar visibility changes
2022-08-21 22:10:41 -03:00
kobewi
185b1a5bd3
Improve SplitContainer minimum size splitting
2022-08-21 03:30:11 +02:00
bruvzg
8f2083e6c0
Fix MenuBar minimum size adding unnecessary extra spacing after the last item.
2022-08-19 22:04:58 +03:00
Michael Alexsander
1da50698fc
Make Menu/OptionButton
item auto-highlight behave better
2022-08-19 14:54:53 -03:00
Yuri Sizov
e08feee8a6
Replace meta properties with regular properties in Control
2022-08-19 20:52:01 +03:00
bruvzg
2040087898
Fix MenuBar not processing shortcuts.
2022-08-19 16:49:50 +03:00