smix8
cc707412e9
Fix NavigationObstacle2D/3D get_global_transform() error
...
Fixes NavigationObstacle2D/3D reporting a 'get_global_transform: Condition "!is_inside_tree()" error when estimating the agent radius.
The collisionshapes that are lower in the SceneTree order than the obstacle node are not loaded in the SceneTree yet so the global_transform function fails.
Also adds warning message when this happens.
2022-05-15 20:29:23 +02:00
smix8
001d89223f
Expose NavigationObstacle2D/3D get_rid() and add config warning
...
Exposes get_rid() function for scripting.
Adds configuration warning when obstacle is used with not intended static body parent.
2022-05-15 01:03:22 +02:00
FireForge
88a8038387
Capitalize/fix some property enum hints
2022-05-12 15:03:16 -05:00
Rémi Verschelde
b6983eeccf
Merge pull request #51591 from Calinou/call-group-default-immediate
...
Make `{call,set,notify}_group()` immediate by default
2022-05-10 14:52:23 +02:00
kobewi
c836bdf5b1
Mention that Area2D doesn't support one_way_collision
2022-05-09 15:00:53 +02:00
Hugo Locurcio
aabbb40009
Make {call,set,notify}_group() immediate by default
...
This results in less surprising behavior out of the box.
Internal usages were modified to keep the existing behavior
identical there.
2022-05-05 16:59:37 +02:00
Haoyu Qiu
312ec612c7
Add autocompletion for AnimatedSprite.play()
2022-05-05 14:36:35 +08:00
Aaron Franke
fa7a7795f0
Rename Basis get_axis to get_column, remove redundant methods
2022-05-03 09:37:47 -05:00
Rémi Verschelde
931838b330
Merge pull request #60627 from aaronfranke/rename-elements
...
Rename Transform2D and Basis `elements` to `columns` and `rows` respectively
2022-05-03 14:40:01 +02:00
Rémi Verschelde
c273ddc3ee
Style: Partially apply clang-tidy's cppcoreguidelines-pro-type-member-init
...
Didn't commit all the changes where it wants to initialize a struct
with `{}`. Should be reviewed in a separate PR.
Option `IgnoreArrays` enabled for now to be conservative, can be
disabled to see if it proposes more useful changes.
Also fixed manually a handful of other missing initializations / moved
some from constructors.
2022-05-02 16:28:25 +02:00
Rémi Verschelde
4e06ce7840
Merge pull request #60655 from smix8/navigation_region_rid_4.x
...
Add get_region_rid() to NavigationRegion2D and NavigationRegion3D
2022-05-01 14:17:40 +02:00
smix8
05d06b8957
Add get_region_rid() NavigationRegion2D and NavigationRegion3D
...
Add get_region_rid() to NavigationRegion2D and NavigationRegion3D
2022-04-30 13:27:30 +02:00
Rémi Verschelde
a817bd96c0
Merge pull request #59297 from fabriceci/fix-jitter-2D-slight-slope
2022-04-29 15:33:45 +02:00
Aaron Franke
b831fb0a54
Rename Transform2D "elements" to "columns"
2022-04-29 08:02:39 -05:00
Rémi Verschelde
212989d467
Merge pull request #59438 from fabriceci/fix-move-and-collide-reported-collisions
...
Fix wrong collision reported on move_and_collide
2022-04-28 18:47:22 +02:00
Rémi Verschelde
3e9ead05f2
Merge pull request #58685 from IgorKordiukiewicz/gpu_particles_2d_interpolation_property
...
Added interpolation property to GPUParticles2D
2022-04-27 13:58:41 +02:00
Rémi Verschelde
1737494479
Merge pull request #60321 from rburing/pathfollow_offset_yes_a_number
2022-04-27 13:27:19 +02:00
Rémi Verschelde
8dfa12cae7
Merge pull request #59979 from bruvzg/cpp_check2
2022-04-27 10:08:26 +02:00
Samuel Wilson
a4c38aa92e
Fix TileMap::set_pattern offsets
...
Currently it is trying to use the target coordinates (i.e., in the destination TileMap) to pull from the pattern, rather than the pattern-local coordinates.
2022-04-27 09:35:33 +02:00
Rémi Verschelde
02bb8e948f
Merge pull request #60261 from fire-forge/theme-prop-renames
2022-04-25 16:20:19 +02:00
RedHeadphone
f603c75035
correct initial cpu particle velocity
2022-04-24 14:50:42 +05:30
FireForge
3073b85de9
Rename theme properties to include underscores
...
- check_vadjust -> check_v_adjust
- close_h_ofs -> close_h_offset
- close_v_ofs -> close_v_offset
- commentfocus -> comment_focus
- hseparation -> h_separation
- ofs -> offset
- selectedframe -> selected_frame
- state_machine_selectedframe -> state_machine_selected_frame
- table_hseparation -> table_h_separation
- table_vseparation -> table_v_separation
- vseparation -> v_separation
2022-04-23 11:16:18 -05:00
bruvzg
de4c97758a
Fix more issues found by cppcheck.
2022-04-20 10:34:00 +03:00
Ricardo Buring
eb9157df23
PathFollow2D and PathFollow3D: don't set offset to NaN
2022-04-17 17:26:05 +02:00
bruvzg
f851c4aa33
Fix some issues found by cppcheck.
2022-04-06 14:34:37 +03:00
kobewi
6e622c58c5
Change gizmo_extents to property
2022-04-05 16:16:28 +02:00
Rémi Verschelde
f8ab79e68a
Zero initialize all pointer class and struct members
...
This prevents the pitfall of UB when checking if they have been
assigned something valid by comparing to nullptr.
2022-04-04 19:49:50 +02:00
Markus Sauermann
01c37dc277
Revert "Fix that collision objects ignore canvas transform"
...
This reverts commit 5521b93750
2022-04-04 18:08:05 +02:00
Igor Kordiukiewicz
fd54762892
Added interpolation property to GPUParticles2D
2022-04-04 15:51:13 +02:00
kobewi
db19cc60fb
Fix TouchScreenButton error spam
2022-04-04 01:47:40 +02:00
Rémi Verschelde
26048c805b
Merge pull request #59331 from bartekd97/navigation-agent-layers
2022-04-01 13:35:51 +02:00
Markus Sauermann
5521b93750
Fix that collision objects ignore canvas transform
...
This aligns collision areas with visual areas within a viewport
2022-03-31 16:07:05 +02:00
Rémi Verschelde
324215c485
Merge pull request #59525 from fire-forge/fix-group-names
2022-03-28 21:44:35 +02:00
FireForge
88b09694e7
Fix inspector group name capitalization
2022-03-28 14:02:06 -05:00
Rémi Verschelde
7119d355eb
String: Remove TTR and DTR defines in non-tools build
...
This ensures we don't use TTR in runtime code, as it's specifically meant
to source translations for the editor.
2022-03-28 20:26:35 +02:00
fabriceci
e2812fcb0f
When only a recovery occurs, don't report a collision on move_and_collide
2022-03-23 10:24:35 +01:00
fabriceci
528dfbf63e
Fix 2D jitter on slight slope
2022-03-21 09:08:52 +01:00
BARTEK-PC\Bartek
4972f1b864
Expose navigable layers for NavigationAgent2D/3D
2022-03-20 15:04:56 +01:00
Rémi Verschelde
acc9b5b390
Merge pull request #55399 from RPicster/particlesmaterial-sphere-emittershape
...
ParticleMaterial: Sphere emission shape emitting from the volume.
2022-03-18 08:21:59 +01:00
Rémi Verschelde
b7bc8dbebe
Merge pull request #57392 from madmiraal/implement-3888
2022-03-14 08:31:58 +01:00
Rémi Verschelde
4f40a71e03
Merge pull request #57436 from AnilBK/change-scopes
...
Scope Changes for some variables.
2022-03-13 22:10:16 +01:00
Igor Kordiukiewicz
8f49150b10
Changed TileMap::set_cell alternative_tile default value to 0
2022-03-02 12:13:45 +01:00
Ricardo Buring
cb5bc58e81
Joint2D and Joint3D: make set_exclude_nodes_from_collision respect signals
2022-02-28 22:25:45 +01:00
Ricardo Buring
9e100c3e7a
Joint2D and Joint3D: update joint on NOTIFICATION_POST_ENTER_TREE
...
This allows reparenting, etc.
2022-02-28 22:21:32 +01:00
Rémi Verschelde
f968c11b86
Merge pull request #58596 from rburing/joints_disconnect_connected_signals
...
`Joint2D` and `Joint3D`: disconnect only connected signals
2022-02-28 11:00:14 +01:00
Haoyu Qiu
3a439a9c03
Fix AnimatedSprite infinite loop
2022-02-28 16:00:45 +08:00
Ricardo Buring
184105e753
Joint2D and Joint3D: disconnect only connected signals
2022-02-27 16:55:57 +01:00
Chris Bradfield
849d34ba8e
Rename motion_velocity to velocity
2022-02-22 23:31:33 -08:00
Hugo Locurcio
6b52aa67b8
Add a property hint for the Line2D Round Precision property
...
This prevents choosing extremely high values which cause performance
issues for no visual benefit.
2022-02-17 00:21:00 +01:00
Rémi Verschelde
b8b4580448
Style: Cleanup single-line blocks, semicolons, dead code
...
Remove currently unused implementation of TextureBasisU, could be re-added
later on if needed and ported.
2022-02-16 14:06:29 +01:00
Rémi Verschelde
0f5455230c
Use switch consistently in _notification (scene folder)
2022-02-15 18:44:55 +01:00
Hendrik Brucker
b396fd4eef
Improve compilation speed (forward declarations/includes cleanup)
2022-02-12 02:46:22 +01:00
Anilforextra
bb5d130509
Code quality cleanup for some variable scopes.
2022-02-10 15:56:01 +05:45
Raul Santos
68b04a5a07
Add array element type to _get_polygons and _get_outlines
2022-02-08 21:15:25 +01:00
Haoyu Qiu
bbcd9c5b97
Fix RayCast{2,3}D.clear_exceptions clears parent
2022-02-08 16:31:07 +08:00
Anilforextra
fc27636999
Vectors: Use clear() and has().
...
Use clear() instead of resize(0).
Use has() instead of "find(p_val) != -1".
2022-02-02 00:11:09 +05:45
Rémi Verschelde
f1bff648f2
Merge pull request #57355 from akien-mga/method-bindings-clearer-types
2022-02-01 14:24:35 +01:00
Marcel Admiraal
15ea6706e2
Invert Camear2D zoom to make it intuitive
2022-01-31 16:35:28 +00:00
Rémi Verschelde
1c6f0aa3a0
Merge pull request #56601 from Scony/fix-navigation-obstacle-errors
2022-01-28 23:25:55 +01:00
Rémi Verschelde
7072b359b4
Improve some method bindings to use specific Object subtypes
...
This was made possible by changes to `VariantCaster` which now make
it possible to pass any `Object`-derived type as pointer.
2022-01-28 15:07:22 +01:00
Rémi Verschelde
b8b33df178
TileSetAtlasSource: Make get_tile_data return TileData *
...
This is now possible thanks to `Variant` changes.
Also unbind some `_` prefixed methods which don't need to be exposed.
2022-01-28 14:27:12 +01:00
fabriceci
cc3c4d6323
Revert #53174 (applying the delta in move and collide), rename rec_vel to distance and improve the doc description
2022-01-26 23:09:30 +01:00
Haoyu Qiu
a775744742
Store ObjectID instead of raw pointer for Shape Owners
2022-01-25 17:16:06 +08:00
Rémi Verschelde
672363f295
Merge pull request #56888 from FreegleBarr/implement_gpuparticle_subemitters2d
2022-01-24 22:19:55 +01:00
Rémi Verschelde
2255777fb9
Merge pull request #57144 from AnilBK/fix-pos-dragging
2022-01-24 21:32:38 +01:00
freeglebarr
6f88294528
ported particle sub-emission to 2D
2022-01-24 17:28:59 -03:00
Rémi Verschelde
5f8f6ae7f6
Merge pull request #57120 from KoBeWi/grandpa_issue
2022-01-24 21:03:48 +01:00
Anilforextra
80187b77a9
Node2D/Node3D: Fix Undraggable Position Property.
2022-01-25 00:52:11 +05:45
fabriceci
856142a97d
rename free mode to floating mode
2022-01-24 15:19:43 +01:00
kobewi
d7f51dd2ec
Better clarify map_to_world() description
2022-01-24 14:13:40 +01:00
kobewi
f74d52e80d
Fix error on scene tiles cleanup
2022-01-19 00:39:26 +01:00
Rémi Verschelde
7c771ea310
Merge pull request #47522 from madmiraal/rename-test_width-test_height
2022-01-18 13:39:57 +01:00
Rémi Verschelde
e0f2902a11
Merge pull request #55665 from KoBeWi/you_touched_my_TouchScreeenButton
2022-01-13 12:23:49 +01:00
Rémi Verschelde
189662e5bd
Merge pull request #56696 from AnilBK/use-init-lists
2022-01-12 10:04:45 +01:00
Anilforextra
6c3a0460a8
Use List Initializations for Vectors.
2022-01-12 10:15:12 +05:45
Arnav Vijaywargiya
0c46f73b5e
Fixed incorrect property types
2022-01-11 17:17:11 +05:30
Anilforextra
b770a4d0ac
Path2D: Check points count before rendering.
2022-01-09 15:17:41 +05:45
Pawel Lampe
9bda2d5859
Fix NavigationObstacle errors
...
* `NavigationObstacle2D` premature radius estimation (before entering the tree)
* `NavigationObstacle3D` premature radius estimation (before entering the tree)
2022-01-07 19:55:22 +01:00
Rémi Verschelde
4dbef3a4f5
i18n: Sync template with current 3.x codebase
...
Weblate will now track the state of `3.x` to prepare for the 3.5 release.
(cherry picked from commit 02d9ac1071
2022-01-07 13:35:28 +01:00
Rémi Verschelde
b23552922f
NavigationServer: Restore constness for thread safe get_singleton
...
This was removed by mistake in #47024 , NavigationServer uses internal
mutability for thread safety, and removing `const` breaks the contract.
2022-01-05 15:41:21 +01:00
Marcel Admiraal
f107139979
Rename Project Window width and height settings to match their function
2022-01-04 13:59:16 +00:00
Rémi Verschelde
fe52458154
Update copyright statements to 2022
...
Happy new year to the wonderful Godot community!
2022-01-03 21:27:34 +01:00
luz paz
a124f1effe
Fix various typos
...
Found via ` codespell -q 3 -S ./thirdparty,*.po,./DONORS.md -L ackward,ang,ans,ba,beng,cas,childs,childrens,dof,doubleclick,expct,fave,findn,gird,hist,inout,leapyear,lod,nd,numer,ois,ony,paket,seeked,sinc,switchs,te,uint,varn`
Update editor/import/resource_importer_layered_texture.cpp
Co-authored-by: Raul Santos <raulsntos@gmail.com>
Update doc/classes/TileSetScenesCollectionSource.xml
Co-authored-by: Raul Santos <raulsntos@gmail.com>
Update scene/gui/graph_edit.cpp
Co-authored-by: Raul Santos <raulsntos@gmail.com>
Update scene/resources/animation.cpp
Co-authored-by: Raul Santos <raulsntos@gmail.com>
Update scene/resources/animation.cpp
Co-authored-by: Raul Santos <raulsntos@gmail.com>
Update scene/resources/animation.cpp
Co-authored-by: Raul Santos <raulsntos@gmail.com>
Update scene/gui/rich_text_label.cpp
Co-authored-by: Raul Santos <raulsntos@gmail.com>
Revert previously committed change
2022-01-02 01:03:58 -05:00
Haoyu Qiu
1078c389f9
Fix crash when executing TileMap.map_pattern
...
Validates the input reference.
2021-12-18 15:53:21 +08:00
Rémi Verschelde
7f9a82b944
Merge pull request #52998 from AnilBK/node2d-renames
...
Node2D member renames.
2021-12-13 09:15:12 +01:00
PouleyKetchoupp
940f3fde5c
Improve RigidDynamicBody force and torque API
...
Makes the API for forces and impulses more flexible, easier to
understand and harmonized between 2D and 3D.
Rigid bodies now have 3 sets of methods for forces and impulses:
-apply_impulse() for impulses (one-shot and time independent)
-apply_force() for forces (time dependent) applied for the current step
-add_constant_force() for forces that keeps being applied each step
Also updated the documentation to clarify the different methods and
parameters in rigid body nodes, body direct state and physics servers.
2021-12-10 15:55:40 -07:00
Rémi Verschelde
4f9b6d9a3f
Merge pull request #51235 from AnilBK/awkward-funcs
2021-12-10 16:58:11 +01:00
Rémi Verschelde
3c448437f6
Merge pull request #55263 from RPicster/ParticleMaterial-random-start-color
2021-12-10 10:06:46 +01:00
Rémi Verschelde
f455660e93
Merge pull request #55572 from aaronfranke/ci-double
2021-12-10 10:02:38 +01:00
Aaron Franke
e9808e3d9a
Add a double-precision editor build to CI
2021-12-09 09:52:48 -06:00
Nathan Franke
49403cbfa0
Replace String comparisons with "", String() to is_empty()
...
Also:
- Adds two stress tests to test_string.h
- Changes to .empty() on std::strings
2021-12-09 04:48:38 -06:00
Jonathan Gollnick
0c14b930ef
Fix _validate_property on AnimatedSprite 2D and 3D
2021-12-08 16:59:11 -06:00
Raffaele Picca
76e2c87f57
Fixed sphere emission shape to emit particles in a spheres volume and added "Sphere Surface" to keep the old behaviour.
2021-12-06 20:48:02 +01:00
kobewi
6a2938471b
Rename TouchScreenButton's textures
2021-12-06 15:46:05 +01:00
Raffaele Picca
ddf82697d7
Random initial color parameter for ParticleMaterial
...
Works with 2D and 3D GPU Particles
2021-12-03 13:58:17 +01:00
Rémi Verschelde
bb3f0a9d58
Merge pull request #55271 from RPicster/particles-texture-animation-speed
2021-12-02 10:14:26 +01:00
lawnjelly
6db29583f2
Faster Path2D drawing with polyline
...
Changes the Path2D drawing to use POLYLINE instead of thick lines.
2021-12-01 15:23:27 +00:00
Rémi Verschelde
cae5615a22
Merge pull request #55417 from ekumlin/issue-54856
2021-11-29 14:46:01 +01:00
Raffaele Picca
37cfa56db3
Visibility rect only shown when a GPUParticle2D is selected to reduce visual clutter in scenes with a lot of Particle nodes.
2021-11-28 19:42:42 +01:00
Raffaele Picca
459e2a4b6f
Fixed texture animation speed when using random lifetime ( Particle2D gpu + cpu) as mentioned here: https://github.com/godotengine/godot/issues/54993
2021-11-26 01:12:23 +01:00
Lightning_A
e078f970db
Rename remove() to remove_at() when removing by index
2021-11-23 18:58:57 -07:00
kobewi
4682f22293
Improve various texts
2021-11-23 12:20:57 +01:00
fabriceci
3a4debfa59
Scales the horizontal velocity according to the wall slope in 2D
2021-11-19 14:09:17 +01:00
Eric
7257bb6ad0
Fix condition on 'jump to limits' logic
...
This is a fix for: #54856
2021-11-17 21:12:34 -08:00
Yuri Roubinsky
8be89357ce
Fix ColorPicker inverted input on color circle
2021-11-17 20:33:17 +03:00
Rémi Verschelde
b99792b5d9
Merge pull request #54167 from brunosxs/fix-game-crash-when-sending-a-notification-from-a-camera-class
2021-11-16 14:11:14 +01:00
Camille Mohr-Daurat
74facb6d39
Merge pull request #54803 from goostengine/shape-cast-2d
...
Add `ShapeCast2D` node
2021-11-12 13:28:44 -07:00
Andrii Doroshenko (Xrayez)
6a67350910
Remove get_closest_* methods from ShapeCast2D
...
The physics API cannot provide needed functionality to ensure the correct behavior, which might lead to confusion (see `rest_info()`).
However `get_closest_collision_safe/unsafe_fraction()` methods are not removed, because they return correct result from `cast_motion()`.
2021-11-12 21:30:35 +02:00
Andrii Doroshenko (Xrayez)
f979d5977a
Add ShapeCast2D node
2021-11-12 21:29:30 +02:00
Gilles Roudière
1224d7a25c
Implement texture padding in TileSetAtlasSources
2021-11-12 15:14:10 +01:00
Camille Mohr-Daurat
11e03ae7f0
Merge pull request #54810 from nekomatata/area-separate-override-modes
...
Separate space override modes for gravity/damping in Area
2021-11-11 15:11:21 -07:00
PouleyKetchoupp
c3ae7ddedd
Add raycast options to hit when starting inside / hit back faces
...
Makes the results consistent for all shape types with options to set
the desired behavior.
2021-11-10 17:43:35 -07:00
Rémi Verschelde
3668312e78
Merge pull request #54847 from nekomatata/fix-test-move-regression
2021-11-10 20:38:49 +01:00
PouleyKetchoupp
5da057adaf
Fix test_move reporting collision when touching another body
...
Reporting rest collision information is needed for move_and_collide and
move_and_slide so floor detection can be done properly, but in the case
of just testing the motion for collision, it makes sense to return false
if the body is able to move all along the path without being stopped.
Updated the logic in test_move and clarified the documentation for
test_move and move_and_collide.
2021-11-10 11:20:02 -07:00
PouleyKetchoupp
bfd0d33244
Fix errors in CharacterBody when floor is destroyed or removed
...
In all physics servers, body_get_direct_state() now silently returns
nullptr when the body has been already freed or is removed from space,
so the client code can detect this state and invalidate the body rid.
In 2D, there is no change in behavior (just no more errors).
In 3D, the Bullet server returned a valid direct body state when the
body was removed from the physics space, but in this case it didn't
make sense to use the information from the body state.
2021-11-10 08:27:33 -07:00
PouleyKetchoupp
3d1c123d45
Separate space override modes for gravity/damping in Area
...
Also make inspector clearer for gravity point properties.
2021-11-09 10:29:24 -07:00
Andrii Doroshenko (Xrayez)
6742a338a8
Rename GradientTexture to GradientTexture1D
...
1. Explicit and unambiguous when comparing to `GradientTexture2D`
2. Consistent with other class names where 1D is used in the engine.
2021-11-07 15:11:04 +02:00
Rémi Verschelde
13aaa73124
Merge pull request #54573 from nekomatata/query-parameters
2021-11-05 21:52:39 +01:00
PouleyKetchoupp
acbd24ea84
Use parameter classes instead of arguments for all physics queries
...
Same as what is already done for shape queries, applied to point and ray
queries. Easier to document and more flexible to add more parameters.
Also expose intersect_point method to script in 3D.
Remove intersect_point_on_canvas in 2D, replaced with a parameter.
2021-11-04 11:44:39 -07:00
Hugo Locurcio
c012fbc8b2
Rename PROPERTY_USAGE_NOEDITOR to PROPERTY_USAGE_NO_EDITOR
...
This is consistent with other constants that include `NO`,
such as `PROPERTY_HINT_COLOR_NO_ALPHA`.
2021-11-03 23:06:17 +01:00
Rémi Verschelde
25bea73544
Merge pull request #54527 from nekomatata/fix-polygon-bone-path-errors
2021-11-03 17:27:36 +01:00
PouleyKetchoupp
8d9619ad46
Fix errors with invalid bone node path in Polygon2D
...
NodePath properties are designed to be relative to the given node, so
validity checks are failing in the editor for Polygon2D nodes, which are
relative to the Skeleton2D node rather than the Polygon2D node.
Fixed by saving bone paths as String properties instead of NodePath.
Shouldn't cause a difference for performance since NodePath properties
are technically saved as String anyway.
2021-11-03 08:28:32 -07:00
Rémi Verschelde
87ddc5bbbf
Merge pull request #54104 from Scony/improve-navigation-obstacles
...
Improve NavigationObstacle3D usability
2021-11-03 10:13:53 +01:00
rafallus
770e3a8e51
Use Callable in Area monitor callback
2021-11-01 21:53:17 -06:00
Rémi Verschelde
529968df30
Merge pull request #54396 from groud/implement_terrain_other_brushes
2021-11-01 22:27:06 +01:00
Camille Mohr-Daurat
a57de3b818
Merge pull request #37880 from nekomatata/rigid-body-damping-override
...
Improved RigidDynamicBody linear/angular damping override
2021-11-01 11:24:01 -07:00
Hugo Locurcio
ce97ddbcb1
Rename GLES2 driver to OpenGL to prepare for the upgrade to GLES3
...
- Use lowercase driver names for the `--rendering-driver`
command line argument.
2021-10-30 02:05:49 +02:00
Gilles Roudière
c609d39214
Implement missing TileMap brushes for terrains
2021-10-29 19:46:42 +02:00
Lyuma
c088a2dd89
Fix crash due to reentrancy in AudioStreamPlayer* finished signal.
...
This crash occurred when an audio stream finished playing in NOTIFICATION_INTERNAL_PROCESS,
during which it would iterate through a loop of playbacks,
leading to a "finished" signal, which removed the audio player from the tree
which led to a NOTIFICATION_EXIT_TREE,
which would mutate the array of playbacks while within the above loop.
This moves the signal callback outside of the loop which avoids the crash.
Note: previously, the signal was called multiple times if the same player finishes multiple times in one frame. Now it is at most once per frame.
Affects AudioStreamPlayer, AudioStreamPlayer2D and AudioStreamPlayer3D
2021-10-28 19:45:29 -07:00
Rémi Verschelde
3b11e33a09
clang-format: Disable alignment of operands, too unreliable
...
Sets `AlignOperands` to `DontAlign`.
`clang-format` developers seem to mostly care about space-based indentation and
every other version of clang-format breaks the bad mismatch of tabs and spaces
that it seems to use for operand alignment. So it's better without, so that it
respects our two-tabs `ContinuationIndentWidth`.
2021-10-28 15:19:35 +02:00
Camille Mohr-Daurat
3c527dcbbd
Merge pull request #54157 from bjauny/fix_potential_nullpointer_collision3d
...
Fix potential null pointer use, based on #54094 fix
2021-10-27 12:40:50 -07:00
Bastien JAUNY
258b5d0019
Fix potential null pointer use, based on #54094 fix
2021-10-27 20:41:14 +02:00
Camille Mohr-Daurat
a1092d14c5
Merge pull request #54302 from fabriceci/fix-2D-character-stuck-on-wall
...
Fix #54298 where a CharacterBody2D can be stuck on the wall.
2021-10-27 11:24:52 -07:00
Gilles Roudière
756e76293f
Implement runtime update of TileData object in TileMap
2021-10-27 18:32:52 +02:00
fabriceci
ee3e43c853
Fix #54298 where a CharacterBody2D can be stuck on the wall.
2021-10-27 18:05:35 +02:00
Gilles Roudière
a6584e4cb8
Optimize TileMap layers updates
2021-10-27 12:07:52 +02:00
Rémi Verschelde
01afa39d21
Merge pull request #54073 from groud/terrains_for_procgen
2021-10-26 08:15:07 +02:00
PouleyKetchoupp
daf7dcac7a
Improved RigidDynamicBody linear/angular damping override
...
Damping values are now non-negative.
Add new properties linear_damp_mode and angular_damp_mode to set the way
RigidDynamicBody and PhysicalBone (2D & 3D) use damping values.
It can now be Combine (default) to add to the default/areas, or Replace
to override the value completely (current behavior).
2021-10-25 18:22:12 -07:00
Pawel Lampe
fa26fb865f
Improve NavigationObstacle3D usability
...
Fix NavigationObstacle3D to be attached to navigation map - without it
the NavigationObstacle3D is not working.
Replace radius approximation algorithm with simple "radius" property.
2021-10-25 19:57:33 +02:00
BrunoSXS
eb2deabffe
Fixes a game crash caused by instantiating Camera2D and sending a notification from it before adding it to the tree.
2021-10-23 17:30:18 -03:00
Rémi Verschelde
e0f887accd
Merge pull request #54120 from zaevi/fix_null-ref_crashes
2021-10-23 19:00:12 +02:00
Zae
924c2078da
Fix unexpected crashes in notification
2021-10-23 13:01:52 +08:00
Rémi Verschelde
9f7218eb69
Merge pull request #54088 from madmiraal/remove-unimplemented-methods
2021-10-22 12:59:32 +02:00
Marcel Admiraal
87a4ba492e
Remove unimplemented methods
2021-10-21 18:44:25 +01:00
Rémi Verschelde
133c1eb0af
Merge pull request #52367 from Duroxxigar/improve-nav-error-messages
...
Improve readability for failing errors in nav area
2021-10-21 19:36:16 +02:00
Rémi Verschelde
e06d264362
Merge pull request #53990 from Kemikal1/master
...
Change the unreacheable return value of shape_find_owner()
2021-10-21 19:24:08 +02:00
Gilles Roudière
d1aef45072
Allow updating TileMap cells using surrounding terrains
2021-10-21 16:57:28 +02:00
kobewi
1a347e9cf3
Fix MeshInstance2D rect
2021-10-21 15:18:52 +02:00
Kemikal1
563d3dbf94
Change the unreacheable return value of shape_find_owner()
...
Update collision_object_3d.cpp
2d modified and UINT32 usage
Proper uINT32max usage
Change the unreacheable return value of shape_find_owner()
This reverts commit 5be98b81428169ba2dd5baecd00f1adfd9260e5c, reversing
changes made to efa3ff6b95
2021-10-21 15:02:28 +03:00
Rémi Verschelde
da98357e6e
doctool: Fix differences between headless and Vulkan rendering backends
...
Fixes #53913 .
2021-10-20 17:48:50 +02:00
