Commit graph

29239 commits

Author SHA1 Message Date
Pedro Rodrigues
eec2731eb2 Fix crash on HTTPClient::poll method
The problem happened because `poll` assumed that when the SSL flag was
true, the `connection` would be a subclass of StreamPeerSSL. However
that invariant could be broken by calling HTTPClient::set_connection
with a `connection` that is not a subclass of StreamPeerSSL.

Fixes #46138

(cherry picked from commit a3a731ed92)
2021-03-04 11:39:51 +01:00
kleonc
5022103ee7 Make Color::from_hsv use Color::set_hsv
(cherry picked from commit b59a06da25)
2021-03-04 11:39:02 +01:00
Michael Alexsander
292c9e380a Make Camera2D's editor helper code only be compiled on editor builds
(cherry picked from commit f70ccbca52)
2021-03-04 11:35:39 +01:00
Jordan Schidlowsky
ced5f5398a add msan sanitizer option for linus/bsd, lsan option for osx
(cherry picked from commit da35cd2f00)
2021-03-04 11:33:35 +01:00
Zak
3f36ca7323 HTTPRequest: Improve response when disconnecting while downloading
Previously if a disconnect occured while downloading a non recoverable error was displayed. This PR attempts to fix this by making sure `request_completed` signal is emitted with an `STATUS_CONNECTION_ERROR` response code.

(cherry picked from commit 70c39737db)
2021-03-04 11:31:57 +01:00
Rémi Verschelde
1134fade46
Merge pull request #46373 from dalexeev/3.2-proposal-1545
[3.2] Merge Category and Property fields in the Project Settings
2021-03-04 10:19:12 +01:00
Rémi Verschelde
74bbdc9486
Merge pull request #46636 from Calinou/doc-itemlist-remove-examples-3.2
Remove incorrect/trivial examples in the ItemList class documentation
2021-03-04 08:56:02 +01:00
Hugo Locurcio
bd907d48ad
Remove incorrect/trivial examples in the ItemList class documentation
This closes https://github.com/godotengine/godot-docs/issues/4712.
2021-03-03 22:56:02 +01:00
Rémi Verschelde
2c331b7900
Merge pull request #46618 from bruvzg/macos_export_entitlements
[macOS] Add entitlements config and export template `dylib` signing to the export.
2021-03-03 22:41:12 +01:00
Rémi Verschelde
c003423674
Merge pull request #46579 from nekomatata/fix-joint-remove-body-regression-3.2
[3.2] Fix Joint2D/Joint node path reset on scene switch
2021-03-03 16:41:59 +01:00
bruvzg
1c27d4a73d
[macOS] Add entitlements config and export template dylib signing to the export. 2021-03-03 12:40:44 +02:00
Danil Alexeev
72e8697d8c
Merge Category and Property fields in the Project Settings
Closes godotengine/godot-proposals#1545.
2021-03-02 19:39:46 +03:00
Rémi Verschelde
9fa85b343c
Merge pull request #46495 from asheraryam/fix-clip-content-error
Fix rounding error in Clip Content [3.2]
2021-03-02 17:07:06 +01:00
PouleyKetchoupp
cdf0ebfac7 Fix Joint2D/Joint node path reset on scene switch
When one of the bodies exited the tree, the corresponding node path was
reset instead of just resetting the joint from the physics server. That
was causing the node path to be reset on scene switch when one of the
bodies is under the joint in the scene tree.
2021-03-02 08:32:00 -07:00
Rémi Verschelde
9ee835ac93
Merge pull request #46409 from asheraryam/fix-scale-pivot-jitter
Fix flicker in control nodes due to pivot offset
2021-03-02 16:15:21 +01:00
Rémi Verschelde
11ee43647b
Merge pull request #46590 from JFonS/fix_gridmap_lightmaps
[3.2] Properly disable dynamic lights on baked instances.
2021-03-02 15:05:29 +01:00
JFonS
62f344f448 Properly disable dynamic lights on baked instances.
Automatically set the `baked_light` bool when applying a lightmap to an
instance. This ensures the disabling of dynamic lights when the
bake mode is set to ALL.
2021-03-02 14:49:01 +01:00
Rémi Verschelde
08898e97a4
Merge pull request #46587 from akien-mga/3.2-cherrypicks
Cherry-picks for the 3.2 branch (future 3.2.4) - 26th batch
2021-03-02 12:02:47 +01:00
Yuri Roubinsky
9517b6e4ce Check before connecting TileMapEditor::settings_changed
(cherry picked from commit 1e7662f972)
2021-03-02 10:26:14 +01:00
Ryan Roden-Corrent
d39e5b9987 Clarify Curve.get_closest_point uses baked points.
Based on the doc, I wasn't sure if get_closest_point would return the
closest baked point or the closest "source" point. It seems to use
baked:
8faecd6a47/scene/resources/curve.cpp (L809)

(cherry picked from commit ef5042a70f)
2021-03-02 10:26:14 +01:00
Ev1lbl0w
3fe851accc Added missing returns on error scenarios
(cherry picked from commit 3d9ef1e4de)
2021-03-02 10:26:14 +01:00
Andy Maloney
28365a5258 Fix some grammar in StyleBoxFlat class docs
(cherry picked from commit 89e7e61773)
2021-03-02 10:26:14 +01:00
Yuri Roubinsky
29616f4a35 Fix parsing hexadecimal (lowercase e,f) in shaders
(cherry picked from commit 19e0a1ec9d)
2021-03-02 10:26:14 +01:00
Mateo Kuruk Miccino
04fefed904 Logger: Cache 'flush_stdout_on_print' to improve performance, and works before ProjectSettings starts.
ProjectSetting: Now 'application/run/flush_stdout_on_print' requires a restart of the Editor to take effect

(cherry picked from commit 89283b7b53)
2021-03-02 10:26:14 +01:00
Pedro Rodrigues
279b9f43f3 Fix crash in GIProbe::bake
The problem happened when the passed from_node was null and the GIProbe
node had no parent node.

Fixes #45978

(cherry picked from commit 82fed7b6da)
2021-03-02 10:26:14 +01:00
Fabio Alessandrelli
05367c755c [Net] Better EOF handling in HTTPRequest.
This fix request_completed being emitted two times, the first with the
result, the second as a failure when retrieving responses served with
read-until-EOF.

(cherry picked from commit d61cd469f1)
2021-03-02 10:26:14 +01:00
Eryk Dwornicki
127f3c0566 Fixed bug that caused collision not to be properly reenabled when joint between two bodies is destroyed
(cherry picked from commit 519e314bea)
2021-03-02 10:26:14 +01:00
Fabian
2aafe2b25e Add set_peer_timeout to NetworkedMultiplayerENet.
(cherry picked from commit 1b54de3039)
2021-03-02 10:26:14 +01:00
kobewi
56c0b39521 Don't check modified time if file doesn't exist
(cherry picked from commit af069109be)
2021-03-02 10:26:14 +01:00
Aaron Franke
b2d723b039 Add generic support to PackedScene.Instance
(cherry picked from commit 3f50954ced)
2021-03-02 10:26:14 +01:00
Rémi Verschelde
2d0dcd2e6c
Merge pull request #46576 from BastiaanOlij/fix_fbx_unique_bone_names
Fix duplicate check for bone names in FBX import
2021-03-02 09:11:12 +01:00
Bastiaan Olij
9c296bcb59 Fix duplicate check for bone names in FBX import 2021-03-02 10:55:29 +11:00
Rémi Verschelde
998ce22ea3
Merge pull request #46564 from pycbouh/graph-edit-hide-minimap-properly-3.2
[3.2] Properly hide GraphEdit's minimap
2021-03-01 17:54:40 +01:00
Yuri Sizov
59dfd084ab Properly hide GraphEdit's minimap 2021-03-01 18:18:05 +03:00
Rémi Verschelde
f4df2cdeef
Merge pull request #46553 from Ev1lbl0w/bugfix-window_size_bug
Prevent invalid values when resizing window (X11)
2021-03-01 14:16:27 +01:00
Ev1lbl0w
be4e34b495
Prevent invalid values when resizing window (X11) 2021-03-01 12:22:16 +00:00
Rémi Verschelde
7e2e96c587
Merge pull request #46552 from lawnjelly/projsettings_2d_renames
Renaming rendering/2d project settings.
2021-03-01 13:19:32 +01:00
lawnjelly
b1e24597e7 Renaming rendering/2d project settings.
The rendering/quality/2d section of project settings is becoming considerably expanded in 3.2.4, and arguably was not the correct place for settings that were not really to do with quality.

3.2.4 is the last sensible opportunity we will have to move these settings, as the only existing one likely to break compatibility in a small way is `pixel_snap`, and given that the whole snapping area is being overhauled we can draw attention to the fact it has changed in the release notes.

Class reference is also updated and slightly improved.

`pixel_snap` is renamed to `gpu_pixel_snap` in the project settings and code to help differentiate from CPU side transform snapping.
2021-03-01 11:38:46 +00:00
Rémi Verschelde
6b4abc6e17
Merge pull request #46520 from lawnjelly/soft_skin_aa
Disallow antialiasing for software skinned 2d polys
2021-03-01 10:21:31 +01:00
lawnjelly
7d5cf60149 Disallow antialiasing for software skinned 2d polys
Antialiasing is not supported for batched polys. Currently due to the fallback mechanism, skinned antialiased polys will be rendered without applying animation.

This PR simply treats such polys as if antialiasing had not been selected. The class reference is updated to reflect this.
2021-03-01 08:26:59 +00:00
Rémi Verschelde
4fcd8483d5
Merge pull request #43813 from lawnjelly/snap_2d_round
Change 2d transform snapping from floor to round
2021-03-01 08:54:41 +01:00
Rémi Verschelde
5c23fc4a06
Merge pull request #46519 from pdfrod/v3.2/fix-out-of-bounds-acess-on-x11
Fix out of bounds array access on OS_X11 code
2021-02-28 21:44:49 +01:00
Pedro Rodrigues
66da113237 Fix out of bounds array access on OS_X11 code
The problem happened on methods `get_screen_position`, `get_screen_size`
and `set_current_screen` when they were passed a negative screen value.

Fixes:
- #46184
- #46185
- #46186
2021-02-28 17:20:04 +00:00
lawnjelly
847a37b196 Change 2d transform snapping from floor to round
Two common problems have emerged as a result of transform snapping:
1) Camera jitter with a camera following a snapped object
2) Pixel gaps between e.g. a platform and a player, where a platform rounds down and a player rounds up

Using round seems to greatly reduce problems due to camera jitter. It also may prove better for  pixel gaps because pixel art is often designed on a grid, so whole numbers are too expected, which are unstable with floor().
2021-02-28 14:34:39 +00:00
asheraryam
25f35b2c9f Fix jitter in control nodes when using pivot-offset and animating scale
This is based on suggested fix from this comment
https://github.com/godotengine/godot/issues/36087#issuecomment-771593146 -- basically the old rounding workaround is removed, and rounding is now done locally in the scroll_container instead.

Fixes #28804

Co-authored-by: Georg Wacker <contact@georgwacker.com>
2021-02-28 15:30:48 +03:00
asheraryam
31a0f7fb0f Fix rounding error in Clip Content
Rounds the position and size of the final clip rect to avoid flickering issues.

Fixes https://github.com/godotengine/godot/issues/46493
2021-02-28 02:51:14 +03:00
Rémi Verschelde
8385a0d8ad
Merge pull request #46458 from m4gr3d/fix_invalid_missing_templates_error
[3.2] Fix invalid missing template error when the Android build template is not installed
2021-02-27 16:52:41 +01:00
Rémi Verschelde
3720dc2cfa
Merge pull request #46454 from m4gr3d/loosen_restrictions_on_plugin_loading_3_2
[3.2] Update the logic to load Godot Android plugins packaged into the binary.
2021-02-27 16:46:48 +01:00
Rémi Verschelde
1717e16c9e
Merge pull request #46471 from nmrkr/3.2-drag-preview-crash-after-free
[3.2] Fix crash during drag if user freed the drag preview
2021-02-27 16:32:18 +01:00
Delf Neumärker
7df977c3ed
Fix crash during drag if user freed the drag preview 2021-02-27 15:16:06 +01:00