Commit graph

2296 commits

Author SHA1 Message Date
Rémi Verschelde
58e7cbccc0
Merge pull request #30927 from mahubu/console-multi-selection-cursor
Change cursor to multi-selection cursor when selecting text in RichTextLabel
2019-08-30 15:05:54 +02:00
Hugo Locurcio
68f0d21cc4
Ignore the prefix and suffix in the SpinBox expression
This fixes a regression caused by
86a31e9e38.
2019-08-30 14:28:32 +02:00
Rémi Verschelde
ca652bbc47
Merge pull request #25353 from azagaya/master
Use also invisible tabs to calculate minimum size of tab container
2019-08-30 13:58:37 +02:00
azagaya
fa6f86b886 Make tab containers in editor, project settings, and export dialog, to use hidden tabs for min size computation. 2019-08-30 08:33:32 -03:00
Hugo Locurcio
86a31e9e38
Calculate the SpinBox value using the Expression class
This closes #31780.
2019-08-29 23:50:56 +02:00
Michael Alexsander Silva Dias
9b09daa8c5 Add feature to Button to make its icon expand/shrink with the button's size 2019-08-29 11:25:00 -03:00
Michael Alexsander Silva Dias
da5195fc92 Fix wrong offset in Button when alignment is set to left 2019-08-28 23:12:22 -03:00
Rémi Verschelde
185072015f
Merge pull request #31606 from toasteater/fix/nativescript-new-json-return-type
Fix the return type of NativeScript::new in API json
2019-08-28 09:15:40 +02:00
Michael Alexsander Silva Dias
9c36d893e3 Fix Multiline texts not updating correcly inside arrays 2019-08-26 13:47:33 -03:00
toasteater
a919f5e614 Fix return type of Control::get_drag_data in API json
Control::get_drag_data is a virtual method that returns Variant, but have the
Object type in its MethodInfo.

This changes the MethodInfo of Control::get_drag_data
2019-08-26 16:38:16 +00:00
Rémi Verschelde
0985d5fa99
Merge pull request #31496 from nekomatata/fix-text-edit-insert-selection
Update TextEdit selection when inserting line
2019-08-25 22:33:23 +02:00
Rémi Verschelde
41b5c62952
Merge pull request #31654 from Paulb23/minimap_fixes
Viewport highlight, colour cache and minimap scrolling fixes.
2019-08-25 22:32:05 +02:00
Paulb23
32d5427f55 Refactor TextEdit control height calculations 2019-08-25 14:49:13 +01:00
PouleyKetchoupp
bc839ed3f3 Update TextEdit selection & cursor when inserting line
Fixes #31458
2019-08-25 15:43:45 +02:00
Paulb23
c5b5c6b49b Minimap scroll now acts similar to scrollbar 2019-08-25 14:43:11 +01:00
Rémi Verschelde
0d37f198f5
Merge pull request #31628 from merumelu/treeitem-icon-modulate
Tree: fix and expose icon modulation
2019-08-25 10:49:26 +02:00
Yuri Roubinski
4efa1b6906 Disallow undo/redo in readonly TextEdit's 2019-08-25 09:57:59 +03:00
merumelu
eac0af5892 Tree: fix and expose icon modulation 2019-08-24 17:37:22 +02:00
Paulb23
ec4d2b26ec Fixed syntax highlighting cache not clearing final line 2019-08-24 15:21:45 +01:00
Paulb23
b75c2b6d76 Adjust viewport colour based on background colour 2019-08-24 14:33:55 +01:00
Rémi Verschelde
98ccdc0889
Merge pull request #30398 from tomasantunes/master2
Increase color preset slots
2019-08-23 09:19:11 +02:00
Rémi Verschelde
d5675c3996
Merge pull request #31575 from creikey/increase-anchor-precision
Increase control node's anchor precision
2019-08-23 08:22:33 +02:00
Paulb23
a5c1830a43 Fix minimap mouse click resolving to -1 2019-08-22 20:07:16 +01:00
Cameron Reikes
5deb83e041 Increase control node's anchor precision 2019-08-22 11:04:24 -07:00
Paulb23
0cea72273f Add minimap to text_edit 2019-08-21 23:48:46 +01:00
Paulb23
895a15b321 Add syntax highlighting cache 2019-08-21 23:36:49 +01:00
Hugo Locurcio
e1b9004b0f
Rename FileDialog's folder icon custom color to folder_icon_modulate
The custom color introduced in be8d569744
had the same name as the "folder" icon, which could cause conflicts
in the generated documentation.

The new name is also more self-explanatory.
2019-08-21 18:43:01 +02:00
geequlim
545b46ac2f Fix filter quotes wraped insert completion options 2019-08-21 22:11:36 +08:00
Hugo Locurcio
be8d569744
Use a different color for folder icons in file dialogs
This makes them easier to distinguish from files for quick
visual grepping.

This can also be used in projects by setting the FileDialog "folder"
color. The default value (`Color(1, 1, 1)`) has no visual impact,
for compatibility with existing projects.
2019-08-20 00:10:27 +02:00
Michael Alexsander Silva Dias
2fa32d69a5 Keep syntax highlighting on TextEdit in readonly mode 2019-08-18 14:00:12 -03:00
Hugo Locurcio
108f9646f5
Add an outline to box selection rectangles for better visibility
This also refactors selection box color definitions
to avoid repetition.
2019-08-15 22:27:32 +02:00
Michael Alexsander Silva Dias
f8a986c094 Fix autocompletion widget having its text leak outside 2019-08-15 14:52:37 -03:00
Rémi Verschelde
6c607c3564
Merge pull request #31266 from IAmActuallyCthulhu/pr/remove-redundant-author-comments
Remove redundant author doc comments
2019-08-14 13:45:54 +02:00
Rémi Verschelde
1dae4c9e7f
Merge pull request #31267 from sparkart/fix_optionbutton_offset
Fix Offset with OptionButton Popup
2019-08-14 11:43:42 +02:00
Fabian
97167209cb Exposed set_as_minsize to gdscript 2019-08-14 16:09:55 +09:30
Rémi Verschelde
f8574da2c2
Merge pull request #31338 from Calinou/reorganize-menus
Reorganize various menus for consistency and conciseness
2019-08-13 16:52:42 +02:00
Hugo Locurcio
9e1c23a353
Reorganize various menus for consistency and conciseness
- Clean up the recent scripts dialog to match the recent scenes dialog
- Add "..." at the end of shortcuts that cause a modal dialog to appear

This closes #31148.
2019-08-13 11:52:10 +02:00
Emmanuel Barroga
26c5bac428 Fix Right-Click Menu Deselecting Edits Content
Right-clicking a property to open the context menu deselects the text field. This causes the context menu to be useless because it doesn't have anything to edit.
2019-08-12 03:39:27 -07:00
IAmActuallyCthulhu
82b9557803
Remove redundant author doc comments 2019-08-12 04:26:38 -05:00
Emmanuel Barroga
b97e198bdd Fix Offset with OptionButton Popup
Fixes the offset issue with the OptionButton's popup.
2019-08-12 00:13:02 -07:00
Fabian Stiewitz
dcf65433f1 fix(Tree): get_meta condition
If an item in a Tree has never been selected, its metadata "__focus_rect"
is not set. If an unselected item is then edited (Tree::edit_selected()),
an error is thrown in console.
2019-08-11 16:55:01 +02:00
Rémi Verschelde
7bb2215ed0
Merge pull request #31213 from KoBeWi/explain_scenes
Replace ERR_EXPLAIN in scene/* code
2019-08-09 14:25:31 +02:00
Tomasz Chabora
af5e0fff66 Remove ERR_EXPLAIN from scene/* code 2019-08-09 13:54:52 +02:00
Emmanuel Barroga
2e1b58c793 Fix Exponential Range Graphical Error
Fixes the Exponential Range Slider having a graphical error with less than 1 values.
2019-08-09 01:47:20 -07:00
Rémi Verschelde
ba541bceca
Merge pull request #31077 from qarmin/coverity_bugs
Change some code proposed by Coverity and Cppcheck
2019-08-07 13:49:33 +02:00
qarmin
e0b5b21863 Add some code changes/fixes proposed by Coverity and Clang Tidy 2019-08-07 12:54:30 +02:00
Ken Paulson
deec700497 Implemented check_vadjust in CheckBox & CheckButton. It was exposed to the editor, but wasn't used. 2019-08-06 13:27:07 -04:00
Michael Alexsander Silva Dias
06a890f7a3 Update WindowDialog title when translation changes 2019-08-05 10:20:52 -03:00
Rémi Verschelde
2b983f9c74
Merge pull request #31075 from KoBeWi/right_for_acceptance
Accept also right-click event in LineEdit
2019-08-05 09:02:04 +02:00
Tomasz Chabora
b65f6f7944 Accept also right-click event in LineEdit 2019-08-04 15:35:50 +02:00
Cameron Reikes
c123a8c4f5 Same method when redrawing as when theme changed 2019-08-01 19:50:14 -07:00
Rémi Verschelde
d66461e85a
Merge pull request #30972 from Chaosus/vs_copy_paste
Implement copy/paste in visual shaders
2019-07-31 11:56:01 +02:00
Chaosus
f704506807 Implement copy/paste in visual shaders 2019-07-31 12:43:29 +03:00
Emmanuel Barroga
7db96e22dd Fix ProgressBar Wrong Value with Border
Closes: #30969

The FG rectangle of the progressbar is incorrect when dealing with a non-zero border. This issue stems from wrong order of operations when drawing the rectangle: int p = r * get_size().width - mp;
2019-07-30 21:47:11 -07:00
Tomás Antunes
606b56b5fb Increase color preset slots 2019-07-30 12:03:00 +01:00
Rémi Verschelde
961b9b30e3
Merge pull request #30932 from Dragoncraft89/master
Translate TabContainer titles, when inherited from node name
2019-07-29 22:41:07 +02:00
Florian Kothmeier
65101c9a20
Translate TabContainer titles, when inherited from node name 2019-07-29 19:07:56 +02:00
NilsIrl
abceb74b49 Remove useless variable and line in OptionButton 2019-07-29 17:41:28 +02:00
NilsIrl
dfecd62235 Change if to switch in OptionButton 2019-07-29 16:47:47 +02:00
Teto
b1dbd114c4 Change cursor to multi-selection cursor when selecting text in RichTextLabel.
Fix for #27545 : returns 'CURSOR_IBEAM' shape when selection is clicked.
2019-07-29 16:22:54 +02:00
Rémi Verschelde
f494d5f10b
Revert "Update Control margins when size is overridden by change to minsize" 2019-07-27 12:55:03 +02:00
Michael Alexsander Silva Dias
e8fc875619 Small adjustments to tooltips in '(Editor)FileDialog' 2019-07-26 11:11:09 -03:00
Rémi Verschelde
4c74f50d1a
Merge pull request #30351 from bojidar-bg/30288-override-global-theme
Keep track of default theme and project custom default theme seperatelly
2019-07-25 14:54:27 +02:00
Rémi Verschelde
43238bb59a DirAccess: Drop compat get_next(bool *is_dir) which was hidden
Fixes this warning:
```
./core/os/dir_access.h:74:17: warning: 'virtual String DirAccess::get_next(bool*)' was hidden [-Woverloaded-virtual]
```

Part of #30790.
2019-07-25 11:09:57 +02:00
Rémi Verschelde
d844e30614 Inspector: Make default float step configurable
Also allow lifting the decimal step formatting with a hint range step
of 0. A new `range_step_decimals()` is added for this to avoid breaking
compatibility on the general purpose `step_decimals()` (which still
returns 0 for an input step of 0).

Supersedes #25470.
Partial fix for #18251.
2019-07-23 17:31:38 +02:00
Rémi Verschelde
d15cf7b672
Merge pull request #30576 from qarmin/lgtm_coverage
Changed some code reported by LGTM and Coverity
2019-07-20 12:00:13 +02:00
qarmin
6cbaf7662f Changed some code showed in LGTM and Coverage 2019-07-20 08:09:57 +02:00
Michael Alexsander Silva Dias
d91346f720 Fix incorrect caret position when clicking a 'LineEdit' with a non-left alignment 2019-07-15 19:32:41 -03:00
Emmanuel Barroga
381faf83c3 Fix GraphNode immediately losing focus
Closes: #30243

GraphNode immediately loses focus, and gives focus to its parent.

This fix changes implementation so that it does not transfer focus to its parent after receiving focus. Instead, it will transfer focus when the "close button" is pressed.
2019-07-13 17:25:20 -07:00
Rémi Verschelde
34d7484039
Merge pull request #30455 from qarmin/const_reference
Pass by reference to const
2019-07-10 15:43:15 +02:00
qarmin
01cc7a996b Use reference to constant in functions 2019-07-10 11:54:12 +02:00
Shiqing
94d542042e Fix incorrect X position of line length guideline 2019-07-10 17:29:43 +08:00
Rémi Verschelde
9580c2b13e TreeItem: Rename new button disable method to set_button_disabled
Follow-up to #30408.

Also sync classref with current source.
2019-07-09 09:17:42 +02:00
Rémi Verschelde
2633efd55b
Merge pull request #28190 from griant/test
fix improper uncommenting behavior in TextEditor
2019-07-09 08:56:27 +02:00
Rémi Verschelde
24c462b974
Merge pull request #30443 from Calinou/improve-node-configuration-warnings
Improve the node configuration warning display
2019-07-09 08:31:20 +02:00
Hugo Locurcio
ff7184c5cb
Improve the node configuration warning display
- Refer to properties explicitly when possible
- When multiple warnings are returned, always separate them by one
  blank line to make them easier to distinguish
- Improve grammar and formatting
2019-07-09 00:18:00 +02:00
Hugo Locurcio
28d3a6051c
Use base Color() constructors instead of Color::html()
This results in slightly smaller binaries (-17 KB for an editor binary)
as no strings need to be allocated.
2019-07-08 21:17:10 +02:00
Rémi Verschelde
3bfffcc568
Merge pull request #30408 from Meriipu/tree_buttondisable
TreeItem: Added a setter for the disabled-property of buttons
2019-07-08 08:35:04 +02:00
Rémi Verschelde
af80182016
Merge pull request #30407 from qarmin/small_fixess
Fixes minor issues found by static analyzer
2019-07-08 08:16:50 +02:00
qarmin
9a77d748c0 Fixes minor issues found by static analyzer 2019-07-07 23:08:51 +02:00
Meriipu
fe9ec58028 TreeItem: Added a setter for the disabled-property of buttons 2019-07-07 16:18:36 +02:00
Rémi Verschelde
da1d5d89fd
Merge pull request #30371 from creikey/fix-30366
Give up finding item if started at beginning
2019-07-06 20:33:08 +02:00
Bojidar Marinov
e222615e97
Fix editor remaining dimmed after certain actions
Fixes #30368
2019-07-06 17:37:40 +03:00
Cameron Reikes
597e6e1bd9 Give up finding item if started at beginning
When the current item is -1, then the loop will infinitely repeat,
constantly setting i to zero and never exiting.
2019-07-05 22:14:49 -07:00
geequlim
4afb31cd52 Fix light area position in the selected completion 2019-07-06 12:15:32 +08:00
Bojidar Marinov
17901da1a8
Keep track of default theme and project custom default theme seperatelly
Fixes #30288
2019-07-05 23:32:52 +03:00
Geequlim
10cfd87414 Show icons for code completion options 2019-07-05 09:25:50 +08:00
Rémi Verschelde
b0ce9401ff
Merge pull request #30126 from qarmin/remove_unnecessary_code
Remove unnecessary code and add some error explanations
2019-07-01 14:32:04 +02:00
Rémi Verschelde
867f38a626
Merge pull request #29572 from qarmin/fix_text_edit_select
Fix TextEdit Select crash
2019-07-01 13:49:06 +02:00
qarmin
3c154eb93b Remove unnecessary code and add some error explanations 2019-07-01 12:59:42 +02:00
Rémi Verschelde
b62d315a7f
Merge pull request #30146 from Chaosus/editor_file_dlg_ex
Auto-change file extension in EditorFileDialog when filter changes
2019-07-01 09:24:37 +02:00
Rémi Verschelde
3758981bd4
Merge pull request #30161 from Calinou/add-tooltip-mouse-filter-warning
Add a configuration warning when using Ignore mouse filter with tooltip
2019-07-01 08:47:22 +02:00
Hugo Locurcio
a2f8297480
Draw the script editor's line length guideline below characters
This prevents characters from looking strange if they cross the
line length guideline.
2019-06-30 23:47:01 +02:00
Hugo Locurcio
a0cc62f000
Add a configuration warning when using Ignore mouse filter with tooltip
This closes #30144.
2019-06-30 19:58:40 +02:00
Rémi Verschelde
82604195b4
Merge pull request #30062 from zaksnet/fix-referencerect-node
Adds ReferenceRect an option to be visible inside the game
2019-06-30 13:41:45 +02:00
Rémi Verschelde
9a999876c3
Merge pull request #30168 from Calinou/label-font-shadow-use-outline
Draw the outline as part of the Label font shadow
2019-06-29 18:43:47 +02:00
Hugo Locurcio
fa0e66a88f
Draw the outline as part of the Label font shadow
This closes #30165.
2019-06-28 23:21:55 +02:00
Chaosus
eeabb132ec Auto-change file extension in EditorFileDialog when filter changes 2019-06-28 18:35:24 +03:00
Chaosus
eb6e260918 Fix some bugs inside ColorPicker 2019-06-28 17:25:00 +03:00
Zak
d29b1b7917 Fix ReferenceRect node
ReferenceRect node by default was only displaying in the editor and not when the game is running.
2019-06-28 12:42:42 +03:00
Rémi Verschelde
f35fd681ac
Merge pull request #30114 from Chaosus/vs_context_menu
Shows menu when dragging connection on empty space in visual shader
2019-06-27 15:14:54 +02:00
Chaosus
0aec3c3113 Shows menu when dragging connection on empty space in visual shader graph 2019-06-27 10:48:18 +03:00
Rémi Verschelde
eaaff9da31
Merge pull request #29941 from qarmin/redundant_code_and_others
Remove redundant code, possible NULL pointers and others
2019-06-27 01:05:18 +02:00
qarmin
4e5310cc60 Some code changed with Clang-Tidy 2019-06-26 15:08:25 +02:00
Rémi Verschelde
18b62d5019
Merge pull request #30053 from guilhermefelipecgs/fix_popup_centered
Fix Popup::popup_centered not centralizing at the first call
2019-06-25 17:46:57 +02:00
Guilherme Felipe
54653565a4 Fix Popup::popup_centered not centering at the first call 2019-06-25 12:04:29 -03:00
Rémi Verschelde
93a67dba37
Merge pull request #30002 from GlaceGwyneth/master
Give LineEdit/TextEdit a custom color for font while uneditable
2019-06-25 13:05:27 +02:00
Rémi Verschelde
b966ee49b2
Merge pull request #29979 from flomar/master
Line edit placeholders now react properly to translation changes.
2019-06-25 08:59:31 +02:00
Gwyneth Lowe
45f78d786a Give TextEdit a custom color for font when read only is set
Previously there was some transparency hard coded into TextEdit when in read only mode.
This change adds a custom color for adjusting the font in read only mode.
It also applies when syntax highlighting is on.
2019-06-24 20:00:05 -05:00
Gwyneth Lowe
f07e5ac153 Give LineEdit a custom font color when un-editable
By default the LineEdit's text when editable is unchecked had some transparency hardcoded.
This change adds a custom color to LineEdit for adjusting the font when editable is off.
Addresses issue 29814
2019-06-24 20:00:05 -05:00
Florian Marchal
0f2b25f83e Line edit placeholders now react properly to translation changes. 2019-06-24 23:22:20 +02:00
Rémi Verschelde
6fbd045845
Merge pull request #29913 from eligt/fix-editor-help
Ensure indentation works properly in rich text
2019-06-24 22:59:59 +02:00
Rémi Verschelde
efa4264633
Merge pull request #30009 from Anutrix/tree-icons-height-fix
Fixed script and visibility icons's highlight height in tree
2019-06-24 18:55:44 +02:00
Gwyneth Lowe
7142064110 Correct typo that broke custom selected font color
Change several font_selected_color to font_color_selected; the actual name of the override
2019-06-24 04:55:29 -05:00
unknown
c58b7ab094 Fixed script and visibility icons's highlight height in tree 2019-06-23 22:26:24 +05:30
Dawid Wdowiak
0f14489ecb Center script line when double clicked on error in debugger 2019-06-23 15:58:07 +02:00
qarmin
c77ff48a85 Fix some editor crashes 2019-06-21 11:34:32 +02:00
Rémi Verschelde
5c66771e3e
Merge pull request #29283 from qarmin/fix_some_always_same_values
Remove always true/false values
2019-06-20 21:10:10 +02:00
qarmin
532a7ba06a Fix TextEdit Select 2019-06-20 17:13:16 +02:00
qarmin
072e40368e Fix always true/false values 2019-06-20 16:59:48 +02:00
Elia Sarti
81065d53df Fix for #29810
Ensure indentation works properly in rich text
Fix formatting
2019-06-20 11:42:25 +01:00
Rémi Verschelde
300d4dfd54
Merge pull request #25573 from nekomatata/button-shortcut-fix
Fixed shortcut events in BaseButton (now acts the same as ui_accept action)
2019-06-20 12:06:31 +02:00
PouleyKetchoupp
1e6fa5d1a5 Fixed shortcut events in BaseButton (now acts the same as ui_accept action) 2019-06-20 09:13:23 +02:00
Rémi Verschelde
5a29be31b3
Merge pull request #27188 from samH-FIT/MacroUpdate
Made use of semicolons after GDCLASS more consistent, added semicolons where I found them missing.
2019-06-19 22:59:49 +02:00
Rémi Verschelde
02ed4b392c
Merge pull request #29902 from KoBeWi/dem_setters
Fix set_pick_color error
2019-06-19 20:43:15 +02:00
JohnJLight
38d3bfe971 Made use of semicolons more consitent, fixed formatting 2019-06-19 15:24:31 +02:00
Tomasz Chabora
9bdf110840 Fix set_pick_color error 2019-06-19 14:52:54 +02:00
Rémi Verschelde
d7af08aa95
Merge pull request #27389 from YeldhamDev/acceptdiag_label_wrap
Add option to enable autowrapping for label inside 'AcceptDialog'
2019-06-19 14:46:32 +02:00
Rémi Verschelde
bb0aeb4874
Merge pull request #28659 from KoBeWi/rainbow_mode
Add HSV mode to color picker
2019-06-19 12:41:51 +02:00
Rémi Verschelde
d61d1af64d
Merge pull request #29489 from groud/fixes_nan
Fixes NaN errors with anchors mode
2019-06-18 09:53:25 +02:00
Rémi Verschelde
3b3ba7d179
Merge pull request #29847 from yurchor/master
Fix minor typos
2019-06-17 17:28:55 +02:00
Rémi Verschelde
1d93b4abef
Merge pull request #29633 from jbuck3/optionbutton-selection
Connect OptionButton selection to menu's "index_pressed" signal
2019-06-17 16:56:16 +02:00
Yuri Chornoivan
340c2c0584 Fix minor typos 2019-06-17 15:11:49 +03:00
Rémi Verschelde
2935caa13f
Merge pull request #29838 from KoBeWi/4real
Fix selection undo... for real
2019-06-17 11:07:26 +02:00
Tomasz Chabora
e5cfb9d6b2 Fix selection undo... for real 2019-06-17 03:54:28 +02:00
Michael Alexsander Silva Dias
98d0c99652 Fix Range's "changed" signal emitting with a value even if binded to emit none 2019-06-16 12:00:49 -03:00
Rémi Verschelde
0a3c21d999
Merge pull request #29785 from eligt/fix-richtext-alignment
Fix RichTextLabel alignment tags not working properly
2019-06-15 10:34:22 +02:00
Rémi Verschelde
e999929024
Merge pull request #29787 from Paulb23/fix_negative_cursor_column
Fix TextEdit cursor.column having a negative value
2019-06-15 00:29:07 +02:00
Paulb23
1d55207fd2 Fix TextEdit cursor.column having a negative value 2019-06-14 21:48:16 +01:00
Elia Sarti
c4e5ee1fd2 Fix RichTextLabel alignment tags not working properly
Also fixes #6982
Fix error and formatting
2019-06-14 21:38:33 +01:00
Rémi Verschelde
8e04aecb19
Merge pull request #29647 from YeldhamDev/file_dialog_hidden_toggle
Add toggle for hidden file visibility in FileDialog
2019-06-14 22:29:49 +02:00
Rémi Verschelde
a745934761
Merge pull request #29731 from akien-mga/scene-is-off-limits
Cleanup some unecessary editor/ includes in scene/
2019-06-12 23:44:24 +02:00
Rémi Verschelde
84d969a42a Cleanup some unecessary editor/ includes in scene/
Part of #29730, handles false positives.
2019-06-12 22:48:43 +02:00
Rémi Verschelde
2cedf7173a BaseButton: Make shortcuts call virtual methods
When buttons are not in Toggle Mode, shortcuts used to only trigger the
`pressed` signal, without calling the `_pressed` virtual method,
contrarily to what happens when you click the button.

For Toggle Mode buttons, it did call the `_toggled` virtual method
together with emitting the `toggled` signal *twice*.

This commit harmonizes it all and makes shortcuts behave the same as
mouse clicks or `ui_accept`, for both toggle and non-toggle modes.

Fixes #29604.
2019-06-12 16:35:49 +02:00
Rémi Verschelde
df25679235
Merge pull request #29601 from NilsIrl/hiding_enabled
Treat hiding_enabled as bool throughout
2019-06-12 14:23:27 +02:00
Rémi Verschelde
434a1fddf3
Merge pull request #29648 from jbuck3/tree-tooltips
Fix Tree button tooltips
2019-06-12 13:29:36 +02:00
Rémi Verschelde
971b5160c6
Merge pull request #29306 from qarmin/small_code_fixes
Small fixes to unrechable code, possibly overflows, using NULL pointers
2019-06-12 12:49:21 +02:00
Rémi Verschelde
4043c8a8c9
Merge pull request #29678 from akien-mga/err-macros-semicolon
Fix error macro calls not ending with semicolon
2019-06-11 19:01:26 +02:00
Rémi Verschelde
15425b450f
Merge pull request #29573 from qarmin/fix_rich_text_process_line
Fix RichLabelText::_process_line crash
2019-06-11 16:00:03 +02:00
Rémi Verschelde
6d16f2f053 Fix error macro calls not ending with semicolon
It's not necessary, but the vast majority of calls of error macros
do have an ending semicolon, so it's best to be consistent.
Most WARN_DEPRECATED calls did *not* have a semicolon, but there's
no reason for them to be treated differently.
2019-06-11 14:49:34 +02:00