Commit graph

1018 commits

Author SHA1 Message Date
Max Hilbrunner
c5690240b4
Merge pull request #18535 from sketchyfun/new_mirror_path_handles
Added curve in/out (tangent) handle mirroring
2018-07-17 16:16:08 +02:00
volzhs
dd2f39da53 Add audio stream preview to Inspector dock 2018-07-17 22:11:35 +09:00
Rémi Verschelde
95d99cb2ac
Merge pull request #20176 from Chaosus/vs_namefixes
Several name fixes for visual shaders
2018-07-17 13:54:22 +02:00
Thomas Herzog
72430b041e
Merge pull request #20169 from Chaosus/rightclick_vs
Visual shaders - make "Add node" menu showed by right click
2018-07-16 15:46:18 +02:00
Thomas Herzog
a21aeec4b9
Merge pull request #20167 from Chaosus/fix_vshader_bug
Fix display scale bug in visual shaders
2018-07-16 15:40:41 +02:00
Juan Linietsky
a3f1ee5c57 Global class names (and GDScript support for it) 2018-07-15 19:29:00 -03:00
Chaosus
3af81427a1 Several name fixes for visual shader 2018-07-15 17:28:06 +03:00
Chaosus
f8417ac682 Visual shaders - make "Add node" menu showed by right click 2018-07-15 10:33:11 +03:00
Chaosus
c88da2fce5 Fix display scale bug in visual shaders 2018-07-15 08:55:41 +03:00
Juan Linietsky
f6ce73f724 Visual Shaders are back. 2018-07-14 18:16:18 -03:00
Juan Linietsky
ea47359408 Add option to convert Particles to CPUParticles 2018-07-07 09:04:22 -03:00
Juan Linietsky
7dcaabaf19 Support for CPU based particles, which aids compatibility with OpenGL ES 2.0 2018-07-06 20:21:42 -03:00
Max Hilbrunner
9f82368d40
Merge pull request #19475 from YeldhamDev/animplayer_cosmetic
Minor changes to the AnimationPlayer editor
2018-07-05 04:25:04 +02:00
Max Hilbrunner
c488a74e0c
Merge pull request #19498 from guilhermefelipecgs/fix_regression
Fix "find and replace" initializing with wrong size
2018-07-05 04:23:18 +02:00
Max Hilbrunner
858d0b6887
Merge pull request #19941 from guilhermefelipecgs/fix_animation_key
Fix animation key icon not show on inspector
2018-07-04 15:18:43 +02:00
Rémi Verschelde
db546732cf
Merge pull request #19824 from JFonS/fix_orthogonal_select
Fix selection in 3D orthogonal view
2018-07-04 15:06:46 +02:00
Guilherme Felipe
63d1b35c59 Fix animaiton key icon not show on inspector 2018-07-03 17:26:31 -03:00
Max Hilbrunner
27b20e7670
Merge pull request #19881 from khairul169/popupmenu_animedit
Fix error msg when selecting popupmenu if there is no animation selected
2018-07-03 18:44:48 +02:00
Max Hilbrunner
dce4bf96cc
Merge pull request #17582 from Ovnuniarchos/TMapEditorMultiSel
Tile randomizer for tilemap editor.
2018-07-03 18:30:02 +02:00
Max Hilbrunner
b21c1f64cd
Merge pull request #18634 from groud/fix_control_child_of_node2d
Fixes the bad calculation of margin & anchors when child of Node2D
2018-07-03 18:06:15 +02:00
Max Hilbrunner
165f3c31a5
Merge pull request #19166 from Grula/issue-18779
Changed "Syntax Menu" into radio Menu
2018-07-03 17:39:17 +02:00
Max Hilbrunner
deb005c966
Merge pull request #19156 from volzhs/fix-remove-split
Fix unable to remove split on Polygon 2D editor after restarting editor
2018-07-03 17:37:01 +02:00
Max Hilbrunner
0705eb904a
Merge pull request #19251 from YeldhamDev/script_templates_changes
Small changes to the comments in the script templates
2018-07-03 16:48:03 +02:00
Max Hilbrunner
74369229de
Merge pull request #19634 from guilhermefelipecgs/fix_shortcut_conflict
Remove shortcut conflict
2018-07-03 15:47:48 +02:00
Juan Linietsky
896e250f2b -Fix in animationplayback, sound would be cut on loop
-Fix on scene importer, keeping changes to animation tracks was not working
2018-07-01 17:45:19 -03:00
Ovnuniarchos
d9d78786dc Tile randomizer for tilemap editor. 2018-07-01 20:50:56 +02:00
khairul169
0a67aa5ce4 Fix error msg when selecting popupmenu if there is no animation 2018-07-01 15:38:42 +07:00
Michael Alexsander Silva Dias
02181292b8 Minor changes to the AnimationPlayer editor. 2018-06-30 00:12:05 -03:00
JFonS
e245efaead Fix selection in 3D orthogonal view 2018-06-28 14:59:39 +02:00
Juan Linietsky
eeab3502d5 Changes to how node paths are selected from property, allowing setting a hint. 2018-06-27 20:50:25 -03:00
Juan Linietsky
9bab5134cf The way multiple quaternions being slerped was not good, changed approach to one that seems to work better. 2018-06-27 16:30:48 -03:00
Juan Linietsky
c633b770cb -Add root motion support in AnimationTree.
-Add RootMotionView, to debug root motion in 3D (disabled in runtime)
2018-06-26 19:06:16 -03:00
Rémi Verschelde
f036353b93
Merge pull request #19164 from marcelofg55/tilemap_undo2
Improve TileMap undo operations, second try
2018-06-26 20:57:39 +02:00
Juan Linietsky
8c7da84e1e renamed AnimationGraphPlayer to AnimationTree 2018-06-25 18:40:24 -03:00
Thomas Herzog
0f7c35f955 added BlendSpace1D editor plugin
This commit also fixes a crash in the BlendSpace2D as well as correct
the drawing of the x-zero indicator in the BlendSpace2D editor plugin.
2018-06-25 21:46:12 +02:00
Thomas Herzog
84252f2ec4 added AnimationBlendSpace1D 2018-06-25 21:36:53 +02:00
Thomas Herzog
1ff7aa4c9b rename BlendSpace to BlendSpace2D 2018-06-25 21:36:10 +02:00
Juan Linietsky
4f5a7ebaec State machine animation node 2018-06-25 16:22:41 -03:00
Rémi Verschelde
4e867a1d7a
Merge pull request #19698 from Chaosus/theme_submenu
Move Theme options to submenu
2018-06-25 16:24:39 +02:00
Juan Linietsky
2365fe472b Added auto triangle generation in blend space, using Delaunay. 2018-06-21 22:48:47 -03:00
Juan Linietsky
b76143bfde Remove error messages 2018-06-21 18:46:17 -03:00
Juan Linietsky
b80946ee0d Fix crashes, ability to add blendpsace into blendtree, ability to delete with delete key 2018-06-21 18:08:11 -03:00
Juan Linietsky
a0719533bd Animation Blend Spaces 2018-06-21 15:46:11 -03:00
Chaosus
7a18b95906 Move Theme options to submenu 2018-06-21 12:10:43 +03:00
Juan Linietsky
0a1c1c660f -Added AnimationGraphPlayer (still missing features)
-Added ability to edit resources from built-in inspector (wip, needs testing and feedback)
2018-06-18 22:12:08 -03:00
Guilherme Felipe
7c52824504 Remove shortcut conflict 2018-06-18 16:24:01 -03:00
Guilherme Felipe
5bae3693bf Fix "find and replace" initializing with wrong size
Fix the code editor outside the allowed limits.
2018-06-13 14:08:04 -03:00
Rémi Verschelde
8efbe9ed3d
Merge pull request #19487 from JFonS/better_3d_select
Improve 3D selection
2018-06-13 18:49:35 +02:00
JFonS
9cd1c20f6a Polished 3D selection 2018-06-13 17:52:37 +02:00
Rémi Verschelde
44050cd24f
Merge pull request #19503 from akien-mga/osx-ctrl-cmd
Fix shortcuts using KEY_MASK_CTRL instead of KEY_MASK_CMD
2018-06-13 15:43:54 +02:00
groud
71cea6b515 Fixes a crash on draw_hover 2018-06-12 11:01:24 +02:00
Rémi Verschelde
3f09cac267 Fix shortcuts using KEY_MASK_CTRL instead of KEY_MASK_CMD
KEY_MASK_CMD is automatically replaced by KEY_MASK_CTRL on non-OSX
and KEY_MASK_META (Command key) on OSX, so it should be used for all
Ctrl/Cmd + key shortcuts.

Also de-hacked the macOS shortcut replacements with proper conditional
definition. Not tested on macOS, cannot judge if they are good shortcuts.

Fixes #10761.
2018-06-11 07:53:28 +02:00
Michael Alexsander Silva Dias
fd17b960e9 Small changes to the comments in the script templates. 2018-06-11 02:04:51 -03:00
Guilherme Felipe
365bb077fe Fix translate messages for new AnimationPlayer 2018-06-08 14:44:18 -03:00
Rémi Verschelde
3aed396a30
Merge pull request #19343 from bojidar-bg/x-fix-tilemap-shape-rotation
Fix bugs related to bad handling of rotated/translated shapes in tilemap
2018-06-08 18:15:51 +02:00
Juan Linietsky
a8dd5750e2
Merge pull request #19334 from guilhermefelipecgs/fix_popup
Fixes popup_centered_* methods, dialogs with wrong sizes and visual script editor
2018-06-08 13:00:53 -03:00
Rémi Verschelde
f35115309b
Merge pull request #19314 from Jellonator/master
Added autotile override
2018-06-08 09:11:49 +02:00
groud
4d78e16bc1 Fixes the bad calculation of margin & anchors when child of Node2D 2018-06-07 21:25:15 +02:00
Juan Linietsky
b659fd6d74 Entirely new (and much improved) animation editor. 2018-06-07 12:52:00 -03:00
Guilherme Felipe
048f149478 Fix theme not updating with changes 2018-06-06 17:58:12 -03:00
Guilherme Felipe
7a3882723c Fix #16069, #19292, #19267 and #18940 2018-06-06 13:16:52 -03:00
Rémi Verschelde
07d4cd7f6d
Merge pull request #19388 from volzhs/show-filename
Show opened script or help name
2018-06-06 09:22:22 +02:00
volzhs
69ac6a1f3d Show opened script or help name 2018-06-06 06:18:11 +09:00
Bojidar Marinov
d73cdeb248
Fix bugs related to bad handling of rotated/translated shapes in tilemap
Fixup #18529 and #12870
2018-06-03 16:32:23 +03:00
James Beedie
6cbafdea16 Added autotile override 2018-06-02 21:25:09 -04:00
NIkola Grulovic
bc666c42ff Syntax Menu as sub-menu of Edit
Moved syntax menu to be sub-menu of edit, as-well made choices radio buttons
2018-06-01 21:32:19 +02:00
Rémi Verschelde
ff0d295d9e
Merge pull request #19250 from YeldhamDev/scene_editor_tooltips
Minor changes to the Scene and Canvas editors' tooltips
2018-06-01 13:31:46 +02:00
Rémi Verschelde
59c2c21b15 Move NavigationMeshEditorPlugin to Recast module as should be
Modules can register their own editor plugins (like GridMap does),
so no need to put module-specific classes in the `editor/` folder.

Also cleans up the previous SCons env pollution from the Recast
module, integrating its code into libmodules as other modules.
2018-05-30 22:10:11 +02:00
Marcelo Fernandez
cadd72793b Improve TileMap undo operations, second try 2018-05-29 19:35:30 -03:00
Michael Alexsander Silva Dias
589f18a374 Minor changes to the Scene and Canvas editors' tooltips. 2018-05-29 13:21:26 -03:00
volzhs
224ca96c57 Fix index out of size error of image.cpp 2018-05-29 14:13:05 +09:00
volzhs
4ea8c6b1e1 Fix unable to remove split on Polygon 2D editor after restarting editor 2018-05-27 22:32:58 +09:00
Max Hilbrunner
23b4b7d53a
Merge pull request #18234 from flashyincceo/font-preview
Adding font preview to file browsers
2018-05-26 18:31:48 +02:00
Rémi Verschelde
665319de35
Revert "Improve TileMap undo operations" 2018-05-25 13:00:28 +02:00
Gilles Roudière
e19405b2b4
Merge pull request #19157 from volzhs/bone-visibility
Don't draw bones if it's not visible
2018-05-25 09:59:51 +02:00
volzhs
6a28bfe09c Don't draw bones if it's not visible 2018-05-25 13:01:15 +09:00
Marcelo Fernandez
f1383f80bf Improve TileMap undo operations 2018-05-23 14:31:51 -03:00
Karolis K
1a92906fe0 Fix AssetLib image loading 2018-05-21 21:09:09 +03:00
Michael Alexsander Silva Dias
6c058040b7 Small tooltip changes. 2018-05-18 14:54:40 -03:00
Juan Linietsky
9b5275b135 -Hid texture flags by default so they dont take so much space
-make curve texture preview not so large, so its easier to embed the editor
2018-05-18 12:37:18 -03:00
Mariano Javier Suligoy
7eddb80b27
Merge pull request #18960 from isaacremnant/autotile_3x3_minimal
Restore support for minimal 3x3 autotile sets
2018-05-17 19:57:55 -03:00
Daniel J. Ramirez
9a365a1216 Moved inspector functionality from EditorNode to InspectorDock. 2018-05-17 16:29:26 -05:00
Juan Linietsky
4b5227ff77 -Ability to open resources in the same window
-Plenty of fixes and improvements to new inspector
-Fixes that were needed to make inspector work better
2018-05-17 18:03:05 -03:00
isaacremnant
e4f0ac558d Restore support for minimal 3x3 autotile sets 2018-05-17 09:49:14 -04:00
Rémi Verschelde
5e20a229eb
Merge pull request #18529 from swarnimarun/master
Fix StaticBody2D ignore in tileset bug
2018-05-17 09:35:51 +02:00
Rémi Verschelde
a404ceb128
Merge pull request #18930 from samdze/master
Changed the name displayed for built-in scripts in the Script tab with a more descriptive one
2018-05-16 23:14:34 +02:00
Rémi Verschelde
c31456b821
Merge pull request #18891 from groud/fix_bone_selection
Bring back 2D bone selection
2018-05-16 22:50:58 +02:00
Guilherme Felipe
35024d4e7b Add missing copyright headers 2018-05-16 14:50:44 -03:00
Karolis K
8694f98170 AssetLib pagination modifications 2018-05-16 17:06:15 +03:00
Samuele Zolfanelli
375c94510f Changed the name displayed in the Script tab for built-in script with a more descriptive one 2018-05-16 15:23:56 +02:00
Rémi Verschelde
98e5a3ea42
Merge pull request #18442 from StraToN/add-button-sort-methods-overview
Add a ToggleButton for alphabetic sorting in methods overview
2018-05-16 10:53:55 +02:00
Juan Linietsky
005b69cf6e -New inspector.
-Changed UI resizing code, gained huge amount of speed.
-Reorganized timer sync to clean up behavior (sorry forgot commit this before)

-
2018-05-15 17:14:31 -03:00
Gilles Roudiere
0021df3da3 Bring back 2D bone selection 2018-05-15 15:18:46 +02:00
Gilles Roudiere
e614789882 Fixes hovered Nodes2D display in the editor (remove duplicates) 2018-05-15 09:37:23 +02:00
Rémi Verschelde
8c71cbbe3f
Merge pull request #18797 from TailyFair/assetlib-video-overlay
Added video thumbnail overlay in asset description
2018-05-14 08:39:27 +02:00
Rémi Verschelde
fb8f71fe54
Merge pull request #18788 from Chaosus/fixblackpreviews
Fix black script previews
2018-05-12 09:40:24 +02:00
Karolis K
0711d865e2 Thumbnail overlay for videos in AssetLib 2018-05-11 23:43:59 +03:00
Chaosus
a081507be7 Fix black script previews 2018-05-11 20:08:17 +03:00
Julian Murgia
68b9fd79e4 Add button hbox with alphabetic sort toggle above methods outline. 2018-05-11 13:30:43 +02:00
Karolis K
c3e921fba3 Fix icon if remote icon load fails 2018-05-10 18:45:22 +03:00
Peter Folkins
365d814361 Adding font preview to file browsers 2018-05-09 13:34:30 -05:00
Ben Hickling
31b6776f11 Added option to 2D and 3D curve editor to mirror curve tangent handles both in angle and/or length 2018-05-09 14:01:04 +01:00
Swarnim Arun
8529763a0f Fix tileset bug #18090 to use StaticBody2D position
Using staticbody2d position to affect the collision shape position whenever a tileset is created.

Formatting the code

Removed the most get/set from my old code.
2018-05-09 12:12:10 +05:30
Andrea Catania
6c4916ddf5
Removed pointer deletion during editor closing 2018-05-08 00:59:22 +02:00
AndreaCatania
9e57a07fb6 Implemented ragdoll
Implementing ragdoll

Implementing ragdoll

Implementing ragdoll

Implementing ragdoll

Implementing ragdoll

a

Implemented implicit hierarchy.

Improved

Added some physics properties

Added bone offset to preserve COM, partially fixed scaling

work in progress

WIP

wip

Implemented Joint Gizmos

Implemented pin joint joint

Implemented all joints
2018-05-07 21:03:16 +02:00
Juan Linietsky
8c30337565
Merge pull request #18684 from muiroc/fix_dragdrop_instancing
Editor: Makes dragdrop instantiation behavior consistent with the instance scene button
2018-05-07 13:34:09 -03:00
Juan Linietsky
d8ea68195a
Merge pull request #18525 from Calinou/improve-3d-grid
Improve the 3D editor grid
2018-05-07 13:09:03 -03:00
Juan Linietsky
14e9a6ae16
Merge pull request #18633 from groud/fix_2d_editor
Fix 2d editor
2018-05-07 11:55:26 -03:00
Juan Linietsky
6e9517ca83
Merge pull request #18642 from flashyincceo/engine-click
Fix script editor CTRL+CLICK on singleton functions
2018-05-07 11:49:34 -03:00
Max Hilbrunner
c587cac304
Merge pull request #18308 from ericmccarthy7/develop
Fix clone down newline bug
2018-05-07 14:49:23 +02:00
muiroc
884b239ca5 SpatialEditorViewport::_create_instance: pass GEN_EDIT_STATE_INSTANCED to scene->instance() 2018-05-06 19:13:23 +02:00
Peter Folkins
0c1a71b047 Fix script editor CTRL+CLICK on singleton functions 2018-05-05 13:23:47 -05:00
groud
7331ca6f63 Fixes some 2d bones display problems 2018-05-05 15:45:26 +02:00
groud
3962862ea3 Fixes several selection problems in the 2D editor 2018-05-05 11:50:23 +02:00
Juan Linietsky
af9a6202eb Fix bone refresh logic, closes #18564 2018-05-04 18:11:28 -03:00
Juan Linietsky
bf561c4946 Made bone handling for actual Bone2D a special case. Make custom bones appear like a custom (less important) option now. 2018-05-04 16:46:32 -03:00
Juan Linietsky
e68cbec1fa Make bones have more contrast with outline 2018-05-04 11:54:21 -03:00
Juan Linietsky
3bd0ca2a2d Skeletal deform working 2018-05-04 11:54:21 -03:00
Rémi Verschelde
d6ddfdf004
Merge pull request #18601 from YeldhamDev/string_changes
Small changes for some strings
2018-05-04 08:16:54 +02:00
Michael Alexsander Silva Dias
5b0ddb1354 Small changes for some strings. 2018-05-03 18:07:18 -03:00
Juan Linietsky
b3e4bc562c Skeleton for 2D WIP 2018-05-03 17:29:56 -03:00
Robin Hübner
b16eaf5827 Remove unused duplicate wireframe shortcut, fixes #18067
It also happens to do nothing currently.
2018-05-03 16:22:30 +02:00
Juan Linietsky
4c3c510a80 WIP Polygon2D weight editing 2018-05-02 11:01:12 -03:00
groud
845a898f37 Fixes locks and groups on 2d editor 2018-05-02 10:37:37 +02:00
Rémi Verschelde
02a51c34ea
Merge pull request #18259 from Superwaitsum/MoveIcons
Changed Sprite Frame buttons for icons
2018-05-02 10:08:57 +02:00
Rémi Verschelde
de97339a2d
Merge pull request #18291 from akien-mga/coverity-uninitialized-scalar-var
Fix Coverity reports of uninitialized scalar variable
2018-05-01 19:14:07 +02:00
Pieter-Jan Briers
20dd2204db Adds z-index properties to TileSets. 2018-05-01 17:24:57 +02:00
Rémi Verschelde
8dd2b2e6f5
Merge pull request #18434 from YeldhamDev/animation_autoplay_fix
Fixed deleting an animation marked to autoplay in the editor affecting the creation of one with the same name
2018-05-01 11:47:37 +02:00
Rémi Verschelde
e1ef2f538f
Merge pull request #18380 from groud/fix_spacebar_panning
Fixes 2d editor panning not working
2018-05-01 08:56:13 +02:00
Rémi Verschelde
4cce6f3417
Merge pull request #18321 from Crazy-P/Fixes-logically-dead-code
Fixes logically dead code (Coverity)
2018-05-01 08:35:10 +02:00
Superwaitsum
7d689dff71 Changed Sprite Frame move buttons for icons 2018-04-30 16:05:21 -05:00
Max Hilbrunner
196fc8599a
Merge pull request #18373 from KidRigger/working
Replaces CTRL with CMD in TileMapEditor for MacOS.
2018-04-30 19:00:41 +02:00
Max Hilbrunner
f274c8b74b
Merge pull request #18381 from groud/fix_hard_to_select_node2d
Fixes hard to select Node2D
2018-04-30 18:58:27 +02:00
Hugo Locurcio
098f9b51b5
Improve the 3D editor grid
- The grid's primary and secondary colors can now be changed
- The number of grid steps (subdivisions) can now be changed
- The grid size can now be changed
- The grid is now darker by default
2018-04-30 14:24:54 +02:00
Hein-Pieter van Braam
91dfccd1ee
Merge pull request #18425 from RandomShaper/fix-theme-editor-samples
Fix theme editor sample widgets
2018-04-28 22:19:13 +02:00
Juan Linietsky
93c77580aa Fix how snapping is applied to 3D polygon editing, make it more friendly. 2018-04-28 11:22:22 -03:00
Juan Linietsky
8d199a9b2c CSG Support for Godot!
-Missing Icons
-Missing freezing option (for baking light and faster load)
-Missing a way to export from Godot (GLTF2?)
-Probably buggy (may freeze editor, can be worked around easily, but let me know if this happens so it's easier to catch bugs)
Happy testing!
2018-04-27 21:55:10 -03:00
Michael Alexsander Silva Dias
75897710b3 Made the Pin button disable when no AnimationPlayer is selected. 2018-04-27 16:06:05 -03:00
Michael Alexsander Silva Dias
e93a56ef3e Fixed deleting an animation marked to autoplay in the editor affecting the creation of one with the same name. 2018-04-27 16:06:05 -03:00
Pedro J. Estébanez
a0626d7d9c Fix theme editor sample widgets 2018-04-27 20:42:57 +02:00
Michael Alexsander Silva Dias
6971604033 Numerous changes to the Animation Editor. 2018-04-26 22:58:30 -03:00
Gilles Roudiere
8dcd39c3c4 Adds shortcuts for zooming in the 2D editor 2018-04-26 10:28:56 +02:00
groud
e8a4c4fa4c Fixes hard to select Node2D 2018-04-23 19:48:15 +02:00
groud
9c5a44aeee Fixes 2d editor panning not working 2018-04-23 19:34:03 +02:00
Anish
cca7633739 Replaces CTRL with CMD in TileMapEditor for MacOS.
Replacing CTRL with CMD makes sense dure to consistency
with MacOS and avoiding conflict with the accessibility
hotkey (ctrl+lmb = rmb)

Fixes: #18238
2018-04-23 19:39:01 +05:30
Hugo Locurcio
1c419531a0 Change ".." punctuation for "..." in editor strings (#16507) 2018-04-22 19:36:01 +02:00
Crazy-P
e6deba8d19 Fixes logically dead code (Coverity)
Fixes reported logically dead codes by Coverity

* image.cpp: Doesn't really need any modification. But to remove the bug
report then we have to move the MAX call away from the for loop
statement.

* rasterizer_gles3.cpp: Removes unnecessary elif condition since it is
checked earlier in the function

* collada.cpp: If stamement never reached due to macro ERR_CONTINUE does
the same.

* navigation_mesh.cpp: Variables should always be null - however, also
checked for the very same condition in their function call. Leaving this
for review (whether the function call is necessary or not)

* path_editor_plugin.cpp: If cancel is true, then it should restore the
edited value to the original provided.
http://docs.godotengine.org/en/3.0/classes/class_editorspatialgizmo.html#class-editorspatialgizmo-commit-handle

* spatial_editor_gizmos.cpp: the very condition of i >= 3 is
predetermined in the if case right before it. Thus case 1 is always '1'
and case 2 is always '-1'

* grid_map_editor.cpp: Same as above in spatial_editor_gizmos.cpp

* voxel_light_baker.cpp: Same as above in spatial_editor_gizmos.cpp

* visual_server.cpp: Same as above in spatial_editor_gizmos.cpp

* visual_script_expression.cpp: char '-' is already true in the switch
case mechanism. Thus it can never reach to default case.

* particles.cpp: Case 'PARAM_MAX' is unreachable due to index checking
right before the switch execution.

* shader_language.cpp: Invalid index is handled in switch default case.
`type < TYPE_FLOAT && type > TYPE_VEC4` -> `(type < TYPE_FLOAT || type > TYPE_VEC4`)
Fixes the "always false problem" in TODO comment.
2018-04-21 22:35:23 +08:00
Eric McCarthy
02b7b916b7 Fix clone down newline bug
Previously cloning down at the end of a script was broken if there was
not an additional empty line.

This fix ensures there is an empty line before attempting to clone
downwards.

Fixes #18206, cheers!
2018-04-19 20:35:42 -04:00
Rémi Verschelde
bf7ca623a6 Fix Coverity reports of uninitialized scalar variable
Fixes most current reports on Coverity Scan of uninitialized scalar
variable (CWE-457): https://cwe.mitre.org/data/definitions/457.html

These happen most of the time (in our code) when instanciating structs
without a constructor (or with an incomplete one), and later returning
the instance. This is sometimes intended though, as some parameters are
only used in some situations and should not be double-initialized for
performance reasons (e.g. `constant` in ShaderLanguage::Token).
2018-04-19 15:20:45 +02:00
Rémi Verschelde
db70538688
Merge pull request #18168 from Chaosus/fixcrash
Fix possible crash when clicking on Skeleton2D or Sprite editor options
2018-04-18 16:19:10 +02:00