Commit graph

5759 commits

Author SHA1 Message Date
Hugo Locurcio
9e3393a624
Optimize the editor icon generation
Icons are no longer upsampled when using an integer editor scale.
This makes some icons slightly less crisp, but the icons themselves
can be adjusted to mitigate this. When using a non-integer editor
scale setting, upsampling is kept as it improves crispness in a
far more visible manner.

When upsampling is disabled, this speeds up the theme generation
by about 100 ms on average, making the project manager and editor
start slightly faster. This also speeds up switching between themes.
2020-01-20 00:31:04 +01:00
Rémi Verschelde
7f7ae0712f i18n: Sync translations with Weblate 2020-01-19 23:19:29 +01:00
Hugo Locurcio
ff135065f4
Improve the batch rename dialog
- Use the editor-defined error, warning and success colors for
  preview texts.
- Make the "Regular Expressions" option into a CheckButton
  (as it does something as soon as it's toggled) and move it out
  of the Advanced Options submenu.
- Make it clearer that the error message originates from an invalid
  regular expression.
- Clarify what the number means in the regex error message.
- Tweak some strings' casing for consistency.
2020-01-19 22:37:56 +01:00
Hugo Locurcio
d72f5e0938
Only create the editor theme once
This prevents the editor theme from being created twice.
This speeds up the project editor and editor startup
significantly; startup is now 1.3 times faster on average
(tested on a debug build). RAM usage was also lowered by 7.5 MB
on average.

This partially addresses #35321.
2020-01-19 21:51:21 +01:00
Hugo Locurcio
8f838f33b7
Improve the Video RAM debugger UX
- Refresh tha tab automatically when switching to it.
- Disable the Refresh button if no project is currently being debugged.
- Scale the column widths on hiDPI displays.
- Rename the tab from "Video Mem" to "Video RAM" for consistency.
2020-01-19 19:03:53 +01:00
Rémi Verschelde
e8dc581bfc
Merge pull request #35303 from timothyqiu/hidpi-anitreeplayer
Fixes AnimationTreePlayer editor UI on HiDPI
2020-01-19 10:21:20 +01:00
Rémi Verschelde
d7072e9cd4
Merge pull request #35273 from dankan1890/quick_fix
AssetLibrary layout fix
2020-01-19 10:13:31 +01:00
Rémi Verschelde
7522aa80c2
Merge pull request #35295 from N0hbdy/animation-editor-line-edit-fix
Fix AnimationTree Editor by using CONNECT_DEFERRED on LineEdit
2020-01-19 09:32:00 +01:00
Rémi Verschelde
b2e2ce1643
Merge pull request #35297 from Calinou/2d-zoom-reset-clamp-editor-scale
Clamp the editor scale to 1 when resetting zoom in the 2D editor
2020-01-19 09:30:12 +01:00
Rémi Verschelde
78c2d41ffc
Merge pull request #35304 from raphael10241024/fix_audiobus_editor
fix audio buses layout editor save
2020-01-19 09:13:05 +01:00
RaphaelHunter
4b70985a1a fix audio buses editor not save, close #26683 2020-01-19 10:56:00 +08:00
Haoyu Qiu
2db685da09 Fixes AnimationTreePlayer editor on HiDPI
* The minimum editor size
* The position of buttons and status text
2020-01-19 10:20:53 +08:00
Hugo Locurcio
c9aca9ef81
Clamp the editor scale to 1 when resetting zoom in the 2D editor
This closes #35294.
2020-01-18 22:26:21 +01:00
N0hbdy
3fffb1c031 Fix AnimationTree Editor by using CONNECT_DEFERRED on LineEdit
Not having this causes the LineEdit to be deleted while still processing
signals, which can cause a crash during focus changes.

Fixes 35293
2020-01-18 12:12:13 -08:00
dankan1890
29daba5b0c AssetLibrary when the download size is unknown:
hidden progress bar
added in the description the downloaded bytes
Fixes #35267
2020-01-18 21:07:51 +01:00
Yuri Roubinsky
41acb1f6ba Fix minimap updating in shader tab 2020-01-18 12:31:33 +03:00
Hugo Locurcio
8bce0b6176
Mark alternate editor display modes as disabled in the GLES2 renderer
This partially addresses #27018.
2020-01-17 16:06:47 +01:00
Lakshay Angrish
1d9e19c7fb show parametric setters and getters in editor help 2020-01-17 15:10:59 +05:30
Rémi Verschelde
045a5ce14a i18n: Sync translation template with current source 2020-01-16 23:47:18 +01:00
Rémi Verschelde
a0f716763b i18n: Sync translations with Weblate 2020-01-16 23:37:56 +01:00
Rémi Verschelde
05e042b06f
Merge pull request #34879 from Phischermen/canvas-item-editor-local-space-mode
Fix issue regarding rotating Canvas Items in editor
2020-01-16 23:10:41 +01:00
Haoyu Qiu
92b36d4706 Adds NULL check before using image loader 2020-01-16 21:49:23 +08:00
Rémi Verschelde
bc34794840
Merge pull request #34091 from andrycodestuffs/master
Fixed unknown ASCII symbols rendered instead of tabs in bookmarks list
2020-01-16 14:11:28 +01:00
andrycodestuffs
d0b3cb89f7 Fixed unknown symbol drawn instead of tabs in breakpoints/bookmarks lists
Tab characters were not rendered properly in the breakpoints and
bookmarks lists of the script editor if the bookmarked line was a
comment, resulting in unknown ASCII symbols “�”.

Fixes #34046.

Also changed formatting a bit to enclose the code in backticks (like in
Markdown) instead of quotes.

Co-authored-by: Rémi Verschelde <rverschelde@gmail.com>
2020-01-16 13:50:30 +01:00
asynts
e564b4fd07 Refactor (and fix) how the connect button is disabled.
It should not be possible to click the "Connect" button unless

  - a node is selected, and
  - that node is valid in the current mode.

The modes are the default and advanced modes which allow connecting to scripts
and nodes respectively.
2020-01-16 12:35:41 +01:00
Rémi Verschelde
fc2550c4c8
Merge pull request #35123 from asynts/asynts.crash-on-double-click
Prevent crash described in #34555.
2020-01-16 12:32:52 +01:00
Aaron Franke
5e1dad3b28
Use int64_t for EditorPropertyInteger and warn when out of double range 2020-01-15 23:39:49 -05:00
Rémi Verschelde
f2d45676c9
Merge pull request #35165 from groud/fix_memleak_filesystemdock
Fixes a memory leak in FileSystemDock
2020-01-15 22:58:57 +01:00
Hugo Locurcio
1339a5c1cb
Add an icon for OGG samples
The icon is the same as WAV samples, as both formats are accepted
in AudioStreamPlayer.

This closes #35163.
2020-01-15 22:32:08 +01:00
Gilles Roudière
76d87e6616 Fixes a memory leak in FileSystemDock
Co-authored-by: Rafał Mikrut <mikrutrafal54@gmail.com>
2020-01-15 21:45:13 +01:00
Haoyu Qiu
43ad6e8c96 Fixes AssetLib crash when JPG module is disabled
JPG module is optional, so check it's existence before using.
2020-01-15 22:16:12 +08:00
asynts
181e74855e Don't close the connection dialog when the validation failed.
Currently the connection dialog is closed when

 1. no method name is specified, or

 2. no script is attached and if the method name isn't a buildin.

That's really annoying.
2020-01-15 10:33:50 +01:00
Rémi Verschelde
40f0649e5b Fix typos with codespell
Using codespell 1.16.0.

See ab3bccdb78 for procedure.
2020-01-15 00:49:52 +01:00
Rémi Verschelde
8d60f5a349
Merge pull request #35132 from Calinou/doc-description-below-brief
doc: Move the class description to be just below the brief description
2020-01-15 00:49:31 +01:00
Hugo Locurcio
3c8abbc4bf
doc: Move the class description to be just below the brief description
- Drop the "Brief description" header as it became redundant
  with this change.
- Fix a bug in the editor help where an extraneous newline was added
  after the header if the class isn't inherited by any others.
- Remove the Category line in the rST markup as it's not useful
  for API users.
2020-01-15 00:05:34 +01:00
Michael Alexsander
34bf81fa7c Cleanup unnecessary code from before the scrollbar overlapping fixes 2020-01-14 18:19:12 -03:00
Rémi Verschelde
8f103b1b69
Merge pull request #34801 from Calinou/add-3d-viewport-crosshair
Add a crosshair to the 3D viewport
2020-01-14 21:02:35 +01:00
asynts
71b4b180ba Prevent crash described in #34555.
Normally it wouldn't be possible to click on the "Connect" button if no node
is selected, because the button would be disabled.

However, double clicking on a node is also hooked up to the same signal
and double clicking is possible even if the "Connect" button is disabled.

This caused a crash described in #34555.
2020-01-14 17:02:18 +01:00
Phischermen
becd1fd1d8 Fix issue regarding rotation
Canvas items will now rotate correctly no matter what their global scale happens to be.
2020-01-14 07:26:34 -08:00
Rémi Verschelde
ea4c88f38a
Merge pull request #35116 from YeldhamDev/more_scrollbar_tweaks
Fix more scrollbar anchorings
2020-01-14 13:55:34 +01:00
Michael Alexsander
e69593842e Fix more scrollbar anchorings 2020-01-14 08:25:55 -03:00
Rémi Verschelde
a565c93aeb Export: Properly disable resource preview thread
Fixes #26857.
Fixes #34433.
Fixes #34826.
2020-01-14 11:34:02 +01:00
Rémi Verschelde
dbbfade584
Merge pull request #35082 from akien-mga/dont-count-yer-chicken
EditorNode: Delay addon init to NOTIFICATION_READY
2020-01-14 08:26:08 +01:00
Michael Alexsander
712cd8a97e Fix more instances of overlapping scrollbars 2020-01-13 22:49:17 -03:00
Hugo Locurcio
2b9f34b867
Add a crosshair to the 3D viewport
The crosshair makes freelook navigation a bit easier, while making it
clearer that it's possible to select nodes by clicking while in
freelook mode.

The crosshair is only displayed while in freelook mode.
It uses an icon designed to be visible on any background.
2020-01-13 22:30:34 +01:00
Rémi Verschelde
017b7de2df EditorNode: Delay addon init to NOTIFICATION_READY
Fixes #25635.
2020-01-13 15:02:11 +01:00
Rémi Verschelde
4a95186b4b Animation editor: Set resource name when duplicating
Fixes #25156.
2020-01-13 13:22:06 +01:00
Hugo Locurcio
929dfe1bcc
Clamp the editor scale to 1 for 2D zoom operations
Some people set the editor scale below 1 to fit more content on
screen, even if their display doesn't have a particularly low DPI.

This closes #35059.
2020-01-13 12:16:27 +01:00
Rémi Verschelde
7a15569c6f
Merge pull request #35050 from Calinou/enlarge-item-list-editor
Increase the size of the item list editor popup
2020-01-13 09:14:02 +01:00
Haoyu Qiu
047d66cc6f Fixes the New Window option in macOS dock menu 2020-01-13 08:58:12 +08:00
Hugo Locurcio
2f56146242
Increase the size of the item list editor popup
This makes it easier to edit large amounts of items.

This partially addresses
https://github.com/godotengine/godot-proposals/issues/368.
2020-01-12 18:19:39 +01:00
Rémi Verschelde
269eb5f06c i18n: Sync translation template with current source
Prevent parsing 'thirdparty' sources, there are invalid UTF-8 files
among Bullet sources.
2020-01-12 14:42:34 +01:00
Rémi Verschelde
48d7f7a70f i18n: Sync translations with Weblate 2020-01-12 14:36:21 +01:00
Rémi Verschelde
26bb08f8b3
Merge pull request #35037 from timothyqiu/plugin-min-height
Fixes min size of various editor plugins on HiDPI
2020-01-12 13:39:34 +01:00
Rémi Verschelde
ccf6f33813
Merge pull request #35006 from BastiaanOlij/offset_mesh_obj
Add option to apply an offset to obj mesh import
2020-01-12 09:09:56 +01:00
Haoyu Qiu
65e2230f6e Fixes min size of various editor plugins on HiDPI
* AnimationTree
* AudioStream
* ResourcePreloader
* ShaderEditor
* VisualShaderEditor
2020-01-12 15:24:15 +08:00
Haoyu Qiu
9c229cb035 Fixes minimap width on HiDPI monitor 2020-01-11 19:36:20 +08:00
Bastiaan Olij
ad6d06dc21 Add option to apply an offset to obj mesh import 2020-01-11 19:27:00 +11:00
Michael Alexsander
14e36c72b0 Make ScriptCreateDialog's script valid message a bit more clearer 2020-01-10 20:14:45 -03:00
Rémi Verschelde
018b3fa159
Merge pull request #34934 from volzhs/copy-params-except-script
Don't copy script with copy params
2020-01-10 23:57:23 +01:00
K. S. Ernest (iFire) Lee
0172a7f932 Use cycle and loop hint flags in glTF2. 2020-01-10 08:02:16 -08:00
Rémi Verschelde
65446a1303
Merge pull request #34981 from timothyqiu/trim-group-name
Trims user provided group name
2020-01-10 09:37:39 +01:00
Rémi Verschelde
4bad292f20
Merge pull request #34969 from volzhs/anim-bezier
Fix inserting bezier curve in Animation editor
2020-01-10 09:36:45 +01:00
Haoyu Qiu
715c0f9dfd Trims user provided group name 2020-01-10 16:08:47 +08:00
Rémi Verschelde
4b83bbd463
Merge pull request #34937 from YeldhamDev/scriptdiag_disable_load
Add option to disable loading scripts in ScriptCreateDialog
2020-01-10 08:18:51 +01:00
Michael Alexsander
34f1dbaf28 Fix TileSet editor's workspace size sometimes not changing correctly on region change 2020-01-10 00:57:49 -03:00
volzhs
3bcedd02b2 Fix inserting bezier curve in Animation editor 2020-01-10 06:22:10 +09:00
Michael Alexsander
8708d44a50 Add option to disable loading scripts in ScriptCreateDialog 2020-01-09 13:09:23 -03:00
Rémi Verschelde
28655e16d6
Merge pull request #33426 from PucklaMotzer09/ignore_disabled_recent
Ignore the classes in the recent and favorite panels of the create dialog if they are disabled
2020-01-09 08:55:37 +01:00
Rémi Verschelde
1d304d87eb
Merge pull request #34940 from volzhs/update-main-scene-file
Update file list in split view when setting main scene
2020-01-09 08:21:26 +01:00
PucklaMotzer09
b0e4205069 Add ignoring of disabled recent and favorite classes in create 2020-01-09 08:17:06 +01:00
Haoyu Qiu
93aa3a0126 Fixes TextureRegion editor drag handle for HiDPI
Before this fix, it's easy to miss the drag handle on a HiDPI monitor.
2020-01-09 13:45:53 +08:00
volzhs
9495229315 Update file list in split view when setting main scene 2020-01-09 09:51:31 +09:00
volzhs
f61cd51643 Don't copy script with copy params 2020-01-09 06:34:47 +09:00
Rémi Verschelde
656cc83aa0 Export: Fix leak or orphaned Controls after #34911
They need to be hidden but still in tree.
2020-01-08 17:45:10 +01:00
Rémi Verschelde
7a941b11d2
Merge pull request #34898 from veryprofessionaldodo/33420
Recent Nodes now respect Editor Profiles  #33420
2020-01-08 16:06:47 +01:00
Rémi Verschelde
5e4d465356
Merge pull request #34913 from akien-mga/main-add-export-pack
Export: Add dedicated --export-pack option to export data pack
2020-01-08 15:43:44 +01:00
veryprofessionaldodo
d88f620c52 Recent Nodes now respect Editor Profiles 2020-01-08 14:23:36 +00:00
Rémi Verschelde
7c29ce4375 Export: Add dedicated --export-pack option to export data pack
The previous behavior relying on the provided extension was problematic
on macOS since .zip is the main extension used for the full project
export (binary + data pack).

We add a dedicated `--export-pack` command line option to define when
only the data pack should be exported. Its extension will still be
inferred from the path.

Fixes #23073.
2020-01-08 14:57:46 +01:00
Rémi Verschelde
ac7dc03ae4 Export: Hide Patches tab until actually implemented
This seems to have been left dangling during 3.0 development and was
never finished.

Hiding for now until it can be completed, otherwise we'll have to drop
it.

See #22394.
2020-01-08 13:29:51 +01:00
Rémi Verschelde
41c8ec991f
Merge pull request #34802 from xelivous/power-of-two-is-good
Change the 2D editor's snap to 8x8 by default
2020-01-08 08:51:58 +01:00
Rémi Verschelde
6fa716c67b
Merge pull request #34887 from akien-mga/cli-export-usability
Export: Improve usability of command line interface
2020-01-08 08:19:39 +01:00
Rémi Verschelde
a28e0b2849
Merge pull request #34905 from YeldhamDev/scriptdiag_minor_fix
Minor fixes for ScriptCreateDialog
2020-01-08 07:05:18 +01:00
Michael Alexsander
f9d11120f7 Minor fixes for ScriptCreateDialog 2020-01-08 02:02:34 -03:00
Michael Alexsander
8b5992f665 Make possible to edit the GraphEdit's selection rect colors 2020-01-07 23:20:48 -03:00
volzhs
a1ab8f8890 Show selected main scene in FileSystem split view 2020-01-08 02:19:54 +09:00
Rémi Verschelde
5011afcb6a Export: Improve usability of command line interface
I'm barely scratching the surface of the changes needed to make the
--export command line interface easy to use, but this should already
improve things somewhat.

- Streamline `can_export()` templates check in all platforms, checking
  first for the presence of official templates, then of any defined
  custom template, and reporting on the absence of any.
  Shouldn't change the actual return value much which is still true if
  either release or debug is usable - we might want to change that
  eventually and better validate against the requested target.

- Fix discrepancy between platforms using `custom_package/debug` and
  `custom_template/debug` (resp. `release`).
  All now use `custom_template`, which will break compatibility for
  `export_presets.cfg` with earlier projects (but is easy to fix).

- Use `can_export()` when attempting a command line export and report
  the same errors that would be shown in the editor.

- Improve error reporting after a failed export attempt, handling
  missing template and invalid path more gracefully.

- Cleanup of unused stuff in EditorNode around the export workflow.

- Improve --export documentation in --help a bit.

Fixes #16949 (at least many of the misunderstandings listed there).
Fixes #18470.
2020-01-07 14:25:56 +01:00
Joost Heitbrink
dc61323b2c PCK: Set VERSION_PATCH in header, factor out header magic
Unify pack file version and magic to avoid hardcoded literals.

`version.py` now always includes `patch` even for the first release in
a new stable branch (e.g. 3.2). The public name stays without the patch
number, but `Engine.get_version_info()` already included `patch == 0`,
and we can remove some extra handling of undefined `VERSION_PATCH` this
way.

Co-authored-by: Rémi Verschelde <rverschelde@gmail.com>
2020-01-06 13:13:17 +01:00
Haoyu Qiu
cca03b57ff Fixes scaled scrolling of TextureRegion editor 2020-01-05 19:52:21 +08:00
Hugo Locurcio
948cb84e37
Take the editor scale into account for 2D zoom operations
The zoom level displayed is now relative to the editor scale.
This means that with an editor scale of 200%, the 100% zoom level
will actually be 200% as it's multiplied by the editor scale.
This prevents things from looking too small when opening a project
on an hiDPI display.

This matches the behavior found in most image editors out there.
2020-01-04 18:43:52 +01:00
Haoyu Qiu
78e9ca58af Makes more strings translatable 2020-01-04 13:46:38 +08:00
xelivous
64ae7feaa4 Change the 2D editor's snap to 8x8 by default 2020-01-03 19:23:49 -06:00
dankan1890
51c601d2e3 [Mono]: the C# script icon is now visible in the editor. 2020-01-03 22:49:22 +01:00
Rémi Verschelde
a18909f945 doc: Sync classref with current source 2020-01-03 15:09:09 +01:00
Rémi Verschelde
da625654e5
Merge pull request #34760 from fire/gltf2-scissors
Support GLTF2 alpha scissors.
2020-01-03 11:14:46 +01:00
Hugo Locurcio
a00ead2a1f
Enable the script editor line length guideline by default
Now that the GDScript style guide has an official recommendation,
it makes sense to enable the line length guideline by default.
2020-01-02 21:47:44 +01:00
K. S. Ernest (iFire) Lee
f028b8b0e4 Support GLTF2 alpha scissors. 2020-01-02 11:52:08 -08:00
Rémi Verschelde
8f68e3d966
Merge pull request #34757 from neikeq/the-revenge-of-the-defvals
Fix missing DEFVAL in some EditorSpatialGizmo methods
2020-01-02 18:23:56 +01:00
Ignacio Etcheverry
bca64e3b6f Fix missing DEFVAL in some EditorSpatialGizmo methods
This was a regression from ac18665c88,
which changed the C++ method signature but forgot to update the method bind.
2020-01-02 18:07:23 +01:00
Rémi Verschelde
bde52cc688
Merge pull request #34618 from qarmin/vector_please_dont_crash
Don't use constant reference in Vector push_back, insert and append_array
2020-01-02 15:44:41 +01:00